csv_generator 0.5.1 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9d9a9aab0ef93184107fb29217cd482102a8b8ab
-  data.tar.gz: ec424aba1eb32cba378f3815bb529e18723f4693
+  metadata.gz: b7ca333b9d9a9cdd6246dd186c3665cd016859f1
+  data.tar.gz: eb87e512cd89d733dcd4af3137050a1973137afa
 SHA512:
-  metadata.gz: a9e9c3ea8d1884d2778661b02d0464503304867f0dda0fe7671d3daba33d9bce50d300259b58d1b6f91dab6119fec99eae939da32bd3e277aa97f6327402fa79
-  data.tar.gz: 387487571fc882d52747affd8178e3a4e9e9bdfdcb7201a32ef2fb09eab9bad7d6589e28f58ec5c664554d0189a8f6ccca7b8c3a7fdccbbd6934728c7dc80115
+  metadata.gz: bd81198e0248578d24a566d1861281bf8a2313094b4f7133bcf4e879c50687524fa85d26a53aebfa4e4a3eacb1418536003ffff3086c0a3138be4af838ebf13b
+  data.tar.gz: 9fa44baa803d84359f7aeb55a64f8b0f1e7d7a9335657d0c792d50706e336de8047bba8d9bd35634d4467b3b6c56ce01f9ef9f052eb17230fa753d0a22a5b311

data/lib/csv_generator.rb

@@ -37,7 +37,7 @@ class CsvGenerator
   end
 
   class RowGenerator
-    KNOWN_OPTIONS = %i(line_separator field_separator quote_charactor).freeze
+    KNOWN_OPTIONS = %i(line_separator field_separator quote_character).freeze
 
     attr_reader(*KNOWN_OPTIONS)
     attr_reader :escaped_quote
@@ -47,7 +47,7 @@ class CsvGenerator
         instance_variable_set :"@#{k}", v
       end
 
-      @escaped_quote = quote_charactor * 2
+      @escaped_quote = quote_character * 2
     end
 
     private
@@ -60,7 +60,7 @@ class CsvGenerator
       {
         line_separator: "\r\n",
         field_separator: ',',
-        quote_charactor: '"',
+        quote_character: '"',
       }
     end
 
@@ -82,14 +82,16 @@ class CsvGenerator
         ''
       when String
         quote value
+      when Fixnum, Float
+        value.to_s
       else
-        value
+        stringify value.to_s
       end
     end
 
     def quote(str)
-      escaped_string = str.gsub quote_charactor, escaped_quote
-      %("#{escaped_string}")
+      escaped_string = str.gsub quote_character, escaped_quote
+      quote_character + escaped_string + quote_character
     end
   end
 end

data/lib/csv_generator/version.rb

@@ -1,3 +1,3 @@
 class CsvGenerator
-  VERSION = '0.5.1'
+  VERSION = '0.5.2'
 end

data/spec/csv_generator_spec.rb

@@ -83,6 +83,38 @@ describe CsvGenerator do
       end
     end
 
+    context 'given float values' do
+      specify do
+        csv << [1.23, 9.876]
+
+        expect(io.string).to eq %(1.23,9.876\r\n)
+      end
+    end
+
+    context 'given negative numbers' do
+      specify do
+        csv << [-123, -0.987]
+
+        expect(io.string).to eq %(-123,-0.987\r\n)
+      end
+    end
+
+    context 'given nil' do
+      specify do
+        csv << ['test', nil, 123]
+
+        expect(io.string).to eq %("test",,123\r\n)
+      end
+    end
+
+    context 'given dates' do
+      specify do
+        csv << [123, Date.new(2014, 12, 6)]
+
+        expect(io.string).to eq %(123,"2014-12-06"\r\n)
+      end
+    end
+
     context 'when called more than once' do
       specify do
         csv << ['test1', 123]
@@ -92,4 +124,39 @@ describe CsvGenerator do
       end
     end
   end
+
+  context 'with options' do
+    context 'given line_separator' do
+      let(:csv) { CsvGenerator.new io, line_separator: "\n" }
+      let(:io) { StringIO.new }
+
+      specify do
+        csv << ['test', 123]
+
+        expect(io.string).to eq %("test",123\n)
+      end
+    end
+
+    context 'given field_separator' do
+      let(:csv) { CsvGenerator.new io, field_separator: "\t" }
+      let(:io) { StringIO.new }
+
+      specify do
+        csv << ['test', 123]
+
+        expect(io.string).to eq %("test"\t123\r\n)
+      end
+    end
+
+    context 'given quote_character' do
+      let(:csv) { CsvGenerator.new io, quote_character: "'" }
+      let(:io) { StringIO.new }
+
+      specify do
+        csv << ['test', %q('single'), %q("double"), 123]
+
+        expect(io.string).to eq %('test','''single''','"double"',123\r\n)
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: csv_generator
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors:
 - SAWADA Tadashi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-03 00:00:00.000000000 Z
+date: 2014-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler