csv_generator 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c20b49a067774dc41149f4f521e3ca83e7738042
-  data.tar.gz: 2d2cf08748d4425922834da6127dc7037d43ba2f
+  metadata.gz: 9d9a9aab0ef93184107fb29217cd482102a8b8ab
+  data.tar.gz: ec424aba1eb32cba378f3815bb529e18723f4693
 SHA512:
-  metadata.gz: ecb7f01e9657c66c43ca7377fa7aae3820a5880f21f54cf0c5f04f2fd95b7e883ef97599ea0d652d3cdedeba04f828cd6d08183f59e8d5a795a71b3dbf38697e
-  data.tar.gz: a182bb3d7f6917a6686e1f0ccd4a8124f83dc4893f23a745f3ee18cdd6b38d78c9a4c6337bbecffb124e59e5cf36be6a398f72f1a38aebaa9ac2769d76a15a1c
+  metadata.gz: a9e9c3ea8d1884d2778661b02d0464503304867f0dda0fe7671d3daba33d9bce50d300259b58d1b6f91dab6119fec99eae939da32bd3e277aa97f6327402fa79
+  data.tar.gz: 387487571fc882d52747affd8178e3a4e9e9bdfdcb7201a32ef2fb09eab9bad7d6589e28f58ec5c664554d0189a8f6ccca7b8c3a7fdccbbd6934728c7dc80115

data/.rubocop.yml

@@ -12,3 +12,6 @@ Style/UnneededPercentQ:
 
 Style/WordArray:
   Enabled: false
+
+Style/TrailingComma:
+  Enabled: false

data/csv_generator.gemspec

@@ -19,6 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler', '~> 1.7'
+  spec.add_development_dependency 'fakefs', '~> 0.6'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.1'

data/lib/csv_generator/version.rb

@@ -1,3 +1,3 @@
 class CsvGenerator
-  VERSION = '0.5.0'
+  VERSION = '0.5.1'
 end

data/lib/csv_generator.rb

@@ -9,20 +9,21 @@ class CsvGenerator
       permission = options[:permission] || 0644
 
       File.open(path, mode, permission) do |io|
-        with io, &block
+        with io, options, &block
       end
     end
 
-    def with(io)
-      generator = new(io)
+    def with(io, options = {})
+      generator = new(io, options)
 
       yield generator if block_given?
       generator
     end
   end
 
-  def initialize(io)
+  def initialize(io, options = {})
     @io = io
+    @options = options
   end
 
   def <<(row_values)
@@ -32,32 +33,49 @@ class CsvGenerator
   private
 
   def row_generator
-    @row_generator ||= RowGenerator.new
+    @row_generator ||= RowGenerator.new(@options)
   end
 
   class RowGenerator
-    def generate(row_values)
-      row_values.map { |value| stringify value }.join(field_separator) + line_separator
+    KNOWN_OPTIONS = %i(line_separator field_separator quote_charactor).freeze
+
+    attr_reader(*KNOWN_OPTIONS)
+    attr_reader :escaped_quote
+
+    def initialize(options = {})
+      default_config.merge(filter_options options).each do |k, v|
+        instance_variable_set :"@#{k}", v
+      end
+
+      @escaped_quote = quote_charactor * 2
     end
 
     private
 
-    def line_separator
-      "\r\n"
+    def filter_options(hash)
+      hash.select { |k, _| KNOWN_OPTIONS.include? k }
     end
 
-    def field_separator
-      ','
+    def default_config
+      {
+        line_separator: "\r\n",
+        field_separator: ',',
+        quote_charactor: '"',
+      }
     end
 
-    def quote_charactor
-      '"'
+    def escape_quote_character(c)
+      c * 2
     end
 
-    def escaped_quote
-      '""'
+    public
+
+    def generate(row_values)
+      row_values.map { |value| stringify value }.join(field_separator) + line_separator
     end
 
+    private
+
     def stringify(value)
       case value
       when nil

data/spec/csv_generator_spec.rb

@@ -1,4 +1,52 @@
+require 'fakefs/spec_helpers'
+
 describe CsvGenerator do
+  describe '.generate' do
+    context 'given only a file name' do
+      include FakeFS::SpecHelpers
+
+      specify do
+        CsvGenerator.generate('test.csv') do |csv|
+          csv << ['test', 123]
+        end
+
+        expect(File.read('test.csv')).to eq %("test",123\r\n)
+      end
+    end
+
+    context 'given the name of an existing file' do
+      include FakeFS::SpecHelpers
+
+      specify do
+        File.open('test.csv', 'w') do |file|
+          file.write(%("existing line",987\r\n))
+        end
+
+        CsvGenerator.generate('test.csv') do |csv|
+          csv << ['test', 123]
+        end
+
+        expect(File.read('test.csv')).to eq %("test",123\r\n)
+      end
+    end
+
+    context 'given "a" as mode' do
+      include FakeFS::SpecHelpers
+
+      specify do
+        File.open('test.csv', 'w') do |file|
+          file.write(%("existing line",987\r\n))
+        end
+
+        CsvGenerator.generate('test.csv', mode: 'a') do |csv|
+          csv << ['test', 123]
+        end
+
+        expect(File.read('test.csv')).to eq %("existing line",987\r\n"test",123\r\n)
+      end
+    end
+  end
+
   describe '#<<' do
     let(:io) { StringIO.new }
     let(:csv) { CsvGenerator.new(io) }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: csv_generator
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - SAWADA Tadashi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-02 00:00:00.000000000 Z
+date: 2014-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.7'
+- !ruby/object:Gem::Dependency
+  name: fakefs
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement