csv_decision 0.0.3 → 0.0.4

data/spec/csv_decision/options_spec.rb

@@ -28,17 +28,29 @@ describe CSVDecision::Options do
       input0,    output0
     DATA
 
-    result = CSVDecision.parse(data, first_match: false)
+    result = CSVDecision.parse(data,
+                               first_match: false,
+                               matchers: [CSVDecision::Matchers::Pattern])
 
     expected = {
       first_match: false,
       regexp_implicit: false,
       text_only: false,
-      matchers: CSVDecision::DEFAULT_MATCHERS
+      matchers: [CSVDecision::Matchers::Pattern]
     }
     expect(result.options).to eql expected
   end
 
+  it 'rejects an invalid option argument' do
+    data = <<~DATA
+      IN :input, OUT :output
+      input0,    output0
+    DATA
+
+    expect { CSVDecision.parse(data, bad_option: false) }
+      .to raise_error(ArgumentError, "invalid option(s) supplied: [:bad_option]")
+  end
+
   it 'parses options from a CSV file' do
     file = Pathname(File.join(SPEC_DATA_VALID, 'options_in_file1.csv'))
     result = CSVDecision.parse(file)

data/spec/csv_decision/parse_spec.rb

@@ -32,4 +32,14 @@ describe CSVDecision::Parse do
       end
     end
   end
+
+  context 'it rejects invalid CSV files' do
+    Dir[File.join(CSVDecision.root, 'spec/data/invalid/*.csv')].each do |file_name|
+      pathname = Pathname(file_name)
+
+      it "rejects CSV file: #{pathname.basename}" do
+        expect { CSVDecision.parse(pathname) }.to raise_error(CSVDecision::FileError)
+      end
+    end
+  end
 end

data/spec/csv_decision/table_spec.rb

@@ -68,9 +68,9 @@ describe CSVDecision::Table do
           options: {},
           data: <<~DATA
             in :constant, out :type
-            :=nil,        NilClass
-            = 0,          Zero
-            :=100.0,      100%
+            :=nil,        :=nil
+            = 0,          = 0
+            :=100.0,      :=100
             ,             Unrecognized
           DATA
         },
@@ -81,9 +81,9 @@ describe CSVDecision::Table do
             options = test[:options].merge(first_match: true)
             table = CSVDecision.parse(test[:data], options)
 
-            expect(table.send(method, constant: nil)).to eq(type: 'NilClass')
-            expect(table.send(method, constant: 0)).to eq(type: 'Zero')
-            expect(table.send(method, constant: BigDecimal.new('100.0'))).to eq(type: '100%')
+            expect(table.send(method, constant: nil)).to eq(type: nil)
+            expect(table.send(method, constant: 0)).to eq(type: 0)
+            expect(table.send(method, constant: BigDecimal.new('100.0'))).to eq(type: BigDecimal('100.0'))
             expect(table.send(method, constant: ':=nil')).to eq(type: 'Unrecognized')
             expect(table.send(method, constant: '= 0')).to eq(type: 'Unrecognized')
             expect(table.send(method, constant: ':=100.0')).to eq(type: 'Unrecognized')
@@ -183,5 +183,111 @@ describe CSVDecision::Table do
         end
       end
     end
+
+    context 'makes correct decision for table with symbol equality compares' do
+      examples = [
+        { example: 'uses == :node',
+          options: {},
+          data: <<~DATA
+            in :node, in :parent, out :top?
+            ,          ==:node,   yes
+            ,          ,          no
+          DATA
+        },
+        { example: 'uses :node',
+          options: {},
+          data: <<~DATA
+            in :node, in :parent, out :top?
+            ,         :node,      yes
+            ,         ,           no
+          DATA
+        },
+        { example: 'uses := :node',
+          options: {},
+          data: <<~DATA
+            in :node, in :parent, out :top?
+            ,         := :node,   yes
+            ,         ,           no
+          DATA
+        },
+        { example: 'uses = :node',
+          options: {},
+          data: <<~DATA
+            in :node, in :parent, out :top?
+            ,         = :node,    yes
+            ,         ,           no
+          DATA
+        },
+        { example: 'uses :node, drops :node input column',
+          options: {},
+          data: <<~DATA
+            in :parent, out :top?
+            :node,      yes
+            ,           no
+          DATA
+        },
+        { example: 'uses :parent, drops :parent input column',
+          options: {},
+          data: <<~DATA
+            in :node, out :top?
+            :parent,  yes
+            ,         no
+          DATA
+        },
+        { example: 'uses != :parent, drops :parent input column',
+          options: {},
+          data: <<~DATA
+            in :node,    out :top?
+            != :parent,  no
+            ,            yes
+          DATA
+        }
+      ]
+
+      examples.each do |test|
+        %i[decide decide!].each do |method|
+          it "#{method} correctly #{test[:example]}" do
+            options = test[:options]
+            table = CSVDecision.parse(test[:data], options)
+
+            expect(table.send(method, node:  0,  parent: 0)).to eq(top?: 'yes')
+            expect(table.send(method, node:  1,  parent: 0)).to eq(top?: 'no')
+            expect(table.send(method, node: '0', parent: 0)).to eq(top?: 'no')
+          end
+        end
+      end
+    end
+
+    context 'makes correct decision for table with symbol ordered compares' do
+      examples = [
+        { example: 'uses == :node',
+          options: {},
+          data: <<~DATA
+            in :traded, in :settled, out :status
+            ,            :traded,    same day
+            ,           >:traded,    pending
+            ,           <:traded,    invalid trade
+            ,                   ,    invalid data
+          DATA
+        },
+      ]
+
+      examples.each do |test|
+        %i[decide decide!].each do |method|
+          it "#{method} correctly #{test[:example]}" do
+            options = test[:options]
+            table = CSVDecision.parse(test[:data], options)
+
+            expect(table.send(method, traded: '20171227',  settled: '20171227')).to eq(status: 'same day')
+            expect(table.send(method, traded:  20171227,   settled:  20171227 )).to eq(status: 'same day')
+            expect(table.send(method, traded: '20171227',  settled: '20171228')).to eq(status: 'pending')
+            expect(table.send(method, traded:  20171227,   settled:  20171228 )).to eq(status: 'pending')
+            expect(table.send(method, traded: '20171228',  settled: '20171227')).to eq(status: 'invalid trade')
+            expect(table.send(method, traded:  20171228,   settled:  20171227 )).to eq(status: 'invalid trade')
+            expect(table.send(method, traded: '20171227',   settled: 20171228 )).to eq(status: 'invalid data')
+          end
+        end
+      end
+    end
   end
 end

data/spec/data/valid/simple_constants.csv

@@ -1,5 +1,5 @@
 in :constant,out :type
-:=nil,        NilClass
-==0,          Zero
-:=100.0,      100%
+:=nil,        := nil
+==0,          =0
+:=100.0,      =100.0
 ,             Unrecognized

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: csv_decision
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Brett Vickers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-23 00:00:00.000000000 Z
+date: 2017-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -185,6 +185,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".coveralls.yml"
 - ".gitignore"
 - ".rspec"
@@ -194,39 +195,91 @@ files:
 - Gemfile
 - LICENSE
 - README.md
-- benchmark.rb
+- benchmarks/rufus_decision.rb
 - csv_decision.gemspec
+- doc/CSVDecision.html
+- doc/CSVDecision/CellValidationError.html
+- doc/CSVDecision/Columns.html
+- doc/CSVDecision/Columns/Default.html
+- doc/CSVDecision/Columns/Dictionary.html
+- doc/CSVDecision/Columns/Entry.html
+- doc/CSVDecision/Constant.html
+- doc/CSVDecision/Data.html
+- doc/CSVDecision/Decide.html
+- doc/CSVDecision/Decision.html
+- doc/CSVDecision/Error.html
+- doc/CSVDecision/FileError.html
+- doc/CSVDecision/Function.html
+- doc/CSVDecision/Header.html
+- doc/CSVDecision/Input.html
+- doc/CSVDecision/Load.html
+- doc/CSVDecision/Matchers.html
+- doc/CSVDecision/Matchers/Constant.html
+- doc/CSVDecision/Matchers/Function.html
+- doc/CSVDecision/Matchers/Matcher.html
+- doc/CSVDecision/Matchers/Numeric.html
+- doc/CSVDecision/Matchers/Pattern.html
+- doc/CSVDecision/Matchers/Range.html
+- doc/CSVDecision/Matchers/Symbol.html
+- doc/CSVDecision/Numeric.html
+- doc/CSVDecision/Options.html
+- doc/CSVDecision/Parse.html
+- doc/CSVDecision/ScanRow.html
+- doc/CSVDecision/Symbol.html
+- doc/CSVDecision/Table.html
+- doc/_index.html
+- doc/class_list.html
+- doc/css/common.css
+- doc/css/full_list.css
+- doc/css/style.css
+- doc/file.README.html
+- doc/file_list.html
+- doc/frames.html
+- doc/index.html
+- doc/js/app.js
+- doc/js/full_list.js
+- doc/js/jquery.js
+- doc/method_list.html
+- doc/top-level-namespace.html
 - lib/csv_decision.rb
 - lib/csv_decision/columns.rb
+- lib/csv_decision/constant.rb
 - lib/csv_decision/data.rb
 - lib/csv_decision/decide.rb
 - lib/csv_decision/decision.rb
+- lib/csv_decision/function.rb
 - lib/csv_decision/header.rb
 - lib/csv_decision/input.rb
 - lib/csv_decision/load.rb
 - lib/csv_decision/matchers.rb
+- lib/csv_decision/matchers/constant.rb
 - lib/csv_decision/matchers/function.rb
 - lib/csv_decision/matchers/numeric.rb
 - lib/csv_decision/matchers/pattern.rb
 - lib/csv_decision/matchers/range.rb
+- lib/csv_decision/matchers/symbol.rb
+- lib/csv_decision/numeric.rb
 - lib/csv_decision/options.rb
 - lib/csv_decision/parse.rb
 - lib/csv_decision/scan_row.rb
+- lib/csv_decision/symbol.rb
 - lib/csv_decision/table.rb
-- spec/csv_decision.rb
 - spec/csv_decision/columns_spec.rb
+- spec/csv_decision/constant_spec.rb
 - spec/csv_decision/data_spec.rb
 - spec/csv_decision/decision_spec.rb
+- spec/csv_decision/examples_spec.rb
 - spec/csv_decision/input_spec.rb
 - spec/csv_decision/load_spec.rb
 - spec/csv_decision/matchers/function_spec.rb
 - spec/csv_decision/matchers/numeric_spec.rb
 - spec/csv_decision/matchers/pattern_spec.rb
 - spec/csv_decision/matchers/range_spec.rb
+- spec/csv_decision/matchers/symbol_spec.rb
 - spec/csv_decision/options_spec.rb
 - spec/csv_decision/parse_spec.rb
-- spec/csv_decision/simple_example_spec.rb
 - spec/csv_decision/table_spec.rb
+- spec/csv_decision_spec.rb
 - spec/data/invalid/invalid_header1.csv
 - spec/data/invalid/invalid_header2.csv
 - spec/data/invalid/invalid_header3.csv
@@ -263,20 +316,22 @@ signing_key:
 specification_version: 4
 summary: CSV based Ruby decision tables.
 test_files:
-- spec/csv_decision.rb
 - spec/csv_decision/columns_spec.rb
+- spec/csv_decision/constant_spec.rb
 - spec/csv_decision/data_spec.rb
 - spec/csv_decision/decision_spec.rb
+- spec/csv_decision/examples_spec.rb
 - spec/csv_decision/input_spec.rb
 - spec/csv_decision/load_spec.rb
 - spec/csv_decision/matchers/function_spec.rb
 - spec/csv_decision/matchers/numeric_spec.rb
 - spec/csv_decision/matchers/pattern_spec.rb
 - spec/csv_decision/matchers/range_spec.rb
+- spec/csv_decision/matchers/symbol_spec.rb
 - spec/csv_decision/options_spec.rb
 - spec/csv_decision/parse_spec.rb
-- spec/csv_decision/simple_example_spec.rb
 - spec/csv_decision/table_spec.rb
+- spec/csv_decision_spec.rb
 - spec/data/invalid/invalid_header1.csv
 - spec/data/invalid/invalid_header2.csv
 - spec/data/invalid/invalid_header3.csv

data/spec/csv_decision/simple_example_spec.rb

@@ -1,75 +0,0 @@
-# frozen_string_literal: true
-
-require_relative '../../lib/csv_decision'
-
-context 'simple example - strings-only' do
-  data = <<~DATA
-    in :topic, in :region,  out :team_member
-    sports,    Europe,      Alice
-    sports,    ,            Bob
-    finance,   America,     Charlie
-    finance,   Europe,      Donald
-    finance,   ,            Ernest
-    politics,  Asia,        Fujio
-    politics,  America,     Gilbert
-    politics,  ,            Henry
-    ,          ,            Zach
-  DATA
-
-  it 'makes correct decisions for CSV string' do
-    table = CSVDecision.parse(data)
-
-    result = table.decide(topic: 'finance', region: 'Europe')
-    expect(result).to eq(team_member: 'Donald')
-
-    result = table.decide(topic: 'sports', region: nil)
-    expect(result).to eq(team_member: 'Bob')
-
-    result = table.decide(topic: 'culture', region: 'America')
-    expect(result).to eq(team_member: 'Zach')
-  end
-
-  it 'makes correct decisions for CSV file' do
-    table = CSVDecision.parse(Pathname('spec/data/valid/simple_example.csv'))
-
-    result = table.decide(topic: 'finance', region: 'Europe')
-    expect(result).to eq(team_member: 'Donald')
-
-    result = table.decide(topic: 'sports', region: nil)
-    expect(result).to eq(team_member: 'Bob')
-
-    result = table.decide(topic: 'culture', region: 'America')
-    expect(result).to eq(team_member: 'Zach')
-  end
-end
-
-context 'simple example - constants' do
-  data = <<~DATA
-    in :constant, out :type
-    :=nil,        NilClass
-    ==false,      FALSE
-    =true,        TRUE
-    = 0,          Zero
-    :=100.0,      100%
-  DATA
-
-  it 'makes correct decisions for CSV string' do
-    table = CSVDecision.parse(data)
-
-    result = table.decide(constant: nil)
-    expect(result).to eq(type: 'NilClass')
-
-    result = table.decide(constant: true)
-    expect(result).to eq(type: 'TRUE')
-
-    result = table.decide(constant: false)
-    expect(result).to eq(type: 'FALSE')
-
-    result = table.decide(constant: 0)
-    expect(result).to eq(type: 'Zero')
-
-    result = table.decide(constant: BigDecimal.new('100.0'))
-    expect(result).to eq(type: '100%')
-  end
-end
-