csv_decision 0.0.1 → 0.0.2

data/spec/csv_decision/parse_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../../lib/csv_decision/parse'
+require_relative '../../lib/csv_decision'
 
 describe CSVDecision::Parse do
   it 'loads an empty decision table' do
@@ -15,7 +15,6 @@ describe CSVDecision::Parse do
     result = CSVDecision.parse(file)
 
     expected = [
-      ['IN :input', 'OUT :output'],
       ['input', '']
     ]
 
@@ -27,7 +26,7 @@ describe CSVDecision::Parse do
     Dir[File.join(CSVDecision.root, 'spec/data/valid/*.csv')].each do |file_name|
       pathname = Pathname(file_name)
 
-      it "loads CSV file #{pathname.basename}" do
+      it "loads CSV file: #{pathname.basename}" do
         expect { CSVDecision.parse(pathname) }.not_to raise_error
         expect(CSVDecision.parse(pathname)).to be_a CSVDecision::Table
       end

data/spec/csv_decision/simple_example_spec.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+require_relative '../../lib/csv_decision'
+
+context 'simple example' do
+  data = <<~DATA
+    in :topic, in :region,  out :team_member
+    sports,    Europe,      Alice
+    sports,    ,            Bob
+    finance,   America,     Charlie
+    finance,   Europe,      Donald
+    finance,   ,            Ernest
+    politics,  Asia,        Fujio
+    politics,  America,     Gilbert
+    politics,  ,            Henry
+    ,          ,            Zach
+  DATA
+
+  it 'makes correct decisions for CSV string' do
+    table = CSVDecision.parse(data)
+
+    result = table.decide(topic: 'finance', region: 'Europe')
+    expect(result).to eq(team_member: 'Donald')
+
+    result = table.decide(topic: 'sports', region: nil)
+    expect(result).to eq(team_member: 'Bob')
+
+    result = table.decide(topic: 'culture', region: 'America')
+    expect(result).to eq(team_member: 'Zach')
+  end
+
+
+  it 'makes correct decisions for CSV file' do
+    table = CSVDecision.parse(Pathname('spec/data/valid/simple_example.csv'))
+
+    result = table.decide(topic: 'finance', region: 'Europe')
+    expect(result).to eq(team_member: 'Donald')
+
+    result = table.decide(topic: 'sports', region: nil)
+    expect(result).to eq(team_member: 'Bob')
+
+    result = table.decide(topic: 'culture', region: 'America')
+    expect(result).to eq(team_member: 'Zach')
+  end
+end

data/spec/csv_decision/table_spec.rb

@@ -0,0 +1,151 @@
+# frozen_string_literal: true
+
+require_relative '../../lib/csv_decision'
+
+SPEC_DATA_VALID ||= File.join(CSVDecision.root, 'spec', 'data', 'valid')
+
+describe CSVDecision::Table do
+  describe '#decide' do
+    context 'makes correct decisions for simple, text-only tables' do
+      examples = [
+        {
+          example: 'parses CSV file',
+          options: {},
+          data: Pathname(File.join(SPEC_DATA_VALID, 'simple_example.csv'))
+        },
+        {
+          example: 'parses data array',
+          options: {},
+          data: [
+            ['in :topic', 'in :region', 'out :team member'],
+            ['sports',    'Europe',     'Alice'],
+            ['sports',    '',           'Bob'],
+            ['finance',   'America',    'Charlie'],
+            ['finance',   'Europe',     'Donald'],
+            ['finance',   '',           'Ernest'],
+            ['politics',  'Asia',       'Fujio'],
+            ['politics',  'America',    'Gilbert'],
+            ['politics',   '',          'Henry'],
+            ['',           '',          'Zach']
+          ]
+        },
+      ]
+      examples.each do |test|
+        %i[decide decide!].each do |method|
+          it "#{method} correctly #{test[:example]} with first_match: true" do
+            options = test[:options].merge(first_match: true)
+            table = CSVDecision.parse(test[:data], options)
+
+            expect(table.send(method, topic: 'finance', region: 'Europe')).to eq(team_member: 'Donald')
+            expect(table.send(method, topic: 'sports',  region: nil)).to eq(team_member: 'Bob')
+            expect(table.send(method, topic: 'culture', region: 'America')).to eq(team_member: 'Zach')
+          end
+
+          it "#{method} correctly #{test[:example]} with first_match: false" do
+            options = test[:options].merge(first_match: false)
+            table = CSVDecision.parse(test[:data], options)
+
+            expect(table.send(method, topic: 'finance', region: 'Europe'))
+              .to eq(team_member: %w[Donald Ernest Zach])
+            expect(table.send(method, topic: 'sports',  region: nil))
+              .to eq(team_member: %w[Bob Zach])
+            expect(table.send(method, topic: 'culture', region: 'America'))
+              .to eq(team_member: 'Zach')
+          end
+        end
+      end
+    end
+
+    context 'makes correct decisions for a table with regexps and ranges' do
+      examples = [
+        {
+          example: 'implicit regular expressions',
+          options: { regexp_implicit: true },
+          data: <<~DATA
+            in :age,   in :trait,  out :salesperson
+            18..35,    maniac,      Adelsky
+            23..40,    bad|maniac,  Bronco
+            36..50,    bad.*,       Espadas
+            51..78,    ,            Thorsten
+            44..100,   !~ maniac,   Ojiisan
+            > 100,     maniac.*,    Chester
+            23..35,    .*rich,      Kerfelden
+            ,          cheerful,    Swanson
+            ,          maniac,      Korolev
+          DATA
+        },
+        {
+          example: 'explicit regular expressions',
+          options: { regexp_implicit: false },
+          data: <<~DATA
+            in :age,   in :trait,     out :salesperson
+            18..35,    maniac,        Adelsky
+            23..40,    =~ bad|maniac, Bronco
+            36..50,    =~ bad.*,      Espadas
+            51..78,    ,              Thorsten
+            44..100,   !~ maniac,     Ojiisan
+            > 100,     =~ maniac.*,   Chester
+            23..35,    =~ .*rich,     Kerfelden
+            ,          cheerful,      Swanson
+            ,          maniac,        Korolev
+          DATA
+        },
+        {
+          example: 'multiple in column references',
+          options: { regexp_implicit: false },
+          data: <<~DATA
+            in :age,  in :age, in :trait,     out :salesperson
+            >= 18,    <= 35,   maniac,        Adelsky
+            >= 23,    <= 40,   =~ bad|maniac, Bronco
+            >= 36,    <= 50,   =~ bad.*,      Espadas
+            >= 51,    <= 78,   ,              Thorsten
+            >= 44,    <= 100,  != maniac,     Ojiisan
+            > 100,    ,        =~ maniac.*,   Chester
+            >= 23,    <= 35,   =~ .*rich,     Kerfelden
+            ,         ,        cheerful,      Swanson
+            ,         ,        maniac,        Korolev
+          DATA
+        },
+      ]
+      examples.each do |test|
+        %i[decide decide!].each do |method|
+          it "#{method} correctly uses #{test[:example]} with first_match: true" do
+            options = test[:options].merge(first_match: true)
+            table = CSVDecision.parse(test[:data], options)
+
+            expect(table.send(method, age:  72)).to eq(salesperson: 'Thorsten')
+            expect(table.send(method, age:  25, trait: 'very rich')).to eq(salesperson: 'Kerfelden')
+            expect(table.send(method, age:  25, trait: 'maniac')).to eq(salesperson: 'Adelsky')
+            expect(table.send(method, age:  44, trait: 'maniac')).to eq(salesperson: 'Korolev')
+            expect(table.send(method, age: 101, trait: 'maniacal')).to eq(salesperson: 'Chester')
+            expect(table.send(method, age:  45, trait: 'cheerful')).to eq(salesperson: 'Ojiisan')
+            expect(table.send(method, age:  49, trait: 'bad')).to eq(salesperson: 'Espadas')
+            expect(table.send(method, age:  40, trait: 'maniac')).to eq(salesperson: 'Bronco')
+          end
+
+          it "#{method} correctly uses #{test[:example]} with first_match: false" do
+            options = test[:options].merge(first_match: false)
+            table = CSVDecision.parse(test[:data], options)
+
+            expect(table.send(method, age:  72))
+              .to eq(salesperson: %w[Thorsten Ojiisan])
+            expect(table.send(method, age:  25, trait: 'very rich'))
+              .to eq(salesperson: 'Kerfelden')
+            expect(table.send(method, age:  25, trait: 'maniac'))
+              .to eq(salesperson: %w[Adelsky Bronco Korolev])
+            expect(table.send(method, age:  44, trait: 'maniac'))
+              .to eq(salesperson: 'Korolev')
+            expect(table.send(method, age: 101, trait: 'maniacal'))
+              .to eq(salesperson: 'Chester')
+            expect(table.send(method, age:  45, trait: 'cheerful'))
+              .to eq(salesperson: %w[Ojiisan Swanson])
+            expect(table.send(method, age:  49, trait: 'bad'))
+              .to eq(salesperson: %w[Espadas Ojiisan])
+            expect(table.send(method, age:  40, trait: 'maniac'))
+              .to eq(salesperson: %w[Bronco Korolev])
+          end
+        end
+      end
+    end
+  end
+end

data/spec/data/invalid/invalid_header1.csv

@@ -0,0 +1,4 @@
+#comment,
+IN :input,BAD :output
+input,#output
+,#end comment

data/spec/data/invalid/invalid_header2.csv

@@ -0,0 +1,4 @@
+#comment,
+IN :input,BAD :-
+input,#output
+,#end comment

data/spec/data/invalid/invalid_header3.csv

@@ -0,0 +1,4 @@
+#comment,
+IN :input,IN :
+input,#output
+,#end comment

data/spec/data/invalid/invalid_header4.csv

@@ -0,0 +1,4 @@
+#comment,
+IN :input,IN :a-b
+input,#output
+,#end comment

data/spec/data/valid/options_in_file1.csv

@@ -0,0 +1,5 @@
+#comment,
+accumulate
+IN :input,OUT :output
+input,#output
+,#end comment

data/spec/data/valid/options_in_file2.csv

@@ -0,0 +1,5 @@
+#comment,
+accumulate
+regexp_implicit
+IN :input,OUT :output
+input,#output

data/spec/data/valid/simple_example.csv

@@ -0,0 +1,10 @@
+in:topic,in:region,out:team_member
+sports,Europe,Alice
+sports,,Bob
+finance,America,Charlie
+finance,Europe,Donald
+finance,,Ernest
+politics,Asia,Fujio
+politics,America,Gilbert
+politics,,Henry
+,,Zach

data/spec/data/valid/valid.csv

@@ -1,4 +1,4 @@
-#comment,
-IN :input,OUT :output
-input,#output
-,#end comment
+,#input columns,#empty column,#output column,#empty column
+#header,IN :input,,OUT :output,
+#data,input,,#output,
+,,,#end comment,

data/spec/spec_helper.rb

@@ -12,6 +12,12 @@
 # the additional setup, and require it from the spec files that actually need
 # it.
 #
+require 'active_support'
+require 'active_support/core_ext'
+require 'json'
+require 'coveralls'
+Coveralls.wear!
+
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
   # rspec-expectations config goes here. You can use an alternate

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: csv_decision
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Brett Vickers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-18 00:00:00.000000000 Z
+date: 2017-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,14 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.1'
+- !ruby/object:Gem::Dependency
+  name: ice_nine
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.11'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.11'
+- !ruby/object:Gem::Dependency
+  name: values
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
   requirement: !ruby/object:Gem::Requirement
@@ -100,28 +128,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: '3.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: '3.7'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.51'
+        version: '0.52'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.51'
+        version: '0.52'
 - !ruby/object:Gem::Dependency
   name: rufus-decision
   requirement: !ruby/object:Gem::Requirement
@@ -142,14 +170,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.12'
+        version: '0.15'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.12'
+        version: '0.15'
 description: CSV based Ruby decision tables.
 email:
 - brett@phillips-vickers.com
@@ -157,22 +185,54 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".coveralls.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
+- LICENSE
 - README.md
+- benchmark.rb
 - csv_decision.gemspec
 - lib/csv_decision.rb
+- lib/csv_decision/columns.rb
 - lib/csv_decision/data.rb
+- lib/csv_decision/decide.rb
+- lib/csv_decision/decision.rb
 - lib/csv_decision/header.rb
+- lib/csv_decision/input.rb
+- lib/csv_decision/load.rb
+- lib/csv_decision/matchers.rb
+- lib/csv_decision/matchers/numeric.rb
+- lib/csv_decision/matchers/pattern.rb
+- lib/csv_decision/matchers/range.rb
 - lib/csv_decision/options.rb
 - lib/csv_decision/parse.rb
+- lib/csv_decision/scan_row.rb
 - lib/csv_decision/table.rb
 - spec/csv_decision.rb
+- spec/csv_decision/columns_spec.rb
 - spec/csv_decision/data_spec.rb
+- spec/csv_decision/decision_spec.rb
+- spec/csv_decision/input_spec.rb
+- spec/csv_decision/load_spec.rb
+- spec/csv_decision/matchers/numeric_spec.rb
+- spec/csv_decision/matchers/pattern_spec.rb
+- spec/csv_decision/matchers/range_spec.rb
+- spec/csv_decision/options_spec.rb
 - spec/csv_decision/parse_spec.rb
+- spec/csv_decision/simple_example_spec.rb
+- spec/csv_decision/table_spec.rb
+- spec/data/invalid/invalid_header1.csv
+- spec/data/invalid/invalid_header2.csv
+- spec/data/invalid/invalid_header3.csv
+- spec/data/invalid/invalid_header4.csv
 - spec/data/valid/empty.csv
+- spec/data/valid/options_in_file1.csv
+- spec/data/valid/options_in_file2.csv
+- spec/data/valid/simple_example.csv
 - spec/data/valid/valid.csv
 - spec/spec_helper.rb
 homepage: https://github.com/bpvickers/csv_decision.git
@@ -187,7 +247,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.1
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -195,14 +255,31 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: CSV based Ruby decision tables.
 test_files:
 - spec/csv_decision.rb
+- spec/csv_decision/columns_spec.rb
 - spec/csv_decision/data_spec.rb
+- spec/csv_decision/decision_spec.rb
+- spec/csv_decision/input_spec.rb
+- spec/csv_decision/load_spec.rb
+- spec/csv_decision/matchers/numeric_spec.rb
+- spec/csv_decision/matchers/pattern_spec.rb
+- spec/csv_decision/matchers/range_spec.rb
+- spec/csv_decision/options_spec.rb
 - spec/csv_decision/parse_spec.rb
+- spec/csv_decision/simple_example_spec.rb
+- spec/csv_decision/table_spec.rb
+- spec/data/invalid/invalid_header1.csv
+- spec/data/invalid/invalid_header2.csv
+- spec/data/invalid/invalid_header3.csv
+- spec/data/invalid/invalid_header4.csv
 - spec/data/valid/empty.csv
+- spec/data/valid/options_in_file1.csv
+- spec/data/valid/options_in_file2.csv
+- spec/data/valid/simple_example.csv
 - spec/data/valid/valid.csv
 - spec/spec_helper.rb