csv-probe 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4ea99229e9677a6c02d4197055be87cf2d7f052d1290cffad61a0cfb93c40175
-  data.tar.gz: 4fbfbb4f010b5582a18671dd64a31bc8802fd831fb3dd3c4a5c447f9b2fd97d8
+  metadata.gz: 2425404adecef9f68fced84863e0acb087f3358935032c3849cab690948e74dc
+  data.tar.gz: 0bf460f9f27439cdcba3150c2f53991ab07512e6e1ffb5195315fdad5689c549
 SHA512:
-  metadata.gz: 50b07ec40e594dfcf0e081ba5fbb8f625a993e7f7aadd48c4027346e1589ec5e61767ff14d8950c078d934ad1f3ecc8818d7a6be4721a73210cb41fdf63a15ba
-  data.tar.gz: 3bf6d4365cb06bde99db33d52dbfea06ea202344dcab334723a39d20ce27eba91a53d49464d0af3132b83302d2d9942bd09cdcd3943661b9c702788f7e04f523
+  metadata.gz: 721e33de3a86d0513dcaab1d0d102454fbcf48492dd6d551ec1f5623de6c0b7ba74189ea7d6ae8825eb34674b2679f251e50c08e87fabf1ae18a993cdc72eaff
+  data.tar.gz: 042b6b18255ddbb787c7318febbc31147e4e593cbedf67047bc25c962491a9a46b3e664841a18ea3b8bfb25ef4025455391a4c7571dbf1a37072bb75c64967f8

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## [Unreleased]
 
+## [0.1.4] - 2022-01-05
+- Fix `nil` handling for list + set column checks when the list or set is something like this:
+  - `a,|b|,b` leading and trailing empty items or 
+  - `a,,b` the whole list/set string is nil
+
 ## [0.1.3] - 2022-01-04
 - Add better `nil` handling to list + set column checks. `nil` resp. `""` does no longer implicitly pass ColumnIsListWithDomain and ColumnIsSetWithDomain checks. `nil` or `""` has to be in the expected items in order to pass the check now.
 

data/lib/csv/probe/checks.rb

@@ -193,13 +193,15 @@ module Probe
       @ok_condition_fn = lambda { |val, _cfg|
         expected_items_arr.map!(&:to_s) # turn nil -> ""
 
-        items = val.split(separator)
-        return true if items.empty? && expected_items_arr.include?("") # empty str allowed
+        items = val.to_s.split(separator, -1)
+        return true if items.empty? && expected_items_arr.include?(nil.to_s) # empty str allowed
+
+        return false if items.empty?
 
         return items.all? { |e| expected_items_arr.include?(e) }
       }
       @fail_msg = lambda { |row, _opts|
-        items = row.fetch(@varname).split(separator)
+        items = row.fetch(@varname).to_s.split(separator, -1)
         diff_items = items - expected_items_arr
         "expected that tokenized items of value #{items.inspect} are a subset of "\
           "#{expected_items_arr.inspect}, but items #{diff_items.inspect} are not"
@@ -212,12 +214,14 @@ module Probe
     def initialize(varname, separator, _placeholder = nil) # rubocop:disable Metrics/MethodLength
       super(varname, nil, nil)
       @ok_condition_fn = lambda { |val, _cfg|
-        items = val.split(separator)
+        return true if val.to_s == ''
+
+        items = val.to_s.split(separator, -1)
         all_uniq = (items.size == items.uniq.size)
         return all_uniq
       }
       @fail_msg = lambda { |row, _opts|
-        items = row.fetch(@varname).split(separator)
+        items = row.fetch(@varname).to_s.split(separator, -1)
         non_uniq_items = items.detect { |e| items.count(e) > 1 }
         "expected that items of tokenized value #{items.inspect} are uniqe, but items #{non_uniq_items.inspect} are not"
       }
@@ -232,14 +236,16 @@ module Probe
       @ok_condition_fn = lambda { |val, _cfg|
         expected_items_arr.map!(&:to_s) # turn nil -> ""
 
-        items = val.split(separator)
-        return true if items.empty? && expected_items_arr.include?("") # empty str allowed
+        items = val.to_s.split(separator, -1)
+        return true if items.empty? && expected_items_arr.include?(nil.to_s) # empty str allowed
+
+        return false if items.empty?
 
         all_valid = items.all? { |i| expected_items_arr.include?(i) }
         return all_valid
       }
       @fail_msg = lambda { |row, _opts|
-        items = row.fetch(@varname).split(separator)
+        items = row.fetch(@varname).to_s.split(separator, -1)
         "expected that items of tokenized value #{items.inspect} are a subset of #{expected_items_arr.inspect}"
       }
       # @fail_msg = lambda {|row, opts|

data/lib/csv/probe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Probe
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: csv-probe
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - homebase.dev
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-01-04 00:00:00.000000000 Z
+date: 2022-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: csv