csv-probe 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 441ebf45d96b8a4dd857fb07accc96117d38557e89697bfb7bda9f3552dfab0b
-  data.tar.gz: 629343b0c775afa3777c1087862b1ed1116a6c7a71c074fae386a4091d4fa0fa
+  metadata.gz: 4ea99229e9677a6c02d4197055be87cf2d7f052d1290cffad61a0cfb93c40175
+  data.tar.gz: 4fbfbb4f010b5582a18671dd64a31bc8802fd831fb3dd3c4a5c447f9b2fd97d8
 SHA512:
-  metadata.gz: d38d085bb5cdf931e0b28bb392e74fda65cdd0fb5e6a48237fce7416b5c5defc67e1aa311dc3c301fff9a2c86f75fc6ce2be42c5a1ee971c1684086565175f2d
-  data.tar.gz: d50453598bbbd185db46d2d01ab62d72487540d30b24d60cdbcd99bf29a2ba7a44f13e36661837c6cc12dd12d1d1576f88dfe9f65561733b05adf016b233078d
+  metadata.gz: 50b07ec40e594dfcf0e081ba5fbb8f625a993e7f7aadd48c4027346e1589ec5e61767ff14d8950c078d934ad1f3ecc8818d7a6be4721a73210cb41fdf63a15ba
+  data.tar.gz: 3bf6d4365cb06bde99db33d52dbfea06ea202344dcab334723a39d20ce27eba91a53d49464d0af3132b83302d2d9942bd09cdcd3943661b9c702788f7e04f523

data/CHANGELOG.md

@@ -1,11 +1,14 @@
 ## [Unreleased]
 
+## [0.1.3] - 2022-01-04
+- Add better `nil` handling to list + set column checks. `nil` resp. `""` does no longer implicitly pass ColumnIsListWithDomain and ColumnIsSetWithDomain checks. `nil` or `""` has to be in the expected items in order to pass the check now.
+
 ## [0.1.2] - 2022-01-03
-- Fix readme
+- Fix README.md
 
 ## [0.1.1] - 2022-01-02
 - Fix rubocop warnings
-- Improve readme
+- Improve README.md
 
 ## [0.1.0] - 2022-01-02
 

data/README.md

@@ -24,6 +24,9 @@ Or install it yourself as:
 Example how to use Probe
 
 ```ruby
+  # load csv-probe gem
+  require 'csv/probe'
+
   # load CSV into CSV::Table
   csv_table = CSV.parse(<<~ROWS, headers: true)
     col1,col2,col3,col4,col5,col6,col7

data/lib/csv/probe/checks.rb

@@ -191,7 +191,11 @@ module Probe
     def initialize(varname, expected_items_arr, separator, _placeholder = nil) # rubocop:disable Metrics/MethodLength
       super(varname, nil, nil)
       @ok_condition_fn = lambda { |val, _cfg|
+        expected_items_arr.map!(&:to_s) # turn nil -> ""
+
         items = val.split(separator)
+        return true if items.empty? && expected_items_arr.include?("") # empty str allowed
+
         return items.all? { |e| expected_items_arr.include?(e) }
       }
       @fail_msg = lambda { |row, _opts|
@@ -208,8 +212,6 @@ module Probe
     def initialize(varname, separator, _placeholder = nil) # rubocop:disable Metrics/MethodLength
       super(varname, nil, nil)
       @ok_condition_fn = lambda { |val, _cfg|
-        return true if val.to_s == ""
-
         items = val.split(separator)
         all_uniq = (items.size == items.uniq.size)
         return all_uniq
@@ -228,9 +230,11 @@ module Probe
       super(varname, nil, nil)
       @pre_checks << ColumnIsSet.new(varname, separator)
       @ok_condition_fn = lambda { |val, _cfg|
-        return true if val.to_s == ""
+        expected_items_arr.map!(&:to_s) # turn nil -> ""
 
         items = val.split(separator)
+        return true if items.empty? && expected_items_arr.include?("") # empty str allowed
+
         all_valid = items.all? { |i| expected_items_arr.include?(i) }
         return all_valid
       }

data/lib/csv/probe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Probe
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/lib/csv/probe.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "csv"
+require "csv" # TODO: should i require it here?
 require "terminal-table"
 require_relative "probe/version"
 require_relative "probe/checks"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: csv-probe
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - homebase.dev
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-01-02 00:00:00.000000000 Z
+date: 2022-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: csv