csv-importer 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9fb2af22af454df8a5d98c1d4fb2b8045c75c39b
-  data.tar.gz: 0ea722d76a33fc31fe3cea489d95e480b63b188c
+  metadata.gz: 6633b4c3453d25cf7071a1f9cf68f80f82c946cd
+  data.tar.gz: 252b40c27f5e1569af2dac05c5f0bbafa1170777
 SHA512:
-  metadata.gz: 7afd22eabb1c1d6e9aa04aac774f0063e8682e5a58a1c5d3fe339084f47fa8f432c82f80e4f78b5cb37bedc6d82ae4f6d9ddac8c044209510c40053182d45d37
-  data.tar.gz: d52f0d10d2b8916e2f049c69301539fc42e09ef3610955cb1eed8ebf8e398080eab4a7b654d6cf0a19dd51447ea23dc2268ec01c2b209adcc16a0f580b8d55a5
+  metadata.gz: 95ce42e97b4deee80fcb36d0ae9db97f1ba292a3a62cccb9a593c9682a6dffb11e202c3aed0f55c2e55ddd2496a89b9087f5c88af516f2e97faa0cc3e50780a0
+  data.tar.gz: 6da83969a1673e7f96c3356dc86d5462124a5c90e1081005d1a0e6795c0bcf8d3e12afa981d48b8ba4db5b3ce3ecf3e1880cbcd68563ea1ccb7b3af6fabc4118

data/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.3.2] - 2017-01-06
+
+### Fixed
+
+* `after_build` block is only called once ([#47][] by [@fxgallego][] and [#52][]
+  [@pnomolos][])
+* `after_build` and `after_save` blocks don't leak between runtime
+  definitions ([#47][] by [@fxgallego][] and [#52][] [@pnomolos][])
+
 ## [0.3.1] - 2016-05-09
 
 ### Added
@@ -105,5 +114,9 @@ report object instead of raising an exception.
 <!--- The following link definition list is generated by PimpMyChangelog --->
 [#26]: https://github.com/BrewhouseTeam/csv-importer/issues/26
 [#38]: https://github.com/BrewhouseTeam/csv-importer/issues/38
+[#47]: https://github.com/BrewhouseTeam/csv-importer/issues/47
+[#52]: https://github.com/BrewhouseTeam/csv-importer/issues/52
 [@egg-chicken]: https://github.com/egg-chicken
-[@shvetsovdm]: https://github.com/shvetsovdm
+[@pnomolos]: https://github.com/pnomolos
+[@fxgallego]: https://github.com/fxgallego
+[@shvetsovdm]: https://github.com/shvetsovdm

data/README.md

@@ -228,7 +228,7 @@ You can also define a composite identifier:
 
 By default, we skip invalid records and report errors back to the user.
 There are times where you want your import to be an all or nothing. The
-`on_error` option is here for you.
+`when_invalid` option is here for you.
 
 ```ruby
 class ImportUserCSV
@@ -238,7 +238,7 @@ class ImportUserCSV
 
   column :email, to: ->(email) { email.downcase }
 
-  on_error :abort
+  when_invalid :abort
 end
 
 import = ImportUserCSV.new(content: "email\nbob@example.com\nINVALID_EMAIL")
@@ -332,7 +332,7 @@ end
 ### Validate the header
 
 On a web application, as soon as a CSV file is uploaded, you can check
-if it has the required columns. This is handy to fail early an provide
+if it has the required columns. This is handy to fail early and provide
 the user with a meaningful error message right away.
 
 ```ruby

data/lib/csv_importer/config.rb

@@ -10,6 +10,14 @@ module CSVImporter
     attribute :after_build_blocks, Array[Proc], default: []
     attribute :after_save_blocks, Array[Proc], default: []
 
+    def initialize_copy(orig)
+      super
+      self.column_definitions = orig.column_definitions.dup
+      self.identifiers = orig.identifiers.dup
+      self.after_save_blocks = orig.after_save_blocks.dup
+      self.after_build_blocks = orig.after_build_blocks.dup
+    end
+
     def after_build(block)
       self.after_build_blocks << block
     end

data/lib/csv_importer/row.rb

@@ -19,6 +19,9 @@ module CSVImporter
         model = find_or_build_model
 
         set_attributes(model)
+
+        after_build_blocks.each { |block| instance_exec(model, &block) }
+        model
       end
     end
 
@@ -43,8 +46,6 @@ module CSVImporter
         set_attribute(model, column_definition, value)
       end
 
-      after_build_blocks.each { |block| instance_exec(model, &block) }
-
       model
     end
 

data/lib/csv_importer/version.rb

@@ -1,3 +1,3 @@
 module CSVImporter
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: csv-importer
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Philippe Creux
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-05-09 00:00:00.000000000 Z
+date: 2017-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus