csv-import-analyzer 0.0.3 → 0.0.4

data/spec/csv-import-analyzer/csv_sanitizer_spec.rb

@@ -1,24 +1,27 @@
 # require 'spec_helper'
 
-require 'pry'
 describe CsvImportAnalyzer::CsvSanitizer do
+  # May be I should really use subject here
+  # why?
   let (:csv_sanitizer) { CsvImportAnalyzer::CsvSanitizer.new }
-  it 'should handle file not found issue' do
+  it "handles file not found issue - when given a invalid file" do
     expect(csv_sanitizer.process("sample.csv", options = {})).to be_instance_of(FileNotFound)
   end
-  #Testing private methods - Although one should really have to test private methods, it's 
-  context 'testing private methods' do
+  
+  # Testing private methods - Although one shouldn't really have to test private methods
+  # Testing here to make sure the private methods are doing what they are supposed to
+  context "testing private methods" do
     let (:test) {"\"t1\", 't2', \"t3\""}
     let (:res) {"\"t1\", \"t2\", \"t3\""}
-    xit 'should replace single quotes to double' do
+    xit "replaces single quotes to double quotes" do
       binding.pry
       expect(csv_sanitizer.send(:replace_line_single_quotes, test, ",")).to eq(res)
     end
     let (:test) {["t1","t2","",nil,"t3"]}
     let (:res) {["t1","t2","NULL","NULL","t3"]}
-    it 'should replace null values' do
+    it "replaces nil or empty values to NULL" do
       expect(csv_sanitizer.send(:replace_null_values, test)).to eq(res)
     end
   end
 
-end
+end

data/spec/csv-import-analyzer/helpers/common_functions_spec.rb

@@ -3,29 +3,30 @@
 class DummyClass
 end
 
-describe 'null_like?' do
-  
-  before(:each) do
-    @dummy_class = DummyClass.new
-    @dummy_class.extend(CsvImportAnalyzer::Helper)
-  end
-
-  context 'when called on null like objects' do
-    it 'returns NULL as null type' do
-      expect(@dummy_class.null_like?('NULL')).to eq(true)
+describe CsvImportAnalyzer::Helper do
+  describe "#null_like?" do
+    before(:each) do
+      @dummy_class = DummyClass.new
+      @dummy_class.extend(CsvImportAnalyzer::Helper)
     end
 
-    it 'returns \\N as null type' do
-      expect(@dummy_class.null_like?('\N')).to eq(true)
-    end
-  end
+    context "when called on null like objects" do
+      it "returns NULL as null type" do
+        expect(@dummy_class.null_like?("NULL")).to eq(true)
+      end
 
-  context 'when called on non-null objects' do
-    it 'returns hello as not null' do
-      expect(@dummy_class.null_like?('Hello')).to eq(false)
+      it "returns \\N as null type" do
+        expect(@dummy_class.null_like?('\N')).to eq(true)
+      end
     end
-    it 'returns Fixnum(3) as not null' do
-      expect(@dummy_class.null_like?(3)).to eq(false)
+
+    context "when called on non-null objects" do
+      it "returns hello as not null" do
+        expect(@dummy_class.null_like?("Hello")).to eq(false)
+      end
+      it "returns Fixnum(3) as not null" do
+        expect(@dummy_class.null_like?(3)).to eq(false)
+      end
     end
   end
 end

data/spec/csv-import-analyzer/helpers/datatype_validation_spec.rb

@@ -3,70 +3,70 @@ require 'date'
 class DummyClass
 end
 
-describe '#validate_field' do
+describe "#validate_field" do
   
   before(:each) do
     @dummy_class = DummyClass.new
     @dummy_class.extend(CsvImportAnalyzer::DatatypeValidator)
   end
 
-  context 'knows what an integer looks like' do
+  context "knows what an integer looks like" do
     
-    it 'returns Fixnum type as integer' do
+    it "returns Fixnum type as integer" do
       expect(@dummy_class.validate_field(10)).to eq("int")
     end
-    it 'returns Fixnum type with spaces as integer' do
-      expect(@dummy_class.validate_field(' 10 ')).to eq("int")
+    it "returns Fixnum type with spaces as integer" do
+      expect(@dummy_class.validate_field(" 10 ")).to eq("int")
     end
-    it 'returns Fixnum type with comma as integer' do
-      expect(@dummy_class.validate_field('1,000')).to eq("int")
+    it "returns Fixnum type with comma as integer" do
+      expect(@dummy_class.validate_field("1,000")).to eq("int")
     end
-    it 'returns Fixnum type negative number as integer' do
+    it "returns Fixnum type negative number as integer" do
       expect(@dummy_class.validate_field(-3)).to eq("int")
     end
 
   end
 
-  context 'knows what an Float looks like' do
+  context "knows what an Float looks like" do
     
-    it 'returns Float type as float' do
+    it "returns Float type as float" do
       expect(@dummy_class.validate_field(10.0)).to eq("float")
     end
-    it 'returns Float type with spaces as float' do
-      expect(@dummy_class.validate_field(' 10.01 ')).to eq("float")
+    it "returns Float type with spaces as float" do
+      expect(@dummy_class.validate_field(" 10.01 ")).to eq("float")
     end
-    it 'returns Float type with comma as float' do
-      expect(@dummy_class.validate_field('1,000.01')).to eq("float")
+    it "returns Float type with comma as float" do
+      expect(@dummy_class.validate_field("1,000.01")).to eq("float")
     end
-    it 'returns Float type negative number as float' do
+    it "returns Float type negative number as float" do
       expect(@dummy_class.validate_field(-3.3)).to eq("float")
     end
 
   end
   
-  context 'it knows what a date looks like' do
-    it 'return true for a valid date type - dd/mm/yyyy' do
-      expect(@dummy_class.validate_field('31/12/2014')).to eq("date")
+  context "it knows what a date looks like" do
+    it "return true for a valid date type - dd/mm/yyyy" do
+      expect(@dummy_class.validate_field("31/12/2014")).to eq("date")
     end
-    it 'return true for a valid date type - mm/dd/yyyy' do
-      expect(@dummy_class.validate_field('12/31/2014')).to eq("date")
+    it "return true for a valid date type - mm/dd/yyyy" do
+      expect(@dummy_class.validate_field("12/31/2014")).to eq("date")
     end
-    it 'return true for a valid date type - mm-dd-yyyy' do
-      expect(@dummy_class.validate_field('12-31-2014')).to eq("date")
+    it "return true for a valid date type - mm-dd-yyyy" do
+      expect(@dummy_class.validate_field("12-31-2014")).to eq("date")
     end
-    it 'return true for a valid date type - mm dd yyyy' do
-      expect(@dummy_class.validate_field('12 31 2014')).to eq("date")
+    it "return true for a valid date type - mm dd yyyy" do
+      expect(@dummy_class.validate_field("12 31 2014")).to eq("date")
     end
   end 
 
-  context 'it knows what a String looks like' do
-    it 'default to String type' do
+  context "it knows what a String looks like" do
+    it "default to String type" do
       expect(@dummy_class.validate_field("100 testingNow:)")).to eq("string")
     end
-    it 'returns String type as string' do
+    it "returns String type as string" do
       expect(@dummy_class.validate_field("Hello")).to eq("string")
     end
-    it 'returns String type of dates as string' do
+    it "returns String type of dates as string" do
       expect(@dummy_class.validate_field("12 31 2014312")).to eq("string")
       expect(@dummy_class.validate_field("12-31-2014312")).to eq("string")
       expect(@dummy_class.validate_field("12/31/2014312")).to eq("string")

data/spec/csv-import-analyzer/helpers/string_class_extension_spec.rb

@@ -1,17 +1,17 @@
 # require 'spec_helper'
 
-describe 'substr_count' do
-  context 'different possible delimiters' do
-    it 'returns count of commas as delimiter in a string' do
+describe "substr_count" do
+  context "different possible delimiters" do
+    it "returns count of commas as delimiter in a string" do
       expect("hello, hi, how, are you?".substr_count(",")).to eq(3)
     end
-    it 'returns count of semi-colons as delimiter in a string' do
+    it "returns count of semi-colons as delimiter in a string" do
       expect("hello; hi, how, are you?".substr_count(";")).to eq(1)
     end
-    it 'returns count of pipe as delimiter in a string' do
+    it "returns count of pipe as delimiter in a string" do
       expect("hello, hi| how| are you?".substr_count("|")).to eq(2)
     end
-    it 'returns count of tab as delimiter in a string' do
+    it "returns count of tab as delimiter in a string" do
       expect("hello\thi\thow| are you?".substr_count("\t")).to eq(2)
     end
   end

data/spec/csv-import-analyzer/query_builder/mysql_query_helper_spec.rb

@@ -1,53 +1,53 @@
 # require 'spec_helper'
 class DummyClass
 end
-describe '#form_query_for_datatype' do
+describe "#form_query_for_datatype" do
   before(:each) do
     @dummy_class = DummyClass.new
     @dummy_class.extend(CsvImportAnalyzer::MysqlQueryHelper)
   end
-  context 'expected arguments are not set' do
+  context "when expected arguments are not set" do
     let(:args) {Hash[:header => :test]}
     let(:args1) {Hash[:datatype, :test]}
-    it ' returns missing arguments error' do
+    it "returns missing arguments error" do
       expect(@dummy_class.form_query_for_datatype(args)).to be_instance_of(MissingRequiredArguments)
     end
-    it 'returns invalid if set to nil' do
+    it "returns invalid if set to nil" do
       expect(@dummy_class.form_query_for_datatype(args1)).to be_instance_of(MissingRequiredArguments)
     end
   end
 
-  context 'expected arguments are set' do
+  context "when expected arguments are set" do
     let(:args) {Hash[:header => :test, :datatype => :string]}
     let(:args1) {Hash[:header => :test, :datatype => :integer]}
-    it 'returns expected sql query for string' do
+    it "returns expected sql query for string" do
       expect(@dummy_class.form_query_for_datatype(args)).to eq("test varchar(255)")
     end
-    it 'returns expected sql query for numeric' do
+    it "returns expected sql query for numeric" do
       expect(@dummy_class.form_query_for_datatype(args1)).to eq("test integer")
     end
   end
 
 end
-describe '#import_csv' do
+describe "#import_csv" do
   before(:each) do
     @dummy_class = DummyClass.new
     @dummy_class.extend(CsvImportAnalyzer::MysqlQueryHelper)
   end
-  context 'expected arguments are not set' do
+  context "when expected arguments are not set" do
     let(:args) {Hash[:tablename => "test", :delimiter => ","]}
     let(:args1) {Hash[:filename => "test"]}
-    it ' return SqlQueryErrror' do
+    it "returns SqlQueryErrror" do
       expect(@dummy_class.import_csv(args)).to be_instance_of(MissingRequiredArguments)
     end
-    it 'should return SqlQueryErrror' do
+    it "returns SqlQueryErrror" do
       expect(@dummy_class.import_csv(args1)).to be_instance_of(MissingRequiredArguments)
     end
   end
 
-  context 'expected arguments are set' do
+  context "when expected arguments are set" do
     let(:args) {Hash[:tablename => "test", :delimiter => ",", :filename => "sample.csv"]}
-    it 'returns expected import query' do
+    it "returns expected import query" do
       expect(@dummy_class.import_csv(args)).to eq("LOAD DATA INFILE sample.csv INTO TABLE test FIELDS TERMINATED BY ',' ENCLOSED BY '\"' LINES TERMINATED BY '\\n' IGNORE 1 LINES;")
     end
   end

data/spec/csv-import-analyzer/query_builder/pg_query_helper_spec.rb

@@ -1,55 +1,55 @@
 # require 'spec_helper'
 class DummyClass
 end
-describe '#form_query_for_datatype' do
+describe "#form_query_for_datatype" do
   before(:each) do
+    # Creating a dummy object to test the modules.
+    # Extending with dummy object by adding module methods to it using extend
     @dummy_class = DummyClass.new
     @dummy_class.extend(CsvImportAnalyzer::PgQueryHelper)
   end
-  context 'expected arguments are not set' do
+  context "when expected arguments are not set" do
     let(:args) {Hash[:header => :test]}
     let(:args1) {Hash[:datatype, :test]}
-    it ' returns missing arguments error' do
+    it "returns missing arguments error" do
       expect(@dummy_class.form_query_for_datatype(args)).to be_instance_of(MissingRequiredArguments)
     end
-    it 'returns invalid if set to nil' do
+    it "returns invalid if set to nil" do
       expect(@dummy_class.form_query_for_datatype(args1)).to be_instance_of(MissingRequiredArguments)
     end
   end
-
-  context 'expected arguments are set' do
+  context "when expected arguments are set" do
     let(:args) {Hash[:header => :test, :datatype => :string]}
     let(:args1) {Hash[:header => :test, :datatype => :integer]}
-    it 'returns expected sql query for string' do
+    it "returns expected sql query for string" do
       expect(@dummy_class.form_query_for_datatype(args)).to eq("test varchar(255)")
     end
-    it 'returns expected sql query for numeric' do
+    it "returns expected sql query for numeric" do
       expect(@dummy_class.form_query_for_datatype(args1)).to eq("test integer")
     end
   end
-
 end
-describe '#import_csv' do
+describe "#import_csv" do
   before(:each) do
     @dummy_class = DummyClass.new
     @dummy_class.extend(CsvImportAnalyzer::PgQueryHelper)
   end
-  context 'expected arguments are not set' do
+  context "when expected arguments are not set" do
     let(:args) {Hash[:tablename => "test", :delimiter => ","]}
     let(:args1) {Hash[:filename => "test"]}
-    it ' return SqlQueryErrror' do
+    it "returns SqlQueryErrror" do
       expect(@dummy_class.import_csv(args)).to be_instance_of(MissingRequiredArguments)
     end
-    it 'should return SqlQueryErrror' do
+    it "returns SqlQueryErrror" do
       expect(@dummy_class.import_csv(args1)).to be_instance_of(MissingRequiredArguments)
     end
   end
 
-  context 'expected arguments are set' do
+  context "when expected arguments are set" do
     let(:args) {Hash[:tablename => "test", :delimiter => ",", :filename => "filename"]}
-    it 'returns expected import query' do
+    it "returns expected import query" do
       expect(@dummy_class.import_csv(args)).to eq("COPY test FROM 'filename' HEADER DELIMITER ',' CSV NULL AS 'NULL';")
     end
   end
 
-end
+end

data/spec/csv-import-analyzer_spec.rb

@@ -1,14 +1,11 @@
 # require 'spec_helper'
 
-# CsvImportAnalyzer.process("sampleTab.csv", {:metadata_output => true})
-
-
 describe CsvImportAnalyzer do
   include CsvImportAnalyzer
-  it 'should return invalid file as file not found' do
+  it "return invalid file as file not found" do
     expect(CsvImportAnalyzer.process("sample.csv")).to be_instance_of(FileNotFound)
   end
-  it 'should be able to process a valid file' do
+  it "processes a valid file" do
     expect(CsvImportAnalyzer.process($sample_csv_path)).not_to be_instance_of(FileNotFound)
   end
-end
+end

data/spec/fixtures/sample.csv

@@ -1,5 +1,5 @@
 Year ID,Make ID,Model ID,Description ID,Price ID
-1997,Ford,,"ac, abs, moon","3000"
-1999,Chevy,"Venture ""Extended Edition""","",4900.00
+1997,Ford,,"ac, abs, moon","3000
+1999,Chevy,"Venture ""Extended Edition""",",4900.00
 1999,'Chevy',"Venture ""Extended Edition, Very Large""",,5000.00
 1996,Jeep,Grand Che'rokee,"MUST SELL!air, moon roof, loaded",4799.00

data/spec/spec_helper.rb

@@ -1,6 +1,9 @@
 require 'simplecov'
+# Must be ahead of requiring core library to start the code coverage.
 SimpleCov.start
 require 'csv-import-analyzer'
+
+# Path to sample files in the fixtures folder that are made available to all specs for testing
 $sample_csv_path = "/home/avinash/Desktop/csv-import-analyzer/spec/fixtures/sample.csv"
 $sample_ssv_path = "/home/avinash/Desktop/csv-import-analyzer/spec/fixtures/semicolon-sample.csv"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: csv-import-analyzer
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Avinash Vallabhaneni
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-09 00:00:00.000000000 Z
+date: 2014-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -85,6 +85,9 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.17
   type: :runtime
@@ -92,6 +95,9 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.17
 description: Santize large csv files and help in predicting datatypes including min
@@ -123,15 +129,21 @@ files:
 - lib/csv-import-analyzer/query_builder/mysql_query_helper.rb
 - lib/csv-import-analyzer/query_builder/pg_query_helper.rb
 - lib/csv-import-analyzer/query_builder/query_helper.rb
-- lib/csv-import-analyzer/sampleTab.csv
 - lib/csv-import-analyzer/sql_query_builder.rb
 - lib/csv-import-analyzer/version.rb
-- samples/metadata_output.json
+- samples/27_sweep_net_arthropods_1.csv
+- samples/584_ccs_survey_data_2010.csv
+- samples/591_fluxtower_data_corrected_2012.csv
+- samples/5_photos_1.csv
+- samples/80_water_chemistry_1.csv
+- samples/86_dbg_irrigation_rates_1.csv
+- samples/AllstarFull.csv
+- samples/LDP_TenMin.dat
 - samples/sampleTab.csv
+- samples/sampleTab.tsv
 - spec/csv-import-analyzer/analyzer/csv_check_bounds_spec.rb
 - spec/csv-import-analyzer/analyzer/delimiter_identifier_spec.rb
 - spec/csv-import-analyzer/analyzer/file_type_assertion_spec.rb
-- spec/csv-import-analyzer/csv_datatype_analysis_spec.rb
 - spec/csv-import-analyzer/csv_sanitizer_spec.rb
 - spec/csv-import-analyzer/export/metadata_analysis_spec.rb
 - spec/csv-import-analyzer/helpers/common_functions_spec.rb
@@ -176,7 +188,6 @@ test_files:
 - spec/csv-import-analyzer/analyzer/csv_check_bounds_spec.rb
 - spec/csv-import-analyzer/analyzer/delimiter_identifier_spec.rb
 - spec/csv-import-analyzer/analyzer/file_type_assertion_spec.rb
-- spec/csv-import-analyzer/csv_datatype_analysis_spec.rb
 - spec/csv-import-analyzer/csv_sanitizer_spec.rb
 - spec/csv-import-analyzer/export/metadata_analysis_spec.rb
 - spec/csv-import-analyzer/helpers/common_functions_spec.rb