css_parser 1.2.2 → 3.0.0

data/lib/css_parser/rule_set.rb

@@ -1,78 +1,302 @@
+# frozen_string_literal: true
+
+require 'forwardable'
+
 module CssParser
   class RuleSet
     # Patterns for specificity calculations
-    RE_ELEMENTS_AND_PSEUDO_ELEMENTS = /((^|[\s\+\>]+)[\w]+|\:(first\-line|first\-letter|before|after))/i
-    RE_NON_ID_ATTRIBUTES_AND_PSEUDO_CLASSES = /(\.[\w]+)|(\[[\w]+)|(\:(link|first\-child|lang))/i
+    RE_ELEMENTS_AND_PSEUDO_ELEMENTS = /((^|[\s+>]+)\w+|:(first-line|first-letter|before|after))/i.freeze
+    RE_NON_ID_ATTRIBUTES_AND_PSEUDO_CLASSES = /(\.\w+)|(\[\w+)|(:(link|first-child|lang))/i.freeze
+
+    BACKGROUND_PROPERTIES = ['background-color', 'background-image', 'background-repeat', 'background-position', 'background-size', 'background-attachment'].freeze
+    LIST_STYLE_PROPERTIES = ['list-style-type', 'list-style-position', 'list-style-image'].freeze
+    FONT_STYLE_PROPERTIES = ['font-style', 'font-variant', 'font-weight', 'font-size', 'line-height', 'font-family'].freeze
+    FONT_WEIGHT_PROPERTIES = ['font-style', 'font-weight', 'font-variant'].freeze
+    BORDER_STYLE_PROPERTIES = ['border-width', 'border-style', 'border-color'].freeze
+    BORDER_PROPERTIES = ['border', 'border-left', 'border-right', 'border-top', 'border-bottom'].freeze
+    DIMENSION_DIRECTIONS = [:top, :right, :bottom, :left].freeze
+
+    NUMBER_OF_DIMENSIONS = 4
+
+    DIMENSIONS = [
+      ['margin', %w[margin-top margin-right margin-bottom margin-left]],
+      ['padding', %w[padding-top padding-right padding-bottom padding-left]],
+      ['border-color', %w[border-top-color border-right-color border-bottom-color border-left-color]],
+      ['border-style', %w[border-top-style border-right-style border-bottom-style border-left-style]],
+      ['border-width', %w[border-top-width border-right-width border-bottom-width border-left-width]]
+    ].freeze
+
+    WHITESPACE_REPLACEMENT = '___SPACE___'
+
+    # Tokens for parse_declarations!
+    COLON = ':'.freeze
+    SEMICOLON = ';'.freeze
+    LPAREN = '('.freeze
+    RPAREN = ')'.freeze
+    IMPORTANT = '!important'.freeze
+    class Declarations
+      class Value
+        attr_reader :value
+        attr_accessor :important
+
+        def initialize(value, important: nil)
+          self.value = value
+          @important = important unless important.nil?
+        end
+
+        def value=(value)
+          value = value.to_s.sub(/\s*;\s*\Z/, '')
+          self.important = !value.slice!(CssParser::IMPORTANT_IN_PROPERTY_RX).nil?
+          value.strip!
+          raise ArgumentError, 'value is empty' if value.empty?
+
+          @value = value.freeze
+        end
+
+        def to_s
+          important ? "#{value} !important" : value
+        end
+
+        def ==(other)
+          return false unless other.is_a?(self.class)
+
+          value == other.value && important == other.important
+        end
+      end
+
+      extend Forwardable
+
+      def_delegators :declarations, :each, :each_value
+
+      def initialize(declarations = {})
+        self.declarations = {}
+        declarations.each { |property, value| add_declaration!(property, value) }
+      end
+
+      # Add a CSS declaration
+      # @param [#to_s] property that should be added
+      # @param [Value, #to_s] value of the property
+      #
+      # @example
+      #   declarations['color'] = 'blue'
+      #
+      #   puts declarations['color']
+      #   => #<CssParser::RuleSet::Declarations::Value:0x000000000305c730 @important=false, @order=1, @value="blue">
+      #
+      # @example
+      #   declarations['margin'] = '0px auto !important'
+      #
+      #   puts declarations['margin']
+      #   => #<CssParser::RuleSet::Declarations::Value:0x00000000030c1838 @important=true, @order=2, @value="0px auto">
+      #
+      # If the property already exists its value will be over-written unless it was !important and the new value
+      # is not !important.
+      # If the value is empty - property will be deleted
+      def []=(property, value)
+        property = normalize_property(property)
+        currently_important = declarations[property]&.important
+
+        if value.is_a?(Value) && (!currently_important || value.important)
+          declarations[property] = value
+        elsif value.to_s.strip.empty?
+          delete property
+        else
+          value = Value.new(value)
+          declarations[property] = value if !currently_important || value.important
+        end
+      rescue ArgumentError => e
+        raise e.exception, "#{property} #{e.message}"
+      end
+      alias add_declaration! []=
+
+      def [](property)
+        declarations[normalize_property(property)]
+      end
+      alias get_value []
+
+      def key?(property)
+        declarations.key?(normalize_property(property))
+      end
+
+      def size
+        declarations.size
+      end
+
+      # Remove CSS declaration
+      # @param [#to_s] property property to be removed
+      #
+      # @example
+      #   declarations.delete('color')
+      def delete(property)
+        declarations.delete(normalize_property(property))
+      end
+      alias remove_declaration! delete
+
+      # Replace CSS property with multiple declarations
+      # @param [#to_s] property property name to be replaces
+      # @param [Hash<String => [String, Value]>] replacements hash with properties to replace with
+      #
+      # @example
+      #  declarations = Declarations.new('line-height' => '0.25px', 'font' => 'small-caps', 'font-size' => '12em')
+      #  declarations.replace_declaration!('font', {'line-height' => '1px', 'font-variant' => 'small-caps', 'font-size' => '24px'})
+      #  declarations
+      #  => #<CssParser::RuleSet::Declarations:0x00000000029c3018
+      #  @declarations=
+      #  {"line-height"=>#<CssParser::RuleSet::Declarations::Value:0x00000000038ac458 @important=false, @value="1px">,
+      #   "font-variant"=>#<CssParser::RuleSet::Declarations::Value:0x00000000039b3ec8 @important=false, @value="small-caps">,
+      #   "font-size"=>#<CssParser::RuleSet::Declarations::Value:0x00000000029c2c80 @important=false, @value="12em">}>
+      def replace_declaration!(property, replacements, preserve_importance: false)
+        property = normalize_property(property)
+        raise ArgumentError, "property #{property} does not exist" unless key?(property)
+
+        replacement_declarations = self.class.new(replacements)
+
+        if preserve_importance
+          importance = get_value(property).important
+          replacement_declarations.each_value { |value| value.important = importance }
+        end
+
+        replacement_keys = declarations.keys
+        replacement_values = declarations.values
+        property_index = replacement_keys.index(property)
+
+        # We should preserve subsequent declarations of the same properties
+        # and prior important ones if replacement one is not important
+        replacements = replacement_declarations.each.with_object({}) do |(key, replacement), result|
+          existing = declarations[key]
+
+          # No existing -> set
+          unless existing
+            result[key] = replacement
+            next
+          end
 
-    BACKGROUND_PROPERTIES = ['background-color', 'background-image', 'background-repeat', 'background-position', 'background-attachment']
-    LIST_STYLE_PROPERTIES = ['list-style-type', 'list-style-position', 'list-style-image']
+          # Replacement more important than existing -> replace
+          if replacement.important && !existing.important
+            result[key] = replacement
+            replaced_index = replacement_keys.index(key)
+            replacement_keys.delete_at(replaced_index)
+            replacement_values.delete_at(replaced_index)
+            property_index -= 1 if replaced_index < property_index
+            next
+          end
+
+          # Existing is more important than replacement -> keep
+          next if !replacement.important && existing.important
+
+          # Existing and replacement importance are the same,
+          # value which is declared later wins
+          result[key] = replacement if property_index > replacement_keys.index(key)
+        end
+
+        return if replacements.empty?
+
+        replacement_keys.delete_at(property_index)
+        replacement_keys.insert(property_index, *replacements.keys)
+
+        replacement_values.delete_at(property_index)
+        replacement_values.insert(property_index, *replacements.values)
+
+        self.declarations = replacement_keys.zip(replacement_values).to_h
+      end
+
+      def to_s(options = {})
+        str = declarations.reduce(+'') do |memo, (prop, value)|
+          importance = options[:force_important] || value.important ? ' !important' : ''
+          memo << "#{prop}: #{value.value}#{importance}; "
+        end
+        # TODO: Clean-up regexp doesn't seem to work
+        str.gsub!(/^[\s^({)]+|[\n\r\f\t]*|\s+$/mx, '')
+        str.strip!
+        str
+      end
+
+      def ==(other)
+        return false unless other.is_a?(self.class)
+
+        declarations == other.declarations && declarations.keys == other.declarations.keys
+      end
+
+    protected
+
+      attr_reader :declarations
+
+    private
+
+      attr_writer :declarations
+
+      def normalize_property(property)
+        property = property.to_s.downcase
+        property.strip!
+        property
+      end
+    end
+
+    extend Forwardable
+
+    # optional field for storing source reference
+    # File offset range
+    attr_reader :offset
+    # the local or remote location
+    attr_accessor :filename
 
     # Array of selector strings.
-    attr_reader   :selectors
-    
+    attr_reader :selectors
+
     # Integer with the specificity to use for this RuleSet.
-    attr_accessor   :specificity
+    attr_accessor :specificity
+
+    # @!method add_declaration!
+    #   @see CssParser::RuleSet::Declarations#add_declaration!
+    # @!method delete
+    #   @see CssParser::RuleSet::Declarations#delete
+    def_delegators :declarations, :add_declaration!, :delete
+    alias []= add_declaration!
+    alias remove_declaration! delete
+
+    def initialize(*args, selectors: nil, block: nil, offset: nil, filename: nil, specificity: nil) # rubocop:disable Metrics/ParameterLists
+      if args.any?
+        if selectors || block || offset || filename || specificity
+          raise ArgumentError, "don't mix positional and keyword arguments"
+        end
+
+        warn '[DEPRECATION] positional arguments are deprecated use keyword instead.', uplevel: 1
+
+        case args.length
+        when 2
+          selectors, block = args
+        when 3
+          selectors, block, specificity = args
+        when 4
+          filename, offset, selectors, block = args
+        when 5
+          filename, offset, selectors, block, specificity = args
+        else
+          raise ArgumentError
+        end
+      end
 
-    def initialize(selectors, block, specificity = nil)
       @selectors = []
       @specificity = specificity
-      @declarations = {}
-      @order = 0
+
+      unless offset.nil? == filename.nil?
+        raise ArgumentError, 'require both offset and filename or no offset and no filename'
+      end
+
+      @offset = offset
+      @filename = filename
+
       parse_selectors!(selectors) if selectors
       parse_declarations!(block)
     end
 
-
     # Get the value of a property
     def get_value(property)
-      return '' unless property and not property.empty?
-
-      property = property.downcase.strip
-      properties = @declarations.inject('') do |val, (key, data)|
-        #puts "COMPARING #{key} #{key.inspect} against #{property} #{property.inspect}"
-        importance = data[:is_important] ? ' !important' : ''
-        val << "#{data[:value]}#{importance}; " if key.downcase.strip == property
-        val
-      end
-      return properties ? properties.strip : ''
-    end
-    alias_method :[], :get_value
+      return '' unless (value = declarations[property])
 
-    # Add a CSS declaration to the current RuleSet.
-    #
-    #  rule_set.add_declaration!('color', 'blue')
-    #
-    #  puts rule_set['color']
-    #  => 'blue;'
-    #
-    #  rule_set.add_declaration!('margin', '0px auto !important')
-    #
-    #  puts rule_set['margin']
-    #  => '0px auto !important;'
-    #
-    # If the property already exists its value will be over-written.
-    def add_declaration!(property, value)
-      if value.nil? or value.empty?
-        @declarations.delete(property)
-        return
-      end
-      
-      value.gsub!(/;\Z/, '')
-      is_important = !value.gsub!(CssParser::IMPORTANT_IN_PROPERTY_RX, '').nil?
-      property = property.downcase.strip
-      #puts "SAVING #{property}  #{value} #{is_important.inspect}"
-      @declarations[property] = {
-        :value => value, :is_important => is_important, :order => @order += 1
-      }
-    end
-    alias_method :[]=, :add_declaration!
-
-    # Remove CSS declaration from the current RuleSet.
-    #
-    #  rule_set.remove_declaration!('color')
-    def remove_declaration!(property)
-      @declarations.delete(property)
+      "#{value};"
     end
+    alias [] get_value
 
     # Iterate through selectors.
     #
@@ -84,41 +308,29 @@ module CssParser
     #     ...
     #   end
     def each_selector(options = {}) # :yields: selector, declarations, specificity
-      declarations = declarations_to_s(options)
+      decs = declarations.to_s(options)
       if @specificity
-        @selectors.each { |sel| yield sel.strip, declarations, @specificity }
+        @selectors.each { |sel| yield sel.strip, decs, @specificity }
       else
-        @selectors.each { |sel| yield sel.strip, declarations, CssParser.calculate_specificity(sel) }
+        @selectors.each { |sel| yield sel.strip, decs, CssParser.calculate_specificity(sel) }
       end
     end
 
     # Iterate through declarations.
     def each_declaration # :yields: property, value, is_important
-      decs = @declarations.sort { |a,b| a[1][:order].nil? || b[1][:order].nil? ? 0 : a[1][:order] <=> b[1][:order] }
-      decs.each do |property, data|
-        value = data[:value]
-        yield property.downcase.strip, value.strip, data[:is_important]
+      declarations.each do |property_name, value|
+        yield property_name, value.value, value.important
       end
     end
 
     # Return all declarations as a string.
-    #--
-    # TODO: Clean-up regexp doesn't seem to work
-    #++
     def declarations_to_s(options = {})
-     options = {:force_important => false}.merge(options)
-     str = ''
-     each_declaration do |prop, val, is_important|
-       importance = (options[:force_important] || is_important) ? ' !important' : ''
-       str += "#{prop}: #{val}#{importance}; "
-     end
-     str.gsub(/^[\s^(\{)]+|[\n\r\f\t]*|[\s]+$/mx, '').strip
+      declarations.to_s(options)
     end
 
     # Return the CSS rule set as a string.
     def to_s
-      decs = declarations_to_s
-      "#{@selectors.join} { #{decs} }"
+      "#{@selectors.join(',')} { #{declarations} }"
     end
 
     # Split shorthand declarations (e.g. +margin+ or +font+) into their constituent parts.
@@ -136,134 +348,131 @@ module CssParser
     #
     # See http://www.w3.org/TR/CSS21/colors.html#propdef-background
     def expand_background_shorthand! # :nodoc:
-      return unless @declarations.has_key?('background')
+      return unless (declaration = declarations['background'])
 
-      value = @declarations['background'][:value]
+      value = declaration.value.dup
 
-      if value =~ CssParser::RE_INHERIT
-        BACKGROUND_PROPERTIES.each do |prop|
-          split_declaration('background', prop, 'inherit')
+      replacement =
+        if value.match(CssParser::RE_INHERIT)
+          BACKGROUND_PROPERTIES.to_h { |key| [key, 'inherit'] }
+        else
+          {
+            'background-image' => value.slice!(CssParser::RE_IMAGE),
+            'background-attachment' => value.slice!(CssParser::RE_SCROLL_FIXED),
+            'background-repeat' => value.slice!(CssParser::RE_REPEAT),
+            'background-color' => value.slice!(CssParser::RE_COLOUR),
+            'background-size' => extract_background_size_from(value),
+            'background-position' => value.slice!(CssParser::RE_BACKGROUND_POSITION)
+          }
         end
-      end
 
-      split_declaration('background', 'background-image', value.slice!(Regexp.union(CssParser::URI_RX, /none/i)))
-      split_declaration('background', 'background-attachment', value.slice!(CssParser::RE_SCROLL_FIXED))
-      split_declaration('background', 'background-repeat', value.slice!(CssParser::RE_REPEAT))
-      split_declaration('background', 'background-color', value.slice!(CssParser::RE_COLOUR))
-      split_declaration('background', 'background-position', value.slice(CssParser::RE_BACKGROUND_POSITION))
+      declarations.replace_declaration!('background', replacement, preserve_importance: true)
+    end
+
+    def extract_background_size_from(value)
+      size = value.slice!(CssParser::RE_BACKGROUND_SIZE)
 
-      @declarations.delete('background')
+      size.sub(%r{^\s*/\s*}, '') if size
     end
 
     # Split shorthand border declarations (e.g. <tt>border: 1px red;</tt>)
     # Additional splitting happens in expand_dimensions_shorthand!
     def expand_border_shorthand! # :nodoc:
-      ['border', 'border-left', 'border-right', 'border-top', 'border-bottom'].each do |k|
-        next unless @declarations.has_key?(k)
+      BORDER_PROPERTIES.each do |k|
+        next unless (declaration = declarations[k])
 
-        value = @declarations[k][:value]
+        value = declaration.value.dup
 
-        split_declaration(k, "#{k}-width", value.slice!(CssParser::RE_BORDER_UNITS))
-        split_declaration(k, "#{k}-color", value.slice!(CssParser::RE_COLOUR))
-        split_declaration(k, "#{k}-style", value.slice!(CssParser::RE_BORDER_STYLE))
+        replacement = {
+          "#{k}-width" => value.slice!(CssParser::RE_BORDER_UNITS),
+          "#{k}-color" => value.slice!(CssParser::RE_COLOUR),
+          "#{k}-style" => value.slice!(CssParser::RE_BORDER_STYLE)
+        }
 
-        @declarations.delete(k)   
+        declarations.replace_declaration!(k, replacement, preserve_importance: true)
       end
     end
 
     # Split shorthand dimensional declarations (e.g. <tt>margin: 0px auto;</tt>)
     # into their constituent parts.  Handles margin, padding, border-color, border-style and border-width.
     def expand_dimensions_shorthand! # :nodoc:
-      {'margin'       => 'margin-%s',
-       'padding'      => 'padding-%s',
-       'border-color' => 'border-%s-color', 
-       'border-style' => 'border-%s-style', 
-       'border-width' => 'border-%s-width'}.each do |property, expanded|
+      DIMENSIONS.each do |property, (top, right, bottom, left)|
+        next unless (declaration = declarations[property])
 
-        next unless @declarations.has_key?(property)
-        
-        value = @declarations[property][:value]
+        value = declaration.value.dup
 
         # RGB and HSL values in borders are the only units that can have spaces (within params).
-        # We cheat a bit here by stripping spaces after commas in RGB and HSL values so that we 
+        # We cheat a bit here by stripping spaces after commas in RGB and HSL values so that we
         # can split easily on spaces.
         #
         # TODO: rgba, hsl, hsla
-        value.gsub!(RE_COLOUR) { |c| c.gsub(/[\s]+/, '') }
-
-        matches = value.strip.split(/[\s]+/)
+        value.gsub!(RE_COLOUR) { |c| c.gsub(/(\s*,\s*)/, ',') }
 
-        t, r, b, l = nil
+        matches = split_value_preserving_function_whitespace(value)
 
         case matches.length
-          when 1
-            t, r, b, l = matches[0], matches[0], matches[0], matches[0]
-          when 2
-            t, b = matches[0], matches[0]
-            r, l = matches[1], matches[1]
-          when 3
-            t =  matches[0]
-            r, l = matches[1], matches[1]
-            b =  matches[2]
-          when 4
-            t =  matches[0]
-            r = matches[1]
-            b =  matches[2]
-            l = matches[3]
+        when 1
+          values = matches.to_a * 4
+        when 2
+          values = matches.to_a * 2
+        when 3
+          values = matches.to_a
+          values << matches[1] # left = right
+        when 4
+          values = matches.to_a
+        else
+          raise ArgumentError, "Cannot parse #{value}"
         end
 
-        split_declaration(property, expanded % 'top', t)
-        split_declaration(property, expanded % 'right', r)
-        split_declaration(property, expanded % 'bottom', b)
-        split_declaration(property, expanded % 'left', l)
+        replacement = [top, right, bottom, left].zip(values).to_h
 
-        @declarations.delete(property)
+        declarations.replace_declaration!(property, replacement, preserve_importance: true)
       end
     end
 
     # Convert shorthand font declarations (e.g. <tt>font: 300 italic 11px/14px verdana, helvetica, sans-serif;</tt>)
     # into their constituent parts.
     def expand_font_shorthand! # :nodoc:
-      return unless @declarations.has_key?('font')
-
-      font_props = {}
+      return unless (declaration = declarations['font'])
 
       # reset properties to 'normal' per http://www.w3.org/TR/CSS21/fonts.html#font-shorthand
-      ['font-style', 'font-variant', 'font-weight', 'font-size',
-       'line-height'].each do |prop|
-        font_props[prop] = 'normal'
-       end
+      font_props = {
+        'font-style' => 'normal',
+        'font-variant' => 'normal',
+        'font-weight' => 'normal',
+        'font-size' => 'normal',
+        'line-height' => 'normal'
+      }
 
-      value = @declarations['font'][:value]
-      is_important = @declarations['font'][:is_important]
-      order = @declarations['font'][:order]
+      value = declaration.value.dup
+      value.gsub!(%r{/\s+}, '/') # handle spaces between font size and height shorthand (e.g. 14px/ 16px)
 
       in_fonts = false
 
-      matches = value.scan(/("(.*[^"])"|'(.*[^'])'|(\w[^ ,]+))/)
-      matches.each do |match|
-        m = match[0].to_s.strip
-        m.gsub!(/[;]$/, '')
+      matches = value.scan(/"(?:.*[^"])"|'(?:.*[^'])'|(?:\w[^ ,]+)/)
+      matches.each do |m|
+        m.strip!
+        m.gsub!(/;$/, '')
 
         if in_fonts
-          if font_props.has_key?('font-family')
-            font_props['font-family'] += ', ' + m
+          if font_props.key?('font-family')
+            font_props['font-family'] += ", #{m}"
           else
             font_props['font-family'] = m
           end
-        elsif m =~ /normal|inherit/i
-          ['font-style', 'font-weight', 'font-variant'].each do |font_prop|
-            font_props[font_prop] = m unless font_props.has_key?(font_prop)
+        elsif /normal|inherit/i.match?(m)
+          FONT_WEIGHT_PROPERTIES.each do |font_prop|
+            font_props[font_prop] ||= m
           end
-        elsif m =~ /italic|oblique/i
+        elsif /italic|oblique/i.match?(m)
           font_props['font-style'] = m
-        elsif m =~ /small\-caps/i
+        elsif /small-caps/i.match?(m)
           font_props['font-variant'] = m
-        elsif m =~ /[1-9]00$|bold|bolder|lighter/i
+        elsif /[1-9]00$|bold|bolder|lighter/i.match?(m)
           font_props['font-weight'] = m
-        elsif m =~ CssParser::FONT_UNITS_RX
-          if m =~ /\//
-            font_props['font-size'], font_props['line-height'] = m.split('/')
+        elsif CssParser::FONT_UNITS_RX.match?(m)
+          if m.include?('/')
+            font_props['font-size'], font_props['line-height'] = m.split('/', 2)
           else
             font_props['font-size'] = m
           end
@@ -271,9 +480,7 @@ module CssParser
         end
       end
 
-      font_props.each { |font_prop, font_val| @declarations[font_prop] = {:value => font_val, :is_important => is_important, :order => order} }
-
-      @declarations.delete('font')
+      declarations.replace_declaration!('font', font_props, preserve_importance: true)
     end
 
     # Convert shorthand list-style declarations (e.g. <tt>list-style: lower-alpha outside;</tt>)
@@ -281,21 +488,22 @@ module CssParser
     #
     # See http://www.w3.org/TR/CSS21/generate.html#lists
     def expand_list_style_shorthand! # :nodoc:
-      return unless @declarations.has_key?('list-style')
+      return unless (declaration = declarations['list-style'])
 
-      value = @declarations['list-style'][:value]
+      value = declaration.value.dup
 
-      if value =~ CssParser::RE_INHERIT
-        LIST_STYLE_PROPERTIES.each do |prop|
-          split_declaration('list-style', prop, 'inherit')
+      replacement =
+        if CssParser::RE_INHERIT.match?(value)
+          LIST_STYLE_PROPERTIES.to_h { |key| [key, 'inherit'] }
+        else
+          {
+            'list-style-type' => value.slice!(CssParser::RE_LIST_STYLE_TYPE),
+            'list-style-position' => value.slice!(CssParser::RE_INSIDE_OUTSIDE),
+            'list-style-image' => value.slice!(CssParser::URI_RX_OR_NONE)
+          }
         end
-      end
 
-      split_declaration('list-style', 'list-style-type', value.slice!(CssParser::RE_LIST_STYLE_TYPE))
-      split_declaration('list-style', 'list-style-position', value.slice!(CssParser::RE_INSIDE_OUTSIDE))
-      split_declaration('list-style', 'list-style-image', value.slice!(Regexp.union(CssParser::URI_RX, /none/i)))
-
-      @declarations.delete('list-style')
+      declarations.replace_declaration!('list-style', replacement, preserve_importance: true)
     end
 
     # Create shorthand declarations (e.g. +margin+ or +font+) whenever possible.
@@ -309,18 +517,24 @@ module CssParser
     end
 
     # Combine several properties into a shorthand one
-    def create_shorthand_properties! properties, shorthand_property # :nodoc:
+    def create_shorthand_properties!(properties, shorthand_property) # :nodoc:
       values = []
+      properties_to_delete = []
       properties.each do |property|
-         if @declarations.has_key?(property) and not @declarations[property][:is_important]
-          values << @declarations[property][:value]
-           @declarations.delete(property)
-         end
-       end
-
-      unless values.empty?
-        @declarations[shorthand_property] = {:value => values.join(' ')}
+        next unless (declaration = declarations[property])
+        next if declaration.important
+
+        values << declaration.value
+        properties_to_delete << property
       end
+
+      return if values.length <= 1
+
+      properties_to_delete.each do |property|
+        declarations.delete(property)
+      end
+
+      declarations[shorthand_property] = values.join(' ')
     end
 
     # Looks for long format CSS background properties (e.g. <tt>background-color</tt>) and
@@ -328,109 +542,89 @@ module CssParser
     #
     # Leaves properties declared !important alone.
     def create_background_shorthand! # :nodoc:
+      # When we have a background-size property we must separate it and distinguish it from
+      # background-position by preceding it with a backslash. In this case we also need to
+      # have a background-position property, so we set it if it's missing.
+      # http://www.w3schools.com/cssref/css3_pr_background.asp
+      if (declaration = declarations['background-size']) && !declaration.important
+        declarations['background-position'] ||= '0% 0%'
+        declaration.value = "/ #{declaration.value}"
+      end
+
       create_shorthand_properties! BACKGROUND_PROPERTIES, 'background'
     end
-    
+
     # Combine border-color, border-style and border-width into border
     # Should be run after create_dimensions_shorthand!
     #
     # TODO: this is extremely similar to create_background_shorthand! and should be combined
     def create_border_shorthand! # :nodoc:
-      values = []
-      
-      ['border-width', 'border-style', 'border-color'].each do |property|
-        if @declarations.has_key?(property) and not @declarations[property][:is_important]
-          # can't merge if any value contains a space (i.e. has multiple values)
-          # we temporarily remove any spaces after commas for the check (inside rgba, etc...)
-          return if @declarations[property][:value].gsub(/\,[\s]/, ',').strip =~ /[\s]/
-          values << @declarations[property][:value]
-        end
+      values = BORDER_STYLE_PROPERTIES.filter_map do |property|
+        next unless (declaration = declarations[property])
+        next if declaration.important
+        # can't merge if any value contains a space (i.e. has multiple values)
+        # we temporarily remove any spaces after commas for the check (inside rgba, etc...)
+        next if /\s/.match?(declaration.value.gsub(/,\s/, ',').strip)
+
+        declaration.value
       end
 
-      @declarations.delete('border-width')
-      @declarations.delete('border-style')
-      @declarations.delete('border-color')
+      return if values.size != BORDER_STYLE_PROPERTIES.size
 
-      unless values.empty?
-        @declarations['border'] = {:value => values.join(' ')}
+      BORDER_STYLE_PROPERTIES.each do |property|
+        declarations.delete(property)
       end
+
+      declarations['border'] = values.join(' ')
     end
-    
-    # Looks for long format CSS dimensional properties (margin, padding, border-color, border-style and border-width) 
+
+    # Looks for long format CSS dimensional properties (margin, padding, border-color, border-style and border-width)
     # and converts them into shorthand CSS properties.
     def create_dimensions_shorthand! # :nodoc:
-      directions = ['top', 'right', 'bottom', 'left']
+      return if declarations.size < NUMBER_OF_DIMENSIONS
 
-      {'margin'       => 'margin-%s',
-       'padding'      => 'padding-%s',
-       'border-color' => 'border-%s-color', 
-       'border-style' => 'border-%s-style', 
-       'border-width' => 'border-%s-width'}.each do |property, expanded|
+      DIMENSIONS.each do |property, dimensions|
+        values = DIMENSION_DIRECTIONS.each_with_index.with_object({}) do |(side, index), result|
+          next unless (declaration = declarations[dimensions[index]])
 
-        foldable = @declarations.select do |dim, val| 
-          dim == expanded % 'top' or dim == expanded % 'right' or dim == expanded % 'bottom' or dim == expanded % 'left'
+          result[side] = declaration.value
         end
+
         # All four dimensions must be present
-        if foldable.length == 4
-          values = {}
-
-          directions.each { |d| values[d.to_sym] = @declarations[expanded % d][:value].downcase.strip }
-
-          if values[:left] == values[:right]
-            if values[:top] == values[:bottom] 
-              if values[:top] == values[:left] # All four sides are equal
-                new_value = values[:top]
-              else # Top and bottom are equal, left and right are equal
-                new_value = values[:top] + ' ' + values[:left]
-              end
-            else # Only left and right are equal
-              new_value = values[:top] + ' ' + values[:left] + ' ' + values[:bottom]
-            end
-          else # No sides are equal
-            new_value = values[:top] + ' ' + values[:right] + ' ' + values[:bottom] + ' ' + values[:left]
-          end
+        next if values.size != dimensions.size
 
-          new_value.strip!
-          @declarations[property] = {:value => new_value.strip} unless new_value.empty?
+        new_value = values.values_at(*compute_dimensions_shorthand(values)).join(' ').strip
+        declarations[property] = new_value unless new_value.empty?
 
-          # Delete the longhand values
-          directions.each { |d| @declarations.delete(expanded % d) }
-        end
+        # Delete the longhand values
+        dimensions.each { |d| declarations.delete(d) }
       end
     end
 
-
-    # Looks for long format CSS font properties (e.g. <tt>font-weight</tt>) and 
-    # tries to convert them into a shorthand CSS <tt>font</tt> property.  All 
+    # Looks for long format CSS font properties (e.g. <tt>font-weight</tt>) and
+    # tries to convert them into a shorthand CSS <tt>font</tt> property.  All
     # font properties must be present in order to create a shorthand declaration.
     def create_font_shorthand! # :nodoc:
-      ['font-style', 'font-variant', 'font-weight', 'font-size',
-       'line-height', 'font-family'].each do |prop|
-        return unless @declarations.has_key?(prop)
-      end
+      return unless FONT_STYLE_PROPERTIES.all? { |prop| declarations.key?(prop) }
 
-      new_value = ''
+      new_value = +''
       ['font-style', 'font-variant', 'font-weight'].each do |property|
-        unless @declarations[property][:value] == 'normal'
-          new_value += @declarations[property][:value] + ' '
+        unless declarations[property].value == 'normal'
+          new_value << declarations[property].value << ' '
         end
       end
 
-      new_value += @declarations['font-size'][:value]
+      new_value << declarations['font-size'].value
 
-      unless @declarations['line-height'][:value] == 'normal'
-        new_value += '/' + @declarations['line-height'][:value]
+      unless declarations['line-height'].value == 'normal'
+        new_value << '/' << declarations['line-height'].value
       end
 
-      new_value += ' ' + @declarations['font-family'][:value]
-
-      @declarations['font'] = {:value => new_value.gsub(/[\s]+/, ' ').strip}
+      new_value << ' ' << declarations['font-family'].value
 
-      ['font-style', 'font-variant', 'font-weight', 'font-size',
-       'line-height', 'font-family'].each do |prop|
-       @declarations.delete(prop)
-      end
+      declarations['font'] = new_value.gsub(/\s+/, ' ')
 
+      FONT_STYLE_PROPERTIES.each { |prop| declarations.delete(prop) }
     end
 
     # Looks for long format CSS list-style properties (e.g. <tt>list-style-type</tt>) and
@@ -443,44 +637,75 @@ module CssParser
 
   private
 
-    # utility method for re-assign shorthand elements to longhand versions
-    def split_declaration(src, dest, v)  # :nodoc:
-      return unless v and not v.empty?
+    attr_accessor :declarations
 
-      if @declarations.has_key?(dest)
-        #puts "dest #{dest} already exists"
-      
-        if @declarations[dest][:order] > @declarations[src][:order]
-          #puts "skipping #{dest}:#{v} due to order "        
-          return
-        else
-          @declarations[dest] = {}    
-        end
-      end
-      @declarations[dest] = @declarations[src].merge({:value => v.to_s.strip})    
+    def compute_dimensions_shorthand(values)
+      # All four sides are equal, returning single value
+      return [:top] if values.values.uniq.count == 1
+
+      # `/* top | right | bottom | left */`
+      return DIMENSION_DIRECTIONS if values[:left] != values[:right]
+
+      # Vertical are the same & horizontal are the same, `/* vertical | horizontal */`
+      return [:top, :left] if values[:top] == values[:bottom]
+
+      [:top, :left, :bottom]
     end
-  
+
     def parse_declarations!(block) # :nodoc:
-      @declarations = {}
+      self.declarations = Declarations.new
 
       return unless block
 
-      block.gsub!(/(^[\s]*)|([\s]*$)/, '')
+      continuation = nil
+      block.split(SEMICOLON) do |decs|
+        decs = (continuation ? "#{continuation};#{decs}" : decs)
+        if unmatched_open_parenthesis?(decs)
+          # Semicolon happened within parenthesis, so it is a part of the value
+          # the rest of the value is in the next segment
+          continuation = decs
+          next
+        end
 
-      block.split(/[\;$]+/m).each do |decs|
-        if matches = decs.match(/(.[^:]*)\:(.[^;]*)(;|\Z)/i)
-          property, value, end_of_declaration = matches.captures
+        next unless (colon = decs.index(COLON))
 
-          add_declaration!(property, value)
-        end
+        property = decs[0, colon]
+        value = decs[(colon + 1)..]
+        property.strip!
+        value.strip!
+        next if property.empty? || value.empty? || value.casecmp?(IMPORTANT)
+
+        add_declaration!(property, value)
+        continuation = nil
       end
     end
 
+    def unmatched_open_parenthesis?(declarations)
+      (lparen_index = declarations.index(LPAREN)) && !declarations.index(RPAREN, lparen_index)
+    end
+
     #--
     # TODO: way too simplistic
     #++
     def parse_selectors!(selectors) # :nodoc:
-      @selectors = selectors.split(',') 
+      @selectors = selectors.split(',').map do |s|
+        s.gsub!(/\s+/, ' ')
+        s.strip!
+        s
+      end
+    end
+
+    def split_value_preserving_function_whitespace(value)
+      split_value = value.gsub(RE_FUNCTIONS) do |c|
+        c.gsub!(/\s+/, WHITESPACE_REPLACEMENT)
+        c
+      end
+
+      matches = split_value.strip.split(/\s+/)
+
+      matches.each do |c|
+        c.gsub!(WHITESPACE_REPLACEMENT, ' ')
+      end
     end
   end
 end