cryptoexchange 0.20.0 → 0.21.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f54e0fe4ad10dc783fbb17f51b123e1340a26df7
-  data.tar.gz: db28b4cf0d169f52cede566a47a8ed4546acf62e
+  metadata.gz: 1c054b25d99833ec0d63d8ebc81eb3d8b2c2827b
+  data.tar.gz: 9221b11da94fd846c3860f169dc741c356298f72
 SHA512:
-  metadata.gz: 8bac8dcf7d4e3c69532e02325fd9a1b568cdf73ffd85a031662d2b24bff334acb6be07a36be65684913728c06f0b3ac919ff75e913e7bd018d07d647ffbfd8cb
-  data.tar.gz: acc44a0b78bd3aa84456602fb35bc0a29de002f3fc04a437522c0d75ef491f67337681df9c7072c46555a5b8ac3b07234ec83878fcb2441a15e7ce93146d4e56
+  metadata.gz: f3e4ef7744e1763799bbc363646fbad893c22a314d32d383e727119fc72ad1059264825beee26fbc03ff3c0aebc6f1a7d20166070e145478338d6b0e5098dcee
+  data.tar.gz: 72f18cfd2ab6805997dc9be5a2e1cdc2b69cbe8ea1436190334578c49d38e44f24e0160883b5fa8903bb3d61cc8cd796ffe6a28df5d55cb2d598ebfe945d0561

data/README.md

@@ -28,7 +28,9 @@ Or install it yourself as:
 | ACX               | Y       | Y          | Y       |         | Y           |
 | Allcoin           | Y       | Y          |         |         | User-Defined|
 | ANX               | Y       |            |         |         | User-Defined|
+| Bancor            | Y       | N          | N       |         | Y           |
 | Bibox             | Y       | Y          | Y       |         | Y           |
+| BigONE            | Y       | Y          | Y       |         | Y           |
 | Bit-Z             | Y       |            |         |         | Y           |
 | Binance           | Y       | Y          |         |         | Y           |
 | Bitbay            | Y       |            |         |         | User-Defined|
@@ -54,6 +56,7 @@ Or install it yourself as:
 | Cobinhood         | Y       | Y          |         |         | Y           |
 | Coincheck         | Y       |            |         |         | User-Defined|
 | CoinExchange      | Y       |            |         |         | Y           |
+| Coinbene          | Y       | Y          | Y       |         | Y           |
 | Coinmate          | Y       | Y          |         |         | User-Defined|
 | Coinnest          | Y       | Y          | Y       |         | User-Defined|
 | Coinone           | Y       |            |         |         | Y           |
@@ -62,6 +65,7 @@ Or install it yourself as:
 | CryptoBridge      | Y       |            |         |         | Y           |
 | Cryptopia         | Y       | Y          | Y       |         | Y           |
 | EtherDelta        | Y       |            |         |         | Y           |
+| Ethfinex          | Y       | Y          | Y       |         | Y           |
 | Exmo              | Y       | Y          | Y       |         | Y           |
 | Gate              | Y       | Y          | Y       |         | Y           |
 | Gatecoin          | Y       |            |         |         | Y           |
@@ -73,6 +77,7 @@ Or install it yourself as:
 | Itbit             | Y       |            |         |         | User-Defined|
 | KKex              | Y       | Y          | Y       |         | Y           |
 | Jubi              | Y       |            |         |         | Y           |
+| Koinex            | Y       |            |         |         | Y           |
 | Korbit            | Y       |            |         |         | User-Defined|
 | Kraken            | Y       |            |         |         | Y           |
 | Kucoin            | Y       |            |         |         | Y           |
@@ -93,19 +98,22 @@ Or install it yourself as:
 | Qryptos           | Y       |            |         |         | Y           |
 | QuadrigaCX        | Y       |            |         |         | User-Defined|
 | Quoine            | Y       |            |         |         | Y           |
+| RadarRelay        | Y       |            |         |         | User-Defined|
 | Stocks Exchange   | Y       |            |         |         | Y           |
 | SZZC              | Y       |            |         |         | Y           |
 | The Rock Trading  | Y       |            |         |         | Y           |
 | Tidex             | Y       |            |         |         | Y           |
+| TradeOgre         | Y       | Y          | Y       |         | Y           |
 | Trade Satoshi     | Y       |            |         |         | Y           |
 | TuxExchange       | Y       |            |         |         | Y           |
 | Unocoin           |         |            |         |         |             |
 | Viabtc            | Y       |            |         |         | User-Defined|
-| Wex               | Y       | Y          |  Y      |         | Y           |
+| Wex               | Y       | Y          | Y       |         | Y           |
 | Yobit             | Y       |            |         |         | Y           |
 | Yuanbao           | Y       |            |         |         | User-Defined|
 | Yunbi             | Y       |            |         |         | Y           |
 | Zaif              | Y       | Y          | Y       |         | Y           |
+| ZB                | Y       | Y          | Y       |         | Y           |
 
 ## Usage
 

data/cryptoexchange.gemspec

@@ -26,9 +26,9 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "rb-readline"
-  spec.add_development_dependency "vcr", "~> 3.0.3"
-  spec.add_development_dependency "webmock"
-  
-  spec.add_dependency "http", '~> 1.0.0'
+  spec.add_development_dependency "vcr", "~> 4.0.0"
+  spec.add_development_dependency "webmock", '~> 3.3.0'
+
+  spec.add_dependency "http", '~> 3.0.0'
   spec.add_dependency "lru_redux"
 end

data/lib/cryptoexchange/client.rb

@@ -26,6 +26,9 @@ module Cryptoexchange
             t.target.casecmp(market_pair.target) == 0
         end
       end
+
+      rescue NoMethodError => e
+        raise Cryptoexchange::ResultParseError, { response: "General no method error thrown" }
     end
 
     def available_exchanges

data/lib/cryptoexchange/error.rb

@@ -5,6 +5,9 @@ module Cryptoexchange
   class HttpResponseError < Error
   end
 
+  class HttpBadRequestError < Error
+  end
+
   class HttpConnectionError < Error
   end
 
@@ -16,4 +19,7 @@ module Cryptoexchange
 
   class TypeFormatError < Error
   end
+
+  class ResultParseError < Error
+  end
 end

data/lib/cryptoexchange/exchanges/anx/services/market.rb

@@ -10,20 +10,17 @@ module Cryptoexchange::Exchanges
 
         def fetch(market_pair)
           output = super(ticker_url(market_pair))
-          adapt(output)
+          adapt(output, market_pair)
         end
 
         def ticker_url(market_pair)
           "#{Cryptoexchange::Exchanges::Anx::Market::API_URL}/#{market_pair.base}#{market_pair.target}/money/ticker"
         end
 
-        def adapt(output)
+        def adapt(output, market_pair)
           ticker = Cryptoexchange::Models::Ticker.new
-          base = output['data']['vol']['currency']
-          target = output['data']['high']['currency']
-
-          ticker.base      = base
-          ticker.target    = target
+          ticker.base      = market_pair.base
+          ticker.target    = market_pair.target
           ticker.market    = Anx::Market::NAME
           ticker.ask       = NumericHelper.to_d(output['data']['sell']['value'])
           ticker.bid       = NumericHelper.to_d(output['data']['buy']['value'])

data/lib/cryptoexchange/exchanges/bancor/market.rb

@@ -0,0 +1,8 @@
+module Cryptoexchange::Exchanges
+  module Bancor
+    class Market
+      NAME = 'bancor'
+      API_URL = 'https://api.bancor.network/0.1'
+    end
+  end
+end

data/lib/cryptoexchange/exchanges/bancor/services/market.rb

@@ -0,0 +1,36 @@
+module Cryptoexchange::Exchanges
+  module Bancor
+    module Services
+      class Market < Cryptoexchange::Services::Market
+        class << self
+          def supports_individual_ticker_query?
+            true
+          end
+        end
+
+        def fetch(market_pair)
+          output = super(ticker_url(market_pair))
+          adapt(output, market_pair)
+        end
+
+        def ticker_url(market_pair)
+          "#{Cryptoexchange::Exchanges::Bancor::Market::API_URL}/currencies/#{market_pair.base}/ticker?fromCurrencyCode=#{market_pair.target}"
+        end
+
+        def adapt(output, market_pair)
+          ticker = Cryptoexchange::Models::Ticker.new
+          ticker.base      = market_pair.base
+          ticker.target    = market_pair.target
+          ticker.market    = Bancor::Market::NAME
+          ticker.last      = NumericHelper.to_d(output['data']['price'])
+          ticker.high      = NumericHelper.to_d(output['data']['price24hLow'])
+          ticker.low       = NumericHelper.to_d(output['data']['price24hLow'])
+          ticker.volume    = NumericHelper.divide(NumericHelper.to_d(output['data']['volume24h'].to_f / 10 ** 18), ticker.last)
+          ticker.timestamp = Time.now.to_i
+          ticker.payload   = output
+          ticker
+        end
+      end
+    end
+  end
+end

data/lib/cryptoexchange/exchanges/bancor/services/pair.rb

@@ -0,0 +1,24 @@
+module Cryptoexchange::Exchanges
+  module Bancor
+    module Services
+      class Pairs < Cryptoexchange::Services::Pairs
+        PAIRS_URL = "#{Cryptoexchange::Exchanges::Bancor::Market::API_URL}/currencies/convertiblePairs"
+
+        def fetch
+          output = super
+          adapt(output)
+        end
+
+        def adapt(output)
+          output['data'].map do |base, target|
+            Cryptoexchange::Models::MarketPair.new(
+              base: base,
+              target: target,
+              market: Bancor::Market::NAME
+            )
+          end
+        end
+      end
+    end
+  end
+end

data/lib/cryptoexchange/exchanges/bigone/market.rb

@@ -0,0 +1,8 @@
+module Cryptoexchange::Exchanges
+  module Bigone
+    class Market
+      NAME = 'bigone'
+      API_URL = 'https://api.big.one'
+    end
+  end
+end

data/lib/cryptoexchange/exchanges/bigone/services/market.rb

@@ -0,0 +1,49 @@
+module Cryptoexchange::Exchanges
+  module Bigone
+    module Services
+      class Market < Cryptoexchange::Services::Market
+        class << self
+          def supports_individual_ticker_query?
+            false
+          end
+        end
+
+        def fetch
+          output = super(ticker_url)
+          adapt_all(output)
+        end
+
+        def ticker_url
+          "#{Cryptoexchange::Exchanges::Bigone::Market::API_URL}/markets"
+        end
+
+        def adapt_all(output)
+          output['data'].map do |pair|
+            base = pair['quote']
+            target = pair['base']
+            market_pair = Cryptoexchange::Models::MarketPair.new(
+                            base: base,
+                            target: target,
+                            market: Bigone::Market::NAME
+                          )
+            adapt(market_pair, pair['ticker'])
+          end
+        end
+
+        def adapt(market_pair, output)
+          ticker = Cryptoexchange::Models::Ticker.new
+          ticker.base = market_pair.base
+          ticker.target = market_pair.target
+          ticker.market = Bigone::Market::NAME
+          ticker.last = NumericHelper.to_d(output['price'].to_f)
+          ticker.high = NumericHelper.to_d(output['high'].to_f)
+          ticker.low = NumericHelper.to_d(output['low'].to_f)
+          ticker.volume = NumericHelper.to_d(output['volume'].to_f)
+          ticker.timestamp = Time.now.to_i
+          ticker.payload = output
+          ticker
+        end
+      end
+    end
+  end
+end

data/lib/cryptoexchange/exchanges/bigone/services/order_book.rb

@@ -0,0 +1,44 @@
+module Cryptoexchange::Exchanges
+  module Bigone
+    module Services
+      class OrderBook < Cryptoexchange::Services::Market
+        class << self
+          def supports_individual_ticker_query?
+            true
+          end
+        end
+
+        def fetch(market_pair)
+          output = super(ticker_url(market_pair))
+          adapt(output, market_pair)
+        end
+
+        def ticker_url(market_pair)
+          "#{Cryptoexchange::Exchanges::Bigone::Market::API_URL}/markets/#{market_pair.base}-#{market_pair.target}/book"
+        end
+
+        def adapt(output, market_pair)
+          order_book = Cryptoexchange::Models::OrderBook.new
+          timestamp = Time.now.to_i
+
+          order_book.base      = market_pair.base
+          order_book.target    = market_pair.target
+          order_book.market    = Bigone::Market::NAME
+          order_book.asks      = adapt_orders(output["data"]["asks"])
+          order_book.bids      = adapt_orders(output["data"]["bids"])
+          order_book.timestamp = timestamp
+          order_book.payload   = output
+          order_book
+        end
+
+        def adapt_orders(orders)
+          orders.collect do |order_entry|
+            Cryptoexchange::Models::Order.new(price: order_entry["price"],
+                                              amount: order_entry["amount"],
+                                              timestamp: nil)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/cryptoexchange/exchanges/bigone/services/pairs.rb

@@ -0,0 +1,23 @@
+module Cryptoexchange::Exchanges
+  module Bigone
+    module Services
+      class Pairs < Cryptoexchange::Services::Pairs
+        PAIRS_URL = "#{Cryptoexchange::Exchanges::Bigone::Market::API_URL}/markets"
+
+        def fetch
+          output = super
+          market_pairs = []
+          output['data'].each do |pair|
+            market_pairs << Cryptoexchange::Models::MarketPair.new(
+                              base: pair['quote'],
+                              target: pair['base'],
+                              market: Bigone::Market::NAME
+                            )
+          end
+          market_pairs
+        end
+
+      end
+    end
+  end
+end

data/lib/cryptoexchange/exchanges/bigone/services/trades.rb

@@ -0,0 +1,32 @@
+module Cryptoexchange::Exchanges
+  module Bigone
+    module Services
+      class Trades < Cryptoexchange::Services::Market
+        def fetch(market_pair)
+          output = super(ticker_url(market_pair))
+          adapt(output, market_pair)
+        end
+
+        def ticker_url(market_pair)
+          "#{Cryptoexchange::Exchanges::Bigone::Market::API_URL}/markets/#{market_pair.base}-#{market_pair.target}/trades"
+        end
+
+        def adapt(output, market_pair)
+          output["data"].collect do |trade|
+            tr = Cryptoexchange::Models::Trade.new
+            tr.trade_id  = trade["trade_id"]
+            tr.base      = market_pair.base
+            tr.target    = market_pair.target
+            tr.market    = Bigone::Market::NAME
+            tr.type      = trade["trade_side"] == "ASK" ? "sell" : "buy"
+            tr.price     = trade["price"]
+            tr.amount    = trade["amount"]
+            tr.timestamp = trade["created_at"].to_i
+            tr.payload   = trade
+            tr
+          end
+        end
+      end
+    end
+  end
+end

data/lib/cryptoexchange/exchanges/bitflyer/services/market.rb

@@ -10,18 +10,17 @@ module Cryptoexchange::Exchanges
 
         def fetch(market_pair)
           output = super(ticker_url(market_pair))
-          adapt(output)
+          adapt(output, market_pair)
         end
 
         def ticker_url(market_pair)
           "#{Cryptoexchange::Exchanges::Bitflyer::Market::API_URL}/ticker?product_code=#{market_pair.base}_#{market_pair.target}"
         end
 
-        def adapt(output)
+        def adapt(output, market_pair)
           ticker           = Cryptoexchange::Models::Ticker.new
-          base, target     = output['product_code'].split('_')
-          ticker.base      = base
-          ticker.target    = target
+          ticker.base      = market_pair.base
+          ticker.target    = market_pair.target
           ticker.market    = Bitflyer::Market::NAME
           ticker.ask       = NumericHelper.to_d(output['best_ask'])
           ticker.bid       = NumericHelper.to_d(output['best_bid'])

data/lib/cryptoexchange/exchanges/bittrex/services/market.rb

@@ -21,6 +21,7 @@ module Cryptoexchange::Exchanges
         end
 
         def adapt(output, market_pair)
+          handle_invalid(output)
           ticker = Cryptoexchange::Models::Ticker.new
           market = output['result'][0]
 
@@ -37,6 +38,12 @@ module Cryptoexchange::Exchanges
           ticker.payload   = market
           ticker
         end
+
+        def handle_invalid(output)
+          if output['message'] == 'INVALID_MARKET'
+            raise Cryptoexchange::ResultParseError, { response: output }
+          end
+        end
       end
     end
   end

data/lib/cryptoexchange/exchanges/coinbene/market.rb

@@ -0,0 +1,8 @@
+module Cryptoexchange::Exchanges
+  module Coinbene
+    class Market
+      NAME = 'coinbene'
+      API_URL = 'http://api.coinbene.com/v1'
+    end
+  end
+end

data/lib/cryptoexchange/exchanges/coinbene/services/market.rb

@@ -0,0 +1,52 @@
+module Cryptoexchange::Exchanges
+  module Coinbene
+    module Services
+      class Market < Cryptoexchange::Services::Market
+        class << self
+          def supports_individual_ticker_query?
+            false
+          end
+        end
+
+        def fetch
+          output = super(ticker_url)
+          adapt_all(output)
+        end
+
+        def ticker_url
+          "#{Cryptoexchange::Exchanges::Coinbene::Market::API_URL}/market/ticker?symbol=all"
+        end
+
+        def adapt_all(output)
+          output['ticker'].map do |ticker|
+            separator = /(USDT|BTC|ETH)\z/ =~ ticker['symbol']
+            base = ticker['symbol'][0..separator - 1]
+            target   = ticker['symbol'][separator..-1]
+            market_pair = Cryptoexchange::Models::MarketPair.new(
+                            base: base,
+                            target: target,
+                            market: Coinbene::Market::NAME
+                          )
+            adapt(ticker, market_pair)
+          end
+        end
+
+        def adapt(output, market_pair)
+          ticker           = Cryptoexchange::Models::Ticker.new
+          ticker.base      = market_pair.base
+          ticker.target    = market_pair.target
+          ticker.market    = Coinbene::Market::NAME
+          ticker.last      = NumericHelper.to_d(output['last'])
+          ticker.bid       = NumericHelper.to_d(output['bid'])
+          ticker.ask       = NumericHelper.to_d(output['ask'])
+          ticker.high      = NumericHelper.to_d(output['24hrHigh'])
+          ticker.low       = NumericHelper.to_d(output['24hrLow'])
+          ticker.volume    = NumericHelper.to_d(output['24hrVol'])
+          ticker.timestamp = Time.now.to_i
+          ticker.payload = output
+          ticker
+        end
+      end
+    end
+  end
+end