crspec 0.1.2 → 0.1.3

data/lib/crspec/transpiler/rewriter.rb

@@ -4,14 +4,26 @@ require "prism"
 
 module Crspec
   module Transpiler
+    # Lint severities:
+    #   :error   - construct is rejected by Crspec at load/run time
+    #   :warning - construct is concurrency-unsafe and needs manual review
+    #   :info    - construct was auto-rewritten or is worth double-checking
+    Lint = Struct.new(:line, :severity, :code, :message)
+
     class Rewriter < Prism::Visitor
-      attr_reader :transformed_code, :warnings
+      attr_reader :transformed_code, :warnings, :lints
 
       def initialize(source_code)
         super()
         @source_code = source_code
         @replacements = []
-        @warnings = []
+        @lints = []
+        @inside_example_depth = 0
+      end
+
+      # Backwards-compatible string warnings.
+      def warnings
+        @lints.map { |l| "Line #{l.line}: [#{l.severity}] #{l.message}" }
       end
 
       def transpile
@@ -20,46 +32,188 @@ module Crspec
         apply_replacements
       end
 
-      def visit_call_node(node)
-        # Convert RSpec.describe -> Crspec.describe
-        if node.receiver.is_a?(Prism::ConstantReadNode) &&
-           node.receiver.name == :RSpec &&
-           node.name == :describe
-          @replacements << {
-            start_offset: node.receiver.location.start_offset,
-            end_offset: node.receiver.location.end_offset,
-            text: "Crspec"
-          }
-        end
+      def safety_score
+        return 100 if @lints.empty?
 
-        # Flag thread-unsafe before(:all) blocks
-        if node.name == :before && node.arguments
-          first_arg = node.arguments.arguments.first
-          if first_arg.is_a?(Prism::SymbolNode) && first_arg.value == "all"
-            @warnings << "Line #{node.location.start_line}: [Thread Safety Warning] before(:all) mutates global state across examples."
+        deductions = @lints.sum do |l|
+          case l.severity
+          when :error then 25
+          when :warning then 10
+          else 2
           end
         end
+        [100 - deductions, 0].max
+      end
 
-        super
+      def visit_call_node(node)
+        rewrite_rspec_receiver(node)
+        rewrite_matcher_define(node)
+        rewrite_before_all(node)
+        rewrite_focus_aliases(node)
+        lint_any_instance(node)
+        lint_env_mutation(node)
+        lint_time_mutation(node)
+
+        example_call = %i[it specify example].include?(node.name)
+        @inside_example_depth += 1 if example_call
+        begin
+          super
+        ensure
+          @inside_example_depth -= 1 if example_call
+        end
       end
 
       def visit_constant_read_node(node)
         if node.name == :RSpec
-          @replacements << {
-            start_offset: node.location.start_offset,
-            end_offset: node.location.end_offset,
-            text: "Crspec"
-          }
+          replace(node.location, "Crspec")
         end
         super
       end
 
+      def visit_class_variable_write_node(node)
+        add_lint(node, :warning, :class_variable,
+                 "class variable mutation (#{node.name}) is shared across all threads/fibers")
+        super
+      end
+
+      def visit_class_variable_read_node(node)
+        add_lint(node, :warning, :class_variable,
+                 "class variable read (#{node.name}) implies shared mutable state")
+        super
+      end
+
+      def visit_constant_write_node(node)
+        if @inside_example_depth.positive?
+          add_lint(node, :warning, :constant_mutation,
+                   "constant assignment (#{node.name}) inside an example mutates global state")
+        end
+        super
+      end
+
+      def visit_index_operator_write_node(node)
+        lint_env_index(node)
+        super
+      end
+
+      def visit_index_and_write_node(node)
+        lint_env_index(node)
+        super
+      end
+
+      def visit_index_or_write_node(node)
+        lint_env_index(node)
+        super
+      end
+
       private
 
+      def rewrite_rspec_receiver(node)
+        return unless node.receiver.is_a?(Prism::ConstantReadNode) && node.receiver.name == :RSpec
+
+        replace(node.receiver.location, "Crspec")
+      end
+
+      # RSpec::Matchers.define -> Crspec::Matchers.define
+      def rewrite_matcher_define(node)
+        return unless node.name == :define
+        return unless node.receiver.is_a?(Prism::ConstantPathNode)
+
+        path = node.receiver
+        parent = path.parent
+        return unless parent.is_a?(Prism::ConstantReadNode) && parent.name == :RSpec && path.name == :Matchers
+
+        replace(parent.location, "Crspec")
+      end
+
+      # before(:all)/before(:context) -> before(:each) with annotation.
+      def rewrite_before_all(node)
+        return unless %i[before after].include?(node.name) && node.arguments
+
+        first_arg = node.arguments.arguments.first
+        return unless first_arg.is_a?(Prism::SymbolNode) && %w[all context suite].include?(first_arg.value)
+
+        add_lint(node, :info, :before_all_rewritten,
+                 "#{node.name}(:#{first_arg.value}) auto-rewritten to #{node.name}(:each); " \
+                 "review for per-example cost (consider let/let!)")
+        replace(first_arg.location, ":each")
+        annotate_line(node, "# CRSPEC-MIGRATION: was #{node.name}(:#{first_arg.value}) — now runs per example; consider let/let! for expensive setup")
+      end
+
+      # fit/fdescribe/fcontext are focus aliases; xit etc are already
+      # supported natively. Normalize focus to plain forms with a note.
+      def rewrite_focus_aliases(node)
+        mapping = { fit: "it", fdescribe: "describe", fcontext: "context" }
+        replacement = mapping[node.name]
+        return unless replacement
+        return if node.receiver
+
+        add_lint(node, :info, :focus_removed,
+                 "#{node.name} (focus) normalized to #{replacement}")
+        replace(node.message_loc, replacement)
+      end
+
+      def lint_any_instance(node)
+        if %i[any_instance allow_any_instance_of expect_any_instance_of].include?(node.name)
+          add_lint(node, :error, :any_instance,
+                   "#{node.name} mutates shared class hierarchies at runtime and is rejected by Crspec; " \
+                   "inject a double or stub the specific instance instead")
+        end
+      end
+
+      def lint_env_mutation(node)
+        return unless node.name == :[]= && node.receiver.is_a?(Prism::ConstantReadNode) && node.receiver.name == :ENV
+
+        add_lint(node, :warning, :env_mutation,
+                 "ENV mutation inside specs is process-global and races across threads")
+      end
+
+      def lint_env_index(node)
+        return unless node.receiver.is_a?(Prism::ConstantReadNode) && node.receiver.name == :ENV
+
+        add_lint(node, :warning, :env_mutation,
+                 "ENV mutation inside specs is process-global and races across threads")
+      end
+
+      TIME_MUTATORS = %i[travel travel_to travel_back freeze return].freeze
+
+      def lint_time_mutation(node)
+        receiver = node.receiver
+        if receiver.is_a?(Prism::ConstantReadNode) && receiver.name == :Timecop
+          add_lint(node, :warning, :time_mutation,
+                   "Timecop.#{node.name} mutates global time state; use ActiveSupport::Testing::TimeHelpers " \
+                   "scoped per example, or inject a clock")
+        end
+      end
+
+      def add_lint(node, severity, code, message)
+        @lints << Lint.new(node.location.start_line, severity, code, message)
+      end
+
+      def replace(location, text)
+        @replacements << {
+          start_offset: location.start_offset,
+          end_offset: location.end_offset,
+          text: text
+        }
+      end
+
+      # Insert a comment line above the node's line.
+      def annotate_line(node, comment)
+        line_start = @source_code.rindex("\n", node.location.start_offset)
+        line_start = line_start.nil? ? 0 : line_start + 1
+        indent = @source_code[line_start..node.location.start_offset][/\A[ \t]*/]
+        @replacements << {
+          start_offset: line_start,
+          end_offset: line_start,
+          text: "#{indent}#{comment}\n"
+        }
+      end
+
       def apply_replacements
         buffer = @source_code.dup
         # Sort replacements backwards so offsets remain valid during splicing
-        sorted = @replacements.uniq { |r| [r[:start_offset], r[:end_offset]] }.sort_by { |r| -r[:start_offset] }
+        sorted = @replacements.uniq { |r| [r[:start_offset], r[:end_offset], r[:text]] }
+                              .sort_by { |r| [-r[:start_offset], -r[:end_offset]] }
         sorted.each do |r|
           buffer[r[:start_offset]...r[:end_offset]] = r[:text]
         end

data/lib/crspec/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Crspec
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/lib/crspec.rb

@@ -5,13 +5,17 @@ require_relative "crspec/configuration"
 require_relative "crspec/execution_context"
 require_relative "crspec/matchers"
 require_relative "crspec/expectations"
+require_relative "crspec/file_fixtures"
 require_relative "crspec/example"
+require_relative "crspec/shared_examples"
 require_relative "crspec/example_group"
 require_relative "crspec/mock/interceptor"
 require_relative "crspec/mock/space"
 require_relative "crspec/mock/double"
 require_relative "crspec/formatters/progress_formatter"
+require_relative "crspec/status_persistence"
 require_relative "crspec/runner"
+require_relative "crspec/process_runner"
 require_relative "crspec/dsl"
 require_relative "crspec/rails/database_isolation"
 require_relative "crspec/rails/system_server"
@@ -24,3 +28,5 @@ require_relative "crspec/generators/init"
 module Crspec
   class Error < StandardError; end
 end
+
+RSpec = Crspec unless defined?(RSpec)

data/lib/rspec/core.rb

@@ -0,0 +1,2 @@
+# frozen_string_literal: true
+require_relative "../crspec"

data/lib/rspec/expectations.rb

@@ -0,0 +1,2 @@
+# frozen_string_literal: true
+require_relative "../crspec"

data/lib/rspec/mocks.rb

@@ -0,0 +1,2 @@
+# frozen_string_literal: true
+require_relative "../crspec"

data/lib/rspec/rails.rb

@@ -0,0 +1,2 @@
+# frozen_string_literal: true
+require_relative "../crspec"

data/lib/rspec.rb

@@ -0,0 +1,2 @@
+# frozen_string_literal: true
+require_relative "crspec"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: crspec
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Aboobacker MK
@@ -10,6 +10,20 @@ bindir: exe
 cert_chain: []
 date: 2026-07-31 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: async
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: prism
   requirement: !ruby/object:Gem::Requirement
@@ -48,20 +62,32 @@ files:
 - lib/crspec/example_group.rb
 - lib/crspec/execution_context.rb
 - lib/crspec/expectations.rb
+- lib/crspec/file_fixtures.rb
 - lib/crspec/formatters/progress_formatter.rb
 - lib/crspec/generators/init.rb
 - lib/crspec/matchers.rb
+- lib/crspec/mock/argument_matchers.rb
 - lib/crspec/mock/double.rb
 - lib/crspec/mock/interceptor.rb
 - lib/crspec/mock/space.rb
+- lib/crspec/process_runner.rb
+- lib/crspec/rails/assets_shim.rb
 - lib/crspec/rails/database_isolation.rb
 - lib/crspec/rails/parallel.rb
 - lib/crspec/rails/request_helpers.rb
 - lib/crspec/rails/system_server.rb
+- lib/crspec/rails/warden_shim.rb
 - lib/crspec/runner.rb
+- lib/crspec/shared_examples.rb
+- lib/crspec/status_persistence.rb
 - lib/crspec/transpiler/cli.rb
 - lib/crspec/transpiler/rewriter.rb
 - lib/crspec/version.rb
+- lib/rspec.rb
+- lib/rspec/core.rb
+- lib/rspec/expectations.rb
+- lib/rspec/mocks.rb
+- lib/rspec/rails.rb
 - sig/crspec.rbs
 homepage: https://github.com/crspec/crspec
 licenses: