crp 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1f19f65da31559dfeb4b01b1e02e1565ddbffd31
-  data.tar.gz: a8bca454e096830f91cf19d76a42a33ff57325d2
+  metadata.gz: 6adae638d0482d2722c43ec24fb795af80805f8b
+  data.tar.gz: b3a43c6695b5b84f7548b15ad26df7d1161a63f5
 SHA512:
-  metadata.gz: b8e1fbb78131298b5270818269330db9e8b6d6abb34c9643c7a23f1530ee0d578899f46f5fee41c1954e484cfe7442e049526ad01e02de3ebcb37b2bb4a8c6c6
-  data.tar.gz: 67f3bbdb21c2233f466743dd1a04700042727df80916a201637f8dc3d1ffacfa321ffc29d80ede25862a398a16d983d76f52caad20886518b103f4c5ee6bed76
+  metadata.gz: 7a3a98542149a438aadbb52b2e74066dcef40a677f53f6ef7bb316f7688ded0136d76df8e46f790160bb33475fce58a9ce242cd511345c0692b2aef0f46fb538
+  data.tar.gz: e6cce06b9a7b04ecceadd035380ac44888bc642ecddb0b7a24b5f1c4c5415534e490dc177b9dfe3125f2370274da2d408dff7155db444c9696884471f59077c3

data/README.md

@@ -44,17 +44,15 @@ Parse the callback received from CRP:
 ```` ruby
 require "crp"
  => true
-review_callback_response = CRP::ReviewCallbackResponse.new(callback_response)
+review_callback = CRP::ReviewCallbackRequest.new(callback_request)
  =>
-review_callback_response.successful?
- => true
-review_callback_response.internal_id
+review_callback.internal_id
  => "123"
-review_callback_response.external_id
+review_callback.external_id
  => "4321"
-review_callback_response.result_code
+review_callback.result_code
  => 1
-review_callback_response.result_message
+review_callback.result_message
  => "Approved"
 ````
 

data/lib/crp.rb

@@ -1,7 +1,7 @@
 require "crp/version"
 require "crp/review_poster"
 require "crp/review_response"
-require "crp/review_callback_response"
+require "crp/review_callback"
 require "crp/result_mapper"
 require "crp/gender_mapper"
 

data/lib/crp/{review_callback_response.rb → review_callback.rb}

@@ -1,19 +1,13 @@
 require 'cgi'
 
 module CRP
-  class ReviewCallbackResponse
-    SUCCESS_STATUS_CODE = 200
-
-    def initialize(response)
-      @response = response
-    end
-
-    def successful?
-      @response.code.to_i == SUCCESS_STATUS_CODE
+  class ReviewCallback
+    def initialize(payload)
+      @payload = payload
     end
 
     def raw_review
-      successful? ? CGI::parse(@response.body) : {}
+      CGI::parse(@payload)
     end
 
     def external_id

data/lib/crp/version.rb

@@ -1,3 +1,3 @@
 module CRP
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/test/review_callback_test.rb

@@ -0,0 +1,41 @@
+require File.expand_path("#{File.dirname(__FILE__)}/test_helper")
+
+require 'cgi'
+
+module CRP
+  describe ReviewCallback do
+    let(:payload)         { valid_callback_review_body }
+    let(:review_callback) { ReviewCallback.new(payload) }
+
+    describe :raw_review do
+      it "returns the raw review" do
+        parsed_valid_callback_review_body = CGI::parse(valid_callback_review_body)
+        review_callback.raw_review.must_equal(parsed_valid_callback_review_body)
+      end
+    end
+
+    describe :internal_id do
+      it "returns the internal id from the callback request" do
+        review_callback.internal_id.must_equal("123")
+      end
+    end
+
+    describe :external_id do
+      it "returns the external id from the callback request" do
+        review_callback.external_id.must_equal("4321")
+      end
+    end
+
+    describe :result_code do
+      it "returns the result code from the callback request" do
+        review_callback.result_code.must_equal(1)
+      end
+    end
+
+    describe :result_message do
+      it "returns the result message from the callback request" do
+        review_callback.result_message.must_equal("Approved")
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: crp
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Agile Wings
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-17 00:00:00.000000000 Z
+date: 2013-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: webmock
@@ -54,7 +54,7 @@ files:
 - lib/crp.rb
 - lib/crp/gender_mapper.rb
 - lib/crp/result_mapper.rb
-- lib/crp/review_callback_response.rb
+- lib/crp/review_callback.rb
 - lib/crp/review_poster.rb
 - lib/crp/review_response.rb
 - lib/crp/version.rb
@@ -63,7 +63,7 @@ files:
 - test/fixtures/valid_review_with_integer_internal_id.json
 - test/gender_mapper_test.rb
 - test/result_mapper_test.rb
-- test/review_callback_response_test.rb
+- test/review_callback_test.rb
 - test/review_poster_test.rb
 - test/review_response_test.rb
 - test/test_helper.rb
@@ -98,7 +98,7 @@ test_files:
 - test/fixtures/valid_review_with_integer_internal_id.json
 - test/gender_mapper_test.rb
 - test/result_mapper_test.rb
-- test/review_callback_response_test.rb
+- test/review_callback_test.rb
 - test/review_poster_test.rb
 - test/review_response_test.rb
 - test/test_helper.rb

data/test/review_callback_response_test.rb

@@ -1,110 +0,0 @@
-require File.expand_path("#{File.dirname(__FILE__)}/test_helper")
-
-require 'cgi'
-
-module CRP
-  describe ReviewCallbackResponse do
-    before do
-      @response = Net::HTTPResponse.new(1.0, 200, "OK")
-    end
-
-    describe :successful? do
-      describe "when it succeeded" do
-        it "returns true" do
-          review_callback_response = ReviewCallbackResponse.new(@response)
-          review_callback_response.successful?.must_equal(true)
-        end
-      end
-
-      describe "when something went wrong" do
-        before do
-          @response = Net::HTTPResponse.new(1.0, 500, "Internal Server Error")
-        end
-
-        it "returns false" do
-          review_callback_response = ReviewCallbackResponse.new(@response)
-          review_callback_response.successful?.must_equal(false)
-        end
-      end
-    end
-
-    describe :raw_review do
-      describe "when it succeeded" do
-        before do
-          @response = MiniTest::Mock.new # can't set response.body for some reason
-          @response.expect(:code, "200")
-          @response.expect(:body, valid_callback_review_body)
-        end
-
-        it "returns the raw review" do
-          review_callback_response = ReviewCallbackResponse.new(@response)
-          parsed_valid_callback_review_body = CGI::parse(valid_callback_review_body)
-          review_callback_response.raw_review.must_equal(parsed_valid_callback_review_body)
-        end
-      end
-
-      describe "when something went wrong" do
-        before do
-          @response = Net::HTTPResponse.new(1.0, 500, "Internal Server Error")
-        end
-
-        it "returns an empty raw review" do
-          review_callback_response = ReviewCallbackResponse.new(@response)
-          review_callback_response.raw_review.must_equal({})
-        end
-      end
-    end
-
-    describe :internal_id do
-      before do
-        @response = MiniTest::Mock.new # can't set response.body for some reason
-        @response.expect(:code, "200")
-        @response.expect(:body, valid_callback_review_body)
-      end
-
-      it "returns the internal id from the callback response" do
-        review_callback_response = ReviewCallbackResponse.new(@response)
-        review_callback_response.internal_id.must_equal("123")
-      end
-    end
-
-    describe :external_id do
-      before do
-        @response = MiniTest::Mock.new # can't set response.body for some reason
-        @response.expect(:code, "200")
-        @response.expect(:body, valid_callback_review_body)
-      end
-
-      it "returns the external id from the callback response" do
-        review_callback_response = ReviewCallbackResponse.new(@response)
-        review_callback_response.external_id.must_equal("4321")
-      end
-    end
-
-    describe :result_code do
-      before do
-        @response = MiniTest::Mock.new # can't set response.body for some reason
-        @response.expect(:code, "200")
-        @response.expect(:body, valid_callback_review_body)
-      end
-
-      it "returns the result code from the callback response" do
-        review_callback_response = ReviewCallbackResponse.new(@response)
-        review_callback_response.result_code.must_equal(1)
-      end
-    end
-
-    describe :result_message do
-      before do
-        @response = MiniTest::Mock.new # can't set response.body for some reason
-        @response.expect(:code, "200")
-        @response.expect(:body, valid_callback_review_body)
-      end
-
-      it "returns the result message from the callback response" do
-        review_callback_response = ReviewCallbackResponse.new(@response)
-        review_callback_response.result_message.must_equal("Approved")
-      end
-    end
-  end
-end