crowbar-client 2.2.1 → 2.3.0

data/spec/crowbar/client/request/node/group_spec.rb

@@ -0,0 +1,53 @@
+#
+# Copyright 2015, SUSE Linux GmbH
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require_relative "../../../../spec_helper"
+
+describe "Crowbar::Client::Request::Node::Group" do
+  it_behaves_like "a request class", true do
+    subject do
+      ::Crowbar::Client::Request::Node::Group.new(
+        attrs
+      )
+    end
+
+    let!(:attrs) do
+      {
+        name: "node1",
+        value: "new_group"
+      }
+    end
+
+    let!(:params) do
+      {}
+    end
+
+    let!(:method) do
+      :post
+    end
+
+    let!(:url) do
+      "nodes/groups/1.0/node1/new_group"
+    end
+
+    let!(:headers) do
+      {
+        "Content-Type" => "application/json",
+        "Accept" => "application/json"
+      }
+    end
+  end
+end

data/spec/crowbar/client/request/node/list_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Node::List" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Node::List.new(
         attrs

data/spec/crowbar/client/request/node/rename_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Node::Rename" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Node::Rename.new(
         attrs

data/spec/crowbar/client/request/node/role_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Node::Role" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Node::Role.new(
         attrs

data/spec/crowbar/client/request/node/show_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Node::Show" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Node::Show.new(
         attrs

data/spec/crowbar/client/request/node/status_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Node::Status" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Node::Status.new(
         attrs

data/spec/crowbar/client/request/node/transition_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Node::Transition" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Node::Transition.new(
         attrs

data/spec/crowbar/client/request/proposal/commit_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Proposal::Commit" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Proposal::Commit.new(
         attrs

data/spec/crowbar/client/request/proposal/create_spec.rb

@@ -17,40 +17,38 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Proposal::Create" do
-  # it_behaves_like "a request class" do
-  #   subject do
-  #     ::Crowbar::Client::Request::Proposal::Create.new(
-  #       attrs
-  #     )
-  #   end
-
-  #   let!(:attrs) do
-  #     {
-  #       barclamp: "ntp",
-  #       proposal: "default"
-  #     }
-  #   end
-
-  #   let!(:params) do
-  #     {}
-  #   end
-
-  #   let!(:method) do
-  #     :post
-  #   end
-
-  #   let!(:url) do
-  #     "crowbar/ntp/1.0/proposals/commit/default"
-  #   end
-
-  #   let!(:headers) do
-  #     {
-  #       "Content-Type" => "application/json",
-  #       "Accept" => "application/json"
-  #     }
-  #   end
-  # end
-
-  pending
-
+  it_behaves_like "a request class", true do
+    subject do
+      ::Crowbar::Client::Request::Proposal::Create.new(
+        attrs
+      )
+    end
+
+    let!(:attrs) do
+      {
+        barclamp: "ntp",
+        proposal: "default",
+        data: "{}"
+      }
+    end
+
+    let!(:params) do
+      {}
+    end
+
+    let!(:method) do
+      :put
+    end
+
+    let!(:url) do
+      "crowbar/ntp/1.0/proposals"
+    end
+
+    let!(:headers) do
+      {
+        "Content-Type" => "application/json",
+        "Accept" => "application/json"
+      }
+    end
+  end
 end

data/spec/crowbar/client/request/proposal/delete_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Proposal::Delete" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Proposal::Delete.new(
         attrs

data/spec/crowbar/client/request/proposal/dequeue_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Proposal::Dequeue" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Proposal::Dequeue.new(
         attrs

data/spec/crowbar/client/request/proposal/edit_spec.rb

@@ -17,40 +17,38 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Proposal::Edit" do
-  # it_behaves_like "a request class" do
-  #   subject do
-  #     ::Crowbar::Client::Request::Proposal::Edit.new(
-  #       attrs
-  #     )
-  #   end
-
-  #   let!(:attrs) do
-  #     {
-  #       barclamp: "ntp",
-  #       proposal: "default"
-  #     }
-  #   end
-
-  #   let!(:params) do
-  #     {}
-  #   end
-
-  #   let!(:method) do
-  #     :delete
-  #   end
-
-  #   let!(:url) do
-  #     "crowbar/ntp/1.0/proposals/dequeue/default"
-  #   end
-
-  #   let!(:headers) do
-  #     {
-  #       "Content-Type" => "application/json",
-  #       "Accept" => "application/json"
-  #     }
-  #   end
-  # end
-
-  pending
-
+  it_behaves_like "a request class", true do
+    subject do
+      ::Crowbar::Client::Request::Proposal::Edit.new(
+        attrs
+      )
+    end
+
+    let!(:attrs) do
+      {
+        barclamp: "ntp",
+        proposal: "default",
+        data: "{}"
+      }
+    end
+
+    let!(:params) do
+      {}
+    end
+
+    let!(:method) do
+      :post
+    end
+
+    let!(:url) do
+      "crowbar/ntp/1.0/proposals/default"
+    end
+
+    let!(:headers) do
+      {
+        "Content-Type" => "application/json",
+        "Accept" => "application/json"
+      }
+    end
+  end
 end

data/spec/crowbar/client/request/proposal/list_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Proposal::List" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Proposal::List.new(
         attrs

data/spec/crowbar/client/request/proposal/reset_spec.rb

@@ -0,0 +1,53 @@
+#
+# Copyright 2015, SUSE Linux GmbH
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require_relative "../../../../spec_helper"
+
+describe "Crowbar::Client::Request::Proposal::Reset" do
+  it_behaves_like "a request class", true do
+    subject do
+      ::Crowbar::Client::Request::Proposal::Reset.new(
+        attrs
+      )
+    end
+
+    let!(:attrs) do
+      {
+        barclamp: "ntp",
+        proposal: "default"
+      }
+    end
+
+    let!(:params) do
+      {}
+    end
+
+    let!(:method) do
+      :post
+    end
+
+    let!(:url) do
+      "crowbar/ntp/1.0/proposals/reset/default"
+    end
+
+    let!(:headers) do
+      {
+        "Content-Type" => "application/json",
+        "Accept" => "application/json"
+      }
+    end
+  end
+end

data/spec/crowbar/client/request/proposal/show_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Proposal::Show" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Proposal::Show.new(
         attrs

data/spec/crowbar/client/request/proposal/template_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Proposal::Template" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Proposal::Template.new(
         attrs

data/spec/crowbar/client/request/repository/activate_all_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Repository::ActivateAll" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Repository::ActivateAll.new(
         attrs

data/spec/crowbar/client/request/repository/activate_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Repository::Activate" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Repository::Activate.new(
         attrs

data/spec/crowbar/client/request/repository/deactivate_all_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Repository::DeactivateAll" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Repository::DeactivateAll.new(
         attrs

data/spec/crowbar/client/request/repository/deactivate_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Repository::Deactivate" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Repository::Deactivate.new(
         attrs

data/spec/crowbar/client/request/repository/list_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Repository::List" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Repository::List.new(
         attrs

data/spec/crowbar/client/request/role/list_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Role::List" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Role::List.new(
         attrs

data/spec/crowbar/client/request/role/show_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Role::Show" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Role::Show.new(
         attrs

data/spec/crowbar/client/request/server/api_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::Server::Api" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::Server::Api.new(
         attrs

data/spec/crowbar/client/request/virtual_ip/allocate_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::VirtualIP::Allocate" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::VirtualIP::Allocate.new(
         attrs

data/spec/crowbar/client/request/virtual_ip/deallocate_spec.rb

@@ -17,7 +17,7 @@
 require_relative "../../../../spec_helper"
 
 describe "Crowbar::Client::Request::VirtualIP::Deallocate" do
-  it_behaves_like "a request class" do
+  it_behaves_like "a request class", true do
     subject do
       ::Crowbar::Client::Request::VirtualIP::Deallocate.new(
         attrs

data/spec/spec_helper.rb

@@ -52,4 +52,6 @@ end
 RSpec.configure do |config|
   config.mock_with :rspec
   config.order = "random"
+
+  config.include HelperMethods
 end

data/{lib/crowbar/client/request/reset.rb → spec/support/helper_methods.rb}

@@ -14,16 +14,15 @@
 # limitations under the License.
 #
 
-module Crowbar
-  module Client
-    module Request
-      module Reset
-        autoload :Nodes,
-          File.expand_path("../reset/nodes", __FILE__)
-
-        autoload :Proposal,
-          File.expand_path("../reset/proposal", __FILE__)
-      end
-    end
+module HelperMethods
+  def fixture_path(file)
+    Pathname.new(
+      File.expand_path(
+        "../../fixtures",
+        __FILE__
+      )
+    ).join(
+      file
+    )
   end
 end

data/spec/support/request_examples.rb

@@ -14,7 +14,7 @@
 # limitations under the License.
 #
 
-shared_examples "a request class" do
+shared_examples "a request class" do |with_body|
   before(:each) do
     Crowbar::Client::Config.configure(
       Crowbar::Client::Config.defaults.merge(
@@ -25,35 +25,54 @@ shared_examples "a request class" do
 
   it "provides a method value" do
     expect(subject.method).to(
-      eql(method)
+      eq(method)
     )
   end
 
   it "provides a specific url" do
     expect(subject.url).to(
-      eql(url)
+      eq(url)
     )
   end
 
   it "provides a valid payload" do
     expect(subject.content).to(
-      eql(params)
+      eq(params)
     )
   end
 
   it "submits payload to an API" do
-    expect(::Crowbar::Client::Request::Party).to(
-      receive(method).with(
-        "/#{url}",
+    content = if with_body
+      {
         body: params.to_json,
         headers: headers
-      ).and_return(
-        double(
-          code: 200
-        )
-      )
+      }
+    else
+      {
+        headers: headers
+      }
+    end
+
+    stub_request(
+      method,
+      "http://crowbar:80/#{url}"
+    ).to_return(
+      status: 200,
+      body: "",
+      headers: {}
     )
 
     subject.process
+
+    expect(
+      a_request(
+        method,
+        "http://crowbar:80/#{url}"
+      ).with(
+        content
+      )
+    ).to(
+      have_been_made.once
+    )
   end
 end