crono_trigger 0.6.0 → 0.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a9b3bad7ab74a886398bcffaa3f2d935ec35dcd83819abe6b24c0453771a4d1
-  data.tar.gz: 4afa776cb8305b9a95b92c180a3c6da86f0ed205e32a93f3887084b3f498e980
+  metadata.gz: e08f955458cc12b3cd3f3aab84e0f662d760c7a72872c655708e70aa4d4d0ac3
+  data.tar.gz: de4c5fdd13008080291d3adf542e05a9fb5e233f423a8d83ea8bc0bc70a09cde
 SHA512:
-  metadata.gz: 7e42ef78268d05a3add743f0616fbaa0ea69dba395328a1304fd1a7b18450777ce9c97ccd7be58f59a47d5f5b7c0854098ca74f5756d1b07470b91d42305ba29
-  data.tar.gz: 1ae81221b5251c7ede8d204385910930162bebba7d74ed743fd5978461c9a9d008b9ede5e3c8890ab02b2867030d088032e5776441e073f26a080b8b53410b5b
+  metadata.gz: ff4f9d234a111fe0d6815e8d6e4d60a003bfc1891a299b808ac89bfc62ef05f4f0146b770ea924c5a7c592852bfb613053ea41ae51344fcc86c2ed4b00c0ea6f
+  data.tar.gz: eed66811d98184c25ecaa8c8fcecc9a44b4dcf46f8cff4bd469af2131ce948c9eca1f0dfa3185d6e3f42f1411322934d74ba666daa0b014d2092cff0cb46a0c1

data/.github/workflows/rspec.yml

@@ -0,0 +1,27 @@
+name: RSpec
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.7', '3.0', '3.1']
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+    # change this to (see https://github.com/ruby/setup-ruby#versioning):
+    # uses: ruby/setup-ruby@v1
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Run tests
+      run: bundle exec rake

data/README.md

@@ -1,6 +1,6 @@
 # CronoTrigger
 [![Gem Version](https://badge.fury.io/rb/crono_trigger.svg)](https://badge.fury.io/rb/crono_trigger)
-[![Build Status](https://travis-ci.org/joker1007/crono_trigger.svg?branch=master)](https://travis-ci.org/joker1007/crono_trigger)
+![rspec](https://github.com/joker1007/crono_trigger/actions/workflows/rspec.yml/badge.svg)
 [![codecov](https://codecov.io/gh/joker1007/crono_trigger/branch/master/graph/badge.svg)](https://codecov.io/gh/joker1007/crono_trigger)
 
 Asynchronous Job Scheduler for Rails.
@@ -137,10 +137,17 @@ mail.next_execute_at # => next 13:00 with Asia/Japan
 
 #### Run Worker
 
+ues `crono_trigger` command.
+`crono_trigger` command accepts model class names.
+
+For example,
+
 ```
 $ crono_trigger MailNotification
 ```
 
+And other options is following.
+
 ```
 $ crono_trigger --help
 Usage: crono_trigger [options] MODEL [MODEL..]

data/lib/crono_trigger/cli.rb

@@ -31,7 +31,7 @@ opt_parser = OptionParser.new do |opts|
   end
 
   opts.on("-c", "--concurrency=SIZE", Integer, "Execute thread size (Default: 25)") do |i|
-    options[:execute_thread] = i
+    options[:executor_thread] = i
   end
 
   opts.on("-l", "--log=LOGFILE", "Set log output destination (Default: STDOUT or ./crono_trigger.log if daemonize is true)") do |log|
@@ -67,7 +67,7 @@ end
 
 CronoTrigger.load_config(options[:config], options[:env]) if options[:config]
 
-%i(polling_thread polling_interval execute_thread).each do |name|
+%i(worker_id polling_thread polling_interval executor_thread).each do |name|
   CronoTrigger.config[name] = options[name] if options[name]
 end
 

data/lib/crono_trigger/polling_thread.rb

@@ -5,6 +5,9 @@ module CronoTrigger
       @stop_flag = stop_flag
       @logger = logger
       @executor = executor
+      if @executor.fallback_policy != :caller_runs
+        raise ArgumentError, "executor's fallback policies except for :caller_runs are not supported"
+      end
       @execution_counter = execution_counter
       @quiet = Concurrent::AtomicBoolean.new(false)
     end
@@ -50,34 +53,28 @@ module CronoTrigger
     end
 
     def poll(model)
-      @logger.debug "(polling-thread-#{Thread.current.object_id}) Poll #{model}"
-      records = []
-      overflowed_record_ids = []
+      @logger.info "(polling-thread-#{Thread.current.object_id}) Poll #{model}"
 
-      begin
-        model.connection_pool.with_connection do
-          records = model.executables_with_lock
+      maybe_has_next = true
+      while maybe_has_next
+        records, maybe_has_next = model.connection_pool.with_connection do
+          model.executables_with_lock
         end
 
         records.each do |record|
-          begin
-            @executor.post do
-              @execution_counter.increment
-              begin
-                process_record(record)
-              ensure
-                @execution_counter.decrement
-              end
+          @executor.post do
+            @execution_counter.increment
+            begin
+              process_record(record)
+            ensure
+              @execution_counter.decrement
             end
-          rescue Concurrent::RejectedExecutionError
-            overflowed_record_ids << record.id
           end
         end
-        unlock_overflowed_records(model, overflowed_record_ids)
-      end while overflowed_record_ids.empty? && records.any?
+      end
     end
 
-    private 
+    private
 
     def process_record(record)
       record.class.connection_pool.with_connection do
@@ -88,16 +85,5 @@ module CronoTrigger
       @logger.error(ex)
       CronoTrigger::GlobalExceptionHandler.handle_global_exception(ex)
     end
-
-    def unlock_overflowed_records(model, overflowed_record_ids)
-      model.connection_pool.with_connection do
-        unless overflowed_record_ids.empty?
-          model.where(id: overflowed_record_ids).crono_trigger_unlock_all!
-        end
-      end
-    rescue ActiveRecord::ConnectionNotEstablished, ActiveRecord::LockWaitTimeout, ActiveRecord::StatementTimeout, ActiveRecord::Deadlocked
-      sleep 1
-      retry
-    end
   end
 end

data/lib/crono_trigger/schedulable.rb

@@ -34,7 +34,7 @@ module CronoTrigger
 
       define_model_callbacks :execute, :retry
 
-      scope :executables, ->(from: Time.current, limit: CronoTrigger.config.executor_thread * 3 || 100, including_locked: false) do
+      scope :executables, ->(from: Time.current, limit: CronoTrigger.config.executor_thread * 3, including_locked: false) do
         t = arel_table
 
         rel = where(t[crono_trigger_column_name(:next_execute_at)].lteq(from))
@@ -56,15 +56,16 @@ module CronoTrigger
         rel
       end
 
-      before_create :set_current_cyctle_id
+      before_create :set_current_cycle_id
       before_update :update_next_execute_at_if_update_cron
 
       validate :validate_cron_format
     end
 
     module ClassMethods
-      def executables_with_lock(limit: CronoTrigger.config.executor_thread * 3 || 100)
+      def executables_with_lock(limit: CronoTrigger.config.executor_thread * 3)
         ids = executables(limit: limit).pluck(:id)
+        maybe_has_next = !ids.empty?
         records = []
         ids.each do |id|
           transaction do
@@ -75,7 +76,7 @@ module CronoTrigger
             end
           end
         end
-        records
+        [records, maybe_has_next]
       end
 
       def crono_trigger_column_name(name)
@@ -305,7 +306,7 @@ module CronoTrigger
       end
     end
 
-    def set_current_cyctle_id
+    def set_current_cycle_id
       if self.class.column_names.include?(crono_trigger_column_name(:current_cycle_id)) &&
           self[crono_trigger_column_name(:current_cycle_id)].nil?
         self[crono_trigger_column_name(:current_cycle_id)] = SecureRandom.uuid

data/lib/crono_trigger/version.rb

@@ -1,3 +1,3 @@
 module CronoTrigger
-  VERSION = "0.6.0"
+  VERSION = "0.6.3"
 end

data/lib/crono_trigger/worker.rb

@@ -24,6 +24,7 @@ module CronoTrigger
         min_threads: 1,
         max_threads: CronoTrigger.config.executor_thread,
         max_queue: CronoTrigger.config.executor_thread * 2,
+        fallback_policy: :caller_runs,
       )
       @execution_counter = Concurrent::AtomicFixnum.new
       @logger = Logger.new(STDOUT) unless @logger

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: crono_trigger
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.3
 platform: ruby
 authors:
 - joker1007
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-08-21 00:00:00.000000000 Z
+date: 2022-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chrono
@@ -244,6 +244,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/rspec.yml"
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
@@ -324,7 +325,7 @@ homepage: https://github.com/joker1007/crono_trigger
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -339,8 +340,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.3.3
+signing_key:
 specification_version: 4
 summary: In Service Asynchronous Job Scheduler for Rails
 test_files: []