cronitor 4.1.2 → 5.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 33e095f9fcce446c592729b13d8de07592c2549bdb4b4f19c5c4a09fe6024415
-  data.tar.gz: f3d808e0588b6ac2e03dd4b0b79d41320b37f004f4c8858008076a307acfab84
+  metadata.gz: ac1824833468d92068ba5664ef8d667fbe2518b34caa8da2cae3a307a7a923e7
+  data.tar.gz: 18ff6d1f48bd6da9686930585b6eaab3d296caedb33c171a5d668c26b69fdaba
 SHA512:
-  metadata.gz: 87bb2ea79e7d93ca390296964de090e08f7b010e65aa1626154bd7677c131ab01e896065cacece5701374aacfebc9d7e2823186302245a3dd3d45d1f0069db5d
-  data.tar.gz: 035fa6604dbc17370f36d8b4833c2aa0938671cef3e85d600a82b811ac1df1306583870478a23be54e645f339d4fe4c504a73416d015a6bc35d11d88952f021b
+  metadata.gz: 3d6e6aeaaaf3c0a8e5942132e833f53169756717dfa49d52d6641dc0a644f470cac6cc2124fdaebf12fb7814b485f9a14753c78a2a059541b94662c9127279a7
+  data.tar.gz: e2d4da41d199b4ff8c01fa768f69f0a48303c98559a2766f537b0a25f6940df21c0ecd2c94d4318636623f230cd8ff7976b75a3219ece9cae419b6eafa8b10ff

data/.github/workflows/publish.yml

@@ -15,15 +15,14 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v2
-      - name: Set up Ruby 2.7
-        uses: actions/setup-ruby@v1
+      - uses: actions/checkout@v3
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.7.x
+          ruby-version: 2.7
+          bundler-cache: true
       - name: Build and test with Rake
         run: |
-          gem install bundler
-          bundle install --jobs 4 --retry 3
           bundle exec rake release
         with:
           api_key: ${{secrets.RUBYGEMS_API_KEY}}

data/.github/workflows/test.yml

@@ -10,25 +10,25 @@ on:
       - master
 
 jobs:
-  lint:
-    strategy:
-      fail-fast: false
-      matrix:
-        ruby:
-          - '2.7'
-          - '3.0'
+#   lint:
+#     strategy:
+#       fail-fast: false
+#       matrix:
+#         ruby:
+#           - '2.7'
+#           - '3.0'
 
-    runs-on: ubuntu-latest
+#     runs-on: ubuntu-latest
 
-    steps:
-      - uses: actions/checkout@v2
-      - name: Set up Ruby 2.7
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: ${{ matrix.ruby }}
-          bundler-cache: true
-      - name: Run Rubocop
-        run: bundle exec rake rubocop
+#     steps:
+#       - uses: actions/checkout@v2
+#       - name: Set up Ruby 2.7
+#         uses: ruby/setup-ruby@v1
+#         with:
+#           ruby-version: ${{ matrix.ruby }}
+#           bundler-cache: true
+#       - name: Run Rubocop
+#         run: bundle exec rake rubocop
 
   spec:
     strategy:
@@ -37,18 +37,18 @@ jobs:
         ruby:
           - '2.7'
           - '3.0'
+          - '3.1'
+          - '3.2'
 
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v2
-      - name: Set up Ruby 2.7
+      - uses: actions/checkout@v3
+      - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true
       - name: Build and test with Rake
         run: |
-          gem install bundler
-          bundle install --jobs 4 --retry 3
           bundle exec rake

data/.rubocop.yml

@@ -12,6 +12,9 @@ AllCops:
   TargetRubyVersion: 2.5
   Exclude:
     - 'spec/cronitor_spec.rb'
+    
+RequireMFA: 
+  Enabled: false
 
 Metrics/AbcSize:
   Enabled: false

data/README.md

@@ -29,8 +29,8 @@ The `Cronitor#job` helper will send telemetry events before calling your block a
 require 'cronitor'
 Cronitor.api_key = 'api_key_123'
 
-Cronitor.job 'warehouse-replenishmenth-report' do
-  ReplenishmentReport.new(Date.today).run()
+Cronitor.job 'important-job' do
+    ImportantJob.new(Date.today).run()
 end
 ```
 
@@ -40,7 +40,7 @@ Cronitor provides a [separate library](https://github.com/cronitorio/cronitor-si
 
 ## Sending Telemetry Events
 
-If you want finer control over when/how [telemetry pings](https://cronitor.io/docs/telemetry-api) are sent,
+If you want more control over when/how [telemetry pings](https://cronitor.io/docs/telemetry-api) are sent,
 you can instantiate a monitor and call `#ping`.
 
 ```ruby
@@ -69,7 +69,7 @@ a deployment or build process. For details on all of the attributes that can be
 require 'cronitor'
 Cronitor.api_key = 'api_key_123'
 
-# read config file and set credentials (if included).
+# read config file.
 Cronitor.read_config('./cronitor.yaml')
 
 # sync config file's monitors to Cronitor.
@@ -78,6 +78,9 @@ Cronitor.apply_config
 # send config file's monitors to Cronitor to validate correctness.
 # monitors will not be saved.
 Cronitor.validate_config
+
+# generate a new config file from the Cronitor API.
+Cronitor.generate_config
 ```
 
 The `cronitor.yaml` file includes three top level keys `jobs`, `checks`, `heartbeats`. You can configure monitors under each key by defining [monitors](https://cronitor.io/docs/monitor-api#attributes).
@@ -129,7 +132,7 @@ You can also create and update monitors by calling `Monitor.put`.
 ```ruby
 require 'cronitor'
 
-monitors = Cronitor::Monitor.put([
+monitors = [
   {
     type: 'job',
     key: 'send-customer-invoices',
@@ -145,13 +148,15 @@ monitors = Cronitor::Monitor.put([
     request: {
         url: 'https://cronitor.io'
     },
-    schedule: 'every 45 seconds',
+    schedule: 'every 60 seconds',
     assertions: [
         'response.code = 200',
         'response.time < 600ms',
     ]
   }
-])
+]
+
+Cronitor::Monitor.put(monitors)
 ```
 
 ### Pause, Reset, Delete
@@ -178,6 +183,11 @@ require 'cronitor'
 Cronitor.api_key = 'apiKey123'
 Cronitor.api_version = '2020-10-01'
 Cronitor.environment = 'cluster_1_prod'
+
+Cronitor.timeout = 20 # defaults to 10 can also be set with ENV['CRONITOR_TIMEOUT']
+Cronitor.logger = nil # defaults to Logger.new($stdout)
+# faster timeout for potentially more time sensitive call
+Cronitor.ping_timeout = 10 # defaults to 5 can also be set with ENV['CRONITOR_PING_TIMEOUT']
 ```
 
 ## Contributing

data/lib/cronitor/config.rb

@@ -1,33 +1,28 @@
 # frozen_string_literal: true
 
 module Cronitor
-  TYPE_JOB = 'job'
-  TYPE_HEARTBEAT = 'heartbeat'
-  TYPE_CHECK = 'check'
-  MONITOR_TYPES = [TYPE_JOB, TYPE_HEARTBEAT, TYPE_CHECK].freeze
-  YAML_KEYS = %w[
-    api_key
-    api_version
-    environment
-  ] + MONITOR_TYPES.map { |t| "#{t}s" }
+  MONITOR_TYPES = [
+    TYPE_JOB = 'job',
+    TYPE_HEARTBEAT = 'heartbeat',
+    TYPE_CHECK = 'check'
+  ].freeze
+  YAML_KEYS = MONITOR_TYPES.map { |t| "#{t}s" }
 
   class << self
-    attr_accessor :api_key, :api_version, :environment, :logger, :config, :_headers
+    attr_accessor :api_key, :api_version, :environment, :logger, :config, :timeout, :ping_timeout, :auto_discover_sidekiq
 
     def configure(&block)
       block.call(self)
     end
   end
 
-  self.api_key = ENV['CRONITOR_API_KEY']
-  self.api_version = ENV['CRONITOR_API_VERSION']
-  self.environment = ENV['CRONITOR_ENVIRONMENT']
-  self.config = ENV['CRONITOR_CONFIG']
+  self.api_key = ENV.fetch('CRONITOR_API_KEY', nil)
+  self.api_version = ENV.fetch('CRONITOR_API_VERSION', nil)
+  self.environment = ENV.fetch('CRONITOR_ENVIRONMENT', nil)
+  self.timeout = ENV.fetch('CRONITOR_TIMEOUT', nil) || 10
+  self.ping_timeout = ENV.fetch('CRONITOR_PING_TIMEOUT', nil) || 5
+  self.config = ENV.fetch('CRONITOR_CONFIG', nil)
+  self.auto_discover_sidekiq = ENV.fetch('CRONITOR_AUTO_DISCOVER_SIDEKIQ', 'true').casecmp('true').zero? # https://github.com/cronitorio/cronitor-sidekiq
   self.logger = Logger.new($stdout)
   logger.level = Logger::INFO
-  self._headers = {
-    'Content-Type': 'application/json',
-    'User-Agent': 'cronitor-ruby',
-    'Cronitor-Version': Cronitor.api_version
-  }
 end

data/lib/cronitor/monitor.rb

@@ -6,56 +6,89 @@ module Cronitor
 
     PING_RETRY_THRESHOLD = 5
 
+    module Formats
+      ALL = [
+        JSON = 'json',
+        YAML = 'yaml'
+      ].freeze
+    end
+
+    module Headers
+      JSON = {
+        'Content-Type': 'application/json',
+        'User-Agent': "cronitor-ruby-#{Cronitor::VERSION}",
+        'Cronitor-Version': Cronitor.api_version
+      }.freeze
+      YAML = JSON.merge({
+                          'Content-Type': 'application/yaml'
+                        })
+    end
+
     def self.put(opts = {})
       rollback = opts[:rollback] || false
       opts.delete(:rollback)
 
       monitors = opts[:monitors] || [opts]
 
+      if opts[:format] == Cronitor::Monitor::Formats::YAML
+        url = "#{Cronitor.monitor_api_url}.yaml"
+        monitors['rollback'] = true if rollback
+        body = YAML.dump(monitors)
+        headers = Cronitor::Monitor::Headers::YAML
+      else
+        url = Cronitor.monitor_api_url
+        body = {
+          monitors: monitors,
+          rollback: rollback
+        }.to_json
+        headers = Cronitor::Monitor::Headers::JSON
+      end
+
       resp = HTTParty.put(
-        Cronitor.monitor_api_url,
+        url,
         basic_auth: {
           username: Cronitor.api_key,
           password: ''
         },
-        body: {
-          monitors: monitors,
-          rollback: rollback
-        }.to_json,
-        headers: Cronitor._headers,
-        timeout: opts[:timeout] || 10
+        body: body,
+        headers: headers,
+        timeout: opts[:timeout] || Cronitor.timeout
       )
 
       case resp.code
       when 200
-        out = []
-        data = JSON.parse(resp.body)
-
-        (data['monitors'] || []).each do |md|
-          m = Monitor.new(md['key'])
-          m.data = Cronitor.symbolize_keys(md)
-          out << m
+        if opts[:format] == Cronitor::Monitor::Formats::YAML
+          YAML.safe_load(resp.body)
+        else
+          out = []
+          data = JSON.parse(resp.body)
+
+          (data['monitors'] || []).each do |md|
+            m = Monitor.new(md['key'])
+            m.data = Cronitor.symbolize_keys(md)
+            out << m
+          end
+          out.length == 1 ? out[0] : out
         end
-        out.length == 1 ? out[0] : out
       when 400
         raise ValidationError.new(resp.body)
       else
-        raise Error.new("Error connecting to Cronitor: #{resp.code}")
+        raise Error.new("Error connecting to Cronitor: #{resp.code}\n #{resp.body}")
       end
     end
 
     def self.delete(key)
       resp = HTTParty.delete(
         "#{Cronitor.monitor_api_url}/#{key}",
-        timeout: 10,
+        timeout: Cronitor.timeout,
         basic_auth: {
           username: Cronitor.api_key,
           password: ''
         },
-        headers: Cronitor._headers
+        headers: Cronitor::Monitor::Headers::JSON
       )
       if resp.code != 204
-        Cronitor.logger.error("Error deleting monitor: #{key}")
+        Cronitor.logger&.error("Error deleting monitor: #{key}")
         return false
       end
       true
@@ -81,7 +114,7 @@ module Cronitor
     def ping(params = {})
       retry_count = params[:retry_count] || 0
       if api_key.nil?
-        Cronitor.logger.error('No API key detected. Set Cronitor.api_key or initialize Monitor with an api_key:')
+        Cronitor.logger&.error('No API key detected. Set Cronitor.api_key or initialize Monitor with an api_key:')
         return false
       end
 
@@ -92,8 +125,8 @@ module Cronitor
         response = HTTParty.get(
           ping_url,
           query: clean_params(params),
-          timeout: 5,
-          headers: Cronitor._headers,
+          timeout: Cronitor.ping_timeout,
+          headers: Cronitor::Monitor::Headers::JSON,
           query_string_normalizer: lambda do |query|
             query.compact!
             metrics = query[:metric]
@@ -106,13 +139,13 @@ module Cronitor
         )
 
         if response.code != 200
-          Cronitor.logger.error("Cronitor Telemetry Error: #{response.code}")
+          Cronitor.logger&.error("Cronitor Telemetry Error: #{response.code}")
           return false
         end
         true
       rescue StandardError => e
         # rescue instances of StandardError i.e. Timeout::Error, SocketError, etc
-        Cronitor.logger.error("Cronitor Telemetry Error: #{e}")
+        Cronitor.logger&.error("Cronitor Telemetry Error: #{e}")
         return false if retry_count >= Monitor::PING_RETRY_THRESHOLD
 
         # apply a backoff before sending the next ping
@@ -131,8 +164,8 @@ module Cronitor
 
       resp = HTTParty.get(
         pause_url,
-        timeout: 5,
-        headers: Cronitor._headers,
+        timeout: Cronitor.timeout,
+        headers: Cronitor::Monitor::Headers::JSON,
         basic_auth: {
           username: api_key,
           password: ''
@@ -162,13 +195,13 @@ module Cronitor
 
     def fetch
       unless api_key
-        Cronitor.logger.error(
+        Cronitor.logger&.error(
           'No API key detected. Set Cronitor.api_key or initialize Monitor with the api_key kwarg'
         )
         return
       end
 
-      HTTParty.get(monitor_api_url, timeout: 10, headers: Cronitor._headers, format: :json)
+      HTTParty.get(monitor_api_url, timeout: Cronitor.timeout, headers: Cronitor::Monitor::Headers::JSON, format: :json)
     end
 
     def clean_params(params)

data/lib/cronitor/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Cronitor
-  VERSION = '4.1.2'
+  VERSION = '5.1.0'
 end

data/lib/cronitor.rb

@@ -13,7 +13,7 @@ require 'cronitor/version'
 require 'cronitor/monitor'
 
 module Cronitor
-  def self.read_config(path = nil, output: false)
+  def self.read_config(path = nil)
     Cronitor.config = path || Cronitor.config
     unless Cronitor.config
       raise ConfigurationError.new(
@@ -26,40 +26,23 @@ module Cronitor
     conf.each do |k, _v|
       raise ConfigurationError.new("Invalid configuration variable: #{k}") unless Cronitor::YAML_KEYS.include?(k)
     end
-
-    Cronitor.api_key     = conf[:api_key] if conf[:api_key]
-    Cronitor.api_version = conf[:api_version] if conf[:api_version]
-    Cronitor.environment = conf[:environment] if conf[:environment]
-
-    return unless output
-
-    monitors = []
-    Cronitor::MONITOR_TYPES.each do |t|
-      plural_t = "#{t}s"
-      to_parse = conf[t] || conf[plural_t] || nil
-      next unless to_parse
-
-      unless to_parse.is_a?(Hash)
-        raise ConfigurationError.new('A Hash with keys corresponding to monitor keys is expected.')
-      end
-
-      to_parse.each do |key, m|
-        m['key'] = key
-        m['type'] = t
-        monitors << m
-      end
-    end
-    conf['monitors'] = monitors
     conf
   end
 
   def self.apply_config(rollback: false)
-    conf = read_config(output: true)
-    # allow a significantly longer timeout on requests that are sending full yaml config
-    monitors = Monitor.put(monitors: conf.fetch('monitors', []), rollback: rollback, timeout: 30)
-    puts("#{monitors.length} monitors #{rollback ? 'validated' : 'synced to Cronitor'}.")
+    conf = read_config
+    # allow a significantly longer timeout on requests that are sending full yaml config. min 30 seconds.
+    timeout = Cronitor.timeout < 30 ? 30 : Cronitor.timeout
+    monitors = Monitor.put(monitors: conf, format: Cronitor::Monitor::Formats::YAML, rollback: rollback,
+                           timeout: timeout)
+    count = 0
+    # step through the different monitor types and count up all the returned configurations
+    Cronitor::YAML_KEYS.each do |k|
+      count += (monitors[k]&.count || 0)
+    end
+    puts("#{count} monitors #{rollback ? 'validated' : 'synced to Cronitor'}.")
   rescue ValidationError => e
-    Cronitor.logger.error(e)
+    Cronitor.logger&.error(e)
   end
 
   def self.validate_config

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cronitor
 version: !ruby/object:Gem::Version
-  version: 4.1.2
+  version: 5.1.0
 platform: ruby
 authors:
 - Jeff Byrnes
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-07-13 00:00:00.000000000 Z
+date: 2023-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty