cron_to_go_sync 0.0.1 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6d51ed36d2923293ce7c72f8dff71b16f2703adda73bd9769e1734ce474b4ec8
-  data.tar.gz: 80cb621f80dc461a634c94a3df036d765e45d5bd97de7eb0e380fc8d51d98a0a
+  metadata.gz: bafcac59f207b83fb56b794ebf4fe8a91a90abe4c91f3de573d8501b36fccc93
+  data.tar.gz: 66fa54377bf9a20cd5692918edd83698ccdfa89e9d805915b4eecf79040d0c0e
 SHA512:
-  metadata.gz: d9b43e4dd3dc46960ad077c9e47507e21c1019cf05071656101653efee5f4f896cb65f89cb4887ef51a145038975ea8c7715c32b098cdc52086496c8a6a4c554
-  data.tar.gz: c014625e1f23df03a36164cfb4995f4b70a2f3bce2eadc40b7350b410b2891029a3a7ed3ee22a13f90afefb95f66fa340d016f1a110b52d84a4e08def4a08a9a
+  metadata.gz: 787bd39026c34fd5b7762e05d4476db86b64f8840cb48b9a0eeb49bec0506463d24f32763a37ef18f3bd8eb51f5f7269f8acd29496147f35ba80d288a9dbde6f
+  data.tar.gz: 2e9710b47ab66b8f2789929d981757da7ec69378e735b753ce4de069710cccecdd701639f5a9918bac6e788b78fc195f178c2a74d7775b5b25ca0e09f551e9c3

data/.github/workflows/ci.yml

@@ -21,9 +21,9 @@ jobs:
         ruby: ["3.0", "3.1", "3.2"]
     steps:
       - name: Checkout code
-        uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
+        uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633
       - name: Install Ruby and gems
-        uses: ruby/setup-ruby@8a45918450651f5e4784b6031db26f4b9f76b251
+        uses: ruby/setup-ruby@6bd3d993c602f6b675728ebaecb2b569ff86e99b
         with:
           bundler-cache: true
           ruby-version: ${{ matrix.ruby }}
@@ -37,17 +37,17 @@ jobs:
       contents: read
     steps:
       - name: Checkout code
-        uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
+        uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633
       - name: Install Ruby and gems
-        uses: ruby/setup-ruby@8a45918450651f5e4784b6031db26f4b9f76b251
+        uses: ruby/setup-ruby@6bd3d993c602f6b675728ebaecb2b569ff86e99b
         with:
           bundler-cache: true
           ruby-version: "3.2"
       - name: Bundle Audit Check
         run: bundle exec bundle-audit update && bundle exec bundle-audit check
       - name: Setup Python
-        uses: actions/setup-python@bd6b4b6205c4dbad673328db7b31b7fab9e241c0
+        uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d
         with:
           python-version: "3.10"
       - name: Run pre-commit
-        uses: pre-commit/action@5f528da5c95691c4cf42ff76a4d10854b62cbb82
+        uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd

data/.github/workflows/release.yml

@@ -7,9 +7,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
+        uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633
       - name: Install Ruby and gems
-        uses: ruby/setup-ruby@8a45918450651f5e4784b6031db26f4b9f76b251
+        uses: ruby/setup-ruby@6bd3d993c602f6b675728ebaecb2b569ff86e99b
         with:
           bundler-cache: true
           ruby-version: "3.2"

data/.pre-commit-config.yaml

@@ -12,7 +12,7 @@ repos:
     exclude: '^spec/data/'
   - id: check-merge-conflict
 - repo: https://github.com/rubocop/rubocop.git
-  rev: '675114c1b5a1999a112f8adaad8c99f8de6f7bcc'
+  rev: '24e7411d9606fd064e720ecb65a965646b6f8a06'
   hooks:
     - id: rubocop
-      additional_dependencies: ["standard:1.25.3"]
+      additional_dependencies: ["standard:1.31.0"]

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+0.0.3
+-----
+- Fix validator for ranges (e.g., `1-5`)
+
+0.0.2
+-----
+- Do not allow "7" in a day-of-week block to represent Sunday (CronToGo only allows "0")
+
 0.0.1
 -----
  - Initial release

data/Gemfile

@@ -6,9 +6,9 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 gemspec
 
 group :development, :test do
-  gem "rspec", "~> 3.0"
+  gem "rspec", "~> 3.13"
   gem "rspec-its", "~>1.3"
-  gem "standard", "~> 1.28.3"
+  gem "standard", "~> 1.35.1"
   gem "pry", "~> 0.14"
   gem "webmock", "~> 3"
   gem "vcr", "~> 6"

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    cron_to_go_sync (0.0.1)
+    cron_to_go_sync (0.0.3)
       activesupport
       dry-types
       dry-validation
@@ -15,14 +15,15 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.5)
+    activesupport (7.0.7.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
-    addressable (2.8.4)
+    addressable (2.8.6)
       public_suffix (>= 2.0.2, < 6.0)
     ast (2.4.2)
+    bigdecimal (3.1.6)
     bundle-audit (0.1.0)
       bundler-audit
     bundler-audit (0.9.1)
@@ -31,13 +32,14 @@ GEM
     citrus (3.0.2)
     coderay (1.1.3)
     concurrent-ruby (1.2.2)
-    crack (0.4.5)
+    crack (1.0.0)
+      bigdecimal
       rexml
-    diff-lcs (1.5.0)
+    diff-lcs (1.5.1)
     dry-configurable (1.0.1)
       dry-core (~> 1.0, < 2)
       zeitwerk (~> 2.6)
-    dry-core (1.0.0)
+    dry-core (1.0.1)
       concurrent-ruby (~> 1.0)
       zeitwerk (~> 2.6)
     dry-inflector (1.0.0)
@@ -54,7 +56,8 @@ GEM
       dry-logic (>= 1.4, < 2)
       dry-types (>= 1.7, < 2)
       zeitwerk (~> 2.6)
-    dry-types (1.7.1)
+    dry-types (1.7.2)
+      bigdecimal (~> 3.0)
       concurrent-ruby (~> 1.0)
       dry-core (~> 1.0)
       dry-inflector (~> 1.0)
@@ -66,104 +69,112 @@ GEM
       dry-initializer (~> 3.0)
       dry-schema (>= 1.12, < 2)
       zeitwerk (~> 2.6)
-    faraday (2.7.5)
-      faraday-net_http (>= 2.0, < 3.1)
-      ruby2_keywords (>= 0.0.4)
+    faraday (2.9.0)
+      faraday-net_http (>= 2.0, < 3.2)
     faraday-follow_redirects (0.3.0)
       faraday (>= 1, < 3)
-    faraday-net_http (3.0.2)
-    faraday-retry (2.1.0)
+    faraday-net_http (3.1.0)
+      net-http
+    faraday-retry (2.2.1)
       faraday (~> 2.0)
-    hashdiff (1.0.1)
-    i18n (1.13.0)
+    hashdiff (1.1.0)
+    i18n (1.14.1)
       concurrent-ruby (~> 1.0)
     interactor (3.1.2)
     interactor-contracts (0.3.0)
       dry-validation (~> 1.0)
       interactor (~> 3)
-    json (2.6.3)
+    json (2.7.1)
     language_server-protocol (3.17.0.3)
-    lint_roller (1.0.0)
+    lint_roller (1.1.0)
     method_source (1.0.0)
-    minitest (5.18.0)
-    parallel (1.23.0)
-    parser (3.2.2.1)
+    minitest (5.19.0)
+    net-http (0.4.1)
+      uri
+    parallel (1.24.0)
+    parser (3.3.0.5)
       ast (~> 2.4.1)
+      racc
     pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    public_suffix (5.0.1)
+    public_suffix (5.0.4)
+    racc (1.7.3)
     rainbow (3.1.1)
-    regexp_parser (2.8.0)
-    rexml (3.2.5)
-    rspec (3.12.0)
-      rspec-core (~> 3.12.0)
-      rspec-expectations (~> 3.12.0)
-      rspec-mocks (~> 3.12.0)
-    rspec-core (3.12.2)
-      rspec-support (~> 3.12.0)
-    rspec-expectations (3.12.3)
+    regexp_parser (2.9.0)
+    rexml (3.2.6)
+    rspec (3.13.0)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.0)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
+      rspec-support (~> 3.13.0)
     rspec-its (1.3.0)
       rspec-core (>= 3.0.0)
       rspec-expectations (>= 3.0.0)
-    rspec-mocks (3.12.5)
+    rspec-mocks (3.13.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
-    rspec-support (3.12.0)
-    rubocop (1.50.2)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.0)
+    rubocop (1.62.1)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.2.0.0)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.28.0, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.28.1)
-      parser (>= 3.2.1.0)
-    rubocop-performance (1.16.0)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
+    rubocop-ast (1.31.2)
+      parser (>= 3.3.0.4)
+    rubocop-performance (1.20.2)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
     ruby-progressbar (1.13.0)
-    ruby2_keywords (0.0.5)
-    standard (1.28.3)
+    standard (1.35.1)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.0)
-      rubocop (~> 1.50.2)
+      rubocop (~> 1.62.0)
       standard-custom (~> 1.0.0)
-      standard-performance (~> 1.0.1)
-    standard-custom (1.0.0)
+      standard-performance (~> 1.3)
+    standard-custom (1.0.2)
       lint_roller (~> 1.0)
-    standard-performance (1.0.1)
-      lint_roller (~> 1.0)
-      rubocop-performance (~> 1.16.0)
+      rubocop (~> 1.50)
+    standard-performance (1.3.1)
+      lint_roller (~> 1.1)
+      rubocop-performance (~> 1.20.2)
     thor (1.2.2)
-    toml-rb (2.2.0)
+    toml-rb (3.0.1)
       citrus (~> 3.0, > 3.0)
+      racc (~> 1.7)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.4.2)
-    vcr (6.1.0)
-    webmock (3.18.1)
+    unicode-display_width (2.5.0)
+    uri (0.13.0)
+    vcr (6.2.0)
+    webmock (3.23.0)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
-    zeitwerk (2.6.8)
+    zeitwerk (2.6.12)
 
 PLATFORMS
   arm64-darwin-22
+  arm64-darwin-23
   x86_64-linux
 
 DEPENDENCIES
   bundle-audit (~> 0.1.0)
   cron_to_go_sync!
   pry (~> 0.14)
-  rspec (~> 3.0)
+  rspec (~> 3.13)
   rspec-its (~> 1.3)
-  standard (~> 1.28.3)
+  standard (~> 1.35.1)
   vcr (~> 6)
   webmock (~> 3)
 

data/lib/cron_to_go_sync/parser.rb

@@ -39,7 +39,7 @@ module CronToGoSync
         unless (error = valid_cron_field(fields[3], 1, 12)).nil?
           key.failure("in month: #{error}")
         end
-        unless (error = valid_cron_field(fields[4], 0, 7)).nil?
+        unless (error = valid_cron_field(fields[4], 0, 6)).nil?
           key.failure("in day of week: #{error}")
         end
       end
@@ -68,7 +68,8 @@ module CronToGoSync
             lower = lower.to_i
             upper = upper.to_i
             return "invalid range lower #{lower}" if lower < lower_limit || lower > upper_limit
-            return "invalid range upper #{upper}" if upper < upper_limit || upper > upper_limit
+            return "invalid range upper #{upper}" if upper < lower_limit || upper > upper_limit
+            return "range not in order" if upper <= lower
           elsif !range.match?(/\A[0-9]+\z/)
             return "invalid range value #{range}"
           else

data/lib/cron_to_go_sync/version.rb

@@ -1,3 +1,3 @@
 module CronToGoSync
-  VERSION = "0.0.1"
+  VERSION = "0.0.3"
 end

data/spec/parser_spec.rb

@@ -30,5 +30,21 @@ RSpec.describe CronToGoSync::Parser do
       input_hash = {"job_name" => {schedule: "*/99 * * * *", enabled: true, ttl: 86400, dyno_size: "Basic", command: "/bin/true"}}
       expect { described_class.parse_hash(input_hash) }.to raise_error(RuntimeError, /invalid denominator value/)
     end
+
+    it "validates schedule range" do
+      input_hash = {"job_name" => {schedule: "* * * * 1-5", enabled: true, ttl: 86400, dyno_size: "Basic", command: "/bin/true"}}
+      parsed = described_class.parse_hash(input_hash)
+      expect(parsed["job_name"][:schedule]).to eq "* * * * 1-5"
+    end
+
+    it "validates schedule range values" do
+      input_hash = {"job_name" => {schedule: "* * * * 1-9", enabled: true, ttl: 86400, dyno_size: "Basic", command: "/bin/true"}}
+      expect { described_class.parse_hash(input_hash) }.to raise_error(RuntimeError, /invalid range upper/)
+    end
+
+    it "validates schedule range order" do
+      input_hash = {"job_name" => {schedule: "* * * * 5-1", enabled: true, ttl: 86400, dyno_size: "Basic", command: "/bin/true"}}
+      expect { described_class.parse_hash(input_hash) }.to raise_error(RuntimeError, /range not in order/)
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cron_to_go_sync
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.3
 platform: ruby
 authors:
 - Instrumentl, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-05-26 00:00:00.000000000 Z
+date: 2024-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -196,7 +196,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.4.19
 signing_key: 
 specification_version: 4
 summary: CronToGo configuration syncing library