RubyGems - critical-path-css-rails - Versions diffs - 1.0.1 → 2.3.0 - Mend

critical-path-css-rails 1.0.1 → 2.3.0

Files changed (38) hide show

checksums.yaml +4 -4
data/.rubocop.yml +0 -1
data/.rubocop_todo.yml +23 -7
data/BACKLOG.md +0 -4
data/Gemfile +4 -0
data/README.md +32 -13
data/app_container_name +1 -0
data/config.ru +6 -0
data/critical-path-css-rails.gemspec +14 -14
data/docker-compose.yml +21 -0
data/docker/ruby/.env +1 -0
data/docker/ruby/Dockerfile +21 -0
data/docker/ruby/startup.dev +6 -0
data/ext/npm/extconf.rb +0 -1
data/lib/critical-path-css-rails.rb +1 -1
data/lib/critical_path_css/configuration.rb +0 -1
data/lib/critical_path_css/css_fetcher.rb +1 -6
data/lib/critical_path_css/rails/config_loader.rb +2 -2
data/lib/critical_path_css/rails/version.rb +1 -1
data/lib/npm_commands.rb +2 -3
data/package-lock.json +194 -622
data/package.json +2 -2
data/spec/features/generate_and_fetch_critical_css_spec.rb +16 -0
data/spec/internal/app/controllers/root_controller.rb +3 -0
data/spec/internal/app/views/layouts/application.html.erb +4 -0
data/spec/internal/app/views/root/index.html.erb +1 -0
data/spec/internal/config/critical_path_css.yml +11 -0
data/spec/internal/config/database.yml +3 -0
data/spec/internal/config/routes.rb +3 -0
data/spec/internal/db/schema.rb +3 -0
data/spec/internal/log/.gitignore +1 -0
data/spec/internal/public/favicon.ico +0 -0
data/spec/{fixtures/static → internal/public}/test.css +1 -1
data/spec/spec_helper.rb +9 -3
metadata +22 -9
data/spec/css_fetcher_spec.rb +0 -25
data/spec/fixtures/static/test.html +0 -7
data/spec/support/static_file_server.rb +0 -45

data/package.json CHANGED Viewed

@@ -1,13 +1,13 @@
 {
   "name": "critical-path-css-rails",
-  "version": "1.0.0",
+  "version": "2.3.0",
   "description": "NPM dependencies of critical-path-css-rails",
   "private": true,
   "directories": {
     "lib": "lib"
   },
   "dependencies": {
-    "penthouse": "=0.11.5"
+    "penthouse": "=1.3.0"
   },
   "license": "MIT"
 }

data/spec/features/generate_and_fetch_critical_css_spec.rb ADDED Viewed

@@ -0,0 +1,16 @@
+require 'spec_helper.rb'
+RSpec.describe 'generate and fetch the critical css' do
+  before do
+    CriticalPathCss.generate_all
+  end
+  context 'on the root page' do
+    let(:route) { '/' }
+    it 'displays the correct critical CSS' do
+      visit route
+      expect(page).to have_content 'p{color:red}'
+    end
+  end
+end

data/spec/internal/app/controllers/root_controller.rb ADDED Viewed

@@ -0,0 +1,3 @@
+class RootController < ActionController::Base
+  def index; end
+end

data/spec/internal/app/views/layouts/application.html.erb ADDED Viewed

@@ -0,0 +1,4 @@
+<html>
+  <head></head>
+  <body><%= yield %></body>
+</html>

data/spec/internal/app/views/root/index.html.erb ADDED Viewed

	@@ -0,0 +1 @@
1	+ <p><%= CriticalPathCss.fetch(request.path) %></p>

data/spec/internal/config/critical_path_css.yml ADDED Viewed

@@ -0,0 +1,11 @@
+defaults: &defaults
+  base_url: http://0.0.0.0:9292
+  css_path: /test.css
+  routes:
+    - /
+development:
+  <<: *defaults
+test:
+  <<: *defaults

data/spec/internal/config/database.yml ADDED Viewed

@@ -0,0 +1,3 @@
+test:
+  adapter:  sqlite3
+  database: db/combustion_test.sqlite

data/spec/internal/config/routes.rb ADDED Viewed

@@ -0,0 +1,3 @@
+Rails.application.routes.draw do
+  root 'root#index'
+end

data/spec/internal/db/schema.rb ADDED Viewed

@@ -0,0 +1,3 @@
+ActiveRecord::Schema.define do
+  #
+end

data/spec/internal/log/.gitignore ADDED Viewed

	@@ -0,0 +1 @@
1	+ *.log

data/spec/internal/public/favicon.ico ADDED Viewed

File without changes

data/spec/{fixtures/static → internal/public}/test.css RENAMED Viewed

@@ -1,3 +1,3 @@
 p {
   color: red;
-}
+}

data/spec/spec_helper.rb CHANGED Viewed

@@ -1,11 +1,17 @@
 # frozen_string_literal: true
-require 'bundler/setup'
-require 'critical-path-css-rails'
+require 'bundler'
-require 'support/static_file_server'
+Bundler.require :default, :development
+Combustion.initialize! :action_controller, :action_view
+require 'rspec/rails'
+require 'capybara/rails'
 RSpec.configure do |config|
+  config.use_transactional_fixtures = true
   # Enable flags like --only-failures and --next-failure
   config.example_status_persistence_file_path = '.rspec_status'

metadata CHANGED Viewed

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: critical-path-css-rails
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 2.3.0
 platform: ruby
 authors:
 - Michael Misshore
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-11-02 00:00:00.000000000 Z
+date: 2018-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: combustion
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: 0.7.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: 0.7.0
 description: Only load the CSS you need for the initial viewport in Rails!
 email: mmisshore@gmail.com
 executables: []
@@ -39,7 +39,13 @@ files:
 - Gemfile
 - LICENSE
 - README.md
+- app_container_name
+- config.ru
 - critical-path-css-rails.gemspec
+- docker-compose.yml
+- docker/ruby/.env
+- docker/ruby/Dockerfile
+- docker/ruby/startup.dev
 - ext/npm/extconf.rb
 - ext/npm/install.rb
 - lib/config/critical_path_css.yml
@@ -55,11 +61,18 @@ files:
 - lib/tasks/critical_path_css.rake
 - package-lock.json
 - package.json
-- spec/css_fetcher_spec.rb
-- spec/fixtures/static/test.css
-- spec/fixtures/static/test.html
+- spec/features/generate_and_fetch_critical_css_spec.rb
+- spec/internal/app/controllers/root_controller.rb
+- spec/internal/app/views/layouts/application.html.erb
+- spec/internal/app/views/root/index.html.erb
+- spec/internal/config/critical_path_css.yml
+- spec/internal/config/database.yml
+- spec/internal/config/routes.rb
+- spec/internal/db/schema.rb
+- spec/internal/log/.gitignore
+- spec/internal/public/favicon.ico
+- spec/internal/public/test.css
 - spec/spec_helper.rb
-- spec/support/static_file_server.rb
 homepage:
 licenses:
 - MIT

data/spec/css_fetcher_spec.rb DELETED Viewed

@@ -1,25 +0,0 @@
-# frozen_string_literal: true
-require 'spec_helper'
-RSpec.describe 'CssFetcher' do
-  before :all do
-    StaticFileServer.start
-  end
-  after :all do
-    StaticFileServer.stop
-  end
-  it 'fetches css' do
-    config = CriticalPathCss::Configuration.new(
-      'base_url' => StaticFileServer.url,
-      'css_path' => 'spec/fixtures/static/test.css',
-      'routes' => ['/test.html']
-    )
-    fetcher = CriticalPathCss::CssFetcher.new(config)
-    expect(fetcher.fetch).to(
-      eq('/test.html' => "p {\n  color: red;\n}\n")
-    )
-  end
-end

data/spec/fixtures/static/test.html DELETED Viewed

@@ -1,7 +0,0 @@
-<!doctype html>
-<head>
-  <link rel="stylesheet" href="test.css">
-</head>
-<body>
-  <p>Hello world</p>
-</body>

data/spec/support/static_file_server.rb DELETED Viewed

@@ -1,45 +0,0 @@
-require 'socket'
-module StaticFileServer
-  class << self
-    def start # rubocop:disable Metrics/MethodLength,Metrics/AbcSize
-      @port = get_free_port
-      rd, wt = IO.pipe
-      @pid = fork do
-        require 'webrick'
-        rd.close
-        server = WEBrick::HTTPServer.new(
-          DocumentRoot: File.expand_path('spec/fixtures/static'),
-          Port: @port,
-          BindAddress: '127.0.0.1',
-          StartCallback: lambda do
-            # write "1", signal a server start message
-            wt.write(1)
-            wt.close
-          end
-        )
-        trap('INT') { server.shutdown }
-        server.start
-      end
-      wt.close
-      # read a byte for the server start signal
-      rd.read(1)
-      rd.close
-    end
-    def stop
-      Process.kill('INT', @pid)
-    end
-    def url
-      "http://localhost:#{@port}"
-    end
-    def get_free_port
-      server = TCPServer.new('127.0.0.1', 0)
-      port = server.addr[1]
-      server.close
-      port
-    end
-  end
-end