crimp 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a3c9582fb50d4c24f80f495871d85326c8db1034
-  data.tar.gz: 6965f4d813151e897087fd66aef13dbfa930221d
+  metadata.gz: f951279d5308025d1f3184b1a823a1577d13ebad
+  data.tar.gz: 9444429cbc53f722f053815ced9db784e29a5374
 SHA512:
-  metadata.gz: b32357f31dff6cb09241cd676acbeb9aa027b472090444b6364631a661c3dab052f6c21db401b5e29ed97250b5b22e13ca4645e34e295f8e35e0fadb7ffebcc0
-  data.tar.gz: 5b374574b25360818eef4946c7c24526be6dfe44d28d4d71f046a11e01c3a771b9f77826f1f910ce7dc4a43e3a136b4b2383dab1a904fdc801d9b680629d4027
+  metadata.gz: f91307d9094be916d32b3e95ca5c620db68979ec5d3eb465efaa2e0876df96543d51a43fad76331d20f04baa34ed254ab355587886ad66db7453badff1afcf3b
+  data.tar.gz: 092f330b087472fd4ebda5653ccb6ba86857597d205e71d15636562fd2ec2b2626cce2598b733d74acd7a7a637796148526f43d91e0bb569a67aee494ea3c98b

data/Guardfile

@@ -1,6 +1,6 @@
 guard 'rspec' do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^lib/.+\.rb$})
-  watch(%r{^spec/support/(.+)\.rb$})                  { "spec" }
-  watch('spec/spec_helper.rb')                        { "spec" }
+  watch(%r{^spec/support/(.+)\.rb$})                  { 'spec' }
+  watch('spec/spec_helper.rb')                        { 'spec' }
 end

data/Rakefile

@@ -1,6 +1,6 @@
-$:.unshift File.join(File.dirname(__FILE__), 'lib')
+$LOAD_PATH.unshift File.join(File.dirname(__FILE__), 'lib')
 
 require 'bundler/gem_tasks'
 require 'rake/rspec'
 
-task :default => :spec
+task default: :spec

data/lib/crimp.rb

@@ -1,5 +1,5 @@
-require "crimp/version"
-require "digest"
+require 'crimp/version'
+require 'digest'
 
 module Crimp
   def self.signature(obj)
@@ -36,7 +36,7 @@ module Crimp
   end
 
   def self.parse_array(array)
-    array.map! { |e| stringify(e) }.sort!
+    array.map { |e| stringify(e) }.sort
   end
 
   def self.parse_hash(hash)
@@ -44,6 +44,6 @@ module Crimp
   end
 
   def self.to_string(obj)
-    "#{obj.to_s}#{obj.class.to_s}"
+    "#{obj}#{obj.class}"
   end
 end

data/lib/crimp/version.rb

@@ -1,3 +1,3 @@
 module Crimp
-  VERSION = "0.1.1"
+  VERSION = '0.1.2'.freeze
 end

data/spec/consistency_spec.rb

@@ -6,38 +6,38 @@ describe Crimp do
       context 'given a Hash' do
         let(:hash) do
           {
-            :a => 123,
-            :b => 1.23,
-            :c => 'string',
-            :d => :sym
+            a: 123,
+            b: 1.23,
+            c: 'string',
+            d: :sym
           }
         end
         let(:md5) { '1dd744d51279187cc08cabe240f98be2' }
 
-        specify { expect(subject.signature hash).to eq md5 }
+        specify { expect(subject.signature(hash)).to eq md5 }
       end
 
       context 'given legacy Hash' do
         let(:hash) do
-          {:a => {:b => 'b', :c => 'c'}, :d => 'd'}
+          { a: { b: 'b', c: 'c' }, d: 'd' }
         end
         let(:md5) { '68d07febc4f47f56fa6ef5de063a77b1' }
 
-        specify { expect(subject.signature hash).to eq md5 }
+        specify { expect(subject.signature(hash)).to eq md5 }
       end
 
       context 'given an Array' do
         let(:array) { [123, 1.23, 'string', :sym] }
         let(:md5) { 'cd29980f258eef3faceca4f4da02ec65' }
 
-        specify { expect(subject.signature array).to eq md5 }
+        specify { expect(subject.signature(array)).to eq md5 }
       end
 
       context 'given legacy Array' do
         let(:array) { [1, 2, 3, [4, [5, 6]]] }
         let(:md5) { '4dc4e1161c9315db0bc43c0201b3ec05' }
 
-        specify { expect(subject.signature array).to eq md5 }
+        specify { expect(subject.signature(array)).to eq md5 }
       end
     end
   end

data/spec/crimp_spec.rb

@@ -1,59 +1,79 @@
 require 'spec_helper'
 
 describe Crimp do
-  let (:hash) { {:a => {:b => 'b', :c => 'c'}, :d => 'd'} }
-  let (:hash_unordered) { {:d => 'd', :a => {:c => 'c', :b => 'b'}} }
+  let (:hash) { { a: { b: 'b', c: 'c' }, d: 'd' } }
+  let (:hash_unordered) { { d: 'd', a: { c: 'c', b: 'b' } } }
   let (:array) { [1, 2, 3, [4, [5, 6]]] }
   let (:array_unordered) { [3, 2, 1, [[5, 6], 4]] }
 
-  describe ".signature" do
-    context "given a Hash" do
-      specify { expect(subject.signature hash).to be_a String }
+  describe '.signature' do
+    context 'given a Hash' do
+      specify { expect(subject.signature(hash)).to be_a String }
 
-      it "returns MD5 hash of stringified Hash" do
-        expect(
-          subject.signature(hash)
-        ).to eq(
-          Digest::MD5.hexdigest(subject.stringify(hash))
-        )
+      it 'returns MD5 hash of stringified Hash' do
+        expect(subject.signature(hash)).to eq(Digest::MD5.hexdigest(subject.stringify(hash)))
+      end
+
+      it 'does not modify original hash' do
+        original_hash = { d: 'd', a: { c: 'c', b: 'b' } }
+        expected_hash = { d: 'd', a: { c: 'c', b: 'b' } }
+
+        subject.signature(original_hash)
+
+        expect(original_hash).to eq(expected_hash)
       end
     end
 
-    context "given an Array" do
-      specify { expect(subject.signature array).to be_a String }
+    context 'given an Array' do
+      specify { expect(subject.signature(array)).to be_a String }
+
+      it 'returns MD5 hash of stringified Array' do
+        expect(subject.signature(array)).to eq(Digest::MD5.hexdigest(subject.stringify(array)))
+      end
+
+      it 'does not modify original array' do
+        original_array = [5, 4, 2, 6, [5, 7, 2]]
+        expected_array = [5, 4, 2, 6, [5, 7, 2]]
+
+        subject.signature(original_array)
 
-      it "returns MD5 hash of stringified Array" do
-        expect(
-          subject.signature(array)
-        ).to eq(
-          Digest::MD5.hexdigest(subject.stringify(array))
-        )
+        expect(original_array).to eq(expected_array)
       end
     end
   end
 
-  describe ".stringify" do
-    context "given a Hash" do
-      specify { expect(subject.stringify hash).to be_a String }
+  describe '.stringify' do
+    context 'given a Hash' do
+      specify { expect(subject.stringify(hash)).to be_a String }
 
-      it "returns equal strings for differently ordered hashes" do
-        expect(
-          subject.stringify(hash)
-        ).to eq(
-          subject.stringify(hash_unordered)
-        )
+      it 'returns equal strings for differently ordered hashes' do
+        expect(subject.stringify(hash)).to eq(subject.stringify(hash_unordered))
+      end
+
+      it 'does not modify original hash' do
+        original_hash = { d: 'd', a: { c: 'c', b: 'b' } }
+        expected_hash = { d: 'd', a: { c: 'c', b: 'b' } }
+
+        subject.signature(original_hash)
+
+        expect(original_hash).to eq(expected_hash)
       end
     end
 
-    context "given an Array" do
-      specify { expect(subject.stringify array).to be_a String }
+    context 'given an Array' do
+      specify { expect(subject.stringify(array)).to be_a String }
+
+      it 'returns equal strings for differently ordered arrays' do
+        expect(subject.stringify(array)).to eq(subject.stringify(array_unordered))
+      end
+
+      it 'does not modify original array' do
+        original_array = [5, 4, 2, 6, [5, 7, 2]]
+        expected_array = [5, 4, 2, 6, [5, 7, 2]]
+
+        subject.signature(original_array)
 
-      it "returns equal strings for differently ordered arrays" do
-        expect(
-          subject.stringify(array)
-        ).to eq(
-          subject.stringify(array_unordered)
-        )
+        expect(original_array).to eq(expected_array)
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,5 +1,4 @@
-$: << File.join(File.dirname(__FILE__),"..", "lib")
+$LOAD_PATH << File.join(File.dirname(__FILE__), '..', 'lib')
 
 require 'pry'
 require 'crimp'
-

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: crimp
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - BBC News
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-06-02 00:00:00.000000000 Z
+date: 2017-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement