crep 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 9e68c3928d59e06f5e2ec9c38ad0b4bc85c3cfa7
-  data.tar.gz: 69355f2f6cdefabc28ef9b0e71d0abdc012a12a3
+SHA256:
+  metadata.gz: 1f850691e9c5310d08744bfe8a5bec641d2d5f66f31e740ee0649a6eace15193
+  data.tar.gz: 74a17e8a6bb887ff990b8de51fc30aea0641b3e6c55ed7e1618ca55cf0d5909e
 SHA512:
-  metadata.gz: a67197963039aeda80eea053d1c0bff6ffa20cec630223782ddfb8f3c32d3c2dba3c104e6f13c7ee74ed59c2b3dfba5d5526714a0edb398bdfd158ca0b3ef70a
-  data.tar.gz: d24461deb9766f4a0f3d83f33ec4257513154628601ca3492ac0465920ab74708f2e66339417477e9edf709d4f669af81e1fa81a2fb9e2789cb9e5af800c2345
+  metadata.gz: 4cbff327806fd717670fc4708b30b666d500a579b2be4053db97036362a6620b2ee118f09b41fd1468b4fda63b8d8fef5ef0df26d430573fd02d138496a69a29
+  data.tar.gz: 8f650185f26a56a2d96daeefaef9538bb17b78d208dfd2ab0c93afd562e811c50dec3b9399570e07584867e08b4dfdae525739dd88ff481cb010965b484e6001

data/.rubocop.yml

@@ -15,3 +15,10 @@ Metrics/ParameterLists:
 Style/Documentation:
   Enabled: false
 
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/*_spec.rb'
+    - '*.gemspec'
+
+Metrics/AbcSize:
+  Enabled: false

data/Changelog.md

@@ -6,10 +6,20 @@
 
 ### Fixed
 
-- Reduced the size of the gem by removing unused assets being bundled with it.
-
 ### Miscellaneous
 
+# v1.0.2
+
+### Added
+
+- Support for generating top crashes without providing a version/build
+
+# v1.0.1
+
+### Fixed
+
+- Reduced the size of the gem by removing unused assets being bundled with it.
+
 # v1.0.0
 
 ### Added

data/Gemfile

@@ -6,7 +6,7 @@ source 'https://rubygems.org'
 gemspec
 
 # contains Support for Statistics
-gem 'hockeyapp', git: 'https://github.com/q231950/hockeyapp.git'
+gem 'hockeyapp', git: 'https://github.com/xing/hockeyapp.git'
 
 gem 'danger'
 gem 'danger-rubocop'

data/Gemfile.lock

@@ -1,5 +1,5 @@
 GIT
-  remote: https://github.com/q231950/hockeyapp.git
+  remote: https://github.com/xing/hockeyapp.git
   revision: 67bdabfdae885e59c977cf30765ac6346dd0ab57
   specs:
     hockeyapp (0.0.17)
@@ -14,7 +14,7 @@ GIT
 PATH
   remote: .
   specs:
-    crep (1.0.1)
+    crep (1.0.2)
       claide (~> 1.0.0)
       colorize
       hockeyapp
@@ -22,11 +22,11 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (5.1.4)
-      activesupport (= 5.1.4)
-    activesupport (5.1.4)
+    activemodel (5.2.1)
+      activesupport (= 5.2.1)
+    activesupport (5.2.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (~> 0.7)
+      i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
     addressable (2.5.2)
@@ -61,7 +61,7 @@ GEM
       danger
       rubocop
     diff-lcs (1.3)
-    docile (1.1.5)
+    docile (1.3.1)
     faraday (0.13.1)
       multipart-post (>= 1.2, < 3)
     faraday-http-cache (1.3.1)
@@ -71,9 +71,9 @@ GEM
       httparty (>= 0.7.3)
       mimemagic
       multipart-post
-    httparty (0.15.6)
+    httparty (0.16.2)
       multi_xml (>= 0.5.2)
-    i18n (0.9.3)
+    i18n (1.1.0)
       concurrent-ruby (~> 1.0)
     json (2.1.0)
     kramdown (1.16.2)
@@ -126,15 +126,15 @@ GEM
     sawyer (0.8.1)
       addressable (>= 2.3.5, < 2.6)
       faraday (~> 0.8, < 1.0)
-    simplecov (0.15.1)
-      docile (~> 1.1.0)
+    simplecov (0.16.1)
+      docile (~> 1.1)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.2)
     terminal-table (1.8.0)
       unicode-display_width (~> 1.1, >= 1.1.1)
     thread_safe (0.3.6)
-    tzinfo (1.2.4)
+    tzinfo (1.2.5)
       thread_safe (~> 0.1)
     unicode-display_width (1.3.0)
 
@@ -154,4 +154,4 @@ DEPENDENCIES
   rubocop (= 0.51.0)
 
 BUNDLED WITH
-   1.16.1
+   1.16.2

data/LICENSE

@@ -1,6 +1,6 @@
 The MIT License
 
-Copyright (c) 2017 XING SE
+Copyright (c) 2018 XING SE
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/Readme.md

@@ -25,7 +25,10 @@ Please follow our guide in the [installation instructions](https://github.com/xi
 $ export CREP_HOCKEY_API_TOKEN='abcde'
 
 # Run Crep
-$ bundle exec crep crashes --identifier='com.example.company' --version='1.23.0' --build='42' --only-unresolved
+$ bundle exec crep crashes --identifier='com.example.company' --version='1.23.0' --build='42'
+
+# Run Crep for the latest version and build
+$ bundle exec crep crashes --identifier='com.example.company' --only-unresolved
 ```
 
 The `--only-unresolved` flag filters out any crashes marked as resolved.

data/crep.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
   # to allow pushing to a single host or delete this section to allow pushing to any host.
   if spec.respond_to?(:metadata)
-    spec.metadata['allowed_push_host'] = "https://rubygems.org"
+    spec.metadata['allowed_push_host'] = 'https://rubygems.org'
   else
     raise 'RubyGems 2.0 or newer is required to protect against ' \
       'public gem pushes.'

data/lib/crep/command/crashes.rb

@@ -3,6 +3,7 @@
 require 'crep/command'
 require 'crep/crash_controller'
 require 'crep/model/crash_sources/hockeyapp_crash_source'
+require 'crep/model/app_source/hockeyapp_app_source'
 require 'hockeyapp'
 
 module Crep
@@ -44,14 +45,16 @@ module Crep
       super
 
       help! 'The identifier (--identifier) is a required parameter' unless @bundle_identifier
-      help! 'The version (--version)  is a required parameter' unless @version
-      help! 'The build number (--build) is a required parameter' unless @build
     end
 
     def run
       crash_datasource = HockeyAppCrashSource.new
       crash_controller = CrashController.new(@bundle_identifier, @top, crash_datasource, @show_only_unresolved, @template)
-      crash_controller.top_crashes(@version, @build)
+      if @version && @build
+        crash_controller.top_crashes(@version, @build)
+      else
+        crash_controller.latest_top_crashes
+      end
     end
   end
 end

data/lib/crep/crash_controller.rb

@@ -17,6 +17,17 @@ module Crep
       @template_path = template_path
     end
 
+    def latest_top_crashes
+      app_source = HockeyAppAppSource.new
+      app_source.configure
+      latest_top_crashes_with_app_source(app_source)
+    end
+
+    def latest_top_crashes_with_app_source(app_source)
+      latest_app = app_source.versions_for_bundle_identifier(@bundle_identifier).first
+      top_crashes(latest_app.version, latest_app.build)
+    end
+
     # returns list of top crashes for the given build
     def top_crashes(version, build)
       @version = version

data/lib/crep/model/app_source/app_source.rb

@@ -12,6 +12,11 @@ module Crep
       raise 'AppSource subclass has to implement the `apps` method.'
     end
 
+    # versions_for_bundle_identifier returns the versions for the first found app with the given bundle identifier
+    def versions_for_bundle_identifier(_bundle_identifier)
+      raise 'AppSource subclass has to implement the `versions_for_bundle_identifier` method.'
+    end
+
     # versions returns the versions for the given app identifier
     def versions(_app_identifier)
       raise 'AppSource subclass has to implement the `versions` method.'

data/lib/crep/model/app_source/hockeyapp_app_source.rb

@@ -19,10 +19,31 @@ module Crep
       @client.get_apps
     end
 
-    def versions(app_identifier)
-      apps = @client.get_apps.select do |a|
+    def versions_for_bundle_identifier(bundle_identifier)
+      apps = apps_for_bundle_identifier(bundle_identifier)
+
+      raise("Unable to find app with bundle identifier: #{bundle_identifier}") unless apps.count.positive?
+
+      app = apps.first
+      app.versions.map do |version|
+        Crep::Version.new(version.shortversion, version.version, app.public_identifier.downcase)
+      end
+    end
+
+    def apps_for_bundle_identifier(bundle_identifier)
+      @client.get_apps.select do |a|
+        a.bundle_identifier.casecmp(bundle_identifier.downcase).zero?
+      end
+    end
+
+    def apps_for_app_identifier(app_identifier)
+      @client.get_apps.select do |a|
         a.public_identifier == app_identifier
       end
+    end
+
+    def versions(app_identifier)
+      apps = apps_for_app_identifier(app_identifier)
 
       raise("Unable to find app with identifier: #{app_identifier}") unless apps.count.positive?
 

data/lib/crep/model/crash_sources/hockeyapp_crash_source.rb

@@ -36,19 +36,25 @@ module Crep
     def crash_groups(version, show_only_unresolved)
       reasons = version.crash_reasons('sort' => 'number_of_crashes', 'order' => 'desc')
       unresolved_reasons = show_only_unresolved ? unresolved_reasons(reasons) : reasons
+      crashes_from_reasons(unresolved_reasons)
+    end
+
+    def crashes_from_reasons(unresolved_reasons)
       unresolved_reasons.map do |reason|
-        url = url(app_id: reason.app.public_identifier, version_id: version.id, reason_id: reason.id)
-        deep_link = deep_link(app_id: reason.app.public_identifier, reason_id: reason.id)
-        Crash.new(file_line: "#{reason.file}:#{reason.line}",
-                  occurrences: reason.number_of_crashes,
-                  reason: reason.reason,
-                  crash_class: reason.crash_class,
-                  registered_at: Date.parse(reason.created_at),
-                  deep_link: deep_link,
-                  url: url)
+        crash_from_reason(reason)
       end
     end
 
+    def crash_from_reason(reason)
+      Crash.new(file_line: "#{reason.file}:#{reason.line}",
+                occurrences: reason.number_of_crashes,
+                reason: reason.reason,
+                crash_class: reason.crash_class,
+                registered_at: Date.parse(reason.created_at),
+                deep_link: deep_link(app_id: reason.app.public_identifier, reason_id: reason.id),
+                url: url(app_id: reason.app.public_identifier, version_id: version.id, reason_id: reason.id))
+    end
+
     def url(app_id:, version_id:, reason_id:)
       "https://rink.hockeyapp.net/manage/apps/#{app_id}/app_versions/#{version_id}/crash_reasons/#{reason_id}"
     end

data/lib/crep/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Crep
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: crep
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Kim Dung-Pham
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-13 00:00:00.000000000 Z
+date: 2018-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -204,7 +204,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Create Crash Reports with ease.