creek 2.4.4 → 2.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: b2377d5d56234ed481fc3642c951b6d207eb45c82faa9cc263159576190da221
-  data.tar.gz: 7552dd98f0eda1dedc73b25dac9350a592ae5ccb176380486c82c0d24898b77a
+SHA1:
+  metadata.gz: b454dcaf4ce681693d8b8db6c022a8119f13deb7
+  data.tar.gz: fd1955d05f4ef0288c0aef9542ac4e8571332c81
 SHA512:
-  metadata.gz: fe1d61dfd5c5de7c31da80dc1aaf25ba9a4d10c7ce5fe2ff0c152b1156182364af6875a24427490600b33030fb64d716b633b93b19ff69312ec6729670154bd8
-  data.tar.gz: f6830f1b392a280eb76d1a13f9ba21094c7cf6a87807a28c8f745ca038c105b1f2290042608d897fd7e25565cea8383f1211ee1b9cc71fd283b33b9478b503a7
+  metadata.gz: d68e0282c6c4170d0097251282e7683c018563386c8961e31bb4d2e3ea65960b0871373e05233499d58d08feb5a2d57389a14e8d53e253bc6b11b2bd23e08ba9
+  data.tar.gz: 5451d628684257f3ffea531d8a77b7b7b306417ff1590f2047e11c9f3468a72a0d0ba333853bbbf50f0806145b4d4334629b8261663beeba70fe1069dac6681d

data/README.md

@@ -118,6 +118,12 @@ Once this is complete, you should be able to run the test suite:
 rake
 ```
 
+There are some remote tests that are excluded by default. To run those, run
+
+```
+bundle exec rspec --tag remote
+```
+
 ## Bug Reporting
 
 Please use the [Issues](https://github.com/pythonicrubyist/creek/issues) page to report bugs or suggest new enhancements.

data/creek.gemspec

@@ -20,12 +20,11 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 2.0.0'
 
-  spec.add_development_dependency "bundler", "~> 1.3"
+  spec.add_development_dependency "bundler", "~> 2.1.2"
   spec.add_development_dependency "rake"
   spec.add_development_dependency 'rspec', '~> 3.6.0'
-  spec.add_development_dependency 'pry'
+  spec.add_development_dependency 'pry-byebug'
 
-  spec.add_dependency 'nokogiri', '>= 1.7.0'
+  spec.add_dependency 'nokogiri', '>= 1.10.0'
   spec.add_dependency 'rubyzip', '>= 1.0.0'
-  spec.add_dependency 'http', '~> 4.0'
 end

data/lib/creek/book.rb

@@ -1,7 +1,7 @@
 require 'zip/filesystem'
 require 'nokogiri'
 require 'date'
-require 'http'
+require 'open-uri'
 
 module Creek
 
@@ -20,13 +20,7 @@ module Creek
         extension = File.extname(options[:original_filename] || path).downcase
         raise 'Not a valid file format.' unless (['.xlsx', '.xlsm'].include? extension)
       end
-      if options[:remote]
-        zipfile = Tempfile.new("file")
-        zipfile.binmode
-        zipfile.write(HTTP.get(path).to_s)
-        zipfile.close
-        path = zipfile.path
-      end
+      path = download_file(path) if options[:remote]
       @files = Zip::File.open(path)
       @shared_strings = SharedStrings.new(self)
     end
@@ -79,5 +73,20 @@ module Creek
         result
       end
     end
+
+    private
+
+    def download_file(url)
+      # OpenUri will return a StringIO if under OpenURI::Buffer::StringMax
+      # threshold, and a Tempfile if over.
+      downloaded = URI(url).open
+      if downloaded.is_a? StringIO
+        path = Tempfile.new(['creek-file', '.xlsx']).path
+        File.binwrite(path, downloaded.read)
+        path
+      else
+        downloaded.path
+      end
+    end
   end
 end

data/lib/creek/drawing.rb

@@ -83,7 +83,9 @@ module Creek
       col_to_selector = 'xdr:to/xdr:col'.freeze
 
       @drawings.xpath('//xdr:twoCellAnchor').each do |drawing|
-        embed = drawing.xpath(image_selector).first.attributes['embed']
+        # embed = drawing.xpath(image_selector).first.attributes['embed']
+        temp = drawing.xpath(image_selector).first
+        embed = temp.attributes['embed'] if temp
         next if embed.nil?
 
         rid = embed.value

data/lib/creek/version.rb

@@ -1,3 +1,3 @@
 module Creek
-  VERSION = "2.4.4"
+  VERSION = "2.5.0"
 end

data/spec/spec_helper.rb

@@ -1,3 +1,7 @@
 require 'creek'
 require 'pry'
+require 'time'
 
+RSpec.configure do |config|
+  config.filter_run_excluding remote: true
+end

data/spec/test_spec.rb

@@ -106,6 +106,20 @@ describe 'Creek parsing a sample XLSX file' do
     expect(@creek).not_to be_nil
   end
 
+  it 'opens small remote files successfully', remote: true do
+    url = 'https://file-examples.com/wp-content/uploads/2017/02/file_example_XLSX_10.xlsx'
+    @creek = Creek::Book.new(url, remote: true)
+
+    expect(@creek.sheets[0]).to be_a Creek::Sheet
+  end
+
+  it 'opens large remote files successfully', remote: true do
+    url = 'http://www.house.leg.state.mn.us/comm/docs/BanaianZooExample.xlsx'
+    @creek = Creek::Book.new(url, remote: true)
+
+    expect(@creek.sheets[0]).to be_a Creek::Sheet
+  end
+
   it 'find sheets successfully.' do
     expect(@creek.sheets.count).to eq(1)
     sheet = @creek.sheets.first

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: creek
 version: !ruby/object:Gem::Version
-  version: 2.4.4
+  version: 2.5.0
 platform: ruby
 authors:
 - pythonicrubyist
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-12 00:00:00.000000000 Z
+date: 2019-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 2.1.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 2.1.2
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -53,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 3.6.0
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: 1.10.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: 1.10.0
 - !ruby/object:Gem::Dependency
   name: rubyzip
   requirement: !ruby/object:Gem::Requirement
@@ -94,20 +94,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.0
-- !ruby/object:Gem::Dependency
-  name: http
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
 description: A Ruby gem that streams and parses large Excel(xlsx and xlsm) files fast
   and efficiently.
 email:
@@ -176,7 +162,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.8
+rubygems_version: 2.5.2.3
 signing_key: 
 specification_version: 4
 summary: A Ruby gem for parsing large Excel(xlsx and xlsm) files.