credy 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 25e3a3d043de72f875cd7a6405aa0f721cb00f61
-  data.tar.gz: 00f78e5960314b372e9d953b4ec546f991559d0a
+  metadata.gz: 8c1d9ed3a0da6fdd31acd12474782f5c9c0509e8
+  data.tar.gz: ef8f0cde519444af8ea026d4a18ee89292149edd
 SHA512:
-  metadata.gz: e2a2b74deef424b8025408786abae8b644df82c458cdd4a6ce5493ec2a4553f5c2135e1b29050dd82f2b9ee09f1d18845b8dd8c4388a3d68ac07a350cb87d97d
-  data.tar.gz: f4006c3b5a2fbaa74c51ea8b4bfee9d64208cd0b8eb0de86ec658d47be112e55065e4765b90de9520468f24ba0ea20281f578fe24833c477b8c80ce3c0b9945b
+  metadata.gz: a3b149b4e0bf0e83ef854da73dee3a8c25392bb1fca65a99e52f520265f35390e09132b6cc2e3630cf13e1d7265fe18602bad3db5581085b62d937d6bc3b3f5c
+  data.tar.gz: a788b494a479f976bb68cbaaa03354c4bfde0f6ac51d46277449dc633bad439cfc9c42e76bb4382cc3bd23f45533370f6c132d6ee31aa4f242c5bb53fedb9ace

data/.travis.yml

@@ -3,4 +3,5 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.1
+  - 2.2.2
   - ruby-head

data/Gemfile.lock

@@ -1,28 +1,36 @@
 PATH
   remote: .
   specs:
-    credy (0.1.1)
-      thor (~> 0.18.1)
+    credy (0.2.1)
+      thor (~> 0.19.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
     diff-lcs (1.2.5)
-    rake (10.0.3)
-    rspec (2.14.1)
-      rspec-core (~> 2.14.0)
-      rspec-expectations (~> 2.14.0)
-      rspec-mocks (~> 2.14.0)
-    rspec-core (2.14.7)
-    rspec-expectations (2.14.5)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.5)
-    thor (0.18.1)
+    rake (10.4.2)
+    rspec (3.3.0)
+      rspec-core (~> 3.3.0)
+      rspec-expectations (~> 3.3.0)
+      rspec-mocks (~> 3.3.0)
+    rspec-core (3.3.1)
+      rspec-support (~> 3.3.0)
+    rspec-expectations (3.3.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.3.0)
+    rspec-mocks (3.3.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.3.0)
+    rspec-support (3.3.0)
+    thor (0.19.1)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   credy!
-  rake (~> 10.0.3)
-  rspec (~> 2.14.1)
+  rake (~> 10.4.2)
+  rspec (~> 3.3.0)
+
+BUNDLED WITH
+   1.10.4

data/LICENSE

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2015 Tim Petricola
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

data/credy.gemspec

@@ -5,7 +5,7 @@ require File.expand_path '../lib/credy/version', __FILE__
 Gem::Specification.new do |s|
   s.authors       = ['Tim Petricola']
   s.email         = ['hi@timpetricola.com']
-  s.summary       = %q{A simple (but powerful) credit card number generator}
+  s.summary       = 'Simple credit card number generator'
   s.license       = 'MIT'
   s.homepage      = 'https://github.com/TimPetricola/Credy'
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
@@ -15,7 +15,7 @@ Gem::Specification.new do |s|
   s.require_paths = ['lib']
   s.version       = Credy::VERSION
 
-  s.add_development_dependency 'rspec', '~> 2.14.1'
-  s.add_development_dependency 'rake', '~> 10.0.3'
-  s.add_runtime_dependency 'thor', '~> 0.18.1'
+  s.add_development_dependency 'rspec', '~> 3.3.0'
+  s.add_development_dependency 'rake', '~> 10.4.2'
+  s.add_runtime_dependency 'thor', '~> 0.19.1'
 end

data/lib/credy.rb

@@ -4,15 +4,15 @@ require 'credy/rules'
 require 'credy/check'
 
 module Credy
-
   def self.root
     File.expand_path '../..', __FILE__
   end
 
-  class CreditCard
+  module CreditCard
+    extend self
 
     # Generate a credit card number
-    def self.generate(options = {})
+    def generate(options = {})
       rule   = find_rule(options) || return
       number = generate_from_rule(rule)
 
@@ -24,7 +24,7 @@ module Credy
     end
 
     # Returns information about a number
-    def self.infos(number)
+    def infos(number)
       rules = Rules.all.select do |rule|
         valid = true
 
@@ -45,10 +45,10 @@ module Credy
     end
 
     # Validates a number
-    def self.validate(number)
+    def validate(number)
       criterii = {}
       criterii[:luhn] = Check.luhn number
-      criterii[:type] = !!self.infos(number)
+      criterii[:type] = !!infos(number)
 
       valid = criterii.all? { |_, v| v == true }
 
@@ -58,12 +58,13 @@ module Credy
       }
     end
 
-    def self.find_rule(options = {})
+    private
+
+    def find_rule(options = {})
       Rules.filter(options).sample
     end
-    private_class_method :find_rule
 
-    def self.complete_number(number)
+    def complete_number(number)
       # Generates the last digit according to luhn algorithm
       digits = (0..9).map(&:to_s)
       begin
@@ -72,9 +73,8 @@ module Credy
 
       full
     end
-    private_class_method :complete_number
 
-    def self.generate_from_rule(rule)
+    def generate_from_rule(rule)
       length = Array(rule[:length]).sample
       number = rule[:prefix]
 
@@ -86,8 +86,5 @@ module Credy
       # Append last digit
       complete_number(number)
     end
-    private_class_method :generate_from_rule
-
   end
-
 end

data/lib/credy/check.rb

@@ -1,9 +1,10 @@
 module Credy
+  module Check
+    extend self
 
-  class Check
-
-    def self.luhn(code)
+    def luhn(code)
       s1 = s2 = 0
+
       code.to_s.reverse.chars.each_slice(2) do |odd, even|
         s1 += odd.to_i
 
@@ -11,9 +12,8 @@ module Credy
         double -= 9 if double >= 10
         s2 += double
       end
+
       (s1 + s2) % 10 == 0
     end
-
   end
-
 end

data/lib/credy/rules.rb

@@ -1,16 +1,16 @@
 require 'yaml'
 
 module Credy
-
-  class Rules
+  module Rules
+    extend self
 
     # Return all the rules from yml files
-    def self.raw
+    def raw
       @rules ||= load_rules("#{Credy.root}/data/*.yml")
     end
 
     # Change hash format to process rules
-    def self.all
+    def all
       rules = []
 
       raw.each do |type, details|
@@ -43,7 +43,7 @@ module Credy
     end
 
     # Returns rules according to given filters
-    def self.filter(filters = {})
+    def filter(filters = {})
       all.select do |rule|
         [:country, :type].each do |condition|
           break false if filters[condition] && filters[condition] != rule[condition]
@@ -52,15 +52,14 @@ module Credy
       end
     end
 
-    def self.load_rules(files)
+    private
+
+    def load_rules(files)
       {}.tap do |rules|
         Dir.glob(files) do |filename|
           rules.merge! YAML::load IO.read(filename)
         end
       end
     end
-    private_class_method :load_rules
-
   end
-
 end

data/lib/credy/version.rb

@@ -1,3 +1,3 @@
 module Credy
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end

data/readme.md

@@ -1,6 +1,6 @@
 # Credy [![Build Status](https://travis-ci.org/TimPetricola/Credy.png?branch=master)](https://travis-ci.org/TimPetricola/Credy) [![Gem Version](https://badge.fury.io/rb/credy.png)](http://badge.fury.io/rb/credy) [![Code Climate](https://codeclimate.com/github/TimPetricola/Credy.png)](https://codeclimate.com/github/TimPetricola/Credy)
 
-A simple credit card generator/validator.
+Simple credit card generator/validator.
 Need a valid credit card number to sign up on a site but you don't want to use your real card?
 Need to validate your customers credit card?
 
@@ -56,39 +56,39 @@ Credy::CreditCard.validate '5108756163954799'
 At the moment, only a few types and countries are (partially) supported.
 
 ### Types
-* americanexpress (American Express)
-* bankcard (Bankcard)
-* china-unionpay (China UnionPay)
-* diners-club-carte-blanche (Diners Club Carte Blanche)
-* diners-club-enroute (Diners Club enRoute)
-* diners-club-international (Diners Club International)
-* diners-club-us-ca (Diners Club United States & Canada)
-* instapayment (InstaPayment)
-* jcb (JCB)
-* laser (Laser)
-* maestro (Maestro)
-* mastercard (Mastercard)
-* solo (Solo)
-* switch (Switch)
-* visa (Visa)
-* visa-electron (Visa Electron)
+* `americanexpress`: American Express
+* `bankcard`: Bankcard
+* `china-unionpay`: China UnionPay
+* `diners-club-carte-blanche`: Diners Club Carte Blanche
+* `diners-club-enroute`: Diners Club enRoute
+* `diners-club-international`: Diners Club International
+* `diners-club-us-ca`: Diners Club United States & Canada
+* `instapayment`: InstaPayment
+* `jcb`: JCB
+* `laser`: Laser
+* `maestro`: Maestro
+* `mastercard`: Mastercard
+* `solo`: Solo
+* `switch`: Switch
+* `visa`: Visa
+* `visa-electron`: Visa Electron
 
 ### Countries
-* au (Australia)
-* ca (Canada)
-* fr (France)
-* pl (Poland)
-* es (Spain)
-* ch (Switzerland)
-* uk (United Kingdom)
-* us (United States)
+* `au`: Australia
+* `ca`: Canada
+* `fr`: France
+* `pl`: Poland
+* `es`: Spain
+* `ch`: Switzerland
+* `uk`: United Kingdom
+* `us`: United States
 
 ## Todo
 * Add more data (see the Data source section)
 * Remove luhn validation for *China UnionPay* and *Diners Club enRoute*
 
 ## Data source
-All data is coming from the [Bank card number](http://en.wikipedia.org/wiki/Bank_card_number) page and the [List of Issuer Identification Numbers](http://en.wikipedia.org/wiki/List_of_Issuer_Identification_Numbers) on [Wikipedia](http://wikipedia.org). I do not assume the responsibility for wrong data.
+All data is coming from the [Bank card number](http://en.wikipedia.org/wiki/Bank_card_number) page and the now deleted [List of Issuer Identification Numbers](http://en.wikipedia.org/wiki/List_of_Issuer_Identification_Numbers) on Wikipedia. I do not assume the responsibility for wrong data.
 
 ## License
 Credy is released under the [MIT License](http://opensource.org/licenses/MIT).

data/spec/bin/credy_spec.rb

@@ -2,13 +2,11 @@ require_relative '../spec_helper'
 silent { load 'bin/credy' }
 
 describe Credy::CLI do
-
   before(:all) do
     @stdout, $stdout = $stdout, StringIO.new
   end
 
   describe 'generate' do
-
     it 'works without options' do
       expect(Credy::CreditCard).to receive(:generate).with({})
       r = Credy::CLI.start ['generate']
@@ -58,13 +56,10 @@ describe Credy::CLI do
           expect(output).to eq "50076645747856835 (visa, au)\n"*2
         end
       end
-
     end
-
   end
 
   describe 'infos' do
-
     it 'calls the infos function' do
       expect(Credy::CreditCard).to receive(:infos).with '5108756163954799'
       silent {
@@ -86,7 +81,6 @@ describe Credy::CLI do
         expect(output).to eq "Type: visa\nCountry: au\nValid\n"
       end
     end
-
   end
 
   describe 'validate' do
@@ -109,8 +103,6 @@ describe Credy::CLI do
         output = silent { Credy::CLI.start ['validate', '5108756163954799'] }
         expect(output).to eq "This number is not valid.\n(luhn: x, type: x)\n"
       end
-
     end
   end
-
 end

data/spec/lib/credy/check_spec.rb

@@ -1,19 +1,15 @@
 require_relative '../../spec_helper'
 
 describe Credy::Check do
-
   describe '.luhn' do
-
     it 'returns true for correct data' do
-      expect(Credy::Check.luhn(49927398716)).to be_true
-      expect(Credy::Check.luhn(1234567812345670)).to be_true
+      expect(Credy::Check.luhn(49927398716)).to be_truthy
+      expect(Credy::Check.luhn(1234567812345670)).to be_truthy
     end
 
     it 'returns false for non correct data' do
-      expect(Credy::Check.luhn(49927398717)).to be_false
-      expect(Credy::Check.luhn(1234567812345678)).to be_false
+      expect(Credy::Check.luhn(49927398717)).to be_falsey
+      expect(Credy::Check.luhn(1234567812345678)).to be_falsey
     end
-
   end
-
 end

data/spec/lib/credy/rules_spec.rb

@@ -1,20 +1,23 @@
 require_relative '../../spec_helper'
 
 describe Credy::Rules do
-
   subject { Credy::Rules }
 
   describe '.raw' do
     it { should respond_to :raw }
-    its(:raw) { should be_a Hash }
+
+    it 'is a hash' do
+      expect(subject.raw).to be_a Hash
+    end
   end
 
   describe '.all' do
-
-    its(:all) { should be_a Array }
+    it 'is a array' do
+      expect(subject.all).to be_a Array
+    end
 
     it 'contains a set of rules' do
-      subject.stub(:raw).and_return({
+      allow(subject).to receive(:raw).and_return({
         'visa' => {
           'length' => [13, 16],
           'countries' => {
@@ -36,7 +39,7 @@ describe Credy::Rules do
     end
 
     it 'works with string prefixes' do
-      subject.stub(:raw).and_return({
+      allow(subject).to receive(:raw).and_return({
         'visa' => {
           'length' => [13, 16],
           'countries' => {
@@ -51,7 +54,7 @@ describe Credy::Rules do
     end
 
     it 'works with integer prefixes' do
-      subject.stub(:raw).and_return({
+      allow(subject).to receive(:raw).and_return({
         'visa' => {
           'length' => [13, 16],
           'countries' => {
@@ -66,7 +69,7 @@ describe Credy::Rules do
     end
 
     it 'works with an array of prefixes' do
-      subject.stub(:raw).and_return({
+      allow(subject).to receive(:raw).and_return({
         'visa' => {
           'length' => [13, 16],
           'countries' => {
@@ -84,9 +87,8 @@ describe Credy::Rules do
   end
 
   describe '.filter' do
-
     before do
-      subject.stub(:raw).and_return({
+      allow(subject).to receive(:raw).and_return({
         'visa' => {
           'length' => [13, 16],
           'countries' => {
@@ -111,18 +113,18 @@ describe Credy::Rules do
     end
 
     it 'filters by type' do
-      expect(subject.filter(type: 'visa')).to have(2).items
-      expect(subject.filter(type: 'mastercard')).to have(1).item
+      expect(subject.filter(type: 'visa').length).to eq 2
+      expect(subject.filter(type: 'mastercard').length).to eq 1
     end
 
     it 'accepts the :country option' do
-      expect(subject.filter(country: 'ch')).to have(1).item
-      expect(subject.filter(country: 'au')).to have(2).items
+      expect(subject.filter(country: 'ch').length).to eq 1
+      expect(subject.filter(country: 'au').length).to eq 2
     end
 
     it 'accepts several options at the same time' do
       rules = subject.filter type: 'visa', country: 'au'
-      expect(rules).to have(1).item
+      expect(rules.length).to eq 1
     end
 
     it 'returns an empty array if nothing is found' do
@@ -130,7 +132,5 @@ describe Credy::Rules do
       expect(rules).to be_a Array
       expect(rules).to be_empty
     end
-
   end
-
 end

data/spec/lib/credy/version_spec.rb

@@ -1,7 +1,5 @@
 describe Credy::VERSION do
-
   it 'is defined' do
     expect(Credy::VERSION).not_to be_nil
   end
-
 end

data/spec/lib/credy_spec.rb

@@ -1,7 +1,6 @@
 require_relative '../spec_helper'
 
 describe Credy::CreditCard do
-
   subject { Credy::CreditCard }
 
   let(:rules) do
@@ -24,11 +23,10 @@ describe Credy::CreditCard do
   end
 
   before(:each) do
-    Credy::Rules.stub(:raw).and_return rules
+    allow(Credy::Rules).to receive(:raw).and_return rules
   end
 
   describe '.generate' do
-
     it 'returns a number, type and country' do
       expect(subject.generate[:number]).not_to be_nil
       expect(subject.generate[:type]).not_to be_nil
@@ -65,40 +63,34 @@ describe Credy::CreditCard do
       number = subject.generate type: 'foo', country: 'bar'
       expect(number).to be_nil
     end
-
   end
 
   describe '.infos' do
-
     it 'returns the correct information according to the card number' do
       infos = subject.infos '5108756163954792'
       expect(infos[:type]).to eq 'mastercard'
       expect(infos[:country]).to eq 'us'
     end
-
   end
 
   describe '.validate' do
-
     it 'returns a hash' do
       r = subject.validate '5108756163954792'
-      expect(r[:valid]).to be_true
-      expect(r[:details][:luhn]).to be_true
-      expect(r[:details][:type]).to be_true
+      expect(r[:valid]).to be_truthy
+      expect(r[:details][:luhn]).to be_truthy
+      expect(r[:details][:type]).to be_truthy
     end
 
     it 'checks against luhn algorithm' do
       r = subject.validate '5108756163954791'
-      expect(r[:valid]).to be_false
-      expect(r[:details][:luhn]).to be_false
+      expect(r[:valid]).to be_falsey
+      expect(r[:details][:luhn]).to be_falsey
     end
 
     it 'checks against card type' do
       r = subject.validate '99999999999999999999992'
-      expect(r[:valid]).to be_false
-      expect(r[:details][:type]).to be_false
+      expect(r[:valid]).to be_falsey
+      expect(r[:details][:type]).to be_falsey
     end
-
   end
-
 end

data/spec/spec_helper.rb

@@ -20,9 +20,3 @@ class String
     self
   end
 end
-
-RSpec.configure do |config|
-  config.expect_with :rspec do |c|
-    c.syntax = :expect
-  end
-end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: credy
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Tim Petricola
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-16 00:00:00.000000000 Z
+date: 2015-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -16,42 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: 3.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: 3.3.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.0.3
+        version: 10.4.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.0.3
+        version: 10.4.2
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.18.1
+        version: 0.19.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.18.1
+        version: 0.19.1
 description: 
 email:
 - hi@timpetricola.com
@@ -64,6 +64,7 @@ files:
 - ".travis.yml"
 - Gemfile
 - Gemfile.lock
+- LICENSE
 - Rakefile
 - bin/credy
 - credy.gemspec
@@ -115,10 +116,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
-summary: A simple (but powerful) credit card number generator
+summary: Simple credit card number generator
 test_files:
 - spec/bin/credy_spec.rb
 - spec/lib/credy/check_spec.rb