credova 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c6def1751d664ad20feed546ae2d5573bb1a3155d6baeb43342bd2e4205a7a78
-  data.tar.gz: bfee41159a3021857829a50e007bbba298b49c1b9138cb8aee2e0b7ae087172e
+  metadata.gz: 6160ea02df46ba9763039d59ba0e830751de8a6f1690502ae2517cd088da7aa2
+  data.tar.gz: 1dbbac5c77a59dc687e214ee1e26c7f39056963c6de3da34f02e633f07808aba
 SHA512:
-  metadata.gz: c2ca07bb361904ea34388e520b9ec17ca189d109ea4c199adb3b6927fb5949effae5e831821da21a3bab41e3a87445d988349700d1d5a18d68ccf28293adaad4
-  data.tar.gz: 2ac7fdc9b902253c07d706ee14200c2e578d58d97ab988fcd495573dfad178e7df0bc57e3368549b2960f7209427d2a5d89a1c2866aac4f17d5706595a97b8da
+  metadata.gz: b4bc3b0004e98909c525d200e92729e13f2287b2f18b3f5311d01e1235a304194c33f07502013c95cf2f578df7b8ae1d12658a3c9efc67bf8a95be2889f26326
+  data.tar.gz: c356d3d1a6f1f946399e2bb03b7dd18034f02bc2cb5c55fd498e13a78fbdc15ffc9699a9a37d72dba888d089e6ef37e6bfe11c2e45874b23f6c7dcc674a66a75

data/lib/credova/api.rb

@@ -29,8 +29,6 @@ module Credova
       uri = URI(request.path)
       request.body = data.is_a?(Hash) ? data.to_json : data
 
-      puts "\n-\nREQUEST_BODY_DATA: #{request.body.inspect}\n-\n"
-
       response = Net::HTTP.start(uri.host, uri.port, use_ssl: true) do |http|
         http.request(request)
       end

data/lib/credova/application.rb

@@ -31,7 +31,7 @@ module Credova
     end
 
     def create(application_data, callback_url = nil)
-      requires!(application_data, CREATE_ATTRS[:required])
+      requires!(application_data, *CREATE_ATTRS[:required])
 
       endpoint = ENDPOINTS[:create]
       headers = [
@@ -59,7 +59,7 @@ module Credova
     end
 
     def set_delivery_information(public_id, delivery_data)
-      requires!(delivery_data, SET_DELIVERY_INFORMATION_ATTRS[:required])
+      requires!(delivery_data, *SET_DELIVERY_INFORMATION_ATTRS[:required])
 
       endpoint = ENDPOINTS[:set_delivery_information] % public_id
       headers = [

data/lib/credova/ffl.rb

@@ -5,7 +5,11 @@ module Credova
 
     include Credova::API
 
-    REQUIRED_CREATE_ATTRS = %i( license_number expiration address_one city state zip )
+    CREATE_ATTRS = {
+      permitted: %i( license_number expiration address address_2 city state zip ).freeze,
+      required:  %i( license_number expiration address city state zip ).freeze,
+    }
+
     ENDPOINTS = {
       create:          "federallicense".freeze,
       upload_document: "federallicense/%s/uploadfile".freeze,
@@ -15,17 +19,19 @@ module Credova
       @client = client
     end
 
-    def create(options = {})
-      requires!(options, REQUIRED_CREATE_ATTRS)
+    def create(ffl_data)
+      requires!(options, *REQUIRED_CREATE_ATTRS)
 
+      ffl_data[:expiration] = ffl_data[:expiration].strftime('%Y/%m/%d')
       endpoint = ENDPOINTS[:create]
-      data = format_data_for_create(options)
       headers  = [
         *auth_header(@client.access_token),
         *content_type_header('application/json'),
       ].to_h
 
-      post_request(endpoint, data, headers)
+      standardize_body_data!(ffl_data, CREATE_ATTRS[:permitted])
+
+      post_request(endpoint, ffl_data, headers)
     end
 
     def upload_document(ffl_public_id, ffl_document_url)
@@ -39,19 +45,5 @@ module Credova
       post_request(endpoint, data, headers)
     end
 
-    private
-
-    def format_data_for_create(data)
-      {
-        licenseNumber: data[:license_number],
-        expiration:    data[:expiration].strftime('%Y/%m/%d'),
-        address:       data[:address_one],
-        address2:      data[:address_two],
-        city:          data[:city],
-        state:         data[:state],
-        zip:           data[:zip],
-      }
-    end
-
   end
 end

data/lib/credova/version.rb

@@ -1,3 +1,3 @@
 module Credova
-  VERSION = "0.1.7"
+  VERSION = "0.1.8"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: credova
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Jeffrey Dill
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-09 00:00:00.000000000 Z
+date: 2019-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler