credit_card_validations 6.0.0 → 7.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c955ab578ccc68fa1525166a326408c8f7ceedb16dfd197b4cee363453f4148c
-  data.tar.gz: f66d2c0969e1aac24c04463633e4466c997527b4d9b3a11f36914d207eea08dc
+  metadata.gz: f8f7d7a9d4f3ab464575d41f7fb4c6892340a2540752e1b3237b532ff2437eed
+  data.tar.gz: 82edcf7c91e4b2d4e3774068fd7dd1ebdb32bf61711328365c1fb17b2e769452
 SHA512:
-  metadata.gz: 96231d43a74789045abf1df806f085d649fb9400c749f2334eaa08771fcc2e369831ae65a74698484fe2b8a531241e8effa4dc6d5258f29523af33319dae435c
-  data.tar.gz: 4926b30dce4ca818b0ab18e7711ba96b8145a461703c3659c3eff1368fa860760febb476d1086b7f7addce5608ee501986c30a2dcb13cdab68f26a78a98e18d7
+  metadata.gz: 2b559bfc0762eb66e6fcd096924bdfad21babcfeb6e9e73f31aebe224f85e80a381c9c01f4568bd473fbdcbc412f0607e719c52a541e81e6e88a7aaadc2d90f1
+  data.tar.gz: f32c9d410d0a06a85d12d837b9c696801de61bbd0fffa1da62563c189d6ec3d51e7068cfbb73470b8254294dd2a5385189161633021fd3e5a7a3783bdea4f173

data/.github/workflows/build.yml

@@ -6,16 +6,21 @@ on:
     - master
 jobs:
   test:
-    name: Tests with Ruby ${{ matrix.ruby }} Rails ${{ matrix.rails }}
+    name: Tests with Ruby ${{ matrix.ruby-version }} Rails ${{ matrix.rails }}
     runs-on: ubuntu-latest
     strategy:
       matrix:
         ruby-version:
-        - 2.7
-        - 3.0
+        - 3.1
+        - 3.2
+        - 3.3
         rails:
-        - '6.1.5'
-        - '7.0.2.3'
+        - '7.1.0'
+        - '7.2.0'
+        - '8.0.0'
+        exclude:
+        - ruby-version: 3.1
+          rails: '8.0.0'
     env:
       RAILS_VERSION: ${{ matrix.rails }}
     steps:
@@ -26,4 +31,4 @@ jobs:
         bundler-cache: true
     - name: Run tests
       run: |
-        bundle exec rake
+        bundle exec rake

data/Changelog.md

@@ -1,3 +1,18 @@
+# 7.0.0
+  * allow rails 8 
+  * drop rails 6.1 and rails 7.0
+  * drop support of eol ruby versions 2.7, 3.0
+  
+# 6.3.0
+  * rails 7.2 support
+   
+# 6.2.0
+  * support ruby 3.3
+  * more accurate brand matching using matched prefix length
+  
+# 6.1.0
+  * support rails 7.1
+
 # 6.0.0
   * changes to discover branch
   * allows to configure usage of own yaml brands file 

data/credit_card_validations.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |gem|
   gem.summary       = "gem should be used for credit card numbers validation, card brands detections, luhn checks"
   gem.homepage      = "http://didww.github.io/credit_card_validations/"
   gem.license       = "MIT"
-  
+
   gem.metadata    = {
     'bug_tracker_uri'   => 'https://github.com/didww/credit_card_validations/issues',
     'changelog_uri'     => 'https://github.com/didww/credit_card_validations/blob/master/Changelog.md',
@@ -25,12 +25,12 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
 
 
-  gem.add_dependency "activemodel", ">= 5.2", "< 7.1"
-  gem.add_dependency "activesupport", ">= 5.2", "< 7.1"
+  gem.add_dependency "activemodel", ">= 5.2", "< 8.1"
+  gem.add_dependency "activesupport", ">= 5.2", "< 8.1"
 
 
   gem.add_development_dependency "minitest", '~> 5.14.3'
   gem.add_development_dependency "mocha", '1.1.0'
-  gem.add_development_dependency 'rake', '~> 10'
+  gem.add_development_dependency 'rake'
   gem.add_development_dependency 'byebug'
 end

data/lib/credit_card_validations/detector.rb

@@ -28,8 +28,14 @@ module CreditCardValidations
     def valid_number?(*keys)
       selected_brands = keys.blank? ? self.brands : resolve_keys(*keys)
       if selected_brands.any?
+        matched_brands = []
         selected_brands.each do |key, brand|
-          return key if matches_brand?(brand)
+          match_data = matches_brand?(brand)
+          matched_brands << {brand: key, matched_prefix_length: match_data.to_s.length} if match_data
+        end
+
+        if matched_brands.present?
+          return matched_brands.sort{|a, b| a[:matched_prefix_length] <=> b[:matched_prefix_length]}.last[:brand]
         end
       end
       nil
@@ -64,8 +70,8 @@ module CreditCardValidations
       rules.each do |rule|
         if (options[:skip_luhn] || valid_luhn?) &&
             rule[:length].include?(number.length) &&
-            number.match(rule[:regexp])
-          return true
+            match_data = number.match(rule[:regexp])
+          return match_data
         end
       end
       false

data/lib/credit_card_validations/version.rb

@@ -1,3 +1,3 @@
 module CreditCardValidations
-  VERSION = '6.0.0'
+  VERSION = '7.0.0'
 end

data/spec/credit_card_validations_spec.rb

@@ -170,6 +170,28 @@ describe CreditCardValidations do
           end
         end
       end
+
+      describe 'Add kortimilli rule' do
+        let(:kortimilli_number) { '505827028341713' }
+
+        it 'before invoke add_brand credit card behaves like maestro' do
+          expect(detector(kortimilli_number).valid?(:maestro)).must_equal true
+          expect(detector(kortimilli_number).maestro?).must_equal true
+          expect(detector(kortimilli_number).brand).must_equal :maestro
+        end
+
+        describe 'after adding wider prefix for kortimilli' do
+          before do
+            CreditCardValidations::Detector.add_brand(:kortimilli, length: 15, prefixes: '505827028')
+          end
+
+          it 'should validate number as kortimilli' do
+            expect(detector(kortimilli_number).valid?(:kortimilli)).must_equal true
+            expect(detector(kortimilli_number).kortimilli?).must_equal true
+            expect(detector(kortimilli_number).brand).must_equal :kortimilli
+          end
+        end
+      end
     end
 
     describe 'plugins' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: credit_card_validations
 version: !ruby/object:Gem::Version
-  version: 6.0.0
+  version: 7.0.0
 platform: ruby
 authors:
 - Igor
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-05 00:00:00.000000000 Z
+date: 2024-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -19,7 +19,7 @@ dependencies:
         version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '8.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '8.1'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -39,7 +39,7 @@ dependencies:
         version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '8.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -49,7 +49,7 @@ dependencies:
         version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '8.1'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -82,16 +82,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
@@ -167,7 +167,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.4.22
 signing_key:
 specification_version: 4
 summary: gem should be used for credit card numbers validation, card brands detections,