credit_card_validations 4.0.0 → 6.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c947efcf4ef54ace4e9c747430dc75dd1efe0570a260853d8c1eca1963b13ae5
-  data.tar.gz: a69886a9b837c4872b5bac9bed3dbc6a88757424d2b4303a2c5918f68548cd29
+  metadata.gz: c955ab578ccc68fa1525166a326408c8f7ceedb16dfd197b4cee363453f4148c
+  data.tar.gz: f66d2c0969e1aac24c04463633e4466c997527b4d9b3a11f36914d207eea08dc
 SHA512:
-  metadata.gz: b5407b4b003aca97df24c20e5145cb43ab90d7fa6a62b21a953fcd53f4a97d77b1bd4b564a71767c7639ce6b1fcd5e12b51f82a3c32255eeaf87b1f66e0e6474
-  data.tar.gz: 6b472410891b0519878b6894222460e042afae072070a5cc22f4af0fbc7773ab01a19a2f12d61572934bbfa3107a672556c128dfe45cd89490bbd709c7f5fd85
+  metadata.gz: 96231d43a74789045abf1df806f085d649fb9400c749f2334eaa08771fcc2e369831ae65a74698484fe2b8a531241e8effa4dc6d5258f29523af33319dae435c
+  data.tar.gz: 4926b30dce4ca818b0ab18e7711ba96b8145a461703c3659c3eff1368fa860760febb476d1086b7f7addce5608ee501986c30a2dcb13cdab68f26a78a98e18d7

data/.github/workflows/build.yml

@@ -0,0 +1,29 @@
+name: CI
+on:
+  pull_request:
+  push:
+    branches:
+    - master
+jobs:
+  test:
+    name: Tests with Ruby ${{ matrix.ruby }} Rails ${{ matrix.rails }}
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version:
+        - 2.7
+        - 3.0
+        rails:
+        - '6.1.5'
+        - '7.0.2.3'
+    env:
+      RAILS_VERSION: ${{ matrix.rails }}
+    steps:
+    - uses: actions/checkout@v3
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true
+    - name: Run tests
+      run: |
+        bundle exec rake

data/Changelog.md

@@ -1,3 +1,18 @@
+# 6.0.0
+  * changes to discover branch
+  * allows to configure usage of own yaml brands file 
+  
+# 5.0.0
+  * rails 7 support
+  * drop rails support < 5.2
+
+# 4.1.0
+ * changes to disover and maesto rules
+
+# 4.0.0
+ * support rails 6
+ * test against ruby 3.0, drop ruby 2.1 support
+
 # 3.5.1
    * Bump activemodel and activesupport versions
 

data/Gemfile

@@ -1,6 +1,7 @@
 source 'https://rubygems.org'
 group :test do
-  gem 'coveralls', require: false # Test coverage website. Go to https://coveralls.io
+  gem 'activemodel', ENV['RAILS_VERSION'], require: false
+  gem 'activesupport', ENV['RAILS_VERSION'], require: false
 end
 # Specify your gem's dependencies in credit_card_validations.gemspec
 gemspec

data/README.md

@@ -1,7 +1,5 @@
 # CreditCardValidations
 
-[![Build Status](http://img.shields.io/travis/didww/credit_card_validations.svg)](https://travis-ci.org/didww/credit_card_validations)
-[![Coverage Status](http://img.shields.io/coveralls/Fivell/credit_card_validations.svg)](https://coveralls.io/r/Fivell/credit_card_validations)
 [![Gem Version](http://img.shields.io/gem/v/credit_card_validations.svg)](https://rubygems.org/gems/credit_card_validations)
 [![License](http://img.shields.io/:license-mit-blue.svg)](http://didww.mit-license.org)
 
@@ -148,6 +146,18 @@ require 'credit_card_validations/plugins/laser'
 require 'credit_card_validations/plugins/diners_us'
 ```
 
+
+### Configuration
+
+In order to override default data source you can copy [original one](https://github.com/didww/credit_card_validations/blob/master/lib/data/brands.yaml) , change it and configure during rails initializer
+
+```ruby
+ CreditCardValidations.configure do |config|
+      config.source = '/path/to/my_brands.yml'
+ end
+```
+
+
 ## Contributing
 
 1. Fork it

data/credit_card_validations.gemspec

@@ -25,12 +25,12 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
 
 
-  gem.add_dependency "activemodel", ">= 3", "<= 6.2"
-  gem.add_dependency "activesupport", ">= 3", "<= 6.2"
+  gem.add_dependency "activemodel", ">= 5.2", "< 7.1"
+  gem.add_dependency "activesupport", ">= 5.2", "< 7.1"
 
 
   gem.add_development_dependency "minitest", '~> 5.14.3'
   gem.add_development_dependency "mocha", '1.1.0'
   gem.add_development_dependency 'rake', '~> 10'
-
+  gem.add_development_dependency 'byebug'
 end

data/lib/credit_card_validations/configuration.rb

@@ -0,0 +1,9 @@
+module CreditCardValidations
+  class Configuration
+    attr_accessor :source
+
+    def initialize
+      @source = nil
+    end
+  end
+end

data/lib/credit_card_validations/version.rb

@@ -1,3 +1,3 @@
 module CreditCardValidations
-  VERSION = '4.0.0'
+  VERSION = '6.0.0'
 end

data/lib/credit_card_validations.rb

@@ -1,4 +1,5 @@
 require 'credit_card_validations/version'
+require 'credit_card_validations/configuration'
 require 'credit_card_validations/error'
 require 'active_model'
 require 'active_support/core_ext'
@@ -14,16 +15,36 @@ module CreditCardValidations
   autoload :Factory, 'credit_card_validations/factory'
   autoload :Mmi, 'credit_card_validations/mmi'
 
+  attr_accessor :configuration
+
+  def self.configuration
+    @configuration ||= Configuration.new
+  end
+
+  def self.reset
+    @configuration = Configuration.new
+  end
+
+  def self.configure
+    yield(configuration)
+    reload!
+  end
 
   def self.add_brand(key, rules, options = {})
     Detector.add_brand(key, rules, options)
   end
 
-  DATA = YAML.load_file(File.join(File.dirname(__FILE__),  'data', 'brands.yaml')) || {}
+  def self.source
+    configuration.source || File.join(File.join(File.dirname(__FILE__)), 'data', 'brands.yaml')
+  end
+
+  def self.data
+    YAML.load_file(source) || {}
+  end
 
   def self.reload!
     Detector.brands = {}
-    DATA.each do |key, data|
+    data.each do |key, data|
       add_brand(key, data.fetch(:rules), data.fetch(:options, {}))
     end
   end

data/lib/data/brands.yaml

@@ -197,7 +197,10 @@
     - '637187'
     - '637529'
     - '639'
-    - '64'
+    - '640'
+    - '641'
+    - '642'
+    - '643'
     - '670'
     - '671'
     - '672'
@@ -477,7 +480,29 @@
     - 16
     - 19
     :prefixes:
-    - '6011'
+    - '300'
+    - '301'
+    - '302'
+    - '303'
+    - '304'
+    - '305'
+    - '3095'
+    - '36'
+    - '38'
+    - '39'
+    - '60110'
+    - '60112'
+    - '60113'
+    - '60114'
+    - '601174'
+    - '601177'
+    - '601178'
+    - '601179'
+    - '601186'
+    - '601187'
+    - '601188'
+    - '601189'
+    - '60119'
     - '644'
     - '645'
     - '646'

data/spec/credit_card_validations_spec.rb

@@ -7,6 +7,39 @@ describe CreditCardValidations do
     CreditCardValidations.reload!
   end
 
+
+  describe 'configure' do
+
+    let(:number) { '6111111180456137' }
+
+    before do
+      expect(card_detector.valid?(:discover)).must_equal false
+      CreditCardValidations.configure do |config|
+        config.source = OVERRIDED_BRANDS_FILE
+      end
+    end
+
+    let(:card_detector) {
+      detector(number)
+    }
+
+    it 'should generate overrided discover' do
+      discover = CreditCardValidations::Factory.random(:discover)
+      expect(detector(discover).valid?('DiscoverBrand')).must_equal true
+    end
+
+    it 'should detect patched discover' do
+      expect(card_detector.valid?(:discover)).must_equal true
+      expect(card_detector.valid?(:visa)).must_equal false
+    end
+
+    after do
+      CreditCardValidations.reset
+      CreditCardValidations.reload!
+    end
+
+  end
+
   describe 'MMI' do
     it 'should detect issuer category' do
       d = detector(VALID_NUMBERS[:visa].first)

data/spec/fixtures/overrided_brands.yml

@@ -0,0 +1,19 @@
+---
+:visa:
+  :rules:
+  - :length:
+    - 13
+    - 16
+    - 19
+    :prefixes:
+    - '4'
+  :options:
+    :brand_name: Visa
+:discover:
+  :rules:
+  - :length:
+    - 16
+    :prefixes:
+    - '61111111'
+  :options:
+    :brand_name: DiscoverBrand

data/spec/fixtures/valid_cards.yml

@@ -43,14 +43,9 @@
 - 3777 5274 9896 404
 - 3782 8224 6310 005
 :discover:
-- 6011 1111 1111 1117
 - 6011 0009 9013 9424
 - 6011 0000 0000 0004
 - 6011 0004 0000 0000
-- 6011 1532 1637 1980
-- 6011 6011 6011 6611
-- 6011 6874 8256 4166
-- 6011 8148 3690 5651
 :maestro:
 - 6759 6498 2643 8453
 - 5641 8200 0000 0005

data/spec/test_helper.rb

@@ -1,9 +1,7 @@
-require 'coveralls'
-Coveralls.wear!
-
 require 'minitest/autorun'
 require 'i18n'
 require 'mocha/mini_test'
+require 'byebug'
 
 lib = File.expand_path("#{File.dirname(__FILE__)}/../lib")
 specs = File.expand_path("#{File.dirname(__FILE__)}/../spec")
@@ -17,4 +15,5 @@ require 'models/credit_card'
 
 VALID_NUMBERS = YAML.load_file File.join(File.dirname(__FILE__), 'fixtures/valid_cards.yml')
 INVALID_NUMBERS = YAML.load_file File.join(File.dirname(__FILE__), 'fixtures/invalid_cards.yml')
+OVERRIDED_BRANDS_FILE =  File.join(File.dirname(__FILE__), 'fixtures/overrided_brands.yml')
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: credit_card_validations
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 6.0.0
 platform: ruby
 authors:
 - Igor
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-18 00:00:00.000000000 Z
+date: 2022-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -16,40 +16,40 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3'
-    - - "<="
+        version: '5.2'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '6.2'
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3'
-    - - "<="
+        version: '5.2'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '6.2'
+        version: '7.1'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3'
-    - - "<="
+        version: '5.2'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '6.2'
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3'
-    - - "<="
+        version: '5.2'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '6.2'
+        version: '7.1'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -92,6 +92,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '10'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A ruby gem for validating credit card numbers
 email:
 - fedoronchuk@gmail.com
@@ -99,19 +113,18 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/build.yml"
 - ".gitignore"
 - ".hound.yml"
-- ".travis.yml"
 - Changelog.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - credit_card_validations.gemspec
-- gemfiles/rails1-4.gemfile
-- gemfiles/rails5.gemfile
 - lib/active_model/credit_card_number_validator.rb
 - lib/credit_card_validations.rb
+- lib/credit_card_validations/configuration.rb
 - lib/credit_card_validations/detector.rb
 - lib/credit_card_validations/error.rb
 - lib/credit_card_validations/factory.rb
@@ -127,6 +140,7 @@ files:
 - spec/credit_card_validations_spec.rb
 - spec/factory_spec.rb
 - spec/fixtures/invalid_cards.yml
+- spec/fixtures/overrided_brands.yml
 - spec/fixtures/valid_cards.yml
 - spec/models/credit_card.rb
 - spec/string_spec.rb
@@ -138,7 +152,7 @@ metadata:
   bug_tracker_uri: https://github.com/didww/credit_card_validations/issues
   changelog_uri: https://github.com/didww/credit_card_validations/blob/master/Changelog.md
   source_code_uri: https://github.com/didww/credit_card_validations
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -153,8 +167,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: gem should be used for credit card numbers validation, card brands detections,
   luhn checks
@@ -163,6 +177,7 @@ test_files:
 - spec/credit_card_validations_spec.rb
 - spec/factory_spec.rb
 - spec/fixtures/invalid_cards.yml
+- spec/fixtures/overrided_brands.yml
 - spec/fixtures/valid_cards.yml
 - spec/models/credit_card.rb
 - spec/string_spec.rb

data/.travis.yml

@@ -1,32 +0,0 @@
-language: ruby
-rvm:
-  - 2.1.10
-  - 2.2.10
-  - 2.3.5
-  - 2.4.5
-  - 2.5.3
-  - 2.6.3
-  - 3.0.0
-  - jruby-9.1.15.0
-gemfile:
-  - gemfiles/rails1-4.gemfile
-  - gemfiles/rails5.gemfile
-matrix:
-  exclude:
-    - gemfile: gemfiles/rails5.gemfile
-      rvm: 2.1.10
-    - gemfile: gemfiles/rails5.gemfile
-      rvm: jruby-9.1.6.0
-    - gemfile: gemfiles/rails1-4.gemfile
-      rvm: 2.5.3
-    - gemfile: gemfiles/rails1-4.gemfile
-      rvm: 2.6.3
-     - gemfile: gemfiles/rails1-4.gemfile
-      rvm: 3.0.0
-  allow_failures:
-    - rvm: 2.1.10
-
-before_install:
-  - gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
-  - gem install bundler -v '< 2'
-  - export BUNDLE_PATH="${TRAVIS_BUILD_DIR}/vendor/bundle"

data/gemfiles/rails1-4.gemfile

@@ -1,11 +0,0 @@
-source "https://rubygems.org"
-
-gem "activemodel", ">= 3", '< 5'
-gem "activesupport", ">= 3", '< 5'
-group :test do
-  gem 'tins', '< 1.3.4', platforms: [:ruby_19, :jruby]
-  gem 'term-ansicolor', '~> 1.3.0', platforms: [:ruby_19, :jruby]
-  gem 'coveralls', require: false # Test coverage website. Go to https://coveralls.io
-end
-
-gemspec :path => "../"

data/gemfiles/rails5.gemfile

@@ -1,10 +0,0 @@
-source "https://rubygems.org"
-
-gem "activemodel", ">= 5"
-gem "activesupport", ">= 5"
-
-group :test do
-  gem 'coveralls', require: false # Test coverage website. Go to https://coveralls.io
-end
-
-gemspec :path => "../"