credit_card_validations 1.5.1 → 2.0.0

data/spec/credit_card_validations_spec.rb

@@ -0,0 +1,168 @@
+require_relative 'test_helper'
+
+describe CreditCardValidations do
+
+
+  before do
+    CreditCardValidations.reload!
+  end
+
+  describe "MMI" do
+    it "should detect issuer category" do
+      d = detector(VALID_NUMBERS[:visa].first)
+      d.issuer_category.must_equal CreditCardValidations::Mmi::ISSUER_CATEGORIES[d.number[0]]
+    end
+  end
+
+  describe "Luhn#valid?" do
+    let(:card_detector) {
+      detector(VALID_NUMBERS[:unionpay].first)
+    }
+    it "should call Luhn.valid? once" do
+      CreditCardValidations::Luhn.expects(:valid?).with(card_detector.number).once
+      card_detector.valid?(:visa, :unionpay).must_equal true
+    end
+
+    it "should call Luhn.valid? twice" do
+      CreditCardValidations::Luhn.expects(:valid?).with(card_detector.number).twice
+      card_detector.valid?(:visa, :mastercard).must_equal false
+    end
+
+    it "should not call Luhn.valid?" do
+
+      CreditCardValidations::Luhn.expects(:valid?).never
+      card_detector.valid?(:unionpay).must_equal true
+    end
+
+  end
+
+
+  it "should check luhn" do
+    VALID_NUMBERS.each do |brand, card_numbers|
+      if has_luhn_check_rule?(brand)
+        card_numbers.each do |number|
+          luhn_valid?(detector(number).number).must_equal true
+        end
+      end
+    end
+  end
+
+  it "should check valid brand" do
+    VALID_NUMBERS.each do |brand, card_numbers|
+      card_numbers.each do |card_number|
+        detector(card_number).send("#{brand}?").must_equal true
+        detector(card_number).brand.must_equal brand
+      end
+    end
+  end
+
+  it "should check if card invalid" do
+    INVALID_NUMBERS.each do |card_number|
+      detector(card_number).valid?.must_equal false
+      detector(card_number).brand.must_be_nil
+      VALID_NUMBERS.keys.each do |brand|
+        detector(card_number).send("#{brand}?").must_equal false
+      end
+    end
+  end
+
+  it "should detect by full brand name" do
+    amex =  CreditCardValidations::Factory.random(:amex)
+    detector(amex).valid?('American Express').must_equal true
+    visa =  CreditCardValidations::Factory.random(:visa)
+    detector(visa).valid?('American Express').must_equal false
+  end
+
+  it "should support multiple brands for single check" do
+    VALID_NUMBERS.slice(:visa, :mastercard).each do |key, value|
+      detector(value.first).brand(:visa, :mastercard).must_equal key
+    end
+
+    VALID_NUMBERS.except(:visa, :mastercard).each do |_, value|
+      detector(value.first).brand(:visa, :mastercard).must_be_nil
+    end
+  end
+
+  it "should check if valid brand without arguments" do
+    VALID_NUMBERS.each do |key, value|
+      value.each do |card_number|
+        detector(card_number).valid?(key).must_equal true
+        assert detector(card_number).valid?.must_equal true
+      end
+    end
+  end
+
+  it "should not be valid? if wrong brand" do
+    detector(VALID_NUMBERS[:visa].first).valid?(:mastercard).must_equal false
+    detector(VALID_NUMBERS[:mastercard].first).valid?(:visa).must_equal false
+  end
+
+  it "should  be valid? if right brand" do
+    detector(VALID_NUMBERS[:visa].first).valid?(:mastercard, :visa).must_equal true
+    detector(VALID_NUMBERS[:visa].first).valid?(:mastercard, :amex).must_equal false
+  end
+
+
+  describe "adding/removing brand" do
+
+
+    let(:voyager_number) {
+      '869926275400212'
+    }
+
+    it "should validate number as voyager" do
+      CreditCardValidations::Detector.add_brand(:voyager, {length: 15, prefixes: '86'})
+      detector(voyager_number).valid?(:voyager).must_equal true
+      detector(voyager_number).voyager?.must_equal true
+      detector(voyager_number).brand.must_equal :voyager
+    end
+
+
+    describe "Add voyager rule" do
+      before do
+        CreditCardValidations::Detector.add_brand(:voyager, {length: 15, prefixes: '86'})
+      end
+
+      it "should validate number as voyager" do
+
+        detector(voyager_number).valid?(:voyager).must_equal true
+        detector(voyager_number).voyager?.must_equal true
+        detector(voyager_number).brand.must_equal :voyager
+
+      end
+
+      describe "Remove voyager rule" do
+        before do
+          CreditCardValidations::Detector.delete_brand(:voyager)
+        end
+
+        it "should not validate number as voyager" do
+          detector(voyager_number).respond_to?(:voyager?).must_equal false
+          detector(voyager_number).brand.must_be_nil
+        end
+      end
+
+    end
+
+
+    it "should raise RuntimeError" do
+      proc { CreditCardValidations::Detector::add_rule(:undefined_brand, 20, [20]) }.must_raise RuntimeError
+    end
+
+  end
+
+
+  def luhn_valid?(number)
+    CreditCardValidations::Luhn.valid?(number)
+  end
+
+  def detector(number)
+    CreditCardValidations::Detector.new(number)
+  end
+
+
+  def has_luhn_check_rule?(key)
+    CreditCardValidations::Detector.has_luhn_check_rule?(key)
+  end
+
+end

data/spec/factory_spec.rb

@@ -0,0 +1,21 @@
+require_relative 'test_helper'
+
+describe CreditCardValidations::Factory do
+
+  it "should generate random brand" do
+    number = CreditCardValidations::Factory.random
+    CreditCardValidations::Detector.new(number).valid?.must_equal true
+  end
+
+  CreditCardValidations::Detector.brands.keys.sort.each do |key|
+    describe "#{key}" do
+
+      it "should generate valid #{key}" do
+        number = CreditCardValidations::Factory.random(key)
+        CreditCardValidations::Detector.new(number).valid?(key).must_equal true
+      end
+
+    end
+  end
+
+end

data/{test → spec}/fixtures/valid_cards.yml

@@ -55,6 +55,7 @@
 - 1800 0163 8277 392
 - 3569 9900 0000 0009
 - 3530 1113 3330 0000
+- 3572 6600 0000 0000 006
 :solo:
 - 6767 6222 2222 2222 222
 - 6334 5805 0000 0000

data/spec/models/credit_card.rb

@@ -0,0 +1,19 @@
+class CreditCard
+  attr_accessor :number, :number2, :number3, :number4, :number5, :number6, :card_type
+  include ActiveModel::Validations
+  validates :number, credit_card_number: {brands: [:amex, :maestro]} , allow_blank: true
+  validates :number2, credit_card_number: {only: [:amex, :maestro]},  allow_blank: true
+  validates :number3, credit_card_number: {except: [:amex, :maestro]} , allow_blank: true
+  validates :number4, credit_card_number: {brands: :any}  , allow_blank: true
+  validates :number5, credit_card_number: true , allow_blank: true
+  validates :number6, credit_card_number: { brands: ->(record){ record.supported_brand } } , allow_blank: true
+
+
+  def supported_brand
+    {
+      "Master Card" => :mastercard,
+      "Visa" => :visa
+    }[self.card_type]
+  end
+
+end

data/spec/string_spec.rb

@@ -0,0 +1,43 @@
+require_relative 'test_helper'
+require 'credit_card_validations/string'
+
+describe "String ext" do
+
+  let(:mastercard) {
+    CreditCardValidations::Factory.random(:mastercard)
+  }
+
+  let(:visa) {
+    CreditCardValidations::Factory.random(:visa)
+  }
+
+  let(:invalid) {
+    INVALID_NUMBERS.sample
+  }
+
+  it "should allow detect brand for mastercard" do
+
+    mastercard.credit_card_brand.must_equal :mastercard
+    mastercard.credit_card_brand_name.must_equal 'MasterCard'
+    mastercard.valid_credit_card_brand?(:mastercard).must_equal true
+    mastercard.valid_credit_card_brand?('MasterCard').must_equal true
+    mastercard.valid_credit_card_brand?(:visa, :amex).must_equal false
+  end
+
+  it "should allow detect brand for visa" do
+
+    visa.credit_card_brand.must_equal :visa
+    visa.credit_card_brand_name.must_equal 'Visa'
+    visa.valid_credit_card_brand?(:mastercard).must_equal false
+    visa.valid_credit_card_brand?(:visa, :amex).must_equal true
+  end
+
+  it "should not allow detect brand for invalid card" do
+
+    invalid.credit_card_brand.must_be_nil
+    invalid.credit_card_brand_name.must_be_nil
+    invalid.valid_credit_card_brand?(:mastercard).must_equal false
+    invalid.valid_credit_card_brand?(:visa, :amex).must_equal false
+  end
+
+end

data/{test → spec}/test_helper.rb

@@ -1,19 +1,20 @@
 require 'coveralls'
 Coveralls.wear!
+
 require 'minitest/autorun'
 require 'i18n'
 require 'mocha/mini_test'
 
 lib = File.expand_path("#{File.dirname(__FILE__)}/../lib")
-unit_tests = File.expand_path("#{File.dirname(__FILE__)}/../test")
+specs = File.expand_path("#{File.dirname(__FILE__)}/../spec")
 $:.unshift(lib)
-$:.unshift(unit_tests)
+$:.unshift(specs)
 
 I18n.config.enforce_available_locales = true
 
 require 'credit_card_validations'
 require 'models/credit_card'
-require 'models/any_credit_card'
-
 
+VALID_NUMBERS = YAML.load_file File.join(File.dirname(__FILE__), 'fixtures/valid_cards.yml')
+INVALID_NUMBERS = YAML.load_file File.join(File.dirname(__FILE__), 'fixtures/invalid_cards.yml')
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: credit_card_validations
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 2.0.0
 platform: ruby
 authors:
 - Igor
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-24 00:00:00.000000000 Z
+date: 2015-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -78,7 +78,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '10'
-description: A ruby gem for validating credit card numbers (a port of ZF2 Zend\Validator\CreditCard)
+description: A ruby gem for validating credit card numbers
 email:
 - fedoronchuk@gmail.com
 executables: []
@@ -86,6 +86,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".travis.yml"
+- Changelog.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -93,18 +94,21 @@ files:
 - credit_card_validations.gemspec
 - lib/active_model/credit_card_number_validator.rb
 - lib/credit_card_validations.rb
-- lib/credit_card_validations/card_rules.rb
 - lib/credit_card_validations/detector.rb
+- lib/credit_card_validations/factory.rb
 - lib/credit_card_validations/luhn.rb
 - lib/credit_card_validations/mmi.rb
 - lib/credit_card_validations/string.rb
 - lib/credit_card_validations/version.rb
-- test/credit_card_validations_test.rb
-- test/fixtures/invalid_cards.yml
-- test/fixtures/valid_cards.yml
-- test/models/any_credit_card.rb
-- test/models/credit_card.rb
-- test/test_helper.rb
+- lib/data/brands.yaml
+- spec/active_model_spec.rb
+- spec/credit_card_validations_spec.rb
+- spec/factory_spec.rb
+- spec/fixtures/invalid_cards.yml
+- spec/fixtures/valid_cards.yml
+- spec/models/credit_card.rb
+- spec/string_spec.rb
+- spec/test_helper.rb
 homepage: https://github.com/Fivell/credit_card_validations
 licenses:
 - MIT
@@ -128,11 +132,15 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: gem for credit card numbers validation, card brands detections
+summary: gem should be used for credit card numbers validation, card brands detections,
+  luhn checks
 test_files:
-- test/credit_card_validations_test.rb
-- test/fixtures/invalid_cards.yml
-- test/fixtures/valid_cards.yml
-- test/models/any_credit_card.rb
-- test/models/credit_card.rb
-- test/test_helper.rb
+- spec/active_model_spec.rb
+- spec/credit_card_validations_spec.rb
+- spec/factory_spec.rb
+- spec/fixtures/invalid_cards.yml
+- spec/fixtures/valid_cards.yml
+- spec/models/credit_card.rb
+- spec/string_spec.rb
+- spec/test_helper.rb
+has_rdoc: 

data/lib/credit_card_validations/card_rules.rb

@@ -1,84 +0,0 @@
-module CreditCardValidations
-  module CardRules
-    ########  most used brands #########
-    mattr_accessor :rules
-
-    self.rules = {
-        visa: [
-            {length: [13, 16], prefixes: ['4']}
-        ],
-        mastercard: [
-            {length: [16], prefixes: ['51', '52', '53', '54', '55']}
-        ],
-
-        amex: [
-            {length: [15], prefixes: ['34', '37']}
-        ],
-        ######## other brands ########
-        diners: [
-            {length: [14], prefixes: ['300', '301', '302', '303', '304', '305', '36', '38']},
-        ],
-
-        #There are Diners Club (North America) cards that begin with 5. These are a joint venture between Diners Club and MasterCard, and are processed like a MasterCard
-        # will be removed in next major version
-
-        diners_us: [
-            {length: [16], prefixes: ['54', '55']}
-        ],
-
-        discover: [
-            {length: [16], prefixes: ['6011', '644', '645', '646', '647', '648',
-                                      '649', '65']}
-        ],
-
-        jcb: [
-            {length: [15,16], prefixes: ['3528', '3529', '353', '354', '355', '356', '357', '358']},
-            {length: [15], prefixes: ['1800', '2131']}
-        ],
-
-
-        laser: [
-            {length: [16, 17, 18, 19], prefixes: ['6304', '6706', '6771']}
-        ],
-
-        solo: [
-            {length: [16, 18, 19], prefixes: ['6334', '6767']}
-        ],
-
-        switch: [
-            {length: [16, 18, 19], prefixes: ['633110', '633312', '633304', '633303', '633301', '633300']}
-
-        ],
-
-        maestro: [
-            {length: [12, 13, 14, 15, 16, 17, 18, 19], prefixes: ['5010', '5011', '5012', '5013', '5014', '5015', '5016', '5017', '5018',
-                                                                  '502', '503', '504', '505', '506', '507', '508',
-                                                                  '56','57', '58', '59',
-                                                                  '6010', '6012', '6013', '6014', '6015', '6016', '6017', '6018', '6019',
-                                                                  '602', '603', '604', '605', '6060',
-                                                                  '621', '627', '629',
-                                                                  '670','671', '672','673', '674', '675', '677',     
-                                                                  '6760', '6761', '6762', '6763', '6764', '6765', '6766', '6768', '6769',
-                                                                  '679'
-            ]}
-        ],
-
-        # Luhn validation are skipped for union pay cards because they have unknown generation algoritm
-        unionpay: [
-            {length: [16, 17, 18, 19], prefixes: ['622', '624', '625', '626', '628'], skip_luhn: true}
-        ],
-
-        dankrot: [
-            {length: [16], prefixes: ['5019']}
-        ],
-
-        rupay: [
-            {length: [16], prefixes: ['6061', '6062', '6063', '6064', '6065', '6066', '6067', '6068', '6069', '607', '608'], skip_luhn: true}
-        ],
-        
-        hipercard: [
-           length: [19], prefixes: ['384']
-        ]
-    }
-  end
-end