credit_card_validations 1.5.0 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8cc121a408a642f75dfcfc595f63c58299895dfc
-  data.tar.gz: c30600f8e3925bce9cd79c1e30d0cb954696882f
+  metadata.gz: 9dc4aaa6683f8c4b1b0bcfea5ca31076fa3109f2
+  data.tar.gz: 33aba134c4e4b5e445f51796740ffe8477d6fdac
 SHA512:
-  metadata.gz: 9b2c71d6eeef539a4adc6eb3aa3d971a5f0db812f2bf396de7e1d82be082243c657f43b5dcf4221b2d1e5e856dca2414160c567bedb5b651e8f63e15ff1d1f0e
-  data.tar.gz: d9979cffa4dec73c7f01b26c80ce654ede26fc4c4aa1458e932282867913d78d5685dbc74594096e8d7e67beca97849f4c068e99773bb2cb076388792d7f5c62
+  metadata.gz: 2bf428e04e75942465f12bec35b449943bd3825c20ecc709364a937f861041284c16909430afb74fd0e9cf76492c7b6f167580d6a8179f6273d60e8def127a65
+  data.tar.gz: f164f228a43fd51410c03040b11f0b0cdb3c09dd1d9a3a2aa7e193f166eec3ad6d43dd9616b9ffef557d237d07089132a5a75c3ed6762eb1c40546fcdb98b030

data/README.md

@@ -34,6 +34,7 @@ The following issuing institutes are accepted:
     Diners Club      | :diners      | http://en.wikipedia.org/wiki/Diners_Club_International
     Dinner Club US   | :diners_us   | http://en.wikipedia.org/wiki/Diners_Club_International#MasterCard_alliance
     Discover         | :discover    | http://en.wikipedia.org/wiki/Discover_Card
+    Hipercard        | :hipercard   | http://pt.wikipedia.org/wiki/Hipercard
     JCB              | :jcb         | http://en.wikipedia.org/wiki/Japan_Credit_Bureau
     Laser            | :laser       | http://en.wikipedia.org/wiki/Laser_%28debit_card%29
     Maestro          | :maestro     | http://en.wikipedia.org/wiki/Maestro_%28debit_card%29

data/lib/credit_card_validations/card_rules.rb

@@ -32,7 +32,8 @@ module CreditCardValidations
         ],
 
         jcb: [
-            {length: [16], prefixes: ['3528', '3529', '353', '354', '355', '356', '357', '358', '1800', '2131']}
+            {length: [15,16], prefixes: ['3528', '3529', '353', '354', '355', '356', '357', '358']},
+            {length: [15], prefixes: ['1800', '2131']}
         ],
 
 
@@ -52,11 +53,14 @@ module CreditCardValidations
         maestro: [
             {length: [12, 13, 14, 15, 16, 17, 18, 19], prefixes: ['5010', '5011', '5012', '5013', '5014', '5015', '5016', '5017', '5018',
                                                                   '502', '503', '504', '505', '506', '507', '508',
-                                                                  '6012', '6013', '6014', '6015', '6016', '6017', '6018', '6019',
+                                                                  '56','57', '58', '59',
+                                                                  '6010', '6012', '6013', '6014', '6015', '6016', '6017', '6018', '6019',
                                                                   '602', '603', '604', '605', '6060',
                                                                   '621', '627', '629',
-                                                                  '677', '675', '674', '673', '672', '671', '670',
-                                                                  '6760', '6761', '6762', '6763', '6764', '6765', '6766', '6768', '6769']}
+                                                                  '670','671', '672','673', '674', '675', '677',     
+                                                                  '6760', '6761', '6762', '6763', '6764', '6765', '6766', '6768', '6769',
+                                                                  '679'
+            ]}
         ],
 
         # Luhn validation are skipped for union pay cards because they have unknown generation algoritm
@@ -70,8 +74,11 @@ module CreditCardValidations
 
         rupay: [
             {length: [16], prefixes: ['6061', '6062', '6063', '6064', '6065', '6066', '6067', '6068', '6069', '607', '608'], skip_luhn: true}
+        ],
+        
+        hipercard: [
+           length: [19], prefixes: ['384']
         ]
-
     }
   end
 end

data/lib/credit_card_validations/detector.rb

@@ -53,12 +53,11 @@ module CreditCardValidations
         length = Array.wrap(length)
         rules[brand] = [] if rules[brand].blank?
         rules[brand] << {length: length, regexp: compile_regexp(prefixes), prefixes: prefixes, skip_luhn: skip_luhn}
-        #create methods like  visa? mastercard? etc
-        class_eval <<-BOOLEAN_RULE, __FILE__, __LINE__
-          def #{brand}?
-             valid?(:#{brand})
-          end
-        BOOLEAN_RULE
+
+        define_method "#{brand}?".to_sym do
+          valid?(brand)
+        end unless method_defined?  "#{brand}?".to_sym
+
         rules[brand]
       end
     end

data/lib/credit_card_validations/version.rb

@@ -1,3 +1,3 @@
 module CreditCardValidations
-  VERSION = "1.5.0"
+  VERSION = "1.5.1"
 end

data/test/credit_card_validations_test.rb

@@ -1,80 +1,73 @@
 require_relative 'test_helper'
+require 'yaml'
 
 class CreditCardValidationsTest < MiniTest::Test
 
-  class CreditCardModel
-    attr_accessor :number
-    include ActiveModel::Validations
-    validates :number, credit_card_number: {brands: [:amex, :maestro]}
+
+  def initialize name
+    super name
+    @test_valid_numbers = YAML.load_file File.join(File.dirname(__FILE__), 'fixtures/valid_cards.yml')
+    @test_invalid_numbers = YAML.load_file File.join(File.dirname(__FILE__), 'fixtures/invalid_cards.yml')
   end
 
-  class CreditCardModelAny
-    attr_accessor :number
-    include ActiveModel::Validations
-    validates :number, presence: true, credit_card_number: true
+
+  def test_card_luhn
+    @test_valid_numbers.each do |brand, card_numbers|
+      if has_luhn_check_rule?(brand)
+        card_numbers.each do |number|
+          assert luhn_valid?(detector(number).number), "#{number} failed luhn"
+        end
+      end
+    end
+
   end
 
-  def initialize name
-    super name
-    @test_numbers = {
-        visa: ['4012 8888 8888 1881', '4111111111111111'],
-        mastercard: ['5274 5763 9425 9961', '5555-5555-5555-4444'],
-        diners: ['3020 4169 3226 43', '30569309025904'],
-        amex: ['3782 8224 6310 005', '371449635398431'],
-        discover: ['6011 1111 1111 1117', '6011000990139424'],
-        maestro: ['6759 6498 2643 8453'],
-        jcb: ['3575 7591 5225 4876', '3566002020360505'],
-        solo: ['6767 6222 2222 2222 222'],
-        unionpay: ['6264-1852-1292-2132-067', '6288997715452584', '6269 9920 5813 4322'],
-        dankrot: ['5019717010103742'],
-        switch: ['6331101999990016'],
-        rupay: ['6076-6000-0619-9992']
-    }
-  end
-
-  def test_card_brand_detection
-    @test_numbers.each do |key, value|
-      value.each do |card_number|
-        assert detector(card_number).send("#{key}?")
-        assert_equal key, detector(card_number).brand
+  def test_card_if_credit_card_valid
+    @test_valid_numbers.each do |brand, card_numbers|
+      card_numbers.each do |card_number|
+        assert detector(card_number).send("#{brand}?"), "#{card_number} is #{brand}"
+        assert_equal brand, detector(card_number).brand, "#{card_number} detects as #{brand}"
       end
     end
   end
 
-  def test_card_brand_is_nil_if_credit_card_invalid
-    assert_nil detector('1111111111111111').brand
+  def test_card_if_credit_card_invalid
+    @test_invalid_numbers.each do |card_number|
+      assert !detector(card_number).valid?
+      assert_nil detector(card_number).brand
+      @test_valid_numbers.keys.each do |brand|
+        assert !detector(card_number).send("#{brand}?")
+      end
+    end
   end
 
   def test_card_brand_detection_with_restriction
-    @test_numbers.slice(:visa, :mastercard).each do |key, value|
+    @test_valid_numbers.slice(:visa, :mastercard).each do |key, value|
       assert_equal key, detector(value.first).brand(:visa, :mastercard)
     end
 
-    @test_numbers.except(:visa, :mastercard).each do |key, value|
+    @test_valid_numbers.except(:visa, :mastercard).each do |key, value|
       assert_nil detector(value.first).brand(:visa, :mastercard)
     end
   end
 
   def test_card_valid_method
-    @test_numbers.each do |key, value|
+    @test_valid_numbers.each do |key, value|
       value.each do |card_number|
         assert detector(card_number).valid?(key)
         assert detector(card_number).valid?
       end
     end
-    assert !detector('1111111111111111').valid?
   end
 
-
   def test_card_particular_brand_valid
-    assert !detector(@test_numbers[:visa].first).valid?(:mastercard)
-    assert !detector(@test_numbers[:mastercard].first).valid?(:visa)
+    assert !detector(@test_valid_numbers[:visa].first).valid?(:mastercard)
+    assert !detector(@test_valid_numbers[:mastercard].first).valid?(:visa)
   end
 
-
   def test_card_particular_brands_valid
-    assert detector(@test_numbers[:visa].first).valid?(:mastercard, :visa)
-    assert !detector(@test_numbers[:visa].first).valid?(:mastercard, :amex)
+    assert detector(@test_valid_numbers[:visa].first).valid?(:mastercard, :visa)
+    assert !detector(@test_valid_numbers[:visa].first).valid?(:mastercard, :amex)
   end
 
   #add rules which were not present before
@@ -89,59 +82,70 @@ class CreditCardValidationsTest < MiniTest::Test
     assert !detector(voyager_test_card_number).mastercard?
   end
 
+  def test_active_model_any_validator
+    cc = AnyCreditCard.new
+    cc.number='1'
+    assert !cc.valid?
+    cc.number = @test_valid_numbers[:mastercard].first
+    assert cc.valid?
+  end
+
   def test_active_model_validator
-    cc = CreditCardModel.new
-    cc.number = @test_numbers[:maestro].first
+    cc = CreditCard.new
+    cc.number = @test_valid_numbers[:maestro].first
     assert cc.valid?
 
-    cc = CreditCardModel.new
-    cc.number = @test_numbers[:mastercard].first
+    cc = CreditCard.new
+    cc.number = @test_valid_numbers[:mastercard].first
     assert !cc.valid?
     assert cc.errors[:number].include?(cc.errors.generate_message(:number, :invalid))
 
-
-    cc = CreditCardModelAny.new
-    cc.number='1'
-    assert !cc.valid?
-    cc.number = @test_numbers[:mastercard].first
-    assert cc.valid?
-
   end
 
   def test_string_extension
+    assert !@test_valid_numbers[:mastercard].first.respond_to?(:credit_card_brand)
+    assert !@test_valid_numbers[:mastercard].first.respond_to?(:valid_credit_card_brand?)
     require 'credit_card_validations/string'
-    assert_equal @test_numbers[:mastercard].first.credit_card_brand, :mastercard
-    assert @test_numbers[:mastercard].first.valid_credit_card_brand?(:mastercard)
-    assert !@test_numbers[:mastercard].first.valid_credit_card_brand?(:visa, :amex)
+    assert_equal @test_valid_numbers[:mastercard].first.credit_card_brand, :mastercard
+    assert @test_valid_numbers[:mastercard].first.valid_credit_card_brand?(:mastercard)
+    assert !@test_valid_numbers[:mastercard].first.valid_credit_card_brand?(:visa, :amex)
   end
 
+  def test_call_luhn
+    d = detector(@test_valid_numbers[:unionpay].first)
+    d.expects(:valid_luhn?).once
+    assert !d.valid?(:visa)
 
-  def test_skip_luhn
-    d = detector(@test_numbers[:unionpay].first)
+    d.expects(:valid_luhn?).once
+    assert d.valid?(:visa, :unionpay)
+  end
 
+  def test_skip_luhn
+    d = detector(@test_valid_numbers[:unionpay].first)
     d.expects(:valid_luhn?).never
     assert d.valid?(:unionpay)
-
-    d.expects(:valid_luhn?).once
-    assert !d.valid?(:visa)
-
     d.expects(:valid_luhn?).never
     assert d.valid?(:unionpay, :visa)
-
-    d.expects(:valid_luhn?).once
-    assert d.valid?(:visa, :unionpay)
   end
 
   def test_mmi
-    d = detector(@test_numbers[:visa])
-    assert_equal d.issuer_category, CreditCardValidations::Mmi::ISSUER_CATEGORIES[@test_numbers[:visa][0]]
+    d = detector(@test_valid_numbers[:visa].first)
+    assert_equal d.issuer_category, CreditCardValidations::Mmi::ISSUER_CATEGORIES[d.number[0]]
   end
 
   protected
 
+  def luhn_valid?(number)
+    CreditCardValidations::Luhn.valid?(number)
+  end
+
   def detector(number)
     CreditCardValidations::Detector.new(number)
   end
 
 
+  def has_luhn_check_rule?(brand)
+    CreditCardValidations::Detector.rules[brand].any? { |rule| !rule[:skip_luhn] }
+  end
+
 end

data/test/fixtures/invalid_cards.yml

@@ -0,0 +1,6 @@
+---
+- '1111111111111111'
+- '00000000000000'
+- fakenumber
+- c4111111111111111
+- 4111111111111111i

data/test/fixtures/valid_cards.yml

@@ -0,0 +1,79 @@
+---
+:visa:
+- 4012 8888 8888 1881
+- 4111 1111 1111 1111
+- 4222 2222 2222 2
+- 4917 6100 0000 0000
+:mastercard:
+- 5274 5763 9425 9961
+- 5555 5555 5555 4444
+- 5105 1051 0510 5100
+:diners:
+- 3020 4169 3226 43
+- 3021 8047 1965 57
+- 3022 1511 5632 52
+- 3600 0000 0000 08
+- 3614 8900 6479 13
+- 3670 0102 0000 00
+- 3852 0000 0232 37
+- 3056 9309 0259 04
+- 3020 4169 3226 43
+:amex:
+- 3714 4963 5398 431
+- 3787 3449 3671 000
+- 3400 0000 0000 009
+- 3411 1111 1111 111
+- 3434 3434 3434 343
+- 3468 2763 0435 344
+- 3700 0000 0000 002
+- 3700 0020 0000 000
+- 3704 0726 9909 809
+- 3705 5601 9309 221
+- 3714 4963 5398 431
+- 3742 0000 0000 004
+- 3764 6228 0921 451
+- 3777 5274 9896 404
+- 3782 8224 6310 005
+:discover:
+- 6011 1111 1111 1117
+- 6011 0009 9013 9424
+- 6011 0000 0000 0004
+- 6011 0004 0000 0000
+- 6011 1532 1637 1980
+- 6011 6011 6011 6611
+- 6011 6874 8256 4166
+- 6011 8148 3690 5651
+:maestro:
+- 6759 6498 2643 8453
+- 5641 8200 0000 0005
+- 5033 9619 8909 17
+- 5868 2416 0825 5333 38
+- 6799 9901 0000 0000 019
+:jcb:
+- 3575 7591 5225 4876
+- 3566 0020 2036 0505
+- 1800 0163 8277 392
+- 3569 9900 0000 0009
+- 3530 1113 3330 0000
+:solo:
+- 6767 6222 2222 2222 222
+- 6334 5805 0000 0000
+- 6334 9000 0000 0005
+- 6334 7306 0000 0000 00
+- 6767 6767 6767 6767 671
+:unionpay:
+- 6264 1852 1292 2132 067
+- 6288 9977 1545 2584
+- 6269 9920 5813 4322
+:dankrot:
+- 5019 7170 1010 3742
+:switch:
+- 6331 1019 9999 0016
+:laser:
+- 6304 9506 0000 0000 00
+- 6304 9000 1774 0292 441
+:rupay:
+- 6076 6000 0619 9992
+- 6070 5500 5000 0047
+:hipercard:
+- 3841 0058 9908 8180 330

data/test/models/any_credit_card.rb

@@ -0,0 +1,6 @@
+class AnyCreditCard
+  attr_accessor :number
+  include ActiveModel::Validations
+  validates :number, presence: true, credit_card_number: true
+end
+

data/test/models/credit_card.rb

@@ -0,0 +1,5 @@
+class CreditCard
+  attr_accessor :number
+  include ActiveModel::Validations
+  validates :number, credit_card_number: {brands: [:amex, :maestro]}
+end

data/test/test_helper.rb

@@ -11,5 +11,9 @@ $:.unshift(unit_tests)
 
 I18n.config.enforce_available_locales = true
 
-
 require 'credit_card_validations'
+require 'models/credit_card'
+require 'models/any_credit_card'
+
+
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: credit_card_validations
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.5.1
 platform: ruby
 authors:
 - Igor
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-06 00:00:00.000000000 Z
+date: 2014-12-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -100,6 +100,10 @@ files:
 - lib/credit_card_validations/string.rb
 - lib/credit_card_validations/version.rb
 - test/credit_card_validations_test.rb
+- test/fixtures/invalid_cards.yml
+- test/fixtures/valid_cards.yml
+- test/models/any_credit_card.rb
+- test/models/credit_card.rb
 - test/test_helper.rb
 homepage: https://github.com/Fivell/credit_card_validations
 licenses:
@@ -127,4 +131,8 @@ specification_version: 4
 summary: gem for credit card numbers validation, card brands detections
 test_files:
 - test/credit_card_validations_test.rb
+- test/fixtures/invalid_cards.yml
+- test/fixtures/valid_cards.yml
+- test/models/any_credit_card.rb
+- test/models/credit_card.rb
 - test/test_helper.rb