credit_card_validation 1.0.0 → 1.0.1

data/.rvmrc

@@ -1 +1 @@
-rvm use ruby-1.9.2-p290@credit_card_validation --create
+rvm use ruby-1.9.3-p385@credit_card_validation --create

data/credit_card_validation.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |s|
   s.version     = CreditCardValidation::VERSION
   s.authors     = ["Rahul Trikha"]
   s.email       = ["rahul.trikha@gmail.com"]
-  s.homepage    = "https://github.com/rahult/credit_card_validation"
+  s.homepage    = "http://rahult.github.com/credit_card_validation"
   s.summary     = %q{Offline Credit Card Validator written for Rails 3+ using ruby >= 1.9.2}
   s.description = %q{A credit card validation library to check offline validity of any AMEX, Discover, MasterCard, Visa cards using length and Luhn algorithm.}
 
@@ -19,8 +19,10 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   # specify any dependencies here; for example:
-  s.add_dependency "activerecord", ">= 3.0.0"
+  s.add_dependency "activemodel", ">= 3.0.0"
+  s.add_development_dependency "activerecord", ">= 3.0.0"
   s.add_development_dependency "sqlite3"
+  s.add_development_dependency "pry"
   s.add_development_dependency "rake"
   s.add_development_dependency "turn"
   s.add_development_dependency "growl"

data/lib/active_model/validations/credit_card_validator.rb

@@ -7,19 +7,23 @@ module ActiveModel
     class CreditCardValidator < ActiveModel::EachValidator
 
       def validate_each(record, attribute, value)
-        unless CreditCardValidation::Validator.new(value).valid?
-          record.errors[attribute] << (options[:message] || "is not a valid credit card")
+        if !value.blank? && !CreditCardValidation::Validator.new(value).valid?
+          record.errors.add(attribute, options[:message] || "is not a valid credit card")
         end
       end
 
     end
 
-    module ClassMethods
-
-      def validates_credit_card(*attributes)
-        validates_with CreditCardValidator, _merge_attributes(*attributes)
+    module HelperMethods
+      # Validates whether the value of the specified attribute is a validate Credit Card
+      #
+      #   class Order < ActiveRecord::Base
+      #     validates_credit_card :card_number
+      #   end
+      #
+      def validates_credit_card(*attr_names)
+        validates_with CreditCardValidator, _merge_attributes(attr_names)
       end
-
     end
 
   end

data/lib/credit_card_validation/version.rb

@@ -1,3 +1,3 @@
 module CreditCardValidation
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/spec/active_record_validator_spec.rb

@@ -73,4 +73,31 @@ describe ActiveModel::Validations::CreditCardValidator do
       @credit_card.wont_be :valid?
     end
   end
+
+  describe "validation can be added using the legacy method" do
+    it "should add validation when using legacy method" do
+      class CreditCard < ActiveRecord::Base
+        validates_credit_card :card_number
+      end
+
+      @credit_card = CreditCard.new
+      @credit_card.card_number = "411111111"
+
+      @credit_card.wont_be :valid?
+    end
+  end
+
+  describe "error message can be ovewritten by using a custom message hash" do
+    it "should respond with a custom a error message if message hash is passed" do
+      class CreditCard < ActiveRecord::Base
+        validates :card_number, credit_card: { message: "card is not valid?" }
+      end
+
+      @credit_card = CreditCard.new
+      @credit_card.card_number = "4111111111111"
+      @credit_card.save
+
+      @credit_card.errors.messages[:card_number].must_include "card is not valid?"
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -3,6 +3,7 @@ require 'minitest/spec'
 require 'minitest/autorun'
 require 'credit_card_validation'
 require 'active_record'
+require 'pry'
 
 ActiveRecord::Base.establish_connection(
   :adapter => 'sqlite3',
@@ -17,4 +18,8 @@ ActiveRecord::Schema.define do
     t.string :card_number
   end
 
+  create_table :orders, :force => true do |t|
+    t.string :card_number
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: credit_card_validation
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -12,7 +12,7 @@ cert_chain: []
 date: 2013-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: activerecord
+  name: activemodel
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
@@ -27,6 +27,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -43,6 +59,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -144,7 +176,7 @@ files:
 - spec/active_record_validator_spec.rb
 - spec/credit_card_validation_spec.rb
 - spec/spec_helper.rb
-homepage: https://github.com/rahult/credit_card_validation
+homepage: http://rahult.github.com/credit_card_validation
 licenses: []
 post_install_message: 
 rdoc_options: []
@@ -158,7 +190,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3495329243541790356
+      hash: -4006868522902697339
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -167,10 +199,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3495329243541790356
+      hash: -4006868522902697339
 requirements: []
 rubyforge_project: credit_card_validation
-rubygems_version: 1.8.24
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Offline Credit Card Validator written for Rails 3+ using ruby >= 1.9.2