creative-paypal-express 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5dd169c91e9532a067b8d075e4b2024b5780026c
-  data.tar.gz: 61519d004da8d2b51dc79cd5f832dec82fd711e1
+  metadata.gz: b5c8dd08fe5bc551e2a9813b1a85459cd1f9535d
+  data.tar.gz: 59701ce1bfce55e33a6b768bd7243e96228ee2e1
 SHA512:
-  metadata.gz: b9b3991b6e6fd62441d38beac1d41324be5716a18ce3199beb11e37d5dee2f375cc4db841c1e477c540b6fcd25b3a4e96f3629875334117093156d8ea9948f0b
-  data.tar.gz: fd01eee4f2c878d650543b690f910a07eb43adfb14819e9191e2a9f824ffedfbe3d27774ed157d722a25113495726b3b63c356d384d45dea79e8e81f5e7c4948
+  metadata.gz: 269e60921f1cf82405379ee8fa14a19c0e17aa96ee8ab1d70c4599fd2769f95b5f6b7cc33eb487e4e9de730a1f2e997493cd20971853f6a3afeb0a8c3995fa94
+  data.tar.gz: 22a5a303da2121d6af991a850e272262a8b944f418f3d2231d48b5f7266b4265db3dd9391a914c560102d91d269a3035d320a43c33cae51814b1f8706fef653c

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## v1.4.0
+__Updated:__
+- Responses no longer raise if ACK is not success, allows you to inspect and handle fails yourself.
+
 ## v1.2.1
 __Updated:__
 - Subscription amendment now takes mandatory currency_code option.

data/README.md

@@ -7,7 +7,7 @@ Express Checkout for Digital Goods is also supported.
 ## Installation
 
 ```rb
-gem "creative-paypal-express", "~> 1.2.1"
+gem "creative-paypal-express", "~> 1.4.0"
 ```
 
 ## Usage

data/VERSION

@@ -1 +1 @@
-1.3.0
+1.4.0

data/creative-paypal-express.gemspec

@@ -15,11 +15,11 @@ Gem::Specification.new do |s|
   s.files = `git ls-files`.split("\n")
   s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
 
-  s.add_dependency "activesupport", ">= 4"
+  # s.add_dependency "activesupport", ">= 4"
   s.add_dependency "rest-client", "~> 2.0.0"
   s.add_dependency "attr_required", ">= 0.0.5"
 
-  # s.add_development_dependency "activesupport", "4.1" # uses this for development, but will probably work with higher versions
+  s.add_development_dependency "activesupport", "~> 4.2" # uses this for development, but will probably work with higher versions
   s.add_development_dependency "rake", "~> 10.5.0"
   s.add_development_dependency "simplecov"
   s.add_development_dependency "rspec", "< 2.99"

data/lib/paypal/nvp/request.rb

@@ -59,14 +59,6 @@ module Paypal
           response = CGI.parse(response).inject({}) do |res, (k, v)|
             res.merge!(k.to_sym => v.first.to_s)
           end
-
-          case response[:ACK]
-          when 'Success', 'SuccessWithWarning'
-            response
-          else
-            raise Exception::APIError.new(response)
-          end
-
         rescue RestClient::Exception => e
           raise Exception::HttpError.new(e.http_code, e.message, e.http_body)
         end

data/spec/paypal/express/request_spec.rb

@@ -245,8 +245,8 @@ describe Paypal::Express::Request do
   describe '#transaction_details' do
     it 'should return Paypal::Express::Response' do
       fake_response 'GetTransactionDetails/success'
-      response = instance.transaction_details 'transaction_id'
-      response.should be_instance_of Paypal::Express::Response
+      response = instance.transaction_details('transaction_id')
+      response.should be_instance_of(Paypal::Express::Response)
     end
 
     it 'should call GetTransactionDetails' do
@@ -259,25 +259,24 @@ describe Paypal::Express::Request do
       }
     end
 
-    it 'should fail with bad transaction id' do
-      expect do
-        fake_response 'GetTransactionDetails/failure'
-        response = instance.transaction_details 'bad_transaction_id'
-      end.to raise_error(Paypal::Exception::APIError)
+    it 'does not fail with bad transaction id' do
+      fake_response 'GetTransactionDetails/failure'
+      response = instance.transaction_details('bad_transaction_id')
+      response.should be_instance_of(Paypal::Express::Response)
     end
 
     it 'should handle all attributes' do
       Paypal.logger.should_not_receive(:warn)
       fake_response 'GetTransactionDetails/success'
-      response = instance.transaction_details 'transaction_id'
+      response = instance.transaction_details('transaction_id')
     end
   end
 
   describe "#capture!" do
     it 'should return Paypal::Express::Response' do
       fake_response 'DoCapture/success'
-      response = instance.capture! 'authorization_id', 181.98, :BRL
-      response.should be_instance_of Paypal::Express::Response
+      response = instance.capture!('authorization_id', 181.98, :BRL)
+      response.should be_instance_of(Paypal::Express::Response)
     end
 
     it 'should call DoExpressCheckoutPayment' do

data/spec/paypal/nvp/request_spec.rb

@@ -78,19 +78,24 @@ describe Paypal::NVP::Request do
   describe '#request' do
     it 'should POST to NPV endpoint' do
       expect do
-        instance.request :RPCMethod
-      end.to request_to Paypal::NVP::Request::ENDPOINT[:production], :post
+        instance.request(:RPCMethod)
+      end.to request_to(Paypal::NVP::Request::ENDPOINT[:production], :post)
     end
 
     context 'when got API error response' do
-      before do
-        fake_response 'SetExpressCheckout/failure'
-      end
+      subject { instance.request(:SetExpressCheckout) }
+      before { fake_response 'SetExpressCheckout/failure' }
 
-      it 'should raise Paypal::Exception::APIError' do
-        expect do
-          instance.request :SetExpressCheckout
-        end.to raise_error(Paypal::Exception::APIError)
+      it 'does not raise, returns the response object to be handled' do
+        expect{ subject }.to_not raise_error
+        expect(subject).to eq({
+          :ACK => "Failure",
+          :CORRELATIONID => "379d1b7f97afb",
+          :L_ERRORCODE0 => "10001",
+          :L_LONGMESSAGE0 => "Timeout processing request",
+          :L_SHORTMESSAGE0 => "Internal Error",
+          :TIMESTAMP => "2011-02-02T02:16:50Z"
+        })
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: creative-paypal-express
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - nov matake
@@ -9,22 +9,8 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-12 00:00:00.000000000 Z
+date: 2017-12-28 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '4'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '4'
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
@@ -53,6 +39,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.0.5
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -238,7 +238,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: PayPal Express Checkout API Client for Instance, Recurring and Digital Goods