creative-paypal-express 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e3a1313ca1047f68a9801c63c2c0eae9aaf4bc9d
-  data.tar.gz: 4d9aeedc4d2692e2301079d42c7b3a8db94834ea
+  metadata.gz: c1b6637908ce92f01757f3561a0835d86e667ce2
+  data.tar.gz: c3c7ca0dde27ed7f3e43bc18f7e6328fdf75c99a
 SHA512:
-  metadata.gz: e942250f8683e6f2d07e8d1c140679fce166365c64082df09e120717b81608a1db38f0d0745ac75768d2276b46141a87a80b90bd7297aefef7a120737b335e0c
-  data.tar.gz: b3ebea5d48de225090e9ad354836b91f0bc65f12f55cd90f7ce0659e63f394becc6609af79cf8445f52016ef384b6087d0359a0c80bc96a9f2e366117a8b7106
+  metadata.gz: 320892ab92f76b77fef75b53044c77f10c1fa3a153ad41ea0cfaf137d6e794f33827adf5f47603c451fae7e98df2f038516a1f10b4f422fb3ecdd1245e97947d
+  data.tar.gz: 06323e9c79aea9270dc3665c054ebd56854ec62dee1dc012804a98cc75f1de0691c8cb6bf2d325a7de2be8b4f61297cfaeadd201c5a620b370ad5f829f6e4b8e

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## v1.2.1
+__Updated:__
+- Subscription amendment now takes mandatory currency_code option.
+
+```rb
+Paypal::Express::Request.new(params).amend!("profile_id", {amount: 19.95, currency_code: "EUR", note: "will show up in email and profile logs"})
+```
+
 ## v1.2.0
 __Added:__
 - Ability to amend a created paypal subscription (its amount)

data/README.md

@@ -7,7 +7,7 @@ Express Checkout for Digital Goods is also supported.
 ## Installation
 
 ```rb
-gem "creative-paypal-express", "~> 1.2.0"
+gem "creative-paypal-express", "~> 1.2.1"
 ```
 
 ## Usage

data/VERSION

@@ -1 +1 @@
-1.2.0
+1.2.1

data/lib/paypal/express/request.rb

@@ -135,7 +135,8 @@ module Paypal
           :PROFILEID => profile_id,
           :NOTE => options[:note],
           :AMT => options[:amount].presence || (raise ArgumentError.new(":amount option missing!")), # Paypal accepts 19.95 type decimals
-        }
+          :CURRENCYCODE => options[:currency_code].presence || (raise ArgumentError.new(":currency_code option missing!")),  # "EUR"
+        }.select{|k, v| v.present?}
 
         response = request(:UpdateRecurringPaymentsProfile, params)
         return Response.new(response)

data/spec/paypal/express/request_spec.rb

@@ -489,21 +489,36 @@ describe Paypal::Express::Request do
   end
 
   describe "#amend!(profile_id, options={})" do
-    it "should raise ArgumentError if :amount not passed" do
-      expect{instance.amend!('profile_id')}.to raise_error(ArgumentError, ":amount option missing!")
+    context "when calling with mandatory options missing" do
+      it "should raise ArgumentError" do
+        expect{instance.amend!('profile_id', {currency_code: "EUR"})}.to raise_error(ArgumentError, ":amount option missing!")
+        expect{instance.amend!('profile_id', {amount: 19.95})}.to raise_error(ArgumentError, ":currency_code option missing!")
+      end
+    end
+
+    context "when calling with note option" do
+      it "should call UpdateRecurringPaymentsProfile with correct method and params" do
+        expect{instance.amend!('profile_id', {note: "test changes", amount: 19.95, currency_code: "EUR"})}.
+          to request_to(nvp_endpoint, :post)
+
+        expect(instance._method_).to eq :UpdateRecurringPaymentsProfile
+        expect(instance._sent_params_).to eq({:PROFILEID => 'profile_id', :NOTE => "test changes", CURRENCYCODE: "EUR", :AMT => 19.95})
+      end
     end
 
-    it "should call UpdateRecurringPaymentsProfile" do
-      expect{instance.amend!('profile_id', {note: "test changes", amount: 19.95})}.
-        to request_to(nvp_endpoint, :post)
+    context "when calling without note option" do
+      it "should call UpdateRecurringPaymentsProfile with correct method and params" do
+        expect{instance.amend!('profile_id', {amount: 19.95, currency_code: "EUR"})}.
+          to request_to(nvp_endpoint, :post)
 
-      expect(instance._method_).to eq :UpdateRecurringPaymentsProfile
-      expect(instance._sent_params_).to eq({:PROFILEID => 'profile_id', :NOTE => "test changes", :AMT => 19.95})
+        expect(instance._method_).to eq :UpdateRecurringPaymentsProfile
+        expect(instance._sent_params_).to eq({:PROFILEID => 'profile_id', CURRENCYCODE: "EUR", :AMT => 19.95})
+      end
     end
 
     it 'should return Paypal::Express::Response' do
       fake_response 'UpdateRecurringPaymentsProfile/success'
-      response = instance.amend!('profile_id', {note: "test changes", amount: 19.95})
+      response = instance.amend!('profile_id', {note: "test changes", currency_code: "EUR", amount: 19.95})
 
       expect(response.class).to eq Paypal::Express::Response
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: creative-paypal-express
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - nov matake
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-21 00:00:00.000000000 Z
+date: 2017-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport