create-ruby-app 1.1.0 → 1.3.0

data/spec/lib/create_ruby_app/actions/set_ruby_implementation_spec.rb

@@ -0,0 +1,194 @@
+require_relative "../../../spec_helper"
+
+RSpec.describe CreateRubyApp::Actions::SetRubyImplementation do
+  describe ".call" do
+    let(:action) { described_class }
+
+    context "when a Ruby version is provided" do
+      let(:app) do
+        instance_double(CreateRubyApp::App, name: "foo", version: "ruby-3.4.5")
+      end
+
+      it "returns the specific version provided" do
+        expect(action.call(app).version).to eq("ruby-3.4.5")
+      end
+    end
+
+    context "when no version if provided, but an `mruby` implementation is found" do
+      let(:app) do
+        instance_double(CreateRubyApp::App, name: "mruby_app", version: nil)
+      end
+
+      it "returns the local version" do
+        %w[ruby truffleruby jruby rubinius].each do |ruby_implementation|
+          allow(Open3).to receive(:capture3).with(
+            "#{ruby_implementation} -v"
+          ).and_return(
+            ["", "", instance_double(Process::Status, success?: false)]
+          )
+        end
+
+        allow(Open3).to receive(:capture3).with("mruby -v").and_return(
+          ["mruby 3.3.0", "", instance_double(Process::Status, success?: true)]
+        )
+
+        allow(app).to receive(:version=) do |version|
+          allow(app).to receive(:version).and_return(version)
+        end
+
+        expect(action.call(app).version).to eq("mruby-3.3.0")
+        expect(app).to have_received(:version=).with("mruby-3.3.0")
+
+        expect(Open3).to have_received(:capture3).with("mruby -v")
+      end
+    end
+
+    context "when no version if provided, but a `jruby` implementation is found" do
+      let(:app) do
+        instance_double(CreateRubyApp::App, name: "jruby_app", version: nil)
+      end
+
+      it "returns the local version" do
+        %w[ruby truffleruby mruby rubinius].each do |ruby_implementation|
+          allow(Open3).to receive(:capture3).with(
+            "#{ruby_implementation} -v"
+          ).and_return(
+            ["", "", instance_double(Process::Status, success?: false)]
+          )
+        end
+
+        allow(Open3).to receive(:capture3).with("jruby -v").and_return([
+          "jruby 9.4.14.0", "", instance_double(
+            Process::Status, success?: true
+          )
+        ])
+
+        allow(app).to receive(:version=) do |version|
+          allow(app).to receive(:version).and_return(version)
+        end
+
+        expect(action.call(app).version).to eq("jruby-9.4.14.0")
+        expect(app).to have_received(:version=).with("jruby-9.4.14.0")
+
+        expect(Open3).to have_received(:capture3).with("jruby -v")
+      end
+    end
+
+    context "when no version if provided, but a `rubinius` implementation is found" do
+      let(:app) do
+        instance_double(CreateRubyApp::App, name: "rubinius_app", version: nil)
+      end
+
+      it "returns the local version" do
+        %w[ruby truffleruby jruby mruby].each do |ruby_implementation|
+          allow(Open3).to receive(:capture3).with(
+            "#{ruby_implementation} -v"
+          ).and_return(
+            ["", "", instance_double(Process::Status, success?: false)]
+          )
+        end
+
+        allow(Open3).to receive(:capture3).with("rubinius -v").and_return(
+          ["rubinius 5.0", "", instance_double(Process::Status, success?: true)]
+        )
+
+        allow(app).to receive(:version=) do |version|
+          allow(app).to receive(:version).and_return(version)
+        end
+
+        expect(action.call(app).version).to eq("rubinius-5.0")
+        expect(app).to have_received(:version=).with("rubinius-5.0")
+
+        expect(Open3).to have_received(:capture3).with("rubinius -v")
+      end
+    end
+
+    context "when no version if provided, but a `ruby` implementation is found" do
+      let(:app) do
+        instance_double(CreateRubyApp::App, name: "ruby_app", version: nil)
+      end
+
+      it "returns the local version" do
+        %w[truffleruby jruby mruby rubinius].each do |ruby_implementation|
+          allow(Open3).to receive(:capture3).with(
+            "#{ruby_implementation} -v"
+          ).and_return(
+            ["", "", instance_double(Process::Status, success?: false)]
+          )
+        end
+
+        allow(Open3).to receive(:capture3).with("ruby -v").and_return(
+          ["ruby 3.4.6", "", instance_double(Process::Status, success?: true)]
+        )
+
+        allow(app).to receive(:version=) do |version|
+          allow(app).to receive(:version).and_return(version)
+        end
+
+        expect(action.call(app).version).to eq("ruby-3.4.6")
+        expect(app).to have_received(:version=).with("ruby-3.4.6")
+
+        expect(Open3).to have_received(:capture3).with("ruby -v")
+      end
+    end
+
+    context "when no version if provided, but a `truffleruby` implementation is found" do
+      let(:app) do
+        instance_double(
+          CreateRubyApp::App,
+          name: "truffleruby_app",
+          version: nil
+        )
+      end
+
+      it "returns the local version" do
+        %w[ruby jruby mruby rubinius].each do |ruby_implementation|
+          allow(Open3).to receive(:capture3).with(
+            "#{ruby_implementation} -v"
+          ).and_return(
+            ["", "", instance_double(Process::Status, success?: false)]
+          )
+        end
+
+        allow(Open3).to receive(:capture3).with("truffleruby -v").and_return([
+          "truffleruby 25.0.0",
+          "",
+          instance_double(
+            Process::Status, success?: true
+          )
+        ])
+
+        allow(app).to receive(:version=) do |version|
+          allow(app).to receive(:version).and_return(version)
+        end
+
+        expect(action.call(app).version).to eq("truffleruby-25.0.0")
+        expect(app).to have_received(:version=).with("truffleruby-25.0.0")
+
+        expect(Open3).to have_received(:capture3).with("truffleruby -v")
+      end
+    end
+
+    context "when no implementation of Ruby is found or provided" do
+      let(:app) do
+        instance_double(CreateRubyApp::App, name: "bar", version: nil)
+      end
+
+      it "throws an error" do
+        %w[ruby truffleruby jruby mruby rubinius].each do |ruby_implementation|
+          allow(Open3).to receive(:capture3).with(
+            "#{ruby_implementation} -v"
+          ).and_return(
+            ["", "", instance_double(Process::Status, success?: false)]
+          )
+        end
+
+        expect do
+          action.call(app)
+        end.to raise_error(
+          "No version of Ruby is found or provided"
+        )
+      end
+    end
+  end
+end

data/spec/lib/create_ruby_app/app_spec.rb

@@ -1,11 +1,11 @@
-# frozen_string_literal: true
-
 require_relative "../../spec_helper"
 
 RSpec.describe CreateRubyApp::App do
   describe "#classify_name" do
     context "when the name of the app contains underscores" do
-      let(:app) { described_class.new(name: "foo_bar_baz") }
+      let(:app) do
+        described_class.new(name: "foo_bar_baz", version: "ruby-3.2.9")
+      end
 
       it "removes the underscores and capitalizes each word" do
         expect(app.classify_name).to eq("FooBarBaz")
@@ -13,7 +13,7 @@ RSpec.describe CreateRubyApp::App do
     end
 
     context "when the name of the app contains no underscores" do
-      let(:app) { described_class.new(name: "foobar") }
+      let(:app) { described_class.new(name: "foobar", version: "ruby-3.5.0") }
 
       it "capitalizes the name" do
         expect(app.classify_name).to eq("Foobar")

data/spec/lib/create_ruby_app/cli_spec.rb

@@ -0,0 +1,112 @@
+require "spec_helper"
+
+RSpec.describe CreateRubyApp::Commands do
+  describe CreateRubyApp::Commands::Version do
+    let(:command) { described_class.new }
+
+    it "outputs the current version" do
+      expect { command.call }.to output("1.3.0\n").to_stdout
+    end
+  end
+
+  describe CreateRubyApp::Commands::New do
+    let(:command) { described_class.new }
+    let(:app) { instance_double(CreateRubyApp::App) }
+
+    before do
+      allow(CreateRubyApp::App).to receive(:new).and_return(app)
+      allow(app).to receive(:run!)
+    end
+
+    it "creates and runs an app with the given name" do
+      command.call(name: "test_app")
+
+      expect(CreateRubyApp::App).to have_received(:new).with(
+        name: "test_app",
+        gems: [],
+        version: nil
+      )
+      expect(app).to have_received(:run!)
+    end
+
+    it "replaces dashes with underscores in the app name" do
+      command.call(name: "test-app")
+
+      expect(CreateRubyApp::App).to have_received(:new).with(
+        name: "test_app",
+        gems: [],
+        version: nil
+      )
+    end
+
+    it "accepts the `-r` flag for setting the Ruby version option" do
+      command.call(name: "test_app", ruby: "ruby-3.4.5")
+
+      expect(CreateRubyApp::App).to have_received(:new).with(
+        name: "test_app",
+        gems: [],
+        version: "ruby-3.4.5"
+      )
+    end
+
+    it "parses the `-g` flags for gems correctly" do
+      command.call(name: "test_app", gems: "rspec,pry,sinatra")
+
+      expect(CreateRubyApp::App).to have_received(:new).with(
+        name: "test_app",
+        gems: %w[rspec pry sinatra],
+        version: nil
+      )
+    end
+
+    it "handles empty gems string" do
+      command.call(name: "test_app", gems: "")
+
+      expect(CreateRubyApp::App).to have_received(:new).with(
+        name: "test_app",
+        gems: [],
+        version: nil
+      )
+    end
+
+    it "handles gems with spaces and empty entries" do
+      command.call(name: "test_app", gems: "rspec, pry,  , sinatra")
+
+      expect(CreateRubyApp::App).to have_received(:new).with(
+        name: "test_app",
+        gems: %w[rspec pry sinatra],
+        version: nil
+      )
+    end
+
+    it "accepts both Ruby and gems options" do
+      command.call(name: "test_app", ruby: "jruby-9.4.0",
+                   gems: "sequel,sinatra")
+
+      expect(CreateRubyApp::App).to have_received(:new).with(
+        name: "test_app",
+        gems: %w[sequel sinatra],
+        version: "jruby-9.4.0"
+      )
+    end
+  end
+end
+
+RSpec.describe CreateRubyApp::CLI do
+  describe ".call" do
+    let(:dry_cli) { instance_double(Dry::CLI) }
+
+    before do
+      allow(Dry::CLI).to receive(:new).with(CreateRubyApp::Commands)
+        .and_return(dry_cli)
+      allow(dry_cli).to receive(:call)
+    end
+
+    it "creates a Dry::CLI instance with commands and calls it" do
+      described_class.call
+
+      expect(Dry::CLI).to have_received(:new).with(CreateRubyApp::Commands)
+      expect(dry_cli).to have_received(:call)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,7 +1,11 @@
-# frozen_string_literal: true
+require "simplecov"
 
-require "rspec"
+SimpleCov.start do
+  add_filter "/spec/"
+  minimum_coverage 90
+end
 
+require "rspec"
 require_relative "../lib/create_ruby_app"
 
 RSpec.configure do |config|

metadata

@@ -1,60 +1,85 @@
 --- !ruby/object:Gem::Specification
 name: create-ruby-app
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Mathias Jean Johansen
-autorequire: 
 bindir: bin
 cert_chain: []
 date: 2019-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: thor
+  name: dry-cli
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.20.3
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.20.3
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: logger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.6'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 12.3.2
+        version: 13.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 12.3.2
+        version: 13.3.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.8.0
+        version: 3.13.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.8.0
-description: |-
-  create-ruby-app is an opinionated tool for scaffolding Ruby
-    applications
+        version: 3.13.1
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.22.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.22.0
+description: create-ruby-app is an opinionated tool for scaffolding Ruby applications
 email: mathias@mjj.io
 executables:
 - create-ruby-app
@@ -62,15 +87,18 @@ extensions: []
 extra_rdoc_files: []
 files:
 - CHANGELOG.md
+- CLAUDE.md
+- CODE_REVIEW.md
 - LICENSE
 - README.md
+- REFACTORING_PLAN.md
 - bin/create-ruby-app
 - lib/create_ruby_app.rb
 - lib/create_ruby_app/actions/create_directories.rb
 - lib/create_ruby_app/actions/generate_files.rb
 - lib/create_ruby_app/actions/install_gems.rb
 - lib/create_ruby_app/actions/make_script_executable.rb
-- lib/create_ruby_app/actions/null_action.rb
+- lib/create_ruby_app/actions/set_ruby_implementation.rb
 - lib/create_ruby_app/app.rb
 - lib/create_ruby_app/cli.rb
 - lib/create_ruby_app/templates/Gemfile.erb
@@ -79,17 +107,19 @@ files:
 - lib/create_ruby_app/templates/script_file.erb
 - lib/create_ruby_app/templates/spec_helper.erb
 - lib/create_ruby_app/version.rb
+- spec/integration/app_creation_spec.rb
 - spec/lib/create_ruby_app/actions/create_directories_spec.rb
 - spec/lib/create_ruby_app/actions/generate_files_spec.rb
 - spec/lib/create_ruby_app/actions/install_gems_spec.rb
 - spec/lib/create_ruby_app/actions/make_script_executable_spec.rb
+- spec/lib/create_ruby_app/actions/set_ruby_implementation_spec.rb
 - spec/lib/create_ruby_app/app_spec.rb
+- spec/lib/create_ruby_app/cli_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/majjoha/create-ruby-app
 licenses:
-- MIT
+- ISC
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -97,21 +127,23 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 3.4.5
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Scaffold Ruby applications effortlessly
 test_files:
-- spec/spec_helper.rb
-- spec/lib/create_ruby_app/actions/make_script_executable_spec.rb
+- spec/integration/app_creation_spec.rb
 - spec/lib/create_ruby_app/actions/create_directories_spec.rb
 - spec/lib/create_ruby_app/actions/generate_files_spec.rb
 - spec/lib/create_ruby_app/actions/install_gems_spec.rb
+- spec/lib/create_ruby_app/actions/make_script_executable_spec.rb
+- spec/lib/create_ruby_app/actions/set_ruby_implementation_spec.rb
 - spec/lib/create_ruby_app/app_spec.rb
+- spec/lib/create_ruby_app/cli_spec.rb
+- spec/spec_helper.rb

data/lib/create_ruby_app/actions/null_action.rb

@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-
-module CreateRubyApp
-  module Actions
-    class NullAction
-      def self.call(app); end
-    end
-  end
-end