crashlog 1.0.3 → 1.0.4

data/script/integration_test

@@ -14,10 +14,8 @@ require File.expand_path('../../rails/init', __FILE__)
 
 fail "Please supply an API Key as the first argument" if ARGV.empty?
 
-host = ARGV[3]
-host ||= "stdin.crashlog.io"
-
-secure = (ARGV[2] == "secure")
+host = ARGV[2]
+host = "https://stdin.crashlog.io" if host.blank?
 
 class SimulatedExceptionRaiser
   attr_reader :secure
@@ -37,12 +35,15 @@ end
 CrashLog.configure(true) do |config|
   config.api_key = ARGV[0]
   config.secret  = ARGV[1]
-  config.scheme  = secure ? 'https' : 'http'
+  config.scheme  = URI.parse(host).scheme
   config.host    = URI.parse(host).host
   config.port    = URI.parse(host).port
+  config.development_mode = true
   # config.service_name = 'Staging'
 end
 
+secure = CrashLog.configuration.secure?
+
 puts "Configuration:"
 CrashLog.configuration.each do |key, value|
   puts sprintf("%25s: %s", key.to_s, value.inspect.slice(0, 55))

data/spec/crash_log/backtrace_spec.rb

@@ -20,6 +20,27 @@ describe CrashLog::Backtrace do
     end
   end
 
+  describe '.split_multiline_backtrace' do
+    it 'splits multiple lines into an array' do
+      CrashLog::Backtrace.send(:split_multiline_backtrace, "line.rb:1\nline.rb:2").size.should == 2
+    end
+  end
+
+  describe 'comparisson' do
+    it 'matches backtraces on lines' do
+      backtrace_1 = CrashLog::Backtrace.parse(caller)
+      backtrace_2 = CrashLog::Backtrace.parse(caller)
+
+      backtrace_1.should == backtrace_2
+    end
+
+    it 'fails to match different backtraces' do
+      backtrace_1 = CrashLog::Backtrace.parse(caller)
+      backtrace_2 = CrashLog::Backtrace.parse(raised_error.backtrace)
+      backtrace_1.should_not == backtrace_2
+    end
+  end
+
   describe 'lines' do
     it 'are converted into a parsed Line object' do
       CrashLog::Backtrace.parse(raised_error.backtrace).lines.first.should be_a(CrashLog::Backtrace::Line)

data/spec/crash_log/configuration_spec.rb

@@ -34,4 +34,11 @@ describe CrashLog::Configuration do
       subject.should be_valid
     end
   end
+
+  describe 'ca bundle config' do
+    it 'locates packaged ca bundle' do
+      subject.ca_bundle_path.should end_with("resources/ca-bundle.crt")
+      File.should exist(subject.ca_bundle_path)
+    end
+  end
 end

data/spec/crash_log/initializer_spec.rb

@@ -1,22 +1,30 @@
 require 'spec_helper'
-# require 'crash_log/rails'
+require 'crash_log/rails'
 
 describe "Initializer" do
 
   let(:logger) { stub("Logger") }
   let(:other_logger) { stub("OtherLogger") }
 
-  # before(:all) do
-  #   load_dummy_app
-  # end
+  let(:rails) { double('Rails') }
+
+  before(:each) do
+    define_constant('Rails', rails)
+  end
+
+  it "triggers use of Rails' logger if logger isn't set and Rails' logger exists" do
+    rails = Module.new do
+      def self.logger
+        "RAILS LOGGER"
+      end
+    end
+    define_constant("Rails", rails)
+    CrashLog::Rails.initialize
+    expect("RAILS LOGGER").to eq(CrashLog.logger)
+  end
 
   describe 'auto configure logger' do
     before do
-      load_dummy_app
-      # unless defined?(Rails)
-      #   module Rails
-      #   end
-      # end
       Rails.stub(:logger).and_return(logger)
       logger.stub(:error)
       other_logger.stub(:error)
@@ -24,22 +32,13 @@ describe "Initializer" do
 
 
     it 'detects presence of Rails logger' do
-      pending
-      # CrashLog::Rails.__send__(:initialize)
-      CrashLog.logger.should be(logger)
+      CrashLog::Rails.__send__(:initialize)
+      CrashLog.logger.should eq(logger)
     end
 
     it "allows overriding of the logger if already assigned" do
-      pending
-      unless defined?(::Rails)
-        module Rails
-        end
-      end
-
-      Rails.stub(:logger).and_return(logger)
-
       CrashLog.logger.should_not == logger
-      # CrashLog::Rails.initialize
+      CrashLog::Rails.initialize
       CrashLog.logger.should == logger
 
       CrashLog.configure do |config|

data/spec/crash_log/rack_spec.rb

@@ -0,0 +1,82 @@
+require "spec_helper"
+
+describe CrashLog::Rack do
+  before do
+    CrashLog.configure do |config|
+      config.api_key = 'KEY'
+      config.secret = 'secret'
+      config.developer_mode = true
+    end
+  end
+
+  class BacktracedException < Exception
+    attr_accessor :backtrace
+
+    def initialize(opts)
+      @backtrace = opts[:backtrace]
+    end
+
+    def set_backtrace(bt)
+      @backtrace = bt
+    end
+
+    def message
+      "Something went wrong. Did you press the red button?"
+    end
+  end
+
+  def build_exception(opts = {})
+    backtrace = caller
+    opts = {:backtrace => backtrace}.merge(opts)
+    BacktracedException.new(opts)
+  end
+
+  it "calls the upstream app with the environment" do
+    environment = { 'key' => 'value' }
+    app = lambda { |env| ['response', {}, env] }
+    stack = CrashLog::Rack.new(app)
+
+    response = stack.call(environment)
+
+    expect(['response', {}, environment]).to eq(response)
+  end
+
+  it "delivers an exception raised while calling an upstream app" do
+    exception = build_exception
+    environment = { 'key' => 'value' }
+
+    CrashLog.should_receive(:notify_or_ignore).with(exception, :rack_env => environment)
+
+    app = lambda do |env|
+      raise exception
+    end
+
+    begin
+      stack = CrashLog::Rack.new(app)
+      stack.call(environment)
+    rescue Exception => raised
+      expect(exception).to eq(raised)
+    else
+      fail "Didn't raise an exception"
+    end
+  end
+
+  it "delivers an exception in rack.exception" do
+    CrashLog.stub(:notify)
+    exception = build_exception
+    environment = { 'key' => 'value' }
+
+    CrashLog.should_receive(:notify_or_ignore).with(exception, :rack_env => environment)
+
+    response = [200, {}, ['okay']]
+    app = lambda do |env|
+      env['rack.exception'] = exception
+      response
+    end
+    stack = CrashLog::Rack.new(app)
+    actual_response = stack.call(environment)
+
+    expect(response).to eq(actual_response)
+  end
+
+end

data/spec/crash_log/reporter_spec.rb

@@ -9,6 +9,7 @@ describe CrashLog::Reporter do
       config.api_key = 'API_KEY'
       # config.adapter = test_adapter
       config.scheme = 'http'
+      config.developer_mode = true
     end
   }
 

data/spec/crash_log_spec.rb

@@ -93,6 +93,8 @@ describe CrashLog do
 
   describe '.ready' do
     it 'logs an ready message' do
+      CrashLog.configuration.colorize = false
+
       CrashLog::Reporter.any_instance.stub(:announce).and_return("Test Application")
       logger = stub('Logger')
       logger.should_receive(:info).

data/spec/requests/rails_controller_rescue_spec.rb

@@ -1,115 +1,118 @@
-require 'spec_helper'
-require 'rack/test'
-require 'uuid'
+if defined?(Rails)
 
-describe 'Rescue from within a Rails 3.x controller' do
-  include RSpec::Rails::RequestExampleGroup
-  include Rack::Test::Methods
+  require 'spec_helper'
+  require 'rack/test'
+  require 'uuid'
 
-  class CollectingReporter
-    attr_reader :collected
+  describe 'Rescue from within a Rails 3.x controller' do
+    # include RSpec::Rails::RequestExampleGroup
+    include Rack::Test::Methods
 
-    def initialize
-      @collected = []
-    end
+    class CollectingReporter
+      attr_reader :collected
 
-    def result
-      {:location_id => UUID.generate }
-    end
+      def initialize
+        @collected = []
+      end
+
+      def result
+        {:location_id => UUID.generate }
+      end
 
-    def notify(payload)
-      @collected << payload
-      true
+      def notify(payload)
+        @collected << payload
+        true
+      end
     end
-  end
 
-  def assert_caught_and_sent
-    CrashLog.reporter.collected.should_not be_empty
-  end
+    def assert_caught_and_sent
+      CrashLog.reporter.collected.should_not be_empty
+    end
 
-  def assert_caught_and_not_sent
-    expect { CrashLog.reporter.collected.empty? }.to be_true
-  end
+    def assert_caught_and_not_sent
+      expect { CrashLog.reporter.collected.empty? }.to be_true
+    end
 
-  def last_notice
-    CrashLog.reporter.collected.last
-  end
+    def last_notice
+      CrashLog.reporter.collected.last
+    end
 
-  before do
-    CrashLog.reporter = CollectingReporter.new
-    CrashLog.configuration.root = File.expand_path("../..", __FILE__)
-  end
+    before do
+      CrashLog.reporter = CollectingReporter.new
+      CrashLog.configuration.root = File.expand_path("../..", __FILE__)
+    end
 
-  it 'is testing tails 3.x' do
-    Rails.version.should =~ /^3\.2\./
-  end
+    it 'is testing tails 3.x' do
+      Rails.version.should =~ /^3\.2\./
+    end
 
-  describe 'dummy app' do
-    it 'should response nicely to index' do
-      get '/'
-      last_response.should be_ok
-      last_response.body.should == 'Works fine here'
+    describe 'dummy app' do
+      it 'should response nicely to index' do
+        get '/'
+        last_response.should be_ok
+        last_response.body.should == 'Works fine here'
+      end
     end
-  end
 
-  let(:action) { get '/broken' }
+    let(:action) { get '/broken' }
 
-  it 'collects payloads' do
-    CrashLog.notify(RuntimeError.new("TEST"))
-    assert_caught_and_sent
-  end
+    it 'collects payloads' do
+      CrashLog.notify(RuntimeError.new("TEST"))
+      assert_caught_and_sent
+    end
 
-  # it 'should intercept error and notify crashlog' do
-  #   begin
-  #     get '/broken'
-  #   rescue StandardError; end
+    # it 'should intercept error and notify crashlog' do
+    #   begin
+    #     get '/broken'
+    #   rescue StandardError; end
 
-  #   last_response.status.should == 500
-  #   last_response.body.should match /We're sorry, but something went wrong/
+    #   last_response.status.should == 500
+    #   last_response.body.should match /We're sorry, but something went wrong/
 
-  #   assert_caught_and_sent
-  # end
+    #   assert_caught_and_sent
+    # end
 
-  # it 'captures standard backtrace attributes' do
-  #   action
+    # it 'captures standard backtrace attributes' do
+    #   action
 
-  #   last_notice.to_json.should have_json_path('notifier/name')
-  #   last_notice.to_json.should have_json_path('backtrace/0/number')
-  #   last_notice.to_json.should have_json_path('backtrace/0/method')
-  #   last_notice.to_json.should have_json_path('backtrace/0/file')
-  #   last_notice.to_json.should have_json_path('backtrace/0/context_line')
-  #   last_notice.to_json.should have_json_path('backtrace/0/pre_context/1')
-  #   last_notice.to_json.should have_json_path('backtrace/0/pre_context/2')
-  #   last_notice.to_json.should have_json_path('backtrace/0/pre_context/3')
-  #   last_notice.to_json.should have_json_path('backtrace/0/pre_context/4')
-  #   last_notice.to_json.should have_json_path('environment/system/hostname')
-  #   last_notice.to_json.should have_json_path('environment/system/application_root')
-  # end
+    #   last_notice.to_json.should have_json_path('notifier/name')
+    #   last_notice.to_json.should have_json_path('backtrace/0/number')
+    #   last_notice.to_json.should have_json_path('backtrace/0/method')
+    #   last_notice.to_json.should have_json_path('backtrace/0/file')
+    #   last_notice.to_json.should have_json_path('backtrace/0/context_line')
+    #   last_notice.to_json.should have_json_path('backtrace/0/pre_context/1')
+    #   last_notice.to_json.should have_json_path('backtrace/0/pre_context/2')
+    #   last_notice.to_json.should have_json_path('backtrace/0/pre_context/3')
+    #   last_notice.to_json.should have_json_path('backtrace/0/pre_context/4')
+    #   last_notice.to_json.should have_json_path('environment/system/hostname')
+    #   last_notice.to_json.should have_json_path('environment/system/application_root')
+    # end
 
-  # it 'captures current user' do
-  #   # ActionController::Base.any_instance.stub(:crash_log_context).and_return({current_user: {id: 1}})
+    # it 'captures current user' do
+    #   # ActionController::Base.any_instance.stub(:crash_log_context).and_return({current_user: {id: 1}})
 
-  #   action
+    #   action
 
-  #   # last_notice.should == ''
-  #   last_notice.to_json.should have_json_path('context/current_user')
-  # end
+    #   # last_notice.should == ''
+    #   last_notice.to_json.should have_json_path('context/current_user')
+    # end
 
-  # it 'should capture crash log custom data'
+    # it 'should capture crash log custom data'
 
-  # it 'should raise error again after notifying' do
-  #   ENV['RAILS_ENV']='production'
+    # it 'should raise error again after notifying' do
+    #   ENV['RAILS_ENV']='production'
 
-  #   logger = stub("Logger")
-  #   ActionDispatch::DebugExceptions.any_instance.stub(:logger).and_return(logger)
-  #   logger.should_receive(:fatal).once
+    #   logger = stub("Logger")
+    #   ActionDispatch::DebugExceptions.any_instance.stub(:logger).and_return(logger)
+    #   logger.should_receive(:fatal).once
 
-  #   begin
-  #     get '/broken'
-  #     last_response.status.should == 500
-  #   rescue
-  #   end
-  # end
+    #   begin
+    #     get '/broken'
+    #     last_response.status.should == 500
+    #   rescue
+    #   end
+    # end
 
-  it 'should be able to defer reporting to another thread'
+    it 'should be able to defer reporting to another thread'
+  end
 end

data/spec/spec_helper.rb

@@ -1,11 +1,15 @@
-if ENV['COV']
+begin
   require 'simplecov'
-  SimpleCov.start
+  SimpleCov.start do
+    add_filter "spec/"
+  end
+rescue LoadError
+  puts "Skipping SimpleCov"
 end
 
-require File.expand_path("../dummy/config/environment.rb",  __FILE__)
+# require File.expand_path("../dummy/config/environment.rb",  __FILE__)
 
-require 'rspec/rails'
+# require 'rspec/rails'
 require 'delorean'
 require 'json_spec'
 require 'uuid'
@@ -26,5 +30,6 @@ RSpec.configure do |config|
 
   config.after(:each) do
     teardown_constants
+    CrashLog.reset_configuration!
   end
 end