crashdesk 0.1.0 → 0.2.0

data/Rakefile

@@ -0,0 +1,21 @@
+#!/usr/bin/env rake
+
+require 'rubygems'
+require 'bundler/setup'
+require 'rspec/core/rake_task'
+
+Bundler::GemHelper.install_tasks
+
+desc 'Default: run specs.'
+task :default => :spec
+
+desc "Run specs"
+RSpec::Core::RakeTask.new do |t|
+  t.pattern = "./spec/**/*_spec.rb" # don't need this, it's default.
+  # Put spec opts in a file named .rspec in root
+end
+
+desc "Run tests with SimpleCov"
+RSpec::Core::RakeTask.new('coverage') do |t|
+  ENV['COVERAGE'] = "true"
+end

data/crashdesk.gemspec

@@ -8,7 +8,7 @@ Gem::Specification.new do |gem|
   gem.summary = "Crashde.sk is helping you track crashes of your application online"
   gem.description = "crashdesk is the Ruby gem for containing core functionality for communication with crashde.sk servers"
   gem.email = "info@crashde.sk"
-  gem.files =  Dir['lib/**/*'] + Dir['spec/**/*'] + Dir['*.rb'] + ["crashdesk.gemspec"]
+  gem.files =  Dir['lib/**/*'] + Dir['spec/**/*'] + Dir['*.rb'] + ["crashdesk.gemspec", 'Rakefile']
   gem.homepage = "http://crashde.sk"
   gem.require_paths = ["lib"]
   gem.rubyforge_project = "crashdesk"

data/lib/crashdesk.rb

@@ -10,8 +10,9 @@ require 'crashdesk/context_base'
 require 'crashdesk/crashlog'
 require 'crashdesk/backtrace'
 require 'crashdesk/environment'
+require 'crashdesk/report_manager'
 require 'crashdesk/reporters/remote'
-require 'crashdesk/serializers/json'
+require 'crashdesk/reporters/logger'
 
 module Crashdesk
 
@@ -37,8 +38,8 @@ module Crashdesk
       @configuration ||= Configuration.new
     end
 
-    def log(message)
-      configuration.logger.info(LOG_PREFIX + message) if configuration.logger
+    def log(message, severity = :info)
+      configuration.logger.send(severity, LOG_PREFIX + message) if configuration.logger
     end
 
     # Main method how to build crashlog from exception, context, and environment

data/lib/crashdesk/configuration.rb

@@ -26,7 +26,7 @@ module Crashdesk
     attr_accessor :environment_name, :project_root
 
     def initialize
-      @host                      = 'crashde.sk'
+      @host = 'crashde.sk'
     end
 
     # Hash like access
@@ -42,6 +42,11 @@ module Crashdesk
       'http'
     end
 
+    def reporters
+      reporters = [:remote]
+      reporters << :logger if logger
+    end
+
     private
 
     def default_port

data/lib/crashdesk/crashlog.rb

@@ -4,7 +4,7 @@ module Crashdesk
 
     attr_accessor :options, :exception, :backtrace, :environment, :exception_class,
       :exception_message, :context, :occurred_at,
-      :reporter
+      :reporters
 
     def initialize(exception, request, context, options = {})
       self.options = options
@@ -18,16 +18,14 @@ module Crashdesk
       # Environment
       self.environment = Crashdesk::Environment.new(
         :environment_name => options[:environment_name],
-        :project_root => Crashdesk.configure.project_root)
+        :project_root => config.project_root)
 
       # Context
       self.context = context
-      self.occurred_at = Time.now.utc.iso8601
+      self.occured_at = Time.now.utc.iso8601
 
       # How to report?
-      self.reporter = options[:reporter] ||
-        Crashdesk::Reporter::Remote.new(:host => 'localhost',
-                                        :port => 4567) # Need to pass HTTP params
+      self.reporters = options[:reporters] || config.reporters
     end
 
     def to_hash
@@ -35,7 +33,7 @@ module Crashdesk
         :api_key => Crashdesk.configuration.api_key,
         :hash_id => backtrace.hash_id,
         :crc => backtrace.crc,
-        :occurred_at => occurred_at,
+        :occured_at => occured_at,
 
         :environment => environment.to_hash,
 
@@ -48,14 +46,20 @@ module Crashdesk
     end
 
     def report
-      json = Crashdesk::Serializer::Json.new(self.to_hash).process
-      reporter.run(json)
+      report_manager = Crashdesk::ReportManager.new(reporters)
+      report_manager.process(self)
     end
 
     def crc
       session_data.crc
     end
 
+    private
+
+    def config
+      Crashdesk.configuration
+    end
+
   end
 
 end

data/lib/crashdesk/report_manager.rb

@@ -0,0 +1,42 @@
+module Crashdesk
+  class ReportManager
+
+    attr_reader :reporters
+
+    def initialize(reporters)
+      @reporters = reporters.map do |reporter|
+        if reporter.respond_to? :run
+          reporter
+        else
+          constantize(reporter).new
+        end
+      end
+    end
+
+    def process(crashlog)
+      reporters.map do |reporter|
+        reporter.run(crashlog)
+      end
+    end
+
+    private
+
+    def constantize(reporter_name, prefix = "::Crashdesk::Reporters::")
+      klass = prefix + klass_name(reporter_name)
+      names = klass.split('::')
+      names.shift if names.empty? || names.first.empty?
+
+
+      constant = Object
+      names.each do |name|
+        constant = constant.const_defined?(name) ? constant.const_get(name) : constant.const_missing(name)
+      end
+      constant
+    end
+
+    def klass_name(k)
+      k.to_s.split('_').collect!{ |w| w.capitalize }.join
+    end
+
+  end
+end

data/lib/crashdesk/reporters/logger.rb

@@ -0,0 +1,13 @@
+module Crashdesk
+  module Reporters
+    class Logger
+
+      def run(crashlog)
+        require 'pp'
+        hash = crashlog.to_hash
+        Crashdesk.log(pp(hash))
+      end
+
+    end
+  end
+end

data/lib/crashdesk/reporters/remote.rb

@@ -2,7 +2,7 @@ require 'net/http'
 require 'net/https'
 
 module Crashdesk
-  module Reporter
+  module Reporters
 
     module QueryParams
       def self.encode(value, key = nil)
@@ -11,7 +11,7 @@ module Crashdesk
         when Array then value.map { |v| encode(v, "#{key}[]") }.join('&')
         when nil   then ''
         else
-          "#{key}=#{CGI.escape(value.to_s)}" 
+          "#{key}=#{CGI.escape(value.to_s)}"
         end
       end
 
@@ -53,25 +53,36 @@ module Crashdesk
         end
       end
 
-      def run(data)
+      def run(crashlog)
+        hash = crashlog.to_hash
+        unless hash.respond_to? :to_json
+          require 'json'
+          unless hash.respond_to? :to_json
+            raise StandardError.new("You need a json gem/library installed to send errors to as JSON (Object.to_json not defined).
+                                    \nInstall json_pure, yajl-ruby, json-jruby, or the c-based json gem")
+          end
+        end
+        data = hash.to_json
+
         http = setup_http_connection
         headers = HEADERS.merge('X-Crashdesk-ApiKey' => Crashdesk.configuration.api_key)
 
         response = begin
+                    log "Sending crash report to #{url} with data: #{data}"
                     http.post(url.path, data, headers)
                   rescue *HTTP_ERRORS => e
-                    logger.error "Unable to connect the Creashdesk server. HTTP Error=#{e}"
+                    log "Unable to connect the Creashdesk server. HTTP Error=#{e}", :error
                     nil
                   end
 
         case response
         when Net::HTTPSuccess then
-          logger.info "Success: #{response.class} #{response}"
+          log "Success: #{response.class} #{response}"
         else
-          logger.info "Failure: #{response.class} #{response}"
+          log "Failure: #{response.class} #{response}"
         end
       rescue => e
-        logger.error "Error sending: #{e.class} - #{e.message}\nBacktrace:\n#{e.backtrace.join("\n\t")}"
+        log "Error sending: #{e.class} - #{e.message}\nBacktrace:\n#{e.backtrace.join("\n\t")}", :error
         nil
       end
 
@@ -92,8 +103,8 @@ module Crashdesk
 
       private
 
-      def logger
-        Crashdesk.logger
+      def log(message, severity = :info)
+        Crashdesk.log(message, severity)
       end
 
       def url

data/lib/crashdesk/reporters/screen.rb

@@ -1,11 +1,8 @@
 module Crashdesk
-  module Reporter
+  module Reporters
 
     class Screen
 
-      def initialize()
-      end
-
       def run(data)
         data.to_json.to_s
       end

data/lib/crashdesk/version.rb

@@ -1,3 +1,3 @@
 module Crashdesk
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/report_manager_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper'
+
+describe Crashdesk::ReportManager do
+
+  context "with predefined reporters" do
+    before(:all) do
+      crashlog_class = class MyCrashlog
+                          def to_hash
+                            {:name => 1, :string => 2}
+                          end
+                       end
+      class ::Crashdesk::Reporters::Echo
+        def run(crashlog)
+          crashlog.to_hash
+        end
+      end
+    end
+
+    before do
+      @crashlog = MyCrashlog.new
+    end
+
+    it "and with Logger should print it with PP" do
+      Crashdesk.should_receive(:log).with({:name => 1, :string => 2})
+      PP.should_receive(:pp).with(name: 1, string: 2)
+      @report_manager = Crashdesk::ReportManager.new([:logger])
+      @report_manager.process(@crashlog)
+    end
+
+    it "and with Foo logger should return echo and also with logger call PP" do
+      @report_manager = Crashdesk::ReportManager.new([:logger, :echo])
+      PP.should_receive(:pp).with(name: 1, string: 2)
+      @report_manager.process(@crashlog).should eq([nil, {name:1,string:2}])
+    end
+
+    it "must accept also constants as argument" do
+      @report_manager = Crashdesk::ReportManager.new([:logger, ::Crashdesk::Reporters::Echo.new])
+      PP.should_receive(:pp).with(name: 1, string: 2)
+      @report_manager.process(@crashlog).should eq([nil, {name:1,string:2}])
+    end
+
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: crashdesk
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-26 00:00:00.000000000 Z
+date: 2012-09-03 00:00:00.000000000 Z
 dependencies: []
 description: crashdesk is the Ruby gem for containing core functionality for communication
   with crashde.sk servers
@@ -23,16 +23,19 @@ files:
 - lib/crashdesk/context_base.rb
 - lib/crashdesk/crashlog.rb
 - lib/crashdesk/environment.rb
+- lib/crashdesk/report_manager.rb
+- lib/crashdesk/reporters/logger.rb
 - lib/crashdesk/reporters/remote.rb
 - lib/crashdesk/reporters/screen.rb
-- lib/crashdesk/serializers/json.rb
 - lib/crashdesk/version.rb
 - lib/crashdesk.rb
 - spec/backtrace_spec.rb
 - spec/configuration_spec.rb
+- spec/report_manager_spec.rb
 - spec/spec_helper.rb
 - spec/stubs/backtrace_basic.txt
 - crashdesk.gemspec
+- Rakefile
 homepage: http://crashde.sk
 licenses: []
 post_install_message: 

data/lib/crashdesk/serializers/json.rb

@@ -1,25 +0,0 @@
-module Crashdesk
-  module Serializer
-
-    class Json
-
-      def initialize(data)
-        unless data.respond_to? :to_json
-          require 'json'
-          unless data.respond_to? :to_json
-            raise StandardError.new("You need a json gem/library installed to send errors to as JSON (Object.to_json not defined).
-                                    \nInstall json_pure, yajl-ruby, json-jruby, or the c-based json gem")
-          end
-        end
-
-        @data = data
-      end
-
-      def process
-        @data.to_json
-      end
-
-    end
-
-  end
-end