cranky 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 832320f9e104372957157b3cef6c0d81592a6b66
-  data.tar.gz: 6560e13c455a033fa20f11041c065bf13b95f7ec
+  metadata.gz: c7f6c5a28b743f350225d95efa1a42db23f299aa
+  data.tar.gz: 8713bef7ea202b009f97c89625403af0d00fd7d4
 SHA512:
-  metadata.gz: 82347e3df728a862aec73692225e6e0344df1503d0ff117ca4f8bff366f8626e7fbc027d7322c32f73b95d11de6a0bd0bbe1c895a1116141e5fbb5c45238e62f
-  data.tar.gz: a5c223a0a63ad0231fb342c5f20fcd17fbdd438431a05f78fff8fa25fbc00b163f8b1bb6bea24166e36070bab98d7ca3f88812987de034d944aa49f3a251f9e8
+  metadata.gz: 6f172f48edbf5686465205c5df9254a3b68b74cc47761d78c8d623511975e0dfc2141bd295c59a1af09ee250eaec743a317cbb14aec3ddb251ed80f58dc36ce7
+  data.tar.gz: 1b3f2af3d7bc85e6a25742aecf10cb27ef635cb4c78622d9e4ddb7bfe4361ad8bb9c8adbd5ed02b602aa921895b25759ab282b20b93d536f66f19b8897e5e5d8

data/Gemfile

@@ -1,6 +1,7 @@
 source "http://gemcutter.org"
 
 group :development do
+  gem "activemodel"
   gem "rake"
   gem "gemcutter"
 end

data/Gemfile.lock

@@ -1,10 +1,22 @@
 GEM
   remote: http://gemcutter.org/
   specs:
+    activemodel (4.2.6)
+      activesupport (= 4.2.6)
+      builder (~> 3.1)
+    activesupport (4.2.6)
+      i18n (~> 0.7)
+      json (~> 1.7, >= 1.7.7)
+      minitest (~> 5.1)
+      thread_safe (~> 0.3, >= 0.3.4)
+      tzinfo (~> 1.1)
+    builder (3.2.2)
     diff-lcs (1.1.2)
     docile (1.1.5)
     gemcutter (0.7.0)
+    i18n (0.7.0)
     json (1.8.3)
+    minitest (5.9.0)
     rake (0.9.2)
     rspec (2.6.0)
       rspec-core (~> 2.6.0)
@@ -19,15 +31,19 @@ GEM
       json (~> 1.8)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.0)
+    thread_safe (0.3.5)
+    tzinfo (1.2.2)
+      thread_safe (~> 0.1)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
+  activemodel
   gemcutter
   rake
   rspec
   simplecov
 
 BUNDLED WITH
-   1.12.2
+   1.12.5

data/README.md

@@ -207,6 +207,16 @@ def apply_trait_manager_to_user(user)
 end
 ~~~
 
+You can create collections...
+
+~~~ruby
+Factory.create(:users_collection)
+
+def users_collection
+  3.time.map { build(:user) }
+end
+~~~
+
 ## Helpers
 
 Of course its nice to get some help...

data/lib/cranky/factory.rb

@@ -6,23 +6,23 @@ module Cranky
     def initialize
       # Factory jobs can be nested, i.e. a factory method can itself invoke another factory method to
       # build a dependent object. In this case jobs the jobs are pushed into a pipeline and executed
-      # in a last in first out order. 
+      # in a last in first out order.
       @pipeline = []
       @n = 0
       @errors = []
     end
-    
+
     def build(what, overrides={})
       crank_it(what, overrides)
     end
 
     def create(what, overrides={})
       item = build(what, overrides)
-      item.save
+      Array(item).each(&:save)
       item
     end
 
-    # Reset the factory instance, clear all instance variables 
+    # Reset the factory instance, clear all instance variables
     def reset
       self.instance_variables.each do |var|
         instance_variable_set(var, nil)
@@ -34,17 +34,18 @@ module Cranky
       build(what, attrs.merge(:_return_attributes => true))
     end
 
-    # Can be left in your tests as an alternative to build and to warn if your factory method 
-    # ever starts producing invalid instances 
+    # Can be left in your tests as an alternative to build and to warn if your factory method
+    # ever starts producing invalid instances
     def debug(*args)
-      item = build(*args) 
-      if !item.valid?
-        if item.errors.respond_to?("messages")
-          errors = item.errors.messages
+      item = build(*args)
+      invalid_item = Array(item).find(&:invalid?)
+      if invalid_item
+        if invalid_item.errors.respond_to?(:messages)
+          errors = invalid_item.errors.messages
         else
-          errors = item.errors
+          errors = invalid_item.errors
         end
-        raise "Oops, the #{item.class} created by the Factory has the following errors: #{errors}"
+        raise "Oops, the #{invalid_item.class} created by the Factory has the following errors: #{errors}"
       end
       item
     end
@@ -86,10 +87,10 @@ module Cranky
         item
       end
 
-      # This method actually makes the required object instance, it gets called by the users factory 
+      # This method actually makes the required object instance, it gets called by the users factory
       # method, where the name 'define' makes more sense than it does here!
       def define(defaults={})
-        current_job.defaults = defaults   
+        current_job.defaults = defaults
         current_job.execute
       end
 
@@ -100,7 +101,7 @@ module Cranky
       end
 
       def current_job
-        @pipeline.last  
+        @pipeline.last
       end
 
       # Returns a hash containing any top-level overrides passed in when the current factory was invoked
@@ -108,7 +109,7 @@ module Cranky
         current_job.overrides
       end
 
-      # Adds a new job to the pipeline then yields to the caller to execute it 
+      # Adds a new job to the pipeline then yields to the caller to execute it
       def new_job(what, overrides)
         @pipeline << Job.new(what, overrides)
         yield

data/lib/cranky/version.rb

@@ -1,3 +1,3 @@
 module Cranky
-  VERSION = "0.4.0"
+  VERSION = "0.5.0"
 end

data/spec/cranky_spec.rb

@@ -19,6 +19,11 @@ describe "The Cranky factory" do
     crank!(:user).saved?.should == true
   end
 
+  it "does save each item in the collection when generated via create or crank!" do
+    Factory.create(:users_collection).select { |u| !u.saved? }.should be_empty
+    crank!(:users_collection).select { |u| !u.saved? }.should be_empty
+  end
+
   it "allows all attributes to be overriden in the call" do
     u = Factory.build(:user, :name => "Indy", :email => "indy@home.com", :role => :dog, :unique => :yep)
     u.name.should == "Indy"
@@ -74,19 +79,15 @@ describe "The Cranky factory" do
   describe "debugger" do 
 
     it "raises an error if the factory produces an invalid object when enabled (rails only)" do
-      error = false
-      begin
-        Factory.debug(:user, :valid => false)
-      rescue
-        error = true 
-      end
-      error.should == true
+      expect { Factory.debug(:user) }.to raise_error(
+        'Oops, the User created by the Factory has the following errors: {:required_attr=>["can\'t be blank"]}'
+      )
     end
 
     it "debug works like build and create when there are no errors" do
-      Factory.debug(:user).class.should == User
-      Factory.debug(:user).saved?.should == false
-      Factory.debug!(:user).saved?.should == true
+      Factory.debug(:user, required_attr: true).class.should == User
+      Factory.debug(:user, required_attr: true).saved?.should == false
+      Factory.debug!(:user, required_attr: true).saved?.should == true
     end
 
   end
@@ -146,7 +147,7 @@ describe "The Cranky factory" do
   end
 
   it "returns nothing extra in the attributes" do
-    crank(:user_attrs).size.should == 6
+    crank(:user_attrs).size.should == 5
   end
 
   specify "attributes for works with factory methods using inherit" do

data/spec/spec_helper.rb

@@ -2,13 +2,18 @@ require 'simplecov'
 SimpleCov.start
 
 require 'cranky'
+require 'active_model'
 
 RSpec.configure do |config|
   config.expect_with(:rspec) { |c| c.syntax = :should }
 end
 
 class TestClass
-  attr_accessor :valid
+  include ActiveModel::Validations
+
+  attr_accessor :required_attr
+
+  validates_presence_of :required_attr
 
   def save
     @saved = true
@@ -18,14 +23,6 @@ class TestClass
     !!@saved
   end
 
-  def valid?
-    @valid
-  end
-
-  def errors
-    "some validation errors"
-  end
-
   def attributes
     self.instance_variables
   end
@@ -59,7 +56,6 @@ class Cranky::Factory
     u.unique = "value#{n}"
     u.email = "fred@home.com"
     u.address = Factory.build(:address)
-    u.valid = true
     u
   end
 
@@ -69,8 +65,7 @@ class Cranky::Factory
                :role => :user,
                :unique => "value#{n}",
                :email => "fred@home.com",
-               :address => Factory.create(:address),
-               :valid => true
+               :address => Factory.create(:address)
     u.argument_received = true if options[:argument_supplied]
     u
   end
@@ -86,8 +81,7 @@ class Cranky::Factory
 
   def address
     define :address => "25 Wisteria Lane",
-           :city => "New York",
-           :valid => true
+           :city => "New York"
   end
 
   def user_hash
@@ -96,6 +90,10 @@ class Cranky::Factory
            :role => :user
   end
 
+  def users_collection
+    3.times.map { build(:user) }
+  end
+
   def apply_trait_manager_to_user_manually(user)
     user.role = :manager
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cranky
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Stephen McGinty
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-30 00:00:00.000000000 Z
+date: 2016-08-10 00:00:00.000000000 Z
 dependencies: []
 description: A very light yet powerful test factory framework with an extremely clean
   syntax that makes it very easy to define your factories.
@@ -49,7 +49,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.4
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.6.4
 signing_key: 
 specification_version: 4
 summary: A very light yet powerful test factory framework.