craigslister 2.1.1 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 83f273dd97db5b9e9322851b3b69a5818194c39e
-  data.tar.gz: a53505d6d77de5be42ff950c88d9379289fb3e8a
+  metadata.gz: 3f87dfc804af5cf58d208043c69c9ac1e7330f95
+  data.tar.gz: 4f35f504ba5936bf0676a534c5b3967214fa97ec
 SHA512:
-  metadata.gz: 813c4dc83d6f84642167220e7f8f25a5bff5aef84bd491b12a8065de2ff20a49f4645743169853645ced314de9a73595d8788857ea43aa1e5977acd81582521e
-  data.tar.gz: 7cac96de0d2b7852b90d9d57ba4a045ab5641e3f36b2c4a264c8a9f26c7722a5af1c34e151f7ca1f82be2eee85aec91b9c1db1b8230ccaac7b12f827eb8b5b4e
+  metadata.gz: 0327eadd2ea042cddf14ac6ba6de2e7c776eab2a218664e0632f0e68d3cbf173e9f9b1dca022c1518e73d5717ba2fa7f4afd82705449249db7362c5ee41298af
+  data.tar.gz: b6ed756491d417895492ec9b65b2c13783dece0d0ba7a2988af887e9f6891c88a617df83822603206e2a4bc2e8dfd0c45620237cd359441a4d96a96bbcd528d4

data/lib/craigslister/craigslister.rb

@@ -14,12 +14,8 @@ class Craigslister
     validate_price_range
   end
 
-  def scrape
-    scraper.scrape
-  end
-
-  def links
-    scraper.links
+  def posts
+    LinkScraper.new(url, base_url).posts
   end
 
   def url
@@ -30,10 +26,6 @@ class Craigslister
 
   private
 
-  def scraper
-    Scraper.new(url, base_url)
-  end
-
   def base_url
     "https://#{area}.craigslist.org"
   end
@@ -46,7 +38,11 @@ class Craigslister
   end
 
   def validate_price_range
-    return unless low && high && low > high
-    fail(InvalidRangeError, 'Price range is invalid.')
+    fail(InvalidRangeError,
+         'Price range is invalid.') if price_invalid?
+  end
+
+  def price_invalid?
+    low && high && low > high
   end
 end

data/lib/craigslister/{scraper.rb → link_scraper.rb}

@@ -1,5 +1,5 @@
-# Houses all higher level scraping logic
-class Scraper
+# Scrapes links and feeds them to PostScraper
+class LinkScraper
   def initialize(url, base_url)
     @url = url
     @base_url = base_url
@@ -9,7 +9,7 @@ class Scraper
     header_link.map { |link| format_link(link['href']) }
   end
 
-  def scrape
+  def posts
     links.flat_map { |link| post_from(link) }
   end
 
@@ -30,7 +30,7 @@ class Scraper
   end
 
   def format_link(link)
-    if link =~ /\w+\.craig/
+    if link.match(/\w+\.craig/)
       'https:' + link
     else
       base_url + link

data/lib/craigslister/post_scraper.rb

@@ -1,4 +1,4 @@
-# Creates Post objects out of an HTML page
+# Scrapes craigslist posts and packages data in Post objects
 class PostScraper
   def initialize(page, link)
     @page = page
@@ -6,14 +6,7 @@ class PostScraper
   end
 
   def new_post
-    Post.new(
-      image: image,
-      title: title,
-      price: price,
-      location: location,
-      description: description,
-      url: link
-    )
+    Post.new(post_params)
   end
 
   private
@@ -24,6 +17,17 @@ class PostScraper
     page.at('span.postingtitletext')
   end
 
+  def post_params
+    {
+      image: image,
+      title: title,
+      price: price,
+      location: location,
+      description: description,
+      url: link
+    }
+  end
+
   def image
     image = page.at('img')
     image ? image['src'] : ''

data/lib/craigslister.rb

@@ -1,6 +1,6 @@
 require 'nokogiri'
 require 'open-uri'
-require 'craigslister/scraper'
+require 'craigslister/link_scraper'
 require 'craigslister/post_scraper'
 require 'craigslister/post'
 require 'craigslister/craigslister'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: craigslister
 version: !ruby/object:Gem::Version
-  version: 2.1.1
+  version: 3.0.0
 platform: ruby
 authors:
 - Chris Scott
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-11 00:00:00.000000000 Z
+date: 2016-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -19,7 +19,7 @@ dependencies:
         version: '1.6'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.6.2
+        version: 1.6.7.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '1.6'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.6.2
+        version: 1.6.7.1
 description: all you need is an item title and you can scrape posts from craigslist
 email: christo247@gmail.com
 executables: []
@@ -38,9 +38,9 @@ extra_rdoc_files: []
 files:
 - lib/craigslister.rb
 - lib/craigslister/craigslister.rb
+- lib/craigslister/link_scraper.rb
 - lib/craigslister/post.rb
 - lib/craigslister/post_scraper.rb
-- lib/craigslister/scraper.rb
 homepage: https://github.com/Yago580/craigslister
 licenses:
 - MIT