craigslister 1.0.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: baee98976e89041bd66fa0185d57da5c795d4528
-  data.tar.gz: b433e97471302f67371aa8e8156f702730eff626
+  metadata.gz: 6e1d5d4462a643f2ffcc73f70e2fe18c26f2cd05
+  data.tar.gz: 784647815b81ed5fcb46cf717c57b3fe85a29058
 SHA512:
-  metadata.gz: d0fcd65f9746e6051c4429cab01b80b1e62f847a6c4cc68f6c12d7a2a375101db21ffe83bf26146719e6b17373a25324f03bfa3ca1d8b60cfc95aa3da76cc234
-  data.tar.gz: 74c642fe4c6344ca693a4de612851ecb97f1612e91b954c9dde1057e3e70e7e2b5789a3cae27b6a399ad98b11a4b8e95672d71339b15fcf0247f4b2b4c4797a7
+  metadata.gz: 07101df2df31e3acf6b4d5b14d44c4d9ad00cf13b72d0d5ee6e3816a1f57cc2236ef8d501f6b380956b7d39c8c0c1eb345caf65735bf08e621a00bd7069798c0
+  data.tar.gz: 2db66d6ac5ccf8de5f25d6393b0d721f36307e2d008717de5dba6d2849799e75322089dda412347ae41ed2bea9f80c18a352d5b00358b8937be00a2c480c03dc

data/lib/craigslister.rb

@@ -1,14 +1,15 @@
 require 'nokogiri'
 require 'open-uri'
 
+
 class InvalidRangeError < StandardError
 end
 
+
 class Craigslister
-  attr_reader :area, :item, :high, :low, :results
+  attr_reader :area, :item, :high, :low
 
   def initialize args
-    @results = []
     @area    = args.fetch(:area, 'sfbay')
     @item    = args[:item]
     @high    = args.fetch(:high, nil)
@@ -17,23 +18,17 @@ class Craigslister
   end
 
   def scrape!
-    links.each_with_index {|link, index| get_data_from(link, index)}
-    results
+    links.map {|link| item_from(link)}.compact
   end
 
-  def url
-    "#{base_url}/"\
-    "search/sss?sort=rel&"\
-    "#{price_query}"\
-    "query=#{item.downcase.split(' ') * '+'}"
+  def links
+    page_from(url).css('.hdrlnk').map {|link| format_link(link)}
   end
 
-  def links
-    page = Nokogiri::HTML(open(url))
-    page.css('.hdrlnk').map do |link|
-      # formats out of town links, otherwise use base_url + link
-      link['href'] =~ /\w+\.craig/ ? "https:" + link['href'] : base_url + link['href']
-    end
+  def url
+    "#{base_url}/search/sss?sort=rel&"\
+    "#{price_query}query="\
+    "#{item.downcase.split(' ') * '+'}"
   end
 
 
@@ -42,20 +37,12 @@ class Craigslister
       "https://#{area}.craigslist.org"
     end
 
-    def get_data_from link, index
-      page = Nokogiri::HTML(open(link))
-      @results << Item.new(scrape_item_data(page, link)) rescue puts "No image for post ##{index+1}"
+    def page_from url
+      Nokogiri::HTML(open(url))
     end
 
-    def scrape_item_data page, url
-      {
-        image: page.at('img')['src'],
-        title: page.at('span.postingtitletext').text.gsub(/ ?- ?\$\d+ ?\(.+\)/, ''),
-        price: page.at('span.postingtitletext span.price').text.gsub(/\$/,'').to_i,
-        location: page.at('span.postingtitletext small').text.gsub(/ ?[\(\)]/,''),
-        description: page.at('section#postingbody').text,
-        url: url
-      }
+    def format_link link
+      link['href'] =~ /\w+\.craig/ ? "https:" + link['href'] : base_url + link['href']
     end
 
     def price_query
@@ -68,8 +55,45 @@ class Craigslister
     def validate_price_range
       raise InvalidRangeError if low && high && low > high
     end
+
+    def item_from link
+      Item.new(get_item_data(page_from(link), link))
+    end
+
+    def get_item_data page, link
+      {
+        image: scrape_image(page),
+        title: page.at('span.postingtitletext').text.gsub(/ ?- ?\$\d+ ?\(.+\)/, ''),
+        price: scrape_price(page),
+        location: scrape_location(page),
+        description: page.at('section#postingbody').text,
+        url: link
+      }
+    end
+
+    def scrape_image page
+      page.at('img') ? page.at('img')['src'] : ""
+    end
+
+    def scrape_price page
+      if price = page.at('span.postingtitletext span.price')
+        price.text.gsub(/\$/,'').to_i
+      else
+        0
+      end
+    end
+
+    def scrape_location page
+      if location = page.at('span.postingtitletext small')
+        location.text.gsub(/ ?[\(\)]/,'')
+      else
+        ""
+      end
+    end
 end
 
+
+
 class Item
   attr_reader :title, :image, :price, :location, :url
 
@@ -81,4 +105,3 @@ class Item
     @url      = args[:url]
   end
 end
-

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: craigslister
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Chris Scott
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-27 00:00:00.000000000 Z
+date: 2015-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -37,7 +37,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/craigslister.rb
-homepage: http://rubygems.org/gems/craigslister
+homepage: https://github.com/Yago580/craigslister
 licenses:
 - MIT
 metadata: {}