cpf_cnpj 0.3.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d13c9e2acfdc0d60eb9ffeb2c9008fdd6bad5d0f
-  data.tar.gz: bf59d4b1eb0c251086bc8d241b2811b61f7cefec
+  metadata.gz: 060f6cfefb56f74570849d75281ab0f5d00fe500
+  data.tar.gz: 52d7c441db65b19ce5175aa82c168a670e708f06
 SHA512:
-  metadata.gz: 778b36870ff6afc4ad0b4c5ba65aa148aef45ba8b8005c2e277808c5559d8e7b7ef4b8e06ff1036aef81b188ce765f5befea46901cbedf84e940a85d672755b2
-  data.tar.gz: c5a4bd47257e4afa53b44bbf514b17bb4c8b2b0726b8cb4157895f42184db1713201ace9c75550a0d566efb4bf65d9497479f1d134c678d5ffae36197177631b
+  metadata.gz: 21a524afa4993d82d12b1abe9ee15f957a786acf5ba89704dc5916f35946e475d50842ce40f78e56bd979c4ec66afdd90376da8d011b28e41e5203a31e8a5530
+  data.tar.gz: 9c25eb4c0c480eb29b040b8595d1b1a9b9e768f21dd689f4c24adc0b4f22be4051624013398a4259c400985c1f843e7a35859681409b0b3a9205f0f8f53866e5

data/.rubocop.yml

@@ -0,0 +1,59 @@
+AllCops:
+  TargetRubyVersion: 2.3
+
+  Include:
+    - '**/*.gemspec'
+    - '**/*.podspec'
+    - '**/*.jbuilder'
+    - '**/*.rake'
+    - '**/*.opal'
+    - '**/config.ru'
+    - '**/Gemfile'
+    - '**/Rakefile'
+    - '**/Capfile'
+    - '**/Guardfile'
+    - '**/Podfile'
+    - '**/Thorfile'
+    - '**/Vagrantfile'
+    - '**/Berksfile'
+    - '**/Cheffile'
+    - '**/Vagabondfile'
+
+Style/Documentation:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Layout/SpaceInsideBlockBraces:
+  EnforcedStyle: space
+  EnforcedStyleForEmptyBraces: space
+  SpaceBeforeBlockParameters: false
+
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+  EnforcedStyleForEmptyBraces: no_space
+
+Layout/FirstArrayElementLineBreak:
+  Enabled: true
+
+Layout/FirstHashElementLineBreak:
+  Enabled: true
+
+Style/SymbolArray:
+  Enabled: true
+
+Style/PercentLiteralDelimiters:
+  PreferredDelimiters:
+    '%':  '[]'
+    '%i': '[]'
+    '%q': '[]'
+    '%Q': '[]'
+    '%r': '[]'
+    '%s': '[]'
+    '%w': '[]'
+    '%W': '[]'
+    '%x': '[]'
+
+Metrics/LineLength:
+  Max: 100

data/.travis.yml

@@ -1,7 +1,8 @@
 language: ruby
 sudo: false
 cache: bundler
+notifications:
+  email: false
 rvm:
-  - '2.1.8'
-  - '2.2.3'
-  - '2.3.0'
+  - '2.4.2'
+  - '2.3.5'

data/Gemfile

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 source "http://rubygems.org"
 gemspec

data/Rakefile

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rake/testtask"
 
 Rake::TestTask.new(:test) do |t|
-  t.libs << 'test'
-  t.test_files = FileList['test/**/*_test.rb']
+  t.libs << "test"
+  t.test_files = FileList["test/**/*_test.rb"]
   t.verbose = true
   t.warning = false
 end
 
-task :default => :test
+task default: :test

data/bin/cnpj

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 $LOAD_PATH.unshift "#{__dir__}/../lib"
 require "cpf_cnpj"
 CpfCnpj::CLI.new(CNPJ, ARGV, STDIN, STDOUT, STDERR).start

data/bin/cpf

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 $LOAD_PATH.unshift "#{__dir__}/../lib"
 require "cpf_cnpj"
 CpfCnpj::CLI.new(CPF, ARGV, STDIN, STDOUT, STDERR).start

data/cpf_cnpj.gemspec

@@ -1,5 +1,6 @@
-# -*- encoding: utf-8 -*-
-require File.expand_path("../lib/cpf_cnpj/version", __FILE__)
+# frozen_string_literal: true
+
+require "./lib/cpf_cnpj/version"
 
 Gem::Specification.new do |gem|
   gem.authors       = ["Nando Vieira"]
@@ -7,9 +8,9 @@ Gem::Specification.new do |gem|
   gem.description   = "Validate, generate and format CPF/CNPJ numbers. Include command-line tools."
   gem.summary       = gem.description
 
-  gem.files         = `git ls-files`.split($\)
-  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
-  gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
+  gem.files         = `git ls-files`.split($OUTPUT_RECORD_SEPARATOR)
+  gem.executables   = gem.files.grep(%r[^bin/]).map {|f| File.basename(f) }
+  gem.test_files    = gem.files.grep(%r[^(test|spec|features)/])
   gem.name          = "cpf_cnpj"
   gem.require_paths = ["lib"]
   gem.version       = CPF::VERSION

data/lib/cnpj.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CNPJ
   require "cpf_cnpj"
   require "cnpj/formatter"
@@ -6,7 +8,8 @@ class CNPJ
   attr_reader :number
   attr_reader :strict
 
-  REGEX = /\A\d{2}\.\d{3}.\d{3}\/\d{4}-\d{2}\Z/
+  REGEX = %r[\A\d{2}\.\d{3}.\d{3}/\d{4}-\d{2}\Z]
+  VALIDATION_SIZE_REGEX = /^\d{14}$/
   NUMBER_SIZE = 12
 
   BLACKLIST = %w[
@@ -19,7 +22,7 @@ class CNPJ
     66666666666666
     77777777777777
     88888888888888
-    9999999999999
+    99999999999999
   ].freeze
 
   def self.valid?(number, strict: false)
@@ -53,7 +56,7 @@ class CNPJ
   end
 
   def valid?
-    return unless stripped.size == 14
+    return unless stripped =~ VALIDATION_SIZE_REGEX
     return if BLACKLIST.include?(stripped)
 
     digits = numbers[0...12]

data/lib/cnpj/formatter.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 class CNPJ
   class Formatter
-    STRICT_REGEX = /[\/.-]/
+    STRICT_REGEX = %r[[/.-]]
     LOOSE_REGEX = /[^\d]/
 
     def self.format(number)

data/lib/cnpj/verifier_digit.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 class CNPJ
   class VerifierDigit
     def self.generate(numbers)
       index = 2
 
-      sum = numbers.reverse.reduce(0) do |sum, number|
-        (sum + number * index).tap do
+      sum = numbers.reverse.reduce(0) do |buffer, number|
+        (buffer + number * index).tap do
           index = index == 9 ? 2 : index + 1
         end
       end

data/lib/cpf.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CPF
   require "cpf_cnpj"
   require "cpf/formatter"
@@ -7,6 +9,7 @@ class CPF
   attr_reader :strict
 
   REGEX = /\A\d{3}\.\d{3}\.\d{3}-\d{2}\Z/
+  VALIDATION_SIZE_REGEX = /^[0-9]{11}$/
   NUMBER_SIZE = 9
 
   BLACKLIST = %w[
@@ -21,6 +24,7 @@ class CPF
     88888888888
     99999999999
     12345678909
+    01234567890
   ].freeze
 
   def self.valid?(number, strict: false)
@@ -53,8 +57,8 @@ class CPF
     @formatted ||= Formatter.format(number)
   end
 
-  def valid?(strict: false)
-    return unless stripped.size == 11
+  def valid?
+    return unless stripped =~ VALIDATION_SIZE_REGEX
     return if BLACKLIST.include?(stripped)
 
     digits = numbers[0...9]

data/lib/cpf/formatter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CPF
   class Formatter
     STRICT_REGEX = /[.-]/

data/lib/cpf/verifier_digit.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CPF
   class VerifierDigit
     def self.generate(numbers)

data/lib/cpf_cnpj.rb

@@ -1,6 +1,9 @@
+# frozen_string_literal: true
+
 require "English"
 require "optparse"
 require "cpf_cnpj/generator"
 require "cpf_cnpj/cli"
+require "cpf_cnpj/version"
 require "cpf"
 require "cnpj"

data/lib/cpf_cnpj/cli.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module CpfCnpj
   class CLI
     attr_reader :document_class, :arguments, :stdin, :stdout, :stderr
@@ -18,9 +20,12 @@ module CpfCnpj
       document_class.name
     end
 
-    def start
-      options = {}
+    def options
+      @options ||= {}
+    end
 
+    # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+    def process_command
       opts.banner = "Usage: #{bin_name} [options] [#{document_name} number]"
       opts.separator ""
       opts.separator "Specific options:"
@@ -47,21 +52,27 @@ module CpfCnpj
       end
 
       opts.on_tail("-h", "--help", "Show help") do
-        help
-        exit
+        help(true)
       end
 
       opts.parse!(arguments)
       opts.permute!(arguments)
+    end
+    # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
+
+    def input
+      stdin.tty? ? arguments.first : stdin.read
+    end
 
-      help if options.empty?
-      generate(options) if options[:generate]
-      input = stdin.tty? ? arguments.first : stdin.read
+    def start
+      process_command
+      help
+      generate(options)
       document = document_class.new(input)
       validate(document)
-      format(document) if options[:format]
-      strip(document) if options[:strip]
-      check(document) if options[:check]
+      format(document)
+      strip(document)
+      check(document)
     end
 
     def validate(document)
@@ -76,28 +87,38 @@ module CpfCnpj
     end
 
     def generate(options)
+      return unless options[:generate]
+
       document = document_class.new(document_class.generate)
 
-      if options[:strip]
-        stdout << document.stripped
-      else
-        stdout << document.formatted
-      end
+      output =  if options[:strip]
+                  document.stripped
+                else
+                  document.formatted
+                end
+
+      stdout << output
 
       exit
     end
 
     def format(document)
+      return unless options[:format]
+
       stdout << document.formatted
       exit
     end
 
     def strip(document)
+      return unless options[:strip]
+
       stdout << document.stripped
       exit
     end
 
-    def help
+    def help(run = options.empty?)
+      return unless run
+
       stderr << opts.to_s
       exit 1
     end

data/lib/cpf_cnpj/generator.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module CpfCnpj
   class Generator
     NUMBERS = [*0..9].freeze
 
     def self.generate(size, verifier_digit_generator)
-      numbers = size.times.map { NUMBERS.sample }
+      numbers = Array.new(size) { NUMBERS.sample }
       numbers << verifier_digit_generator.generate(numbers)
       numbers << verifier_digit_generator.generate(numbers)
       numbers.join("")

data/lib/cpf_cnpj/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module CpfCnpj
-  VERSION = "0.3.0"
+  VERSION = "0.4.1"
 end
 
 class CPF

data/test/support/capture_syscall.rb

@@ -1,3 +1,7 @@
+# frozen_string_literal: true
+
+require "timeout"
+
 module CaptureSyscall
   def capture_syscall
     exit_status = nil

data/test/test_helper.rb

@@ -1,5 +1,6 @@
-require "bundler"
-Bundler.setup
+# frozen_string_literal: true
+
+require "bundler/setup"
 Bundler.require
 
 require "minitest/utils"

data/test/unit/cnpj/cli_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 
 module CNPJCli
@@ -84,7 +86,7 @@ module CNPJCli
       end
 
       assert_equal 0, exit_status
-      assert_match /\A\d{14}\Z/, stdout
+      assert_match(/\A\d{14}\Z/, stdout)
     end
   end
 

data/test/unit/cnpj/formatter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 
 class CNPJFormatterTest < Minitest::Test

data/test/unit/cnpj/generator_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 
 class CNPJGeneratorTest < Minitest::Test

data/test/unit/cnpj_test.rb

@@ -1,7 +1,10 @@
+# frozen_string_literal: true
+
 require "test_helper"
 
 class CnpjTest < Minitest::Test
   test "blacklists common numbers" do
+    refute CNPJ.valid?("00000000000000")
     refute CNPJ.valid?("11111111111111")
     refute CNPJ.valid?("22222222222222")
     refute CNPJ.valid?("33333333333333")
@@ -41,6 +44,14 @@ class CnpjTest < Minitest::Test
   end
 
   test "generates stripped number" do
-    assert_match /\A\d{14}\z/, CNPJ.generate
+    assert_match(/\A\d{14}\z/, CNPJ.generate)
+  end
+
+  test "rejects strings" do
+    refute CNPJ.valid?("aa.bb.ccc/dddd-ee")
+  end
+
+  test "rejects strings (strict)" do
+    refute CNPJ.valid?("aa.bb.ccc/dddd-ee", strict: true)
   end
 end

data/test/unit/cpf/cli_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 
 module CPFCli
@@ -54,7 +56,7 @@ module CPFCli
 
     %w[-v --version].each do |switch|
       test "outputs version [using #{switch}]" do
-        exit_status, stdout, stderr = capture_syscall do
+        exit_status, stdout, _stderr = capture_syscall do
           system "./bin/cpf #{switch}"
         end
 
@@ -84,7 +86,7 @@ module CPFCli
       end
 
       assert_equal 0, exit_status
-      assert_match /\A\d{11}\Z/, stdout
+      assert_match(/\A\d{11}\Z/, stdout)
     end
   end
 
@@ -103,8 +105,6 @@ module CPFCli
     end
 
     test "formats argument using stdin" do
-      stdin = StringIO.new("76616598837")
-
       exit_status, stdout = capture_syscall do
         system "echo 76616598837 | ./bin/cpf --format"
       end

data/test/unit/cpf/formatter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 
 class CPFFormatterTest < Minitest::Test

data/test/unit/cpf/generator_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 
 class CPFGeneratorTest < Minitest::Test

data/test/unit/cpf_test.rb

@@ -1,7 +1,10 @@
+# frozen_string_literal: true
+
 require "test_helper"
 
 class CpfTest < Minitest::Test
   test "blacklists common numbers" do
+    refute CPF.valid?("01234567890")
     refute CPF.valid?("11111111111")
     refute CPF.valid?("22222222222")
     refute CPF.valid?("33333333333")
@@ -18,6 +21,10 @@ class CpfTest < Minitest::Test
     refute CPF.valid?("")
   end
 
+  test "rejects strings" do
+    refute CPF.valid?("aaa.bbb.ccc-dd")
+  end
+
   test "rejects nil values" do
     refute CPF.valid?(nil)
   end
@@ -43,6 +50,10 @@ class CpfTest < Minitest::Test
     assert CPF.valid?("29537995593", strict: true)
   end
 
+  test "rejects strings (strict)" do
+    refute CPF.valid?("aaa.bbb.ccc-dd", strict: true)
+  end
+
   test "returns stripped number" do
     cpf = CPF.new("295.379.955-93")
     assert_equal "29537995593", cpf.stripped
@@ -54,11 +65,11 @@ class CpfTest < Minitest::Test
   end
 
   test "generates formatted number" do
-    assert_match /\A\d{3}\.\d{3}\.\d{3}-\d{2}\z/, CPF.generate(true)
+    assert_match(/\A\d{3}\.\d{3}\.\d{3}-\d{2}\z/, CPF.generate(true))
   end
 
   test "generates stripped number" do
-    assert_match /\A\d{11}\z/, CPF.generate
+    assert_match(/\A\d{11}\z/, CPF.generate)
   end
 
   test "invalidates memoization cache" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cpf_cnpj
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Nando Vieira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-01 00:00:00.000000000 Z
+date: 2017-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry-meta
@@ -63,6 +63,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE
@@ -110,7 +111,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Validate, generate and format CPF/CNPJ numbers. Include command-line tools.