RubyGems - cp-sparrow - Versions diffs - 0.0.14 → 0.0.15 - Mend

cp-sparrow 0.0.14 → 0.0.15

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (73) hide show

data/spec/integration/apps/rails_app/config/secrets.yml ADDED

@@ -0,0 +1,22 @@
+# Be sure to restart your server when you modify this file.
+# Your secret key is used for verifying the integrity of signed cookies.
+# If you change this key, all old signed cookies will become invalid!
+# Make sure the secret is at least 30 characters and all random,
+# no regular words or you'll be exposed to dictionary attacks.
+# You can use `rake secret` to generate a secure secret key.
+# Make sure the secrets in this file are kept private
+# if you're sharing your code publicly.
+development:
+  secret_key_base: 75dda1c248b28032a71bdc4492618eb696b43f9e8e0115f4f3d8bb603e3c26051e15aeaa3f0d11c71b35db060f4627766342b3a93a4cdcb10c38a5294e2d1885
+test:
+  secret_key_base: d29a85353762cd6ea8936982d8a62def1850ac37bdbb42305cac6cf987e40c4ea8a6353aa54906260334f055b88d863104f8d250b457e9846c7d4a81fc6f288b
+# Do not keep production secrets in the repository,
+# instead read values from the environment.
+production:
+  secret_key_base: <%= ENV["SECRET_KEY_BASE"] %>

data/spec/integration/apps/rails_app/lib/assets/.keep ADDED

File without changes

data/spec/integration/apps/rails_app/public/404.html CHANGED

@@ -2,25 +2,66 @@
 <html>
 <head>
   <title>The page you were looking for doesn't exist (404)</title>
-  <style type="text/css">
-    body { background-color: #fff; color: #666; text-align: center; font-family: arial, sans-serif; }
-    div.dialog {
-      width: 25em;
-      padding: 0 4em;
-      margin: 4em auto 0 auto;
-      border: 1px solid #ccc;
-      border-right-color: #999;
-      border-bottom-color: #999;
-    }
-    h1 { font-size: 100%; color: #f00; line-height: 1.5em; }
+  <meta name="viewport" content="width=device-width,initial-scale=1">
+  <style>
+  body {
+    background-color: #EFEFEF;
+    color: #2E2F30;
+    text-align: center;
+    font-family: arial, sans-serif;
+    margin: 0;
+  }
+  div.dialog {
+    width: 95%;
+    max-width: 33em;
+    margin: 4em auto 0;
+  }
+  div.dialog > div {
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-left-color: #999;
+    border-bottom-color: #BBB;
+    border-top: #B00100 solid 4px;
+    border-top-left-radius: 9px;
+    border-top-right-radius: 9px;
+    background-color: white;
+    padding: 7px 12% 0;
+    box-shadow: 0 3px 8px rgba(50, 50, 50, 0.17);
+  }
+  h1 {
+    font-size: 100%;
+    color: #730E15;
+    line-height: 1.5em;
+  }
+  div.dialog > p {
+    margin: 0 0 1em;
+    padding: 1em;
+    background-color: #F7F7F7;
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-left-color: #999;
+    border-bottom-color: #999;
+    border-bottom-left-radius: 4px;
+    border-bottom-right-radius: 4px;
+    border-top-color: #DADADA;
+    color: #666;
+    box-shadow: 0 3px 8px rgba(50, 50, 50, 0.17);
+  }
   </style>
 </head>
 <body>
   <!-- This file lives in public/404.html -->
   <div class="dialog">
-    <h1>The page you were looking for doesn't exist.</h1>
-    <p>You may have mistyped the address or the page may have moved.</p>
+    <div>
+      <h1>The page you were looking for doesn't exist.</h1>
+      <p>You may have mistyped the address or the page may have moved.</p>
+    </div>
+    <p>If you are the application owner check the logs for more information.</p>
   </div>
 </body>
 </html>

data/spec/integration/apps/rails_app/public/422.html CHANGED

@@ -2,25 +2,66 @@
 <html>
 <head>
   <title>The change you wanted was rejected (422)</title>
-  <style type="text/css">
-    body { background-color: #fff; color: #666; text-align: center; font-family: arial, sans-serif; }
-    div.dialog {
-      width: 25em;
-      padding: 0 4em;
-      margin: 4em auto 0 auto;
-      border: 1px solid #ccc;
-      border-right-color: #999;
-      border-bottom-color: #999;
-    }
-    h1 { font-size: 100%; color: #f00; line-height: 1.5em; }
+  <meta name="viewport" content="width=device-width,initial-scale=1">
+  <style>
+  body {
+    background-color: #EFEFEF;
+    color: #2E2F30;
+    text-align: center;
+    font-family: arial, sans-serif;
+    margin: 0;
+  }
+  div.dialog {
+    width: 95%;
+    max-width: 33em;
+    margin: 4em auto 0;
+  }
+  div.dialog > div {
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-left-color: #999;
+    border-bottom-color: #BBB;
+    border-top: #B00100 solid 4px;
+    border-top-left-radius: 9px;
+    border-top-right-radius: 9px;
+    background-color: white;
+    padding: 7px 12% 0;
+    box-shadow: 0 3px 8px rgba(50, 50, 50, 0.17);
+  }
+  h1 {
+    font-size: 100%;
+    color: #730E15;
+    line-height: 1.5em;
+  }
+  div.dialog > p {
+    margin: 0 0 1em;
+    padding: 1em;
+    background-color: #F7F7F7;
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-left-color: #999;
+    border-bottom-color: #999;
+    border-bottom-left-radius: 4px;
+    border-bottom-right-radius: 4px;
+    border-top-color: #DADADA;
+    color: #666;
+    box-shadow: 0 3px 8px rgba(50, 50, 50, 0.17);
+  }
   </style>
 </head>
 <body>
   <!-- This file lives in public/422.html -->
   <div class="dialog">
-    <h1>The change you wanted was rejected.</h1>
-    <p>Maybe you tried to change something you didn't have access to.</p>
+    <div>
+      <h1>The change you wanted was rejected.</h1>
+      <p>Maybe you tried to change something you didn't have access to.</p>
+    </div>
+    <p>If you are the application owner check the logs for more information.</p>
   </div>
 </body>
 </html>

data/spec/integration/apps/rails_app/public/500.html CHANGED

@@ -2,24 +2,65 @@
 <html>
 <head>
   <title>We're sorry, but something went wrong (500)</title>
-  <style type="text/css">
-    body { background-color: #fff; color: #666; text-align: center; font-family: arial, sans-serif; }
-    div.dialog {
-      width: 25em;
-      padding: 0 4em;
-      margin: 4em auto 0 auto;
-      border: 1px solid #ccc;
-      border-right-color: #999;
-      border-bottom-color: #999;
-    }
-    h1 { font-size: 100%; color: #f00; line-height: 1.5em; }
+  <meta name="viewport" content="width=device-width,initial-scale=1">
+  <style>
+  body {
+    background-color: #EFEFEF;
+    color: #2E2F30;
+    text-align: center;
+    font-family: arial, sans-serif;
+    margin: 0;
+  }
+  div.dialog {
+    width: 95%;
+    max-width: 33em;
+    margin: 4em auto 0;
+  }
+  div.dialog > div {
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-left-color: #999;
+    border-bottom-color: #BBB;
+    border-top: #B00100 solid 4px;
+    border-top-left-radius: 9px;
+    border-top-right-radius: 9px;
+    background-color: white;
+    padding: 7px 12% 0;
+    box-shadow: 0 3px 8px rgba(50, 50, 50, 0.17);
+  }
+  h1 {
+    font-size: 100%;
+    color: #730E15;
+    line-height: 1.5em;
+  }
+  div.dialog > p {
+    margin: 0 0 1em;
+    padding: 1em;
+    background-color: #F7F7F7;
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-left-color: #999;
+    border-bottom-color: #999;
+    border-bottom-left-radius: 4px;
+    border-bottom-right-radius: 4px;
+    border-top-color: #DADADA;
+    color: #666;
+    box-shadow: 0 3px 8px rgba(50, 50, 50, 0.17);
+  }
   </style>
 </head>
 <body>
   <!-- This file lives in public/500.html -->
   <div class="dialog">
-    <h1>We're sorry, but something went wrong.</h1>
+    <div>
+      <h1>We're sorry, but something went wrong.</h1>
+    </div>
+    <p>If you are the application owner check the logs for more information.</p>
   </div>
 </body>
 </html>

data/spec/integration/rack/camel_caser_spec.rb CHANGED

@@ -1,23 +1,23 @@
 require 'spec_helper'
 describe "camel caser middleware", type: :rack do
-  let(:json) do
-    MultiJson.dump({userName: "dsci", bar:{ lordFoo: 12 }})
+  let(:json) do
+    JSON.generate({userName: "dsci", bar:{ lordFoo: 12 }})
   end
-  context "accept header is given" do
-    before do
+  context "accept header is given" do
+    before do
       post '/', json, {'request-json-format' => 'underscore',
                        'response-json-format' => 'underscore'}
     end
-    subject do
-      MultiJson.load(last_response.body)
+    subject do
+      JSON.parse(last_response.body)
     end
-    it "converts lower camelcase to underscore params" do
+    it "converts lower camelcase to underscore params" do
       expect(subject).to have_key("keys")
       expect(subject["keys"]).to include("user_name")
       expect(subject["keys"]).to include("bar")
@@ -26,22 +26,22 @@ describe "camel caser middleware", type: :rack do
     end
   end
-  context "accept header is not given" do
-    before do
+  context "default behavior without manual configuration" do
+    before do
       post '/', json
     end
     subject do
-      MultiJson.load(last_response.body)
+      JSON.parse(last_response.body)
     end
-    it "did not convert lower camelcase to underscore params" do
+    it "converts incoming camelCase arguments to snake_case" do
       expect(subject).to have_key("keys")
-      expect(subject["keys"]).to include("userName")
+      expect(subject["keys"]).to include("user_name")
     end
-    it 'converted the snake case fake key to camelCase' do
+    it 'converted the snake case fake key to camelCase for the response' do
       expect(subject['fake_key']).to_not be_present
       expect(subject['fakeKey']).to eq false
     end

data/spec/integration/rack/error_spec.rb ADDED

@@ -0,0 +1,17 @@
+require 'spec_helper'
+describe 'the reactions when encountering error status', type: :rack do
+  context 'when encountering a server error' do
+    let(:json) { { error_code: 507 } }
+    before do
+      json_string = JSON.generate(json)
+      post '/error', json_string, {}
+    end
+    it 'delegates the error response without failing' do
+      expect(last_response.status).to eq json[:error_code]
+      expect(last_response.body).to be_present
+    end
+  end
+end

data/spec/integration/rails/camel_caser_accept_header_spec.rb CHANGED

@@ -9,7 +9,7 @@ describe "camel caser middleware for Rails", type: :rails do
       "DE"      => 'german'
     }
   end
-  let(:json) { MultiJson.dump(json_object) }
+  let(:json) { JSON.generate(json_object) }
     context "camel caser middleware for Rails with accept header " do
@@ -33,7 +33,7 @@ describe "camel caser middleware for Rails", type: :rails do
                                'CONTENT-TYPE'         => 'application/json',
                                'ACCEPT'               => 'text/html' }
-        last_json = MultiJson.load(last_response.body)
+        last_json = JSON.parse(last_response.body)
         expect(last_json['keys']).to include('userName')
         expect(last_json['keys']).to include('bar')
         expect(last_json['keys']).to include('DE')
@@ -46,7 +46,7 @@ describe "camel caser middleware for Rails", type: :rails do
                                'CONTENT-TYPE'         => 'application/json',
                                'ACCEPT'               => 'foo/bar, gate/protect' }
-        last_json = MultiJson.load(last_response.body)
+        last_json = JSON.parse(last_response.body)
         expect(last_json['keys']).to include('user_name')
         expect(last_json['keys']).to include('de')
       end

data/spec/integration/rails/camel_caser_spec.rb CHANGED

@@ -10,7 +10,7 @@ describe "camel caser middleware for Rails", type: :rails do
       "DE"      => 'german',
     }
   end
-  let(:json) { MultiJson.dump(json_object) }
+  let(:json) { JSON.generate(json_object) }
   context "accept header is given" do
@@ -21,7 +21,7 @@ describe "camel caser middleware for Rails", type: :rails do
                                'CONTENT-TYPE'         => 'application/json' }
       end
-      subject { MultiJson.load(last_response.body) }
+      subject { JSON.parse(last_response.body) }
       it "converts lower camelcase to underscore params" do
         expect(last_response).to be_successful
@@ -40,7 +40,7 @@ describe "camel caser middleware for Rails", type: :rails do
                                         'response-json-format' => 'underscore' }
         end
-        subject { MultiJson.load(last_response.body) }
+        subject { JSON.parse(last_response.body) }
         it 'should not touch the input keys and the response' do
           expect(subject).to have_key('camelCase')
@@ -161,7 +161,7 @@ describe "camel caser middleware for Rails", type: :rails do
               'CONTENT-TYPE'        => 'application/json'
             }
       end
-      subject { MultiJson.load(last_response.body) }
+      subject { JSON.parse(last_response.body) }
       it 'should return an array as root element' do
         expect(subject).to_not have_key("user_options")
@@ -180,18 +180,19 @@ describe "camel caser middleware for Rails", type: :rails do
       end
       subject do
-        MultiJson.load(last_response.body)
+        JSON.parse(last_response.body)
       end
-      it "did not convert lower camelcase to underscore params" do
+      it "converts incoming request parameters to snake_case" do
         expect(subject).to have_key("keys")
-        expect(subject["keys"]).to include("userName")
+        expect(subject["keys"]).to include("user_name")
       end
-      it "did not convert all UPPERCASE words to underscore params" do
+      # not touching UPPERCASE params only works for camelizing strategies
+      it "converts UPPERCASE params when using underscore strategy" do
         expect(subject).to have_key("keys")
-        expect(subject["keys"]).to include("DE")
+        expect(subject["keys"]).to include("de")
       end
     end
@@ -204,7 +205,7 @@ describe "camel caser middleware for Rails", type: :rails do
       end
       subject do
-        MultiJson.load(last_response.body)
+        JSON.parse(last_response.body)
       end
       it 'underscores the response' do
@@ -220,7 +221,7 @@ describe "camel caser middleware for Rails", type: :rails do
                                   'CONTENT-TYPE' => 'application/json; charset=utf-8'
                                 }
       end
-      subject { MultiJson.load(last_response.body) }
+      subject { JSON.parse(last_response.body) }
       it 'should return an array as root element' do
         expect(subject.class).to eq Array
@@ -230,7 +231,7 @@ describe "camel caser middleware for Rails", type: :rails do
     end
-    context 'reaction on error responses' do
+    describe 'the reaction on error responses' do
       require 'action_controller/metal/exceptions'
       it 'lets Rails do its RoutingError when the url is not found' do
         expect do
@@ -239,9 +240,18 @@ describe "camel caser middleware for Rails", type: :rails do
       end
       it 'does not touch the response if a server error gets triggered' do
-        expect {
+        expect do
           get '/error', {}, { 'CONTENT-TYPE' => 'application/json' }
-        }.to raise_error ZeroDivisionError
+        end.to raise_error ZeroDivisionError
+      end
+      it 'does not fail on 507 error' do
+        expect do
+          get '/error-507', {}, 'CONTENT-TYPE' => 'appliation/json',
+           'Accept' => 'application/json'
+        end.to_not raise_error
+        expect(last_response.status).to eq 507
+        expect(JSON.parse(last_response.body)).to eq({'error_code' => 507})
       end
     end
@@ -250,7 +260,7 @@ describe "camel caser middleware for Rails", type: :rails do
         get '/welcome', json_object, { 'CONTENT_TYPE'        => 'text/html',
                                        'request-json-format' => 'underscore' }
-        last_json = MultiJson.load(last_response.body)
+        last_json = JSON.parse(last_response.body)
         expect(last_json).to have_key 'fakeKey'
         expect(last_json).to have_key 'keys'
       end
@@ -264,7 +274,7 @@ describe "camel caser middleware for Rails", type: :rails do
                                'response-json-format' => 'underscore',
                                'CONTENT-TYPE'         => '' }
-        last_json = MultiJson.load(last_response.body)
+        last_json = JSON.parse(last_response.body)
         expect(last_json['keys']).to include('userName')
         expect(last_json['keys']).to include('DE')
       end
@@ -278,15 +288,16 @@ describe "camel caser middleware for Rails", type: :rails do
                                'response-json-format' => 'underscore',
                                'CONTENT_TYPE'         => ''}
-        last_json = MultiJson.load(last_response.body)
+        last_json = JSON.parse(last_response.body)
         expect(last_json['keys']).to include('user_name')
         expect(last_json['keys']).to include('bar')
         # at the moment the "let uppercase as it is"-option only works for
         # camelCase. This test implies that.
         expect(last_json['keys']).to include('de')
       end
       it 'processes everything if content-types configured contains nil and no content-type is sent' do
+        skip("Test is the same as above? Removal of content_type will fail the test.")
         Sparrow.configure do |config|
           config.allowed_content_types = [nil]
         end
@@ -295,7 +306,7 @@ describe "camel caser middleware for Rails", type: :rails do
                                'response-json-format' => 'underscore',
                                'CONTENT_TYPE'         => ''}
-        last_json = MultiJson.load(last_response.body)
+        last_json = JSON.parse(last_response.body)
         expect(last_json['keys']).to include('user_name')
         expect(last_json['keys']).to include('bar')
         # at the moment the "let uppercase as it is"-option only works for