coverband 6.2.1 → 6.2.2

data/test/coverband/reporters/web_test.rb

@@ -10,6 +10,39 @@ module Coverband
   class WebTest < Minitest::Test
     include Rack::Test::Methods
 
+    class FakeViewsTracker
+      REPORT_ROUTE = "views_tracker"
+      TITLE = "Views"
+
+      attr_reader :used_keys
+
+      def initialize(used_keys:)
+        @used_keys = used_keys
+      end
+
+      def route
+        REPORT_ROUTE
+      end
+
+      def title
+        TITLE
+      end
+
+      def unused_keys
+        []
+      end
+
+      def tracking_since
+        "N/A"
+      end
+
+      def clear_key!(_key)
+      end
+
+      def reset_recordings
+      end
+    end
+
     def app
       Coverband::Reporters::Web.new
     end
@@ -55,6 +88,40 @@ module Coverband
       get "/unknown.js"
       assert last_response.not_found?
     end
+
+    test "views tracker defaults to sorting used keys by last activity" do
+      tracker = FakeViewsTracker.new(
+        used_keys: {
+          "app/views/a_first.html.erb" => "100",
+          "app/views/z_latest.html.erb" => "200"
+        }
+      )
+
+      Coverband.configuration.trackers = [tracker]
+      get "/views_tracker"
+
+      assert last_response.ok?
+      first_index = last_response.body.index("app/views/a_first.html.erb")
+      latest_index = last_response.body.index("app/views/z_latest.html.erb")
+      assert latest_index < first_index
+    end
+
+    test "views tracker supports alpha sort toggle" do
+      tracker = FakeViewsTracker.new(
+        used_keys: {
+          "app/views/z_latest.html.erb" => "200",
+          "app/views/a_first.html.erb" => "100"
+        }
+      )
+
+      Coverband.configuration.trackers = [tracker]
+      get "/views_tracker?used_sort=alpha"
+
+      assert last_response.ok?
+      first_index = last_response.body.index("app/views/a_first.html.erb")
+      latest_index = last_response.body.index("app/views/z_latest.html.erb")
+      assert first_index < latest_index
+    end
   end
 end
 

data/test/coverband/track_key_test.rb

@@ -51,6 +51,15 @@ class TrackKeyTest < Minitest::Test
     assert Coverband.track_key(:routes_tracker, "index#show")
   end
 
+  test "track_key with query_burst_tracker" do
+    mock_query_burst_tracker = mock
+    payload = {key: "controller:users#index", queries: 42, sql_time_ms: 155.2}
+    mock_query_burst_tracker.expects(:track_key).with(payload).returns(true)
+    Coverband.configuration.expects(:query_burst_tracker).returns(mock_query_burst_tracker)
+
+    assert Coverband.track_key(:query_burst_tracker, payload)
+  end
+
   test "track_key logs error when tracking fails" do
     mock_logger = mock
     mock_logger.expects(:error).with(regexp_matches(/Failed to track key/))

data/test/forked/rails_route_tracker_stack_test.rb

@@ -38,7 +38,7 @@ class RailsRoutesWithoutConfigStackTest < Minitest::Test
   def shutdown_server
     if File.exist?("/tmp/testrack.pid")
       pid = `cat /tmp/testrack.pid`&.strip&.to_i
-      Process.kill("HUP", pid)
+      Process.kill("TERM", pid)
       sleep 1
     end
   end

data/test/forked/rails_view_tracker_stack_test.rb

@@ -37,7 +37,7 @@ class RailsWithoutConfigStackTest < Minitest::Test
   def shutdown_server
     if File.exist?("/tmp/testrack.pid")
       pid = `cat /tmp/testrack.pid`&.strip&.to_i
-      Process.kill("HUP", pid)
+      Process.kill("TERM", pid)
       sleep 1
     end
   end

data/test/javascript/dead_code_session.test.mjs

@@ -0,0 +1,123 @@
+import { test } from "node:test";
+import assert from "node:assert/strict";
+import { createRequire } from "node:module";
+const require = createRequire(import.meta.url);
+const D = require("../../public/dead_code_session.js");
+
+test("parseState returns empty state on garbage", () => {
+  assert.deepEqual(D.parseState(null), D.emptyState());
+  assert.deepEqual(D.parseState("{not json"), D.emptyState());
+  assert.deepEqual(D.parseState('{"hiddenPaths": "nope"}').hiddenPaths, []);
+});
+
+test("parseState keeps valid entries and normalizes marks", () => {
+  const s = D.parseState(JSON.stringify({
+    hiddenPaths: ["app/", 5, "lib/foo.rb"],
+    markedPaths: [{ path: "old/" }, { nope: true }],
+    hideRuntimeUsed: true
+  }));
+  assert.deepEqual(s.hiddenPaths, ["app/", "lib/foo.rb"]);
+  assert.deepEqual(s.markedPaths, [{ path: "old/", comment: "", markedAt: "" }]);
+  assert.equal(s.hideRuntimeUsed, true);
+});
+
+test("pathMatches: folder prefix vs exact file", () => {
+  assert.ok(D.pathMatches("app/models/", "app/models/foo.rb"));
+  assert.ok(!D.pathMatches("app/models/", "app/models2/foo.rb"));
+  assert.ok(D.pathMatches("app/foo.rb", "app/foo.rb"));
+  assert.ok(!D.pathMatches("app/foo.rb", "app/foo.rb.bak"));
+});
+
+test("isExcluded combines hides, marks, and runtime rule", () => {
+  const s = D.emptyState();
+  D.addHidden(s, "app/hidden/");
+  D.addMark(s, "lib/dead.rb", "bye", "2026-08-07T00:00:00Z");
+  assert.ok(D.isExcluded(s, "app/hidden/x.rb", 0));
+  assert.ok(D.isExcluded(s, "lib/dead.rb", 0));
+  assert.ok(!D.isExcluded(s, "app/live.rb", 12.5));
+  s.hideRuntimeUsed = true;
+  assert.ok(D.isExcluded(s, "app/live.rb", 12.5));
+  assert.ok(!D.isExcluded(s, "app/unused.rb", 0));
+  assert.ok(!D.isExcluded(s, "app/unknown.rb", null));
+});
+
+test("addHidden dedupes; removeHidden removes; clearHides resets toggle", () => {
+  const s = D.emptyState();
+  D.addHidden(s, "app/");
+  D.addHidden(s, "app/");
+  assert.deepEqual(s.hiddenPaths, ["app/"]);
+  D.removeHidden(s, "app/");
+  assert.deepEqual(s.hiddenPaths, []);
+  s.hideRuntimeUsed = true;
+  D.addHidden(s, "x.rb");
+  D.clearHides(s);
+  assert.deepEqual(s.hiddenPaths, []);
+  assert.equal(s.hideRuntimeUsed, false);
+});
+
+test("addMark replaces same path; updateComment; removeMark; clearMarks", () => {
+  const s = D.emptyState();
+  D.addMark(s, "a.rb", "one", "t1");
+  D.addMark(s, "a.rb", "two", "t2");
+  assert.deepEqual(s.markedPaths, [{ path: "a.rb", comment: "two", markedAt: "t2" }]);
+  D.updateComment(s, "a.rb", "three");
+  assert.equal(s.markedPaths[0].comment, "three");
+  D.removeMark(s, "a.rb");
+  assert.deepEqual(s.markedPaths, []);
+  D.addMark(s, "b.rb", "", "t");
+  D.clearMarks(s);
+  assert.deepEqual(s.markedPaths, []);
+});
+
+test("toCSV escapes per RFC 4180", () => {
+  const csv = D.toCSV([
+    { path: "app/a.rb", comment: 'has "quotes", commas\nand newline', markedAt: "2026-08-07T01:02:03Z" },
+    { path: "lib/", comment: "", markedAt: "" }
+  ]);
+  assert.equal(csv,
+    'path,comment,marked_at\r\n' +
+    'app/a.rb,"has ""quotes"", commas\nand newline",2026-08-07T01:02:03Z\r\n' +
+    'lib/,,\r\n');
+});
+
+test("segmentPrefixes splits path into cumulative prefixes", () => {
+  assert.deepEqual(D.segmentPrefixes("app/models/foo.rb"), [
+    { label: "app", prefix: "app/", isFile: false },
+    { label: "models", prefix: "app/models/", isFile: false },
+    { label: "foo.rb", prefix: "app/models/foo.rb", isFile: true }
+  ]);
+  assert.deepEqual(D.segmentPrefixes("foo.rb"), [{ label: "foo.rb", prefix: "foo.rb", isFile: true }]);
+});
+
+test("isExcludedIgnoringMarks applies hides and runtime rule but never marks", () => {
+  const s = D.emptyState();
+  D.addHidden(s, "app/hidden/");
+  D.addMark(s, "lib/dead.rb", "bye", "2026-08-07T00:00:00Z");
+  assert.ok(D.isExcludedIgnoringMarks(s, "app/hidden/x.rb", 0));
+  assert.ok(!D.isExcludedIgnoringMarks(s, "lib/dead.rb", 0), "marks alone must not exclude");
+  s.hideRuntimeUsed = true;
+  assert.ok(D.isExcludedIgnoringMarks(s, "app/live.rb", 12.5));
+  assert.ok(!D.isExcludedIgnoringMarks(s, "app/unused.rb", 0));
+});
+
+test("extractPath pulls the title attribute out of a rendered cell", () => {
+  assert.equal(D.extractPath('<a class="src_link" title="app/models/foo.rb">foo.rb</a>'), "app/models/foo.rb");
+  assert.equal(D.extractPath("<span>no title here</span>"), "");
+  assert.equal(D.extractPath(42), "");
+});
+
+test("rowRuntime parses the runtime column, null when not numeric", () => {
+  assert.equal(D.rowRuntime(["path", "link", "12.5"]), 12.5);
+  assert.equal(D.rowRuntime(["path", "link", "0"]), 0);
+  assert.equal(D.rowRuntime(["path", "link", "-"]), null);
+  assert.equal(D.rowRuntime(["path", "link", undefined]), null);
+});
+
+test("escapeHtml escapes the five HTML-significant characters", () => {
+  assert.equal(D.escapeHtml('<b>"Tom" & Jerry</b>'), "&lt;b&gt;&quot;Tom&quot; &amp; Jerry&lt;/b&gt;");
+  assert.equal(D.escapeHtml("plain"), "plain");
+});
+
+test("csvFilename embeds the ISO date", () => {
+  assert.equal(D.csvFilename(new Date("2026-08-07T15:04:05Z")), "coverband-dead-code-2026-08-07.csv");
+});

data/views/abstract_tracker.erb

@@ -27,9 +27,23 @@
         </ul>
 
         <h2>Used <%= tracker.title %>: (<%= tracker.used_keys.length %>)</h2>
-        <p>These <%= tracker.title %> have been rendered at least once</p>
+        <p>
+          These <%= tracker.title %> have been rendered at least once.
+          Sort:
+          <% if used_keys_sort == "last_active" %>
+            <strong>Last Active</strong>
+          <% else %>
+            <a href='<%= "#{base_path}/#{tracker.route}?used_sort=last_active" %>'>Last Active</a>
+          <% end %>
+          |
+          <% if used_keys_sort == "alpha" %>
+            <strong>Alphabetical</strong>
+          <% else %>
+            <a href='<%= "#{base_path}/#{tracker.route}?used_sort=alpha" %>'>Alphabetical</a>
+          <% end %>
+        </p>
         <ul>
-        <% tracker.used_keys.each_pair do |key, time_at| %>
+        <% (sorted_used_keys || tracker.used_keys).each_pair do |key, time_at| %>
           <li class="used-keys">
             <%= key %>
             <span class="last_seen_at">last activity recorded <%= Time.at(time_at.to_i)%></span>
@@ -39,6 +53,39 @@
           </li>
         <% end %>
         </ul>
+
+        <% if tracker.respond_to?(:used_key_stats) %>
+          <% key_stats = tracker.used_key_stats %>
+          <% if key_stats.any? %>
+            <h3><%= tracker.title %> Stats</h3>
+            <table class="file_list sorted">
+              <thead>
+                <tr>
+                  <th>Key</th>
+                  <th>Requests</th>
+                  <th>Total SQL Calls</th>
+                  <th>Total SQL ms</th>
+                  <th>Max SQL Calls</th>
+                  <th>Max SQL ms</th>
+                  <th>Threshold Hits</th>
+                </tr>
+              </thead>
+              <tbody>
+                <% key_stats.each_pair do |key, stats| %>
+                  <tr>
+                    <td><%= key %></td>
+                    <td><%= stats["requests"].to_i %></td>
+                    <td><%= stats["total_queries"].to_i %></td>
+                    <td><%= stats["total_sql_time_ms"].to_f.round(2) %></td>
+                    <td><%= stats["max_queries"].to_i %></td>
+                    <td><%= stats["max_sql_time_ms"].to_f.round(2) %></td>
+                    <td><%= stats["threshold_hits"].to_i %></td>
+                  </tr>
+                <% end %>
+              </tbody>
+            </table>
+          <% end %>
+        <% end %>
       </div>
       <div id="footer">
         Generated by <a href="http://github.com/danmayer/coverband">Coverband</a> v<%= Coverband::VERSION %>

data/views/layout.erb

@@ -4,6 +4,7 @@
     <title>Coverband: <%= Coverband::VERSION %></title>
     <meta http-equiv="content-type" content="text/html; charset=utf-8" />
     <script src='<%= assets_path('dependencies.js') %>' type='text/javascript'></script>
+    <script src='<%= assets_path('dead_code_session.js') %>' type='text/javascript'></script>
     <script src='<%= assets_path('application.js') %>' type='text/javascript'></script>
     <link href='<%= assets_path('application.css') %>' media='screen, projection, print' rel='stylesheet' type='text/css'>
     <link rel="shortcut icon" type="image/png" href="<%= assets_path("favicon_#{coverage_css_class(result.source_files.covered_percent)}.png") %>" />

data/views/nav.erb

@@ -37,6 +37,11 @@
     <li class='<%= nav_options[:active_link] == 'routes_tracker' ? 'active' : '' %>'>
       <a href='<%= base_path %>routes_tracker'>Route Tracker</a>
     </li>
+  <% end %>
+  <% if Coverband.configuration.track_query_bursts %>
+    <li class='<%= nav_options[:active_link] == 'query_bursts_tracker' ? 'active' : '' %>'>
+      <a href='<%= base_path %>query_bursts_tracker'>Query Burst Tracker</a>
+    </li>
   <% end %>
     <% if Coverband.configuration.track_translations %>
     <li class='<%= nav_options[:active_link] == 'translations_tracker' ? 'active' : '' %>'>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 6.2.1
+  version: 6.2.2
 platform: ruby
 authors:
 - Dan Mayer
@@ -365,6 +365,7 @@ files:
 - lib/coverband/collectors/abstract_tracker.rb
 - lib/coverband/collectors/coverage.rb
 - lib/coverband/collectors/delta.rb
+- lib/coverband/collectors/query_burst_tracker.rb
 - lib/coverband/collectors/route_tracker.rb
 - lib/coverband/collectors/translation_tracker.rb
 - lib/coverband/collectors/view_tracker.rb
@@ -421,6 +422,7 @@ files:
 - public/colorbox/controls.png
 - public/colorbox/loading.gif
 - public/colorbox/loading_background.png
+- public/dead_code_session.js
 - public/dependencies.js
 - public/favicon.png
 - public/favicon_green.png
@@ -461,8 +463,10 @@ files:
 - test/coverband/adapters/redis_store_test.rb
 - test/coverband/adapters/web_service_store_test.rb
 - test/coverband/at_exit_test.rb
+- test/coverband/benchmarks/benchmark_memory_leak_check_test.rb
 - test/coverband/collectors/coverage_test.rb
 - test/coverband/collectors/delta_test.rb
+- test/coverband/collectors/query_burst_tracker_test.rb
 - test/coverband/collectors/route_tracker_test.rb
 - test/coverband/collectors/translation_tracker_test.rb
 - test/coverband/collectors/view_tracker_test.rb
@@ -528,6 +532,7 @@ files:
 - test/integration/full_stack_send_deferred_eager_test.rb
 - test/integration/full_stack_test.rb
 - test/integration/mcp_integration_test.rb
+- test/javascript/dead_code_session.test.mjs
 - test/jruby_check.rb
 - test/rails7_dummy/Rakefile
 - test/rails7_dummy/app/controllers/dummy_controller.rb