coverband 6.1.4 → 6.1.5

data/test/coverband/track_key_test.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+require File.expand_path("../test_helper", File.dirname(__FILE__))
+
+class TrackKeyTest < Minitest::Test
+  test "track_key accepts supported tracker types" do
+    mock_view_tracker = mock
+    mock_view_tracker.expects(:track_key).with("view/path/index.html.erb").returns(true)
+    Coverband.configuration.expects(:view_tracker).returns(mock_view_tracker)
+    
+    assert Coverband.track_key(:view_tracker, "view/path/index.html.erb")
+  end
+
+  test "track_key raises ArgumentError for unsupported tracker type" do
+    assert_raises ArgumentError do
+      Coverband.track_key(:unsupported_tracker, "some_key")
+    end
+  end
+
+  test "track_key returns false for nil key" do
+    assert_equal false, Coverband.track_key(:view_tracker, nil)
+  end
+
+  test "track_key handles missing trackers" do
+    Coverband.configuration.expects(:view_tracker).returns(nil)
+    
+    assert_equal false, Coverband.track_key(:view_tracker, "some_view")
+  end
+
+  test "track_key handles trackers without track_key method" do
+    mock_invalid_tracker = mock
+    mock_invalid_tracker.expects(:respond_to?).with(:track_key).returns(false)
+    Coverband.configuration.expects(:view_tracker).returns(mock_invalid_tracker)
+    
+    assert_equal false, Coverband.track_key(:view_tracker, "some_view")
+  end
+
+  test "track_key with translations_tracker" do
+    mock_translations_tracker = mock
+    mock_translations_tracker.expects(:track_key).with("translation.key").returns(true)
+    Coverband.configuration.expects(:translations_tracker).returns(mock_translations_tracker)
+    
+    assert Coverband.track_key(:translations_tracker, "translation.key")
+  end
+
+  test "track_key with routes_tracker" do
+    mock_routes_tracker = mock
+    mock_routes_tracker.expects(:track_key).with("index#show").returns(true)
+    Coverband.configuration.expects(:routes_tracker).returns(mock_routes_tracker)
+    
+    assert Coverband.track_key(:routes_tracker, "index#show")
+  end
+
+  test "track_key logs error when tracking fails" do
+    mock_logger = mock
+    mock_logger.expects(:error).with(regexp_matches(/Failed to track key/))
+    
+    mock_tracker = mock
+    mock_tracker.expects(:track_key).with("test_key").raises(StandardError.new("Test error"))
+    
+    Coverband.configuration.expects(:translations_tracker).returns(mock_tracker)
+    Coverband.configuration.expects(:logger).returns(mock_logger)
+    
+    assert_equal false, Coverband.track_key(:translations_tracker, "test_key")
+  end
+end

data/test/coverband/utils/dead_methods_test.rb

@@ -16,7 +16,7 @@ if defined?(RubyVM::AbstractSyntaxTree)
 
         def test_dog_dead_methods
           file_path = require_unique_file
-          coverage = [nil, nil, 1, 1, 0, nil, nil]
+          coverage = [nil, nil, 1, 1, 0, nil, nil, 1, nil, 1, nil, nil]
           dead_methods =
             DeadMethods.scan(file_path: file_path, coverage: coverage)
           assert_equal(1, dead_methods.length)
@@ -36,6 +36,18 @@ if defined?(RubyVM::AbstractSyntaxTree)
           assert_equal(6, dead_method.last_line_number)
         end
 
+        def test_all_dead_methods_on_runtime
+          @coverband.eager_loading!
+          require_unique_file
+          @coverband.report_coverage
+          @coverband.runtime!
+          dead_methods = DeadMethods.scan_all
+          dead_method = dead_methods.find { |method| method.class_name == :Dog }
+          assert(dead_method)
+          assert_equal(4, dead_method.first_line_number)
+          assert_equal(6, dead_method.last_line_number)
+        end
+
         def test_output_all
           require_unique_file
           @coverband.report_coverage
@@ -44,7 +56,7 @@ if defined?(RubyVM::AbstractSyntaxTree)
 
         def test_dog_methods_not_dead
           file = require_unique_file
-          coverage = [nil, nil, 1, 1, 1, nil, nil]
+          coverage = [nil, nil, 1, 1, 1, nil, nil, 1, nil, 1, nil, nil]
           assert_empty(DeadMethods.scan(file_path: file, coverage: coverage))
         end
       end

data/test/coverband/utils/method_definition_scanner_test.rb

@@ -40,7 +40,7 @@ if defined?(RubyVM::AbstractSyntaxTree)
         def test_scan
           method_definitions = MethodDefinitionScanner.scan("./test/dog.rb")
           assert(method_definitions)
-          assert_equal(1, method_definitions.length)
+          assert_equal(3, method_definitions.length)
           method_definition = method_definitions.first # assert_equal(4, method.first_line)
           assert_equal(4, method_definition.first_line_number)
           assert_equal(6, method_definition.last_line_number)

data/test/dog.rb

@@ -4,4 +4,9 @@ class Dog
   def bark
     "woof"
   end
+
+  def single_line; end # rubocop:disable Style
+
+  def empty
+  end
 end

data/test/forked/rails_full_stack_views_test.rb

@@ -33,7 +33,7 @@ class RailsFullStackTest < Minitest::Test
 
     visit "/coverage/routes_tracker"
     assert_content("Used Routes: (1)")
-    assert_content("Unused Routes: (5)")
+    assert_content("Unused Routes: (4)")
 
     visit "/dummy_view/show_haml"
     assert_content("I am haml text")

data/test/rails7_dummy/config/coverband.rb

@@ -1,3 +1,15 @@
 # frozen_string_literal: true
 
-require_relative "../../rails5_dummy/config/coverband"
+Coverband.configure do |config|
+  # NOTE: we reuse this config in each of the fake rails projects
+  # the below ensures the root is set to the correct fake project
+  config.root = ::File.expand_path("../../../", __FILE__).to_s + "/rails#{Rails::VERSION::MAJOR}_dummy"
+  config.store = Coverband::Adapters::RedisStore.new(Redis.new(db: 2, url: ENV["REDIS_URL"]), redis_namespace: "coverband_test") if defined? Redis
+  config.ignore = %w[.erb$ .slim$]
+  config.root_paths = []
+  config.logger = Rails.logger
+  config.verbose = true
+  config.background_reporting_enabled = true
+  config.track_routes = true
+  config.use_oneshot_lines_coverage = true if ENV["ONESHOT"]
+end

data/test/rails7_dummy/config/coverband_missing_redis.rb

@@ -1,3 +1,14 @@
 # frozen_string_literal: true
 
-require_relative "../../rails5_dummy/config/coverband_missing_redis"
+Coverband.configure do |config|
+  config.root = Dir.pwd
+  config.store = Coverband::Adapters::RedisStore.new(Redis.new(db: 2, url: "redis://127.0.0.1:123"), redis_namespace: "coverband_test") if defined? Redis
+  config.ignore = %w[vendor .erb$ .slim$]
+  config.root_paths = []
+  config.logger = Rails.logger
+  config.verbose = true
+  config.background_reporting_enabled = true
+  config.track_gems = true
+  config.gem_details = true
+  config.use_oneshot_lines_coverage = true if ENV["ONESHOT"]
+end

data/test/rails8_dummy/config/coverband.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+require_relative "../../rails7_dummy/config/coverband"

data/test/rails8_dummy/config/coverband_missing_redis.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+require_relative "../../rails7_dummy/config/coverband_missing_redis"

data/test/rails8_dummy/tmp/local_secret.txt

@@ -0,0 +1 @@
+c5de6abbe8f20a9a3ed005913ceb885dfc18906657583137cb54a4ac99f44be4104653f3d8b3385ae2e4099b84bb5910691d984f10e45228abaada5d7368da78

data/test/test_helper.rb

@@ -5,9 +5,7 @@ require "bigdecimal"
 original_verbosity = $VERBOSE
 $VERBOSE = nil
 
-if ENV["SKIP_SIMPLECOV"] || BigDecimal(RUBY_VERSION[0, 3]) >= BigDecimal("3.1")
-  $SKIP_SIMPLECOV = true
-end
+$SKIP_SIMPLECOV = true
 
 require "rubygems"
 
@@ -19,7 +17,6 @@ end
 require "minitest/autorun"
 require "minitest/stub_const"
 require "mocha/minitest"
-require "ostruct"
 require "json"
 require "redis"
 require "resque"

data/test/unique_files.rb

@@ -3,7 +3,6 @@
 require "securerandom"
 require "fileutils"
 require "erb"
-require "ostruct"
 
 UNIQUE_FILES_DIR = "./test/unique_files"
 
@@ -14,7 +13,12 @@ def require_unique_file(file = "dog.rb", variables = {})
   temp_file = "#{dir}/#{file_name}"
   FileUtils.mkdir_p(Pathname.new(temp_file).dirname.to_s)
   file_contents = File.read("./test/#{file}")
-  file_contents = ERB.new(file_contents).result(OpenStruct.new(variables).instance_eval { binding }) if variables.any?
+  if variables.any?
+    # Create a binding with the variables defined
+    b = binding
+    variables.each { |key, value| b.local_variable_set(key, value) }
+    file_contents = ERB.new(file_contents).result(b)
+  end
   File.write(temp_file, file_contents)
   require temp_file
   Coverband::Utils::RelativeFileConverter.convert(File.expand_path(temp_file))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 6.1.4
+  version: 6.1.5
 platform: ruby
 authors:
 - Dan Mayer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-10-19 00:00:00.000000000 Z
+date: 2025-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
@@ -277,6 +277,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: base64
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Rack middleware to measure production code usage (LOC runtime usage)
 email:
 - dan@mayerdan.com
@@ -296,11 +310,10 @@ files:
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
 - Gemfile
-- Gemfile.rails6.0
-- Gemfile.rails6.1
-- Gemfile.rails7
 - Gemfile.rails7.0
 - Gemfile.rails7.1
+- Gemfile.rails7.2
+- Gemfile.rails8.0
 - LICENSE
 - README.md
 - Rakefile
@@ -421,6 +434,7 @@ files:
 - test/coverband/reporters/html_test.rb
 - test/coverband/reporters/json_test.rb
 - test/coverband/reporters/web_test.rb
+- test/coverband/track_key_test.rb
 - test/coverband/utils/absolute_file_converter_test.rb
 - test/coverband/utils/dead_methods_test.rb
 - test/coverband/utils/file_hasher_test.rb
@@ -453,49 +467,6 @@ files:
 - test/integration/full_stack_send_deferred_eager_test.rb
 - test/integration/full_stack_test.rb
 - test/jruby_check.rb
-- test/rails4_dummy/Rakefile
-- test/rails4_dummy/app/controllers/dummy_controller.rb
-- test/rails4_dummy/app/controllers/dummy_view_controller.rb
-- test/rails4_dummy/app/views/dummy_view/show.html.erb
-- test/rails4_dummy/app/views/dummy_view/show_haml.html.haml
-- test/rails4_dummy/app/views/dummy_view/show_slim.html.slim
-- test/rails4_dummy/config.ru
-- test/rails4_dummy/config/application.rb
-- test/rails4_dummy/config/boot.rb
-- test/rails4_dummy/config/coverband.rb
-- test/rails4_dummy/config/coverband_missing_redis.rb
-- test/rails4_dummy/config/environment.rb
-- test/rails4_dummy/config/routes.rb
-- test/rails4_dummy/config/secrets.yml
-- test/rails4_dummy/tmp/.keep
-- test/rails5_dummy/Rakefile
-- test/rails5_dummy/app/controllers/dummy_controller.rb
-- test/rails5_dummy/app/controllers/dummy_view_controller.rb
-- test/rails5_dummy/app/views/dummy_view/show.html.erb
-- test/rails5_dummy/app/views/dummy_view/show_haml.html.haml
-- test/rails5_dummy/app/views/dummy_view/show_slim.html.slim
-- test/rails5_dummy/config.ru
-- test/rails5_dummy/config/application.rb
-- test/rails5_dummy/config/coverband.rb
-- test/rails5_dummy/config/coverband_missing_redis.rb
-- test/rails5_dummy/config/environment.rb
-- test/rails5_dummy/config/routes.rb
-- test/rails5_dummy/tmp/.keep
-- test/rails6_dummy/Rakefile
-- test/rails6_dummy/app/controllers/dummy_controller.rb
-- test/rails6_dummy/app/controllers/dummy_view_controller.rb
-- test/rails6_dummy/app/views/dummy_view/show.html.erb
-- test/rails6_dummy/app/views/dummy_view/show_haml.html.haml
-- test/rails6_dummy/app/views/dummy_view/show_slim.html.slim
-- test/rails6_dummy/config.ru
-- test/rails6_dummy/config/application.rb
-- test/rails6_dummy/config/boot.rb
-- test/rails6_dummy/config/coverband.rb
-- test/rails6_dummy/config/coverband_missing_redis.rb
-- test/rails6_dummy/config/environment.rb
-- test/rails6_dummy/config/routes.rb
-- test/rails6_dummy/config/secrets.yml
-- test/rails6_dummy/tmp/.keep
 - test/rails7_dummy/Rakefile
 - test/rails7_dummy/app/controllers/dummy_controller.rb
 - test/rails7_dummy/app/controllers/dummy_view_controller.rb
@@ -511,6 +482,22 @@ files:
 - test/rails7_dummy/config/routes.rb
 - test/rails7_dummy/config/secrets.yml
 - test/rails7_dummy/tmp/.keep
+- test/rails8_dummy/Rakefile
+- test/rails8_dummy/app/controllers/dummy_controller.rb
+- test/rails8_dummy/app/controllers/dummy_view_controller.rb
+- test/rails8_dummy/app/views/dummy_view/show.html.erb
+- test/rails8_dummy/app/views/dummy_view/show_haml.html.haml
+- test/rails8_dummy/app/views/dummy_view/show_slim.html.slim
+- test/rails8_dummy/config.ru
+- test/rails8_dummy/config/application.rb
+- test/rails8_dummy/config/boot.rb
+- test/rails8_dummy/config/coverband.rb
+- test/rails8_dummy/config/coverband_missing_redis.rb
+- test/rails8_dummy/config/environment.rb
+- test/rails8_dummy/config/routes.rb
+- test/rails8_dummy/config/secrets.yml
+- test/rails8_dummy/tmp/.keep
+- test/rails8_dummy/tmp/local_secret.txt
 - test/rails_test_helper.rb
 - test/test_helper.rb
 - test/unique_files.rb
@@ -538,7 +525,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/Gemfile.rails6.1

@@ -1,10 +0,0 @@
-# frozen_string_literal: true
-
-source "https://rubygems.org"
-
-# Specify your gem's dependencies in coverband.gemspec
-gemspec
-gem "rails", "~>6.1.0"
-gem "haml"
-gem "slim"
-gem "webrick"

data/test/rails4_dummy/config/application.rb

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-require File.expand_path("boot", __dir__)
-
-require "rails"
-require "action_controller/railtie"
-require "coverband"
-Bundler.require(*Rails.groups)
-
-module Rails4Dummy
-  class Application < Rails::Application
-    config.eager_load = true
-    config.consider_all_requests_local = true
-  end
-end

data/test/rails4_dummy/config/coverband.rb

@@ -1,3 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../../rails5_dummy/config/coverband"

data/test/rails4_dummy/config/coverband_missing_redis.rb

@@ -1,3 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../../rails5_dummy/config/coverband_missing_redis"

data/test/rails5_dummy/Rakefile

@@ -1,6 +0,0 @@
-# Add your own tasks in files placed in lib/tasks ending in .rake,
-# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
-
-require_relative "config/application"
-
-Rails.application.load_tasks

data/test/rails5_dummy/app/controllers/dummy_controller.rb

@@ -1,5 +0,0 @@
-class DummyController < ActionController::API
-  def show
-    render plain: "I am no dummy"
-  end
-end

data/test/rails5_dummy/app/controllers/dummy_view_controller.rb

@@ -1,16 +0,0 @@
-class DummyViewController < ActionController::Base
-  def show
-    @text = "I am no dummy view tracker text"
-    render layout: false
-  end
-
-  def show_haml
-    @text = "I am haml text"
-    render layout: false
-  end
-
-  def show_slim
-    @text = "I am slim text"
-    render layout: false
-  end
-end

data/test/rails5_dummy/app/views/dummy_view/show.html.erb

@@ -1,5 +0,0 @@
-rendered view
-
-<div>
-  <%= @text %>
-</div>

data/test/rails5_dummy/app/views/dummy_view/show_haml.html.haml

@@ -1,4 +0,0 @@
-rendered haml view
-
-#foo
-  = @text

data/test/rails5_dummy/app/views/dummy_view/show_slim.html.slim

@@ -1,4 +0,0 @@
-rendered slim view
-
-#content
-  = @text

data/test/rails5_dummy/config/application.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-require "rails"
-require "action_controller/railtie"
-require "action_view/railtie"
-require "coverband"
-Bundler.require(*Rails.groups)
-
-module Rails5Dummy
-  class Application < Rails::Application
-    config.eager_load = true
-    config.consider_all_requests_local = true
-  end
-end

data/test/rails5_dummy/config/coverband.rb

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-Coverband.configure do |config|
-  # NOTE: we reuse this config in each of the fake rails projects
-  # the below ensures the root is set to the correct fake project
-  config.root = ::File.expand_path("../../../", __FILE__).to_s + "/rails#{Rails::VERSION::MAJOR}_dummy"
-  config.store = Coverband::Adapters::RedisStore.new(Redis.new(db: 2, url: ENV["REDIS_URL"]), redis_namespace: "coverband_test") if defined? Redis
-  config.ignore = %w[.erb$ .slim$]
-  config.root_paths = []
-  config.logger = Rails.logger
-  config.verbose = true
-  config.background_reporting_enabled = true
-  config.track_routes = true
-  config.use_oneshot_lines_coverage = true if ENV["ONESHOT"]
-end

data/test/rails5_dummy/config/coverband_missing_redis.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-Coverband.configure do |config|
-  config.root = Dir.pwd
-  config.store = Coverband::Adapters::RedisStore.new(Redis.new(db: 2, url: "redis://127.0.0.1:123"), redis_namespace: "coverband_test") if defined? Redis
-  config.ignore = %w[vendor .erb$ .slim$]
-  config.root_paths = []
-  config.logger = Rails.logger
-  config.verbose = true
-  config.background_reporting_enabled = true
-  config.track_gems = true
-  config.gem_details = true
-  config.use_oneshot_lines_coverage = true if ENV["ONESHOT"]
-end

data/test/rails5_dummy/config/environment.rb

@@ -1,2 +0,0 @@
-require_relative "application"
-Rails.application.initialize!

data/test/rails5_dummy/config/routes.rb

@@ -1,7 +0,0 @@
-Rails.application.routes.draw do
-  get "dummy/show"
-  get "dummy_view/show", to: "dummy_view#show"
-  get "dummy_view/show_haml", to: "dummy_view#show_haml"
-  get "dummy_view/show_slim", to: "dummy_view#show_slim"
-  mount Coverband::Reporters::Web.new, at: "/coverage"
-end

data/test/rails5_dummy/config.ru

@@ -1,3 +0,0 @@
-require_relative "config/environment"
-
-run Rails.application

data/test/rails6_dummy/Rakefile

@@ -1,6 +0,0 @@
-# Add your own tasks in files placed in lib/tasks ending in .rake,
-# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
-
-require_relative "config/application"
-
-Rails.application.load_tasks

data/test/rails6_dummy/app/controllers/dummy_controller.rb

@@ -1,5 +0,0 @@
-class DummyController < ActionController::Base
-  def show
-    render plain: "I am no dummy"
-  end
-end

data/test/rails6_dummy/app/controllers/dummy_view_controller.rb

@@ -1,16 +0,0 @@
-class DummyViewController < ActionController::Base
-  def show
-    @text = "I am no dummy view tracker text"
-    render layout: false
-  end
-
-  def show_haml
-    @text = "I am haml text"
-    render layout: false
-  end
-
-  def show_slim
-    @text = "I am slim text"
-    render layout: false
-  end
-end

data/test/rails6_dummy/app/views/dummy_view/show.html.erb

@@ -1,5 +0,0 @@
-rendered view
-
-<div>
-  <%= @text %>
-</div>

data/test/rails6_dummy/app/views/dummy_view/show_haml.html.haml

@@ -1,4 +0,0 @@
-rendered haml view
-
-#foo
-  = @text

data/test/rails6_dummy/app/views/dummy_view/show_slim.html.slim

@@ -1,4 +0,0 @@
-rendered slim view
-
-#content
-  = @text

data/test/rails6_dummy/config/boot.rb

@@ -1,3 +0,0 @@
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", __FILE__)
-
-require "bundler/setup" # Set up gems listed in the Gemfile.

data/test/rails6_dummy/config/coverband.rb

@@ -1,3 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../../rails5_dummy/config/coverband"

data/test/rails6_dummy/config/coverband_missing_redis.rb

@@ -1,3 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../../rails5_dummy/config/coverband_missing_redis"

data/test/rails6_dummy/config/environment.rb

@@ -1,5 +0,0 @@
-# Load the Rails application.
-require File.expand_path("../application", __FILE__)
-
-# Initialize the Rails application.
-Rails.application.initialize!

data/test/rails6_dummy/config/routes.rb

@@ -1,7 +0,0 @@
-Rails.application.routes.draw do
-  get "dummy/show"
-  get "dummy_view/show", to: "dummy_view#show"
-  get "dummy_view/show_haml", to: "dummy_view#show_haml"
-  get "dummy_view/show_slim", to: "dummy_view#show_slim"
-  mount Coverband::Reporters::Web.new, at: "/coverage"
-end

data/test/rails6_dummy/config/secrets.yml

@@ -1,3 +0,0 @@
-test:
-  secret_key_base: 8080f2894307a3dcf72127c0a279a729c58c7c10c11a15de761c8e16017e0e478647d1a7ac11bf143730cac7b6901fa000428c6b4873d9298250f8ca4657b5c6
-

data/test/rails6_dummy/config.ru

@@ -1,4 +0,0 @@
-# This file is used by Rack-based servers to start the application.
-
-require ::File.expand_path("../config/environment", __FILE__)
-run Rails.application