coverband 6.0.2 → 6.0.3.rc.1

data/lib/coverband/reporters/json_report.rb

@@ -5,11 +5,22 @@
 module Coverband
   module Reporters
     class JSONReport < Base
-      attr_accessor :filtered_report_files
+      attr_accessor :filtered_report_files, :options, :page, :as_report, :store, :filename
 
       def initialize(store, options = {})
+        self.options = options
+        self.page = options.fetch(:page) { nil }
+        self.filename = options.fetch(:filename) { nil }
+        self.as_report = options.fetch(:as_report) { false }
+        self.store = store
+
         coverband_reports = Coverband::Reporters::Base.report(store, options)
-        self.filtered_report_files = self.class.fix_reports(coverband_reports)
+        # NOTE: paged reports can't find and add in files that has never been loaded
+        self.filtered_report_files = if page || filename
+          coverband_reports
+        else
+          self.class.fix_reports(coverband_reports)
+        end
       end
 
       def report
@@ -21,10 +32,35 @@ module Coverband
       def report_as_json
         result = Coverband::Utils::Results.new(filtered_report_files)
         source_files = result.source_files
-        {
+
+        data = {
           **coverage_totals(source_files),
           files: coverage_files(result, source_files)
-        }.to_json
+        }
+
+        if as_report
+          row_data = []
+          data[:files].each_pair do |key, data|
+            row_data << [
+              key,
+              data[:covered_percent].to_s,
+              data[:runtime_percentage].to_s,
+              data[:lines_of_code].to_s,
+              (data[:lines_covered] + data[:lines_missed]).to_s,
+              data[:lines_covered].to_s,
+              data[:lines_runtime].to_s,
+              data[:lines_missed].to_s,
+              data[:covered_strength].to_s
+            ]
+          end
+          filesreported = store.file_count(:runtime)
+          data["iTotalRecords"] = filesreported
+          data["iTotalDisplayRecords"] = filesreported
+          data["aaData"] = row_data
+          data.delete(:files)
+          data = data.as_json
+        end
+        data.to_json
       end
 
       def coverage_totals(source_files)
@@ -41,11 +77,13 @@ module Coverband
       # Using a hash indexed by file name for quick lookups
       def coverage_files(result, source_files)
         source_files.each_with_object({}) do |source_file, hash|
+          runtime_coverage = result.file_with_type(source_file, Coverband::RUNTIME_TYPE)&.covered_lines_count || 0
           hash[source_file.short_name] = {
             never_loaded: source_file.never_loaded,
             runtime_percentage: result.runtime_relevant_coverage(source_file),
             lines_of_code: source_file.lines.count,
             lines_covered: source_file.covered_lines.count,
+            lines_runtime: runtime_coverage,
             lines_missed: source_file.missed_lines.count,
             covered_percent: source_file.covered_percent,
             covered_strength: source_file.covered_strength

data/lib/coverband/reporters/web.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require "base64"
 require "coverband"
 
 begin
@@ -56,7 +57,7 @@ module Coverband
 
         return [401, {"www-authenticate" => 'Basic realm=""'}, [""]] unless check_auth
 
-        request_path_info = request.path_info == "" ? "/" : request.path_info
+        request_path_info = (request.path_info == "") ? "/" : request.path_info
         tracker_route = false
         Coverband.configuration.trackers.each do |tracker|
           if request_path_info.match(tracker.class::REPORT_ROUTE)
@@ -97,6 +98,8 @@ module Coverband
               [200, coverband_headers(content_type: "text/json"), [load_file_details]]
             when %r{\/json}
               [200, coverband_headers(content_type: "text/json"), [json]]
+            when %r{\/report_json}
+              [200, coverband_headers(content_type: "text/json"), [report_json]]
             when %r{\/$}
               [200, coverband_headers, [index]]
             else
@@ -120,6 +123,17 @@ module Coverband
         Coverband::Reporters::JSONReport.new(Coverband.configuration.store).report
       end
 
+      def report_json
+        report_options = {
+          as_report: true
+        }
+        report_options[:page] = (request.params["page"] || 1).to_i if request.params["page"]
+        Coverband::Reporters::JSONReport.new(
+          Coverband.configuration.store,
+          report_options
+        ).report
+      end
+
       def settings
         Coverband::Utils::HTMLFormatter.new(nil, base_path: base_path).format_settings!
       end
@@ -218,7 +232,7 @@ module Coverband
       # %r{\/.*\/}.match?(request.path) ? request.path.match("\/.*\/")[0] : "/"
       # ^^ the above is NOT valid Ruby 2.3/2.4 even though rubocop / standard think it is
       def base_path
-        request.path =~ %r{\/.*\/} ? request.path.match("/.*/")[0] : "/"
+        (request.path =~ %r{\/.*\/}) ? request.path.match("/.*/")[0] : "/"
       end
     end
   end

data/lib/coverband/reporters/web_pager.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require "base64"
+require "coverband"
+
+begin
+  require "rack"
+rescue LoadError
+  puts "error loading Coverband web reporter as Rack is not available"
+end
+
+module Coverband
+  module Reporters
+    class WebPager < Web
+      def index
+        notice = "<strong>Notice:</strong> #{Rack::Utils.escape_html(request.params["notice"])}<br/>"
+        notice = request.params["notice"] ? notice : ""
+        # TODO: remove the call to the store render empty table
+        Coverband::Reporters::HTMLReport.new(Coverband.configuration.store,
+          page: (request.params["page"] || 1).to_i,
+          static: false,
+          base_path: base_path,
+          notice: notice,
+          open_report: false).report
+      end
+    end
+  end
+end

data/lib/coverband/utils/absolute_file_converter.rb

@@ -22,25 +22,25 @@ module Coverband
 
       def convert(relative_path)
         @cache[relative_path] ||= begin
-                                    relative_filename = relative_path
-                                    local_filename = relative_filename
-                                    @roots.each do |root|
-                                      relative_filename = relative_filename.sub(/^#{root}/, "./")
-                                      # once we have a relative path break out of the loop
-                                      break if relative_filename.start_with? "./"
-                                    end
-                                    # the filename for our reports is expected to be a full path.
-                                    # roots.last should be roots << current_root}/
-                                    # a fully expanded path of config.root
-                                    # filename = filename.gsub('./', roots.last)
-                                    # above only works for app files
-                                    # we need to rethink some of this logic
-                                    # gems aren't at project root and can have multiple locations
-                                    local_root = @roots.find { |root|
-                                      File.exist?(relative_filename.gsub("./", root))
-                                    }
-                                    local_root ? relative_filename.gsub("./", local_root) : local_filename
-                                  end
+          relative_filename = relative_path
+          local_filename = relative_filename
+          @roots.each do |root|
+            relative_filename = relative_filename.sub(/^#{root}/, "./")
+            # once we have a relative path break out of the loop
+            break if relative_filename.start_with? "./"
+          end
+          # the filename for our reports is expected to be a full path.
+          # roots.last should be roots << current_root}/
+          # a fully expanded path of config.root
+          # filename = filename.gsub('./', roots.last)
+          # above only works for app files
+          # we need to rethink some of this logic
+          # gems aren't at project root and can have multiple locations
+          local_root = @roots.find { |root|
+            File.exist?(relative_filename.gsub("./", root))
+          }
+          local_root ? relative_filename.gsub("./", local_root) : local_filename
+        end
       end
     end
   end

data/lib/coverband/utils/file_hasher.rb

@@ -7,9 +7,9 @@ module Coverband
 
       def self.hash_file(file, path_converter: AbsoluteFileConverter.instance)
         @cache[file] ||= begin
-                           file = path_converter.convert(file)
-                           Digest::MD5.file(file).hexdigest if File.exist?(file)
-                         end
+          file = path_converter.convert(file)
+          Digest::MD5.file(file).hexdigest if File.exist?(file)
+        end
       end
     end
   end

data/lib/coverband/utils/html_formatter.rb

@@ -13,12 +13,13 @@ require "time"
 module Coverband
   module Utils
     class HTMLFormatter
-      attr_reader :notice, :base_path, :tracker
+      attr_reader :notice, :base_path, :tracker, :page
 
       def initialize(report, options = {})
         @notice = options.fetch(:notice, nil)
         @base_path = options.fetch(:base_path, "./")
         @tracker = options.fetch(:tracker, nil)
+        @page = options.fetch(:page, nil)
         @coverage_result = Coverband::Utils::Results.new(report) if report
       end
 
@@ -126,11 +127,10 @@ module Coverband
       # Returns a table containing the given source files
       def formatted_file_list(title, result, source_files, options = {})
         title_id = title.gsub(/^[^a-zA-Z]+/, "").gsub(/[^a-zA-Z0-9\-\_]/, "")
-        # Silence a warning by using the following variable to assign to itself:
+        # Silence a warning by using the following variable to assign to `_`:
         # "warning: possibly useless use of a variable in void context"
         # The variable is used by ERB via binding.
-        title_id = title_id
-        options = options
+        _ = title_id, options
 
         template("file_list").result(binding)
       end

data/lib/coverband/utils/method_definition_scanner.rb

@@ -71,7 +71,7 @@ if defined?(RubyVM::AbstractSyntaxTree)
         def scan_node(node, class_name)
           definitions = []
           return definitions unless node.is_a?(RubyVM::AbstractSyntaxTree::Node)
-          current_class = node.type == :CLASS ? node.children.first.children.last : class_name
+          current_class = (node.type == :CLASS) ? node.children.first.children.last : class_name
           if node.type == :DEFN
             definitions <<
               MethodDefinition.new(

data/lib/coverband/utils/railtie.rb

@@ -11,12 +11,10 @@ module Coverband
 
   class Railtie < Rails::Railtie
     initializer "coverband.configure" do |app|
-      begin
-        app.middleware.use Coverband::BackgroundMiddleware
-      rescue Redis::CannotConnectError => error
-        Coverband.configuration.logger.info "Redis is not available (#{error}), Coverband not configured"
-        Coverband.configuration.logger.info "If this is a setup task like assets:precompile feel free to ignore"
-      end
+      app.middleware.use Coverband::BackgroundMiddleware
+    rescue Redis::CannotConnectError => error
+      Coverband.configuration.logger.info "Redis is not available (#{error}), Coverband not configured"
+      Coverband.configuration.logger.info "If this is a setup task like assets:precompile feel free to ignore"
     end
 
     config.after_initialize do

data/lib/coverband/utils/relative_file_converter.rb

@@ -22,13 +22,13 @@ module Coverband
 
       def convert(file)
         @cache[file] ||= begin
-                           relative_file = file
-                           @roots.each do |root|
-                             relative_file = file.gsub(/^#{root}/, ".")
-                             break relative_file if relative_file.start_with?(".")
-                           end
-                           relative_file
-                         end
+          relative_file = file
+          @roots.each do |root|
+            relative_file = file.gsub(/^#{root}/, ".")
+            break relative_file if relative_file.start_with?(".")
+          end
+          relative_file
+        end
       end
 
       private

data/lib/coverband/utils/results.rb

@@ -68,11 +68,7 @@ module Coverband
       end
 
       def respond_to_missing?(method)
-        if get_results(type).respond_to?(method)
-          true
-        else
-          false
-        end
+        get_results(type).respond_to?(method)
       end
 
       private

data/lib/coverband/utils/source_file.rb

@@ -74,7 +74,7 @@ module Coverband
           return "skipped" if skipped?
           return "never" if never?
           return "missed" if missed?
-          return "covered" if covered?
+          "covered" if covered?
         end
       end
 
@@ -162,7 +162,7 @@ module Coverband
         return 0.0 if relevant_lines.zero?
 
         # handle edge case where runtime in dev can go over 100%
-        [Float(covered_lines.size * 100.0 / relevant_lines.to_f), 100.0].min
+        [Float(covered_lines.size * 100.0 / relevant_lines.to_f), 100.0].min&.round(2)
       end
 
       def formatted_covered_percent

data/lib/coverband/utils/tasks.rb

@@ -35,7 +35,7 @@ namespace :coverband do
       Coverband.configuration.store.merge_mode = true
     end
     Rack::Server.start app: Coverband::Reporters::Web.new,
-                       Port: ENV.fetch("COVERBAND_COVERAGE_PORT", 9022).to_i
+      Port: ENV.fetch("COVERBAND_COVERAGE_PORT", 9022).to_i
   end
 
   ###

data/lib/coverband/version.rb

@@ -5,5 +5,5 @@
 # use format "4.2.1.rc.1" ~> 4.2.1.rc to prerelease versions like v4.2.1.rc.2 and v4.2.1.rc.3
 ###
 module Coverband
-  VERSION = "6.0.2"
+  VERSION = "6.0.3.rc.1"
 end

data/lib/coverband.rb

@@ -82,9 +82,9 @@ module Coverband
   end
 
   def self.tasks_to_ignore?
-    (defined?(Rake) &&
-    Rake.respond_to?(:application) &&
-    (Rake&.application&.top_level_tasks || []).any? { |task| Coverband::Configuration::IGNORE_TASKS.include?(task) })
+    defined?(Rake) &&
+      Rake.respond_to?(:application) &&
+      (Rake&.application&.top_level_tasks || []).any? { |task| Coverband::Configuration::IGNORE_TASKS.include?(task) }
   end
 
   def self.eager_loading_coverage!
@@ -130,6 +130,7 @@ module Coverband
       ###
       def initialize
         require "coverband/reporters/web"
+        require "coverband/reporters/web_pager"
         require "coverband/utils/html_formatter"
         require "coverband/utils/result"
         require "coverband/utils/file_list"
@@ -147,4 +148,19 @@ module Coverband
       end
     end
   end
+
+  module Reporters
+    class WebPager < Web
+      def initialize
+        require "coverband/reporters/web"
+        require "coverband/reporters/web_pager"
+        super
+      end
+
+      def self.call(env)
+        @app ||= new
+        @app.call(env)
+      end
+    end
+  end
 end

data/public/application.js

@@ -33,6 +33,41 @@ $(document).ready(function() {
     ]
   });
 
+  // TODO: add support for searching...
+  // hmm should I just use manual paging? or load more...
+  if ($(".file_list.unsorted").length == 1) {
+    var current_rows = 0;
+    var total_rows = 0;
+    var page = 1;
+
+    // write a function to get a page of data and add it to the table
+    function get_page(page) {
+      $.ajax({
+        url: `/coverage/report_json?page=${page}`,
+        type: 'GET',
+        dataType: 'json',
+        success: function(data) {
+          console.log(data);
+          total_rows = data["iTotalRecords"];
+          // NOTE: we request 250 at a time, but we seem to have some files that we have as a list but 0 coverage,
+          // so we don't get back 250 per page... to ensure we we need to account for filtered out and empty files
+          // this 250 at the moment is synced to the 250 in the hash redis store
+          current_rows += 250; //data["aaData"].length;
+          console.log(current_rows);
+          console.log(total_rows);
+          $(".file_list.unsorted").dataTable().fnAddData(data["aaData"]);
+          page += 1;
+          // the page less than 100 is to stop infinite loop in case of folks never clearing out old coverage reports
+          if (page < 100 && current_rows < total_rows) {
+            get_page(page);
+          }
+        }
+      });
+    }
+    get_page(page);
+  }
+
+
   // Syntax highlight all files up front - deactivated
   // $('.source_table pre code').each(function(i, e) {hljs.highlightBlock(e, '  ')});
 

data/public/dependencies.js

@@ -1147,7 +1147,7 @@ this._iRecordsTotal:this.aiDisplayMaster.length};this.fnRecordsDisplay=function(
 bSort:true,bInfo:true,bAutoWidth:true,bProcessing:false,bSortClasses:true,bStateSave:false,bServerSide:false};this.oScroll={sX:"",sXInner:"",sY:"",bCollapse:false,iBarWidth:0};this.aanFeatures=[];this.oLanguage={sProcessing:"Processing...",sLengthMenu:"Show _MENU_ entries",sZeroRecords:"No matching records found",sEmptyTable:"No data available in table",sInfo:"Showing _START_ to _END_ of _TOTAL_ entries",sInfoEmpty:"Showing 0 to 0 of 0 entries",sInfoFiltered:"(filtered from _MAX_ total entries)",
 sInfoPostFix:"",sSearch:"Search:",sUrl:"",oPaginate:{sFirst:"First",sPrevious:"Previous",sNext:"Next",sLast:"Last"}};this.aoData=[];this.aiDisplay=[];this.aiDisplayMaster=[];this.aoColumns=[];this.iNextId=0;this.asDataSearch=[];this.oPreviousSearch={sSearch:"",bRegex:false,bSmart:true};this.aoPreSearchCols=[];this.aaSorting=[[0,"asc",0]];this.aaSortingFixed=null;this.asStripClasses=[];this.asDestoryStrips=[];this.fnFooterCallback=this.fnHeaderCallback=this.fnRowCallback=null;this.aoDrawCallback=[];
 this.fnInitComplete=null;this.sTableId="";this.nTableWrapper=this.nTBody=this.nTFoot=this.nTHead=this.nTable=null;this.iDefaultSortIndex=0;this.bInitialised=false;this.aoOpenRows=[];this.sDom="lfrtip";this.sPaginationType="two_button";this.iCookieDuration=7200;this.sCookiePrefix="SpryMedia_DataTables_";this.sAjaxSource=null;this.bAjaxDataGet=true;this.fnServerData=function(a,b,c){j.ajax({url:a,data:b,success:c,dataType:"json",cache:false,error:function(){alert("DataTables warning: JSON data from server failed to load or be parsed. This is most likely to be caused by a JSON formatting error.")}})};
-this.fnFormatNumber=function(a){if(a<1E3)return a;else{var b=a+"";a=b.split("");var c="";b=b.length;for(var d=0;d<b;d++){if(d%3===0&&d!==0)c=","+c;c=a[b-d-1]+c}}return c};this.aLengthMenu=[10,25,50,100];this.iDraw=0;this.iDrawError=-1;this._iDisplayLength=10;this._iDisplayStart=0;this._iDisplayEnd=10;this._iRecordsDisplay=this._iRecordsTotal=0;this.bJUI=false;this.oClasses=m.oStdClasses;this.bSorted=this.bFiltered=false;this.oInit=null}function q(a){return function(){var b=[B(this[m.iApiIndex])].concat(Array.prototype.slice.call(arguments));
+this.fnFormatNumber=function(a){if(a<1E3)return a;else{var b=a+"";a=b.split("");var c="";b=b.length;for(var d=0;d<b;d++){if(d%3===0&&d!==0)c=","+c;c=a[b-d-1]+c}}return c};this.aLengthMenu=[250];this.iDraw=0;this.iDrawError=-1;this._iDisplayLength=250;this._iDisplayStart=0;this._iDisplayEnd=250;this._iRecordsDisplay=this._iRecordsTotal=0;this.bJUI=false;this.oClasses=m.oStdClasses;this.bSorted=this.bFiltered=false;this.oInit=null}function q(a){return function(){var b=[B(this[m.iApiIndex])].concat(Array.prototype.slice.call(arguments));
 return m.oApi[a].apply(this,b)}}function r(a){if(a.bInitialised===false)setTimeout(function(){r(a)},200);else{na(a);z(a);if(a.oFeatures.bSort)O(a);else{a.aiDisplay=a.aiDisplayMaster.slice();F(a);D(a)}if(a.sAjaxSource!==null&&!a.oFeatures.bServerSide){K(a,true);a.fnServerData.call(a.oInstance,a.sAjaxSource,null,function(b){for(var c=0;c<b.aaData.length;c++)w(a,b.aaData[c]);a.iInitDisplayStart=a._iDisplayStart;if(a.oFeatures.bSort)O(a);else{a.aiDisplay=a.aiDisplayMaster.slice();F(a);D(a)}K(a,false);
 typeof a.fnInitComplete=="function"&&a.fnInitComplete.call(a.oInstance,a,b)})}else{typeof a.fnInitComplete=="function"&&a.fnInitComplete.call(a.oInstance,a);a.oFeatures.bServerSide||K(a,false)}}}function u(a,b,c){n(a.oLanguage,b,"sProcessing");n(a.oLanguage,b,"sLengthMenu");n(a.oLanguage,b,"sEmptyTable");n(a.oLanguage,b,"sZeroRecords");n(a.oLanguage,b,"sInfo");n(a.oLanguage,b,"sInfoEmpty");n(a.oLanguage,b,"sInfoFiltered");n(a.oLanguage,b,"sInfoPostFix");n(a.oLanguage,b,"sSearch");if(typeof b.oPaginate!=
 "undefined"){n(a.oLanguage.oPaginate,b.oPaginate,"sFirst");n(a.oLanguage.oPaginate,b.oPaginate,"sPrevious");n(a.oLanguage.oPaginate,b.oPaginate,"sNext");n(a.oLanguage.oPaginate,b.oPaginate,"sLast")}typeof b.sEmptyTable=="undefined"&&typeof b.sZeroRecords!="undefined"&&n(a.oLanguage,b,"sZeroRecords","sEmptyTable");c&&r(a)}function y(a,b){a.aoColumns[a.aoColumns.length++]={sType:null,_bAutoType:true,bVisible:true,bSearchable:true,bSortable:true,asSorting:["asc","desc"],sSortingClass:a.oClasses.sSortable,

data/roadmap.md

@@ -53,4 +53,4 @@ Will be the fully modern release that drops maintenance legacy support in favor
 
 It is important for a project to not only know what problems it is trying to solve, but what things are out of scope. We will start to try to document that here:
 
-* We have in the past tried to add coverage tracking for all gems, this added a lot of complexity and compuation overhead and slowed things down to much. It also was of less value than we had hoped. There are alterntative ways to instrument a shared library to track across multiple applications, and single application gem utilization is easier to handle in a one of basis. It is unlikely we will support that again.
+* We have in the past tried to add coverage tracking for all gems, this added a lot of complexity and computation overhead and slowed things down to much. It also was of less value than we had hoped. There are alternative ways to instrument a shared library to track across multiple applications, and single application gem utilization is easier to handle in a one of basis. It is unlikely we will support that again.

data/test/benchmarks/benchmark.rake

@@ -5,7 +5,7 @@ namespace :benchmarks do
   # Enable and start GC before each job run. Disable GC afterwards.
   #
   # Inspired by https://www.omniref.com/ruby/2.2.1/symbols/Benchmark/bm?#annotation=4095926&line=182
-  class GCSuite
+  class GCSuite # standard:disable Lint/ConstantDefinitionInBlock
     def warming(*)
       run_gc
     end
@@ -99,11 +99,11 @@ namespace :benchmarks do
     Coverband::Collectors::Coverage.instance.reset_instance
   end
 
-  LINES = 45
-  NON_NIL_LINES = 18
+  lines = 45
+  non_nil_lines = 18
   def fake_line_numbers
-    LINES.times.map do |line|
-      coverage = line < NON_NIL_LINES ? rand(5) : nil
+    lines.times.map do |line|
+      coverage = (line < non_nil_lines) ? rand(5) : nil
     end
   end
 

data/test/coverband/adapters/file_store_test.rb

@@ -16,7 +16,7 @@ class AdaptersFileStoreTest < Minitest::Test
       previous_file_path = "#{@test_file_path}.#{::Process.pid}"
       `rm #{@test_file_path}` if File.exist?(@test_file_path)
       `rm #{previous_file_path}` if File.exist?(previous_file_path)
-      File.open(previous_file_path, "w") { |f| f.write(test_data.to_json) }
+      File.write(previous_file_path, test_data.to_json)
       @store = Coverband::Adapters::FileStore.new(@test_file_path)
     end
 

data/test/coverband/collectors/coverage_test.rb

@@ -53,7 +53,7 @@ class CollectorsCoverageTest < Minitest::Test
   end
 
   test "defaults to a redis store" do
-    assert_equal Coverband::Adapters::RedisStore, coverband.instance_variable_get("@store").class
+    assert_equal Coverband::Adapters::RedisStore, coverband.instance_variable_get(:@store).class
   end
 
   test "report_coverage raises errors in tests" do

data/test/coverband/reporters/json_test.rb

@@ -38,7 +38,7 @@ class ReportJSONTest < Minitest::Test
     json = Coverband::Reporters::JSONReport.new(@store).report
     parsed = JSON.parse(json)
 
-    expected_keys = ["never_loaded", "runtime_percentage", "lines_of_code", "lines_covered", "lines_missed", "covered_percent", "covered_strength"]
+    expected_keys = ["never_loaded", "runtime_percentage", "lines_of_code", "lines_covered", "lines_runtime", "lines_missed", "covered_percent", "covered_strength"]
 
     assert_equal parsed["files"].length, 2
     parsed["files"].keys.each do |file|

data/test/coverband/utils/source_file_test.rb

@@ -7,10 +7,10 @@ require File.expand_path("../../test_helper", File.dirname(__FILE__))
 # initial version of test pulled into Coverband from Simplecov 12/19/2018
 ####
 describe Coverband::Utils::SourceFile do
-  COVERAGE_FOR_SAMPLE_RB = [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil, nil, nil, nil, nil, nil, nil].freeze
+  coverage_for_sample_rb = [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil, nil, nil, nil, nil, nil, nil].freeze
   describe "a source file initialized with some coverage data" do
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture("sample.rb"), COVERAGE_FOR_SAMPLE_RB)
+      Coverband::Utils::SourceFile.new(source_fixture("sample.rb"), coverage_for_sample_rb)
     end
 
     it "has a filename" do
@@ -70,7 +70,7 @@ describe Coverband::Utils::SourceFile do
 
   describe "simulating potential Ruby 1.9 defect -- see Issue #56" do
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture("sample.rb"), COVERAGE_FOR_SAMPLE_RB + [nil])
+      Coverband::Utils::SourceFile.new(source_fixture("sample.rb"), coverage_for_sample_rb + [nil])
     end
 
     it "has 16 source lines regardless of extra data in coverage array" do
@@ -88,10 +88,10 @@ describe Coverband::Utils::SourceFile do
   end
 
   describe "a file that is never relevant" do
-    COVERAGE_FOR_NEVER_RB = [nil, nil].freeze
+    coverage_for_never_rb = [nil, nil].freeze
 
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture("never.rb"), COVERAGE_FOR_NEVER_RB)
+      Coverband::Utils::SourceFile.new(source_fixture("never.rb"), coverage_for_never_rb)
     end
 
     it "has 0.0 covered_strength" do
@@ -104,10 +104,10 @@ describe Coverband::Utils::SourceFile do
   end
 
   describe "a file where nothing is ever executed mixed with skipping #563" do
-    COVERAGE_FOR_SKIPPED_RB = [nil, nil, nil, nil].freeze
+    coverage_for_skipped_rb = [nil, nil, nil, nil].freeze
 
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture("skipped.rb"), COVERAGE_FOR_SKIPPED_RB)
+      Coverband::Utils::SourceFile.new(source_fixture("skipped.rb"), coverage_for_skipped_rb)
     end
 
     it "has 0.0 covered_strength" do
@@ -120,10 +120,10 @@ describe Coverband::Utils::SourceFile do
   end
 
   describe "a file where everything is skipped and missed #563" do
-    COVERAGE_FOR_SKIPPED_RB_2 = [nil, nil, 0, nil].freeze
+    coverage_for_skipped_rb_2 = [nil, nil, 0, nil].freeze
 
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture("skipped.rb"), COVERAGE_FOR_SKIPPED_RB_2)
+      Coverband::Utils::SourceFile.new(source_fixture("skipped.rb"), coverage_for_skipped_rb_2)
     end
 
     it "has 0.0 covered_strength" do
@@ -136,10 +136,10 @@ describe Coverband::Utils::SourceFile do
   end
 
   describe "a file where everything is skipped/irrelevamt but executed #563" do
-    COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB = [nil, nil, 1, 1, 0, nil, nil, nil].freeze
+    coverage_for_skkiped_and_executed_rb = [nil, nil, 1, 1, 0, nil, nil, nil].freeze
 
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture("skipped_and_executed.rb"), COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB)
+      Coverband::Utils::SourceFile.new(source_fixture("skipped_and_executed.rb"), coverage_for_skkiped_and_executed_rb)
     end
 
     it "has 0.0 covered_strength" do

data/test/fixtures/casting_invitor.rb

@@ -34,7 +34,7 @@ class CastingInviter
 
   def invalid_invitees
     @invalid_invitees ||=
-      invitee_list.map { |item| item unless item.match(EMAIL_REGEX) }.compact
+      invitee_list.reject { |item| item.match(EMAIL_REGEX) }
   end
 
   def invitee_list

data/test/fixtures/sample.rb

@@ -8,9 +8,9 @@ class Foo
     @foo
   end
 
-  #:nocov:
+  # :nocov:
   def skipped
     @foo * 2
   end
-  #:nocov:
+  # :nocov:
 end

data/test/fixtures/skipped_and_executed.rb

@@ -5,4 +5,4 @@ class Foo
     0
   end
 end
-#:nocov:
+# :nocov:

data/test/forked/rails_rake_full_stack_test.rb

@@ -11,7 +11,7 @@ class RailsRakeFullStackTest < Minitest::Test
   end
 
   # test 'rake tasks shows coverage properly within eager_loading' do
-  # this was testing gem data, which we no logner support and I dont know if this makes sense anymre
+  # this was testing gem data, which we no longer support and I dont know if this makes sense anymre
   # end
 
   test "ignored rake tasks don't add coverage" do

data/test/test_helper.rb

@@ -92,11 +92,11 @@ Mocha::Configuration.prevent(:stubbing_method_unnecessarily)
 Mocha::Configuration.prevent(:stubbing_non_existent_method)
 
 def test(name, &block)
-  test_name = "test_#{name.gsub(/\s+/, "_")}".to_sym
+  test_name = :"test_#{name.gsub(/\s+/, "_")}"
   defined = begin
     instance_method(test_name)
-            rescue
-              false
+  rescue
+    false
   end
   raise "#{test_name} is already defined in #{self}" if defined
 
@@ -172,8 +172,6 @@ ensure
   $stderr = previous_stderr
 end
 
-require "coverband"
-
 Coverband::Configuration.class_eval do
   def test_env
     true