coverband 5.2.5.rc.2 → 5.2.5.rc.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 29c141e8e62eabb26244757e45620d7167ecff2e54b6be387afc02af325270af
-  data.tar.gz: 7dda0bea9109e8c36175d6b45ddae9470590fe45d60ed53f284b7f6a64d769f3
+  metadata.gz: 371f700add3ee62e62457c7637526f35af0804eb2174d23e7ce0f838dfe3dbe1
+  data.tar.gz: 7e8d14239826ad9eb501afb37dca1fd5f26b5f3d9452c4d3baee57f5cfef5b6d
 SHA512:
-  metadata.gz: 22c115d68356bc5c238c97ab5ef8e9fb6fc37769a91559cfbf254e0266f8a997fa00e53d4a0b3d6b8195d69633c08765327d8b1283094bbd34242966d1ef1421
-  data.tar.gz: 29722490a0d2a3b0af5cf37e67d976b73e12bd50b4649af8f9d3f332a4a07193399ffc2300cb2c02b83effd94dc36c5a7e37eb1a585be2e86cd30bb4062f5cc1
+  metadata.gz: 75fbb3421bab3ece39c76ef607e8fd4d79644a4fc97989c973ff28605b88acfbfd335ee448474388e0722d6b5ec0e1c7bcaa48f637b5b4da617111948ca02dc5
+  data.tar.gz: 7fbca23b6649391422521350b704731aad4052235f6cf3b2366b409310b2ed0feed78445df2f2466deb4ffc523d7d99e26dc26151a45b86af0de2257872044a0

data/lib/coverband/collectors/route_tracker.rb

@@ -27,7 +27,7 @@ module Coverband
                 action: route.defaults[:action],
                 url_path: route.path.spec.to_s.gsub("(.:format)", ""),
                 verb: route.verb
-              }.to_s
+              }
             end
           else
             []
@@ -62,9 +62,9 @@ module Coverband
           }
         else
           {
-            controller: payload[:controller],
+            controller: payload[:params]["controller"],
             action: payload[:action],
-            url_path: payload[:path],
+            url_path: nil,
             verb: payload[:method]
           }
         end
@@ -81,16 +81,13 @@ module Coverband
       end
 
       def all_routes
-        all_routes = []
-        target.each do |route|
-          all_routes << route
-        end
-        all_routes.uniq
+        target.uniq
       end
 
       def unused_routes(used_routes = nil)
         recently_used_routes = (used_routes || self.used_routes).keys
-        all_routes - recently_used_routes
+        # NOTE: we match with or without path to handle paths with named params like `/user/:user_id` to used routes filling with all the variable named paths
+        all_routes.reject { |r| recently_used_routes.include?(r.to_s) || recently_used_routes.include?(r.merge(url_path: nil).to_s) }
       end
 
       def as_json

data/lib/coverband/version.rb

@@ -5,5 +5,5 @@
 # use format "4.2.1.rc.1" ~> 4.2.1.rc to prerelease versions like v4.2.1.rc.2 and v4.2.1.rc.3
 ###
 module Coverband
-  VERSION = "5.2.5.rc.2"
+  VERSION = "5.2.5.rc.3"
 end

data/test/coverband/collectors/route_tracker_test.rb

@@ -42,10 +42,11 @@ class RouterTrackerTest < Minitest::Test
 
   test "track controller routes" do
     store = fake_store
-    route_hash = {controller: "SomeController", action: "index", url_path: "path", verb: "GET"}
+    route_hash = {controller: "some/controller", action: "index", url_path: nil, verb: "GET"}
     store.raw_store.expects(:hset).with(tracker_key, route_hash.to_s, anything)
     tracker = Coverband::Collectors::RouteTracker.new(store: store, roots: "dir")
     payload = {
+      params: {"controller" => "some/controller"},
       controller: "SomeController",
       action: "index",
       path: "path",
@@ -58,9 +59,10 @@ class RouterTrackerTest < Minitest::Test
 
   test "report used routes" do
     store = fake_store
-    route_hash = {controller: "SomeController", action: "index", url_path: "path", verb: "GET"}
+    route_hash = {controller: "some/controller", action: "index", url_path: nil, verb: "GET"}
     tracker = Coverband::Collectors::RouteTracker.new(store: store, roots: "dir")
     payload = {
+      params: {"controller" => "some/controller"},
       controller: "SomeController",
       action: "index",
       path: "path",
@@ -73,8 +75,23 @@ class RouterTrackerTest < Minitest::Test
 
   test "report unused routes" do
     store = fake_store
-    tracker = Coverband::Collectors::RouteTracker.new(store: store, roots: "dir")
+    app_routes = [
+      {
+        controller: "some/controller",
+        action: "show",
+        url_path: "some/controller/show",
+        verb: "GET"
+      },
+      {
+        controller: "some/controller",
+        action: "index",
+        url_path: "some/controller/show",
+        verb: "GET"
+      }
+    ]
+    tracker = Coverband::Collectors::RouteTracker.new(store: store, roots: "dir", target: app_routes)
     payload = {
+      params: {"controller" => "some/controller"},
       controller: "SomeController",
       action: "index",
       path: "path",
@@ -82,12 +99,36 @@ class RouterTrackerTest < Minitest::Test
     }
     tracker.track_routes("name", "start", "finish", "id", payload)
     tracker.report_routes_tracked
+    assert_equal [app_routes.first], tracker.unused_routes
+  end
+
+  test "report unused routes pulls out parameterized routes" do
+    store = fake_store
+    app_routes = [
+      {
+        controller: "some/controller",
+        action: "show",
+        url_path: "some/controller/:user_id",
+        verb: "GET"
+      }
+    ]
+    tracker = Coverband::Collectors::RouteTracker.new(store: store, roots: "dir", target: app_routes)
+    payload = {
+      params: {"controller" => "some/controller"},
+      controller: "SomeController",
+      action: "show",
+      path: "some/controller/123",
+      method: "GET"
+    }
+    tracker.track_routes("name", "start", "finish", "id", payload)
+    tracker.report_routes_tracked
     assert_equal [], tracker.unused_routes
   end
 
   test "reset store" do
     store = fake_store
     payload = {
+      params: {"controller" => "some/controller"},
       controller: "SomeController",
       action: "index",
       path: "path",
@@ -102,9 +143,10 @@ class RouterTrackerTest < Minitest::Test
 
   test "clear_file" do
     store = fake_store
-    route_hash = {controller: "SomeController", action: "index", url_path: "path", verb: "GET"}
+    route_hash = {controller: "some/controller", action: "index", url_path: nil, verb: "GET"}
     tracker = Coverband::Collectors::RouteTracker.new(store: store, roots: "dir")
     payload = {
+      params: {"controller" => "some/controller"},
       controller: "SomeController",
       action: "index",
       path: "path",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 5.2.5.rc.2
+  version: 5.2.5.rc.3
 platform: ruby
 authors:
 - Dan Mayer
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-02 00:00:00.000000000 Z
+date: 2022-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: benchmark-ips