coverband 5.1.0.rcmailer.2 → 5.2.0.rc.2

data/test/coverband/utils/method_definition_scanner_test.rb

@@ -0,0 +1,85 @@
+# frozen_string_literal: true
+
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
+
+if defined?(RubyVM::AbstractSyntaxTree)
+  require "coverband/utils/method_definition_scanner"
+  module Coverband
+    module Utils
+      class MethodBodyTest < Minitest::Test
+        def test_no_method_body_coverage
+          method_body =
+            MethodDefinitionScanner::MethodBody.new(
+              MethodDefinitionScanner::MethodDefinition.new(
+                first_line_number: 4,
+                last_line_number: 6,
+                name: :bark,
+                class_name: :Dog,
+                file_path: "./test/dog.rb"
+              )
+            )
+          refute(method_body.coverage?([nil, nil, 1, 1, 0, nil, 1]))
+        end
+
+        def test_method_body_coverage
+          method_body =
+            MethodDefinitionScanner::MethodBody.new(
+              MethodDefinitionScanner::MethodDefinition.new(
+                first_line_number: 4,
+                last_line_number: 6,
+                name: :bark,
+                class_name: :Dog,
+                file_path: "./test/dog.rb"
+              )
+            )
+          assert(method_body.coverage?([nil, nil, 1, 1, 1, nil, 1]))
+        end
+      end
+
+      class MethodDefinitionScannerTest < Minitest::Test
+        def test_scan
+          method_definitions = MethodDefinitionScanner.scan("./test/dog.rb")
+          assert(method_definitions)
+          assert_equal(1, method_definitions.length)
+          method_definition = method_definitions.first # assert_equal(4, method.first_line)
+          assert_equal(4, method_definition.first_line_number)
+          assert_equal(6, method_definition.last_line_number)
+          assert_equal(:bark, method_definition.name)
+          assert_equal(:Dog, method_definition.class_name)
+        end
+
+        def test_scan_large_class
+          method_definitions =
+            MethodDefinitionScanner.scan("./test/fixtures/casting_invitor.rb")
+          method_first_line_numbers =
+            method_definitions.map(&:first_line_number)
+          assert_equal(
+            [6, 13, 17, 35, 40, 44, 48, 52],
+            method_first_line_numbers
+          )
+          method_last_line_numbers = method_definitions.map(&:last_line_number)
+          assert_equal(
+            [11, 15, 31, 38, 42, 46, 50, 59],
+            method_last_line_numbers
+          )
+          method_names = method_definitions.map(&:name)
+          assert_equal(
+            %i[
+              initialize
+              valid?
+              deliver
+              invalid_invitees
+              invitee_list
+              valid_message?
+              valid_invitees?
+              create_invitation
+            ],
+            method_names
+          )
+          class_names = method_definitions.map(&:class_name)
+          assert_equal(8.times.map { :CastingInviter }, class_names)
+        end
+      end
+    end
+  end
+end

data/test/fixtures/casting_invitor.rb

@@ -0,0 +1,60 @@
+class CastingInviter
+  EMAIL_REGEX = /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\z/
+
+  attr_reader :message, :invitees, :casting
+
+  def initialize(attributes = {})
+    @message = attributes[:message] || ""
+    @invitees = attributes[:invitees] || ""
+    @sender = attributes[:sender]
+    @casting = attributes[:casting]
+  end
+
+  def valid?
+    valid_message? && valid_invitees?
+  end
+
+  def deliver
+    if valid?
+      invitee_list.each do |email|
+        invitation = create_invitation(email)
+        Mailer.invitation_notification(invitation, @message)
+      end
+    else
+      failure_message =
+        "Your #{
+          @casting
+        } message couldn’t be sent. Invitees emails or message are invalid"
+      invitation = create_invitation(@sender)
+      Mailer.invitation_notification(invitation, failure_message)
+    end
+  end
+
+  private
+
+  def invalid_invitees
+    @invalid_invitees ||=
+      invitee_list.map { |item| item unless item.match(EMAIL_REGEX) }.compact
+  end
+
+  def invitee_list
+    @invitee_list ||= @invitees.gsub(/\s+/, "").split(/[\n,;]+/)
+  end
+
+  def valid_message?
+    @message.present?
+  end
+
+  def valid_invitees?
+    invalid_invitees.empty?
+  end
+
+  def create_invitation(email)
+    Invitation.create(
+      casting: @casting,
+      sender: @sender,
+      invitee_email: email,
+      status: "pending"
+    )
+  end
+end

data/test/forked/rails_full_stack_test.rb

@@ -58,7 +58,7 @@ class RailsFullStackTest < Minitest::Test
 
       # we don't want this to run during our standard test suite
       # as the below profiler changes the runtime
-      # and shold only be included for isolated processes
+      # and should only be included for isolated processes
       begin
         require "memory_profiler"
 

data/test/integration/full_stack_deferred_eager_test.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+require File.expand_path("../test_helper", File.dirname(__FILE__))
+require "rack"
+
+class FullStackDeferredEagerTest < Minitest::Test
+  REDIS_STORAGE_FORMAT_VERSION = Coverband::Adapters::RedisStore::REDIS_STORAGE_FORMAT_VERSION
+  TEST_RACK_APP = "../fake_app/basic_rack.rb"
+
+  def setup
+    super
+    Coverband::Collectors::Coverage.instance.reset_instance
+    Coverband.configure do |config|
+      config.background_reporting_enabled = false
+      config.track_gems = true
+      config.defer_eager_loading_data = true
+    end
+    Coverband.start
+    Coverband::Collectors::Coverage.instance.eager_loading!
+    @rack_file = require_unique_file "fake_app/basic_rack.rb"
+    Coverband.report_coverage
+    Coverband::Collectors::Coverage.instance.runtime!
+  end
+
+  test "call app" do
+    # eager loaded class coverage starts empty
+    Coverband.eager_loading_coverage!
+    expected = {}
+    assert_equal expected, Coverband.configuration.store.coverage
+
+    Coverband::Collectors::Coverage.instance.runtime!
+    request = Rack::MockRequest.env_for("/anything.json")
+    middleware = Coverband::BackgroundMiddleware.new(fake_app_with_lines)
+    results = middleware.call(request)
+    assert_equal "Hello Rack!", results.last
+    Coverband.report_coverage
+    expected = [nil, nil, 0, nil, 0, 0, 1, nil, nil]
+    assert_equal expected, Coverband.configuration.store.coverage[@rack_file]["data"]
+
+    # eager loaded class coverage is saved at first normal coverage report
+    Coverband.eager_loading_coverage!
+    expected = [nil, nil, 1, nil, 1, 1, 0, nil, nil]
+    assert_equal expected, Coverband.configuration.store.coverage[@rack_file]["data"]
+  end
+
+  private
+
+  def fake_app_with_lines
+    @fake_app_with_lines ||= ::HelloWorld.new
+  end
+end

data/test/test_helper.rb

@@ -3,6 +3,7 @@
 original_verbosity = $VERBOSE
 $VERBOSE = nil
 require "rubygems"
+require "pry-byebug" unless ENV["CI"]
 require "simplecov"
 require "coveralls"
 require "minitest/autorun"

data/test/unique_files.rb

@@ -20,10 +20,10 @@ def require_unique_file(file = "dog.rb", variables = {})
   Coverband::Utils::RelativeFileConverter.convert(File.expand_path(temp_file))
 end
 
-@@dogs = 0
 def require_class_unique_file
-  @@dogs += 1
-  require_unique_file("dog.rb.erb", dog_number: @@dogs)
+  @dogs ||= 0
+  @dogs += 1
+  require_unique_file("dog.rb.erb", dog_number: @dogs)
 end
 
 def remove_unique_files

data/views/file_list.erb

@@ -22,8 +22,8 @@
     <thead>
       <tr>
         <th title="The source file name">File</th>
-        <th title="Percentage of relavent lines covered (load & runtime)">% covered</th>
-        <th title="Runtime Percentage of relavent lines covered">% runtime</th>
+        <th title="Percentage of relevant lines covered (load & runtime)">% covered</th>
+        <th title="Runtime Percentage of relevant lines covered">% runtime</th>
         <th title="The total line number count for the file">Lines</th>
         <th title="Line number count excluding comments, whitespace, etc...">Relevant Lines</th>
         <th title="The number of lines covered (load & runtime)">Lines covered</th>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 5.1.0.rcmailer.2
+  version: 5.2.0.rc.2
 platform: ruby
 authors:
 - Dan Mayer
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-12-30 00:00:00.000000000 Z
+date: 2022-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
@@ -272,6 +272,7 @@ extra_rdoc_files: []
 files:
 - ".github/ISSUE_TEMPLATE/bug_report.md"
 - ".github/ISSUE_TEMPLATE/feature_request.md"
+- ".github/workflows/diagram.yml"
 - ".github/workflows/main.yml"
 - ".gitignore"
 - ".jrubyrc"
@@ -288,11 +289,13 @@ files:
 - changes.md
 - config.ru
 - coverband.gemspec
+- diagram.svg
 - lib/alternative_coverband_patch.rb
 - lib/coverband.rb
 - lib/coverband/adapters/base.rb
 - lib/coverband/adapters/file_store.rb
 - lib/coverband/adapters/hash_redis_store.rb
+- lib/coverband/adapters/null_store.rb
 - lib/coverband/adapters/redis_store.rb
 - lib/coverband/adapters/stdout_store.rb
 - lib/coverband/adapters/web_service_store.rb
@@ -312,11 +315,13 @@ files:
 - lib/coverband/reporters/html_report.rb
 - lib/coverband/reporters/web.rb
 - lib/coverband/utils/absolute_file_converter.rb
+- lib/coverband/utils/dead_methods.rb
 - lib/coverband/utils/file_hasher.rb
 - lib/coverband/utils/file_list.rb
 - lib/coverband/utils/html_formatter.rb
 - lib/coverband/utils/jruby_ext.rb
 - lib/coverband/utils/lines_classifier.rb
+- lib/coverband/utils/method_definition_scanner.rb
 - lib/coverband/utils/railtie.rb
 - lib/coverband/utils/relative_file_converter.rb
 - lib/coverband/utils/result.rb
@@ -356,6 +361,7 @@ files:
 - public/images/ui-icons_cd0a0a_256x240.png
 - public/loading.gif
 - public/magnify.png
+- roadmap.md
 - test/benchmarks/.gitignore
 - test/benchmarks/benchmark.rake
 - test/benchmarks/coverage_fork.sh
@@ -366,6 +372,7 @@ files:
 - test/coverband/adapters/base_test.rb
 - test/coverband/adapters/file_store_test.rb
 - test/coverband/adapters/hash_redis_store_test.rb
+- test/coverband/adapters/null_store_test.rb
 - test/coverband/adapters/redis_store_test.rb
 - test/coverband/adapters/web_service_store_test.rb
 - test/coverband/at_exit_test.rb
@@ -385,10 +392,12 @@ files:
 - test/coverband/reporters/html_test.rb
 - test/coverband/reporters/web_test.rb
 - test/coverband/utils/absolute_file_converter_test.rb
+- test/coverband/utils/dead_methods_test.rb
 - test/coverband/utils/file_hasher_test.rb
 - test/coverband/utils/file_list_test.rb
 - test/coverband/utils/html_formatter_test.rb
 - test/coverband/utils/lines_classifier_test.rb
+- test/coverband/utils/method_definition_scanner_test.rb
 - test/coverband/utils/relative_file_converter_test.rb
 - test/coverband/utils/result_test.rb
 - test/coverband/utils/results_test.rb
@@ -399,6 +408,7 @@ files:
 - test/fake_app/basic_rack.rb
 - test/fixtures/app/controllers/sample_controller.rb
 - test/fixtures/app/models/user.rb
+- test/fixtures/casting_invitor.rb
 - test/fixtures/never.rb
 - test/fixtures/sample.rb
 - test/fixtures/skipped.rb
@@ -408,6 +418,7 @@ files:
 - test/forked/rails_full_stack_views_test.rb
 - test/forked/rails_rake_full_stack_test.rb
 - test/forked/rails_view_tracker_stack_test.rb
+- test/integration/full_stack_deferred_eager_test.rb
 - test/integration/full_stack_test.rb
 - test/jruby_check.rb
 - test/rails4_dummy/Rakefile
@@ -467,7 +478,12 @@ files:
 homepage: https://github.com/danmayer/coverband
 licenses:
 - MIT
-metadata: {}
+metadata:
+  homepage_uri: https://github.com/danmayer/coverband
+  bug_tracker_uri: https://github.com/danmayer/coverband/issues
+  documentation_uri: https://github.com/danmayer/coverband
+  changelog_uri: https://github.com/danmayer/coverband/blob/main/changes.md
+  source_code_uri: https://github.com/danmayer/coverband
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -476,7 +492,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">"
@@ -498,6 +514,7 @@ test_files:
 - test/coverband/adapters/base_test.rb
 - test/coverband/adapters/file_store_test.rb
 - test/coverband/adapters/hash_redis_store_test.rb
+- test/coverband/adapters/null_store_test.rb
 - test/coverband/adapters/redis_store_test.rb
 - test/coverband/adapters/web_service_store_test.rb
 - test/coverband/at_exit_test.rb
@@ -517,10 +534,12 @@ test_files:
 - test/coverband/reporters/html_test.rb
 - test/coverband/reporters/web_test.rb
 - test/coverband/utils/absolute_file_converter_test.rb
+- test/coverband/utils/dead_methods_test.rb
 - test/coverband/utils/file_hasher_test.rb
 - test/coverband/utils/file_list_test.rb
 - test/coverband/utils/html_formatter_test.rb
 - test/coverband/utils/lines_classifier_test.rb
+- test/coverband/utils/method_definition_scanner_test.rb
 - test/coverband/utils/relative_file_converter_test.rb
 - test/coverband/utils/result_test.rb
 - test/coverband/utils/results_test.rb
@@ -531,6 +550,7 @@ test_files:
 - test/fake_app/basic_rack.rb
 - test/fixtures/app/controllers/sample_controller.rb
 - test/fixtures/app/models/user.rb
+- test/fixtures/casting_invitor.rb
 - test/fixtures/never.rb
 - test/fixtures/sample.rb
 - test/fixtures/skipped.rb
@@ -540,6 +560,7 @@ test_files:
 - test/forked/rails_full_stack_views_test.rb
 - test/forked/rails_rake_full_stack_test.rb
 - test/forked/rails_view_tracker_stack_test.rb
+- test/integration/full_stack_deferred_eager_test.rb
 - test/integration/full_stack_test.rb
 - test/jruby_check.rb
 - test/rails4_dummy/Rakefile