coverband 5.0.1 → 5.1.0

data/test/forked/rails_view_tracker_stack_test.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require File.expand_path("../rails_test_helper", File.dirname(__FILE__))
+
+class RailsWithoutConfigStackTest < Minitest::Test
+  def setup
+    super
+    setup_server
+  end
+
+  def teardown
+    super
+    shutdown_server
+  end
+
+  test "check view tracker" do
+    output = `sleep 7 && curl http://localhost:9999/dummy_view/show`
+    assert output.match(/rendered view/)
+    assert output.match(/I am no dummy view tracker text/)
+    output = `sleep 1 && curl http://localhost:9999/coverage/view_tracker`
+    assert output.match(/Used Views: \(1\)/)
+    assert output.match(/dummy_view\/show/)
+  end
+
+  private
+
+  # NOTE: We aren't leveraging Capybara because it loads all of our other test helpers and such,
+  # which in turn Configures coverband making it impossible to test the configuration error
+  def setup_server
+    ENV["RAILS_ENV"] = "test"
+    require "rails"
+    fork do
+      exec "cd test/rails#{Rails::VERSION::MAJOR}_dummy && COVERBAND_TEST=test bundle exec rackup config.ru -p 9999 --pid /tmp/testrack.pid"
+    end
+  end
+
+  def shutdown_server
+    if File.exist?("/tmp/testrack.pid")
+      pid = `cat /tmp/testrack.pid`&.strip&.to_i
+      Process.kill("HUP", pid)
+      sleep 1
+    end
+  end
+end

data/test/rails4_dummy/app/controllers/dummy_view_controller.rb

@@ -0,0 +1,16 @@
+class DummyViewController < ActionController::Base
+  def show
+    @text = "I am no dummy view tracker text"
+    render layout: false
+  end
+
+  def show_haml
+    @text = "I am haml text"
+    render layout: false
+  end
+
+  def show_slim
+    @text = "I am slim text"
+    render layout: false
+  end
+end

data/test/rails4_dummy/app/views/dummy_view/show.html.erb

@@ -0,0 +1,5 @@
+rendered view
+
+<div>
+  <%= @text %>
+</div>

data/test/rails4_dummy/app/views/dummy_view/show_haml.html.haml

@@ -0,0 +1,4 @@
+rendered haml view
+
+#foo
+  = @text

data/test/rails4_dummy/app/views/dummy_view/show_slim.html.slim

@@ -0,0 +1,4 @@
+rendered slim view
+
+#content
+  = @text

data/test/rails4_dummy/config/application.rb

@@ -10,5 +10,6 @@ Bundler.require(*Rails.groups)
 module Rails4Dummy
   class Application < Rails::Application
     config.eager_load = true
+    config.consider_all_requests_local = true
   end
 end

data/test/rails4_dummy/config/routes.rb

@@ -1,4 +1,7 @@
 Rails.application.routes.draw do
   get "dummy/show"
+  get "dummy_view/show", to: "dummy_view#show"
+  get "dummy_view/show_haml", to: "dummy_view#show_haml"
+  get "dummy_view/show_slim", to: "dummy_view#show_slim"
   mount Coverband::Reporters::Web.new, at: "/coverage"
 end

data/test/rails5_dummy/app/controllers/dummy_view_controller.rb

@@ -0,0 +1,16 @@
+class DummyViewController < ActionController::Base
+  def show
+    @text = "I am no dummy view tracker text"
+    render layout: false
+  end
+
+  def show_haml
+    @text = "I am haml text"
+    render layout: false
+  end
+
+  def show_slim
+    @text = "I am slim text"
+    render layout: false
+  end
+end

data/test/rails5_dummy/app/views/dummy_view/show.html.erb

@@ -0,0 +1,5 @@
+rendered view
+
+<div>
+  <%= @text %>
+</div>

data/test/rails5_dummy/app/views/dummy_view/show_haml.html.haml

@@ -0,0 +1,4 @@
+rendered haml view
+
+#foo
+  = @text

data/test/rails5_dummy/app/views/dummy_view/show_slim.html.slim

@@ -0,0 +1,4 @@
+rendered slim view
+
+#content
+  = @text

data/test/rails5_dummy/config/application.rb

@@ -2,11 +2,13 @@
 
 require "rails"
 require "action_controller/railtie"
+require "action_view/railtie"
 require "coverband"
 Bundler.require(*Rails.groups)
 
 module Rails5Dummy
   class Application < Rails::Application
     config.eager_load = true
+    config.consider_all_requests_local = true
   end
 end

data/test/rails5_dummy/config/coverband.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 
 Coverband.configure do |config|
-  config.root = Dir.pwd
+  # NOTE: we reuse this config in each of the fake rails projects
+  # the below ensures the root is set to the correct fake project
+  config.root = ::File.expand_path("../../../", __FILE__).to_s + "/rails#{Rails::VERSION::MAJOR}_dummy"
   config.store = Coverband::Adapters::RedisStore.new(Redis.new(db: 2, url: ENV["REDIS_URL"]), redis_namespace: "coverband_test") if defined? Redis
   config.ignore = %w[.erb$ .slim$]
   config.root_paths = []

data/test/rails5_dummy/config/routes.rb

@@ -1,4 +1,7 @@
 Rails.application.routes.draw do
   get "dummy/show"
+  get "dummy_view/show", to: "dummy_view#show"
+  get "dummy_view/show_haml", to: "dummy_view#show_haml"
+  get "dummy_view/show_slim", to: "dummy_view#show_slim"
   mount Coverband::Reporters::Web.new, at: "/coverage"
 end

data/test/rails6_dummy/app/controllers/dummy_view_controller.rb

@@ -0,0 +1,16 @@
+class DummyViewController < ActionController::Base
+  def show
+    @text = "I am no dummy view tracker text"
+    render layout: false
+  end
+
+  def show_haml
+    @text = "I am haml text"
+    render layout: false
+  end
+
+  def show_slim
+    @text = "I am slim text"
+    render layout: false
+  end
+end

data/test/rails6_dummy/app/views/dummy_view/show.html.erb

@@ -0,0 +1,5 @@
+rendered view
+
+<div>
+  <%= @text %>
+</div>

data/test/rails6_dummy/app/views/dummy_view/show_haml.html.haml

@@ -0,0 +1,4 @@
+rendered haml view
+
+#foo
+  = @text

data/test/rails6_dummy/app/views/dummy_view/show_slim.html.slim

@@ -0,0 +1,4 @@
+rendered slim view
+
+#content
+  = @text

data/test/rails6_dummy/config/application.rb

@@ -10,5 +10,6 @@ Bundler.require(*Rails.groups)
 module Rails6Dummy
   class Application < Rails::Application
     config.eager_load = true
+    config.consider_all_requests_local = true
   end
 end

data/test/rails6_dummy/config/routes.rb

@@ -1,4 +1,7 @@
 Rails.application.routes.draw do
   get "dummy/show"
+  get "dummy_view/show", to: "dummy_view#show"
+  get "dummy_view/show_haml", to: "dummy_view#show_haml"
+  get "dummy_view/show_slim", to: "dummy_view#show_slim"
   mount Coverband::Reporters::Web.new, at: "/coverage"
 end

data/test/test_helper.rb

@@ -3,6 +3,7 @@
 original_verbosity = $VERBOSE
 $VERBOSE = nil
 require "rubygems"
+require "pry-byebug" unless ENV["CI"]
 require "simplecov"
 require "coveralls"
 require "minitest/autorun"

data/views/view_tracker.erb

@@ -26,7 +26,7 @@
         <p>These views have not been rendered since recording started at <%= tracker.tracking_since %></p>
         <ul>
         <% tracker.unused_views.each do |view_file| %>
-          <li><%= view_file %></li>
+          <li class="unused-views"><%= view_file %></li>
         <% end %>
         </ul>
 
@@ -34,7 +34,7 @@
         <p>These views have been rendered at least once</p>
         <ul>
         <% tracker.used_views.each_pair do |view_file, time_at| %>
-          <li>
+          <li class="used-views">
             <%= view_file %>
             <span class="last_seen_at">last activity recorded <%= Time.at(time_at.to_i)%></span>
             <% if Coverband.configuration.web_enable_clear %>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 5.0.1
+  version: 5.1.0
 platform: ruby
 authors:
 - Dan Mayer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-07 00:00:00.000000000 Z
+date: 2020-12-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
@@ -270,11 +270,14 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/ISSUE_TEMPLATE/bug_report.md"
+- ".github/ISSUE_TEMPLATE/feature_request.md"
+- ".github/workflows/main.yml"
 - ".gitignore"
 - ".jrubyrc"
 - ".standard.yml"
-- ".travis.yml"
 - CODE_OF_CONDUCT.md
+- CONTRIBUTING.md
 - Gemfile
 - Gemfile.rails4
 - Gemfile.rails6
@@ -309,11 +312,13 @@ files:
 - lib/coverband/reporters/html_report.rb
 - lib/coverband/reporters/web.rb
 - lib/coverband/utils/absolute_file_converter.rb
+- lib/coverband/utils/dead_methods.rb
 - lib/coverband/utils/file_hasher.rb
 - lib/coverband/utils/file_list.rb
 - lib/coverband/utils/html_formatter.rb
 - lib/coverband/utils/jruby_ext.rb
 - lib/coverband/utils/lines_classifier.rb
+- lib/coverband/utils/method_definition_scanner.rb
 - lib/coverband/utils/railtie.rb
 - lib/coverband/utils/relative_file_converter.rb
 - lib/coverband/utils/result.rb
@@ -382,10 +387,12 @@ files:
 - test/coverband/reporters/html_test.rb
 - test/coverband/reporters/web_test.rb
 - test/coverband/utils/absolute_file_converter_test.rb
+- test/coverband/utils/dead_methods_test.rb
 - test/coverband/utils/file_hasher_test.rb
 - test/coverband/utils/file_list_test.rb
 - test/coverband/utils/html_formatter_test.rb
 - test/coverband/utils/lines_classifier_test.rb
+- test/coverband/utils/method_definition_scanner_test.rb
 - test/coverband/utils/relative_file_converter_test.rb
 - test/coverband/utils/result_test.rb
 - test/coverband/utils/results_test.rb
@@ -396,17 +403,24 @@ files:
 - test/fake_app/basic_rack.rb
 - test/fixtures/app/controllers/sample_controller.rb
 - test/fixtures/app/models/user.rb
+- test/fixtures/casting_invitor.rb
 - test/fixtures/never.rb
 - test/fixtures/sample.rb
 - test/fixtures/skipped.rb
 - test/fixtures/skipped_and_executed.rb
 - test/fixtures/utf-8.rb
 - test/forked/rails_full_stack_test.rb
+- test/forked/rails_full_stack_views_test.rb
 - test/forked/rails_rake_full_stack_test.rb
+- test/forked/rails_view_tracker_stack_test.rb
 - test/integration/full_stack_test.rb
 - test/jruby_check.rb
 - test/rails4_dummy/Rakefile
 - test/rails4_dummy/app/controllers/dummy_controller.rb
+- test/rails4_dummy/app/controllers/dummy_view_controller.rb
+- test/rails4_dummy/app/views/dummy_view/show.html.erb
+- test/rails4_dummy/app/views/dummy_view/show_haml.html.haml
+- test/rails4_dummy/app/views/dummy_view/show_slim.html.slim
 - test/rails4_dummy/config.ru
 - test/rails4_dummy/config/application.rb
 - test/rails4_dummy/config/boot.rb
@@ -418,6 +432,10 @@ files:
 - test/rails4_dummy/tmp/.keep
 - test/rails5_dummy/Rakefile
 - test/rails5_dummy/app/controllers/dummy_controller.rb
+- test/rails5_dummy/app/controllers/dummy_view_controller.rb
+- test/rails5_dummy/app/views/dummy_view/show.html.erb
+- test/rails5_dummy/app/views/dummy_view/show_haml.html.haml
+- test/rails5_dummy/app/views/dummy_view/show_slim.html.slim
 - test/rails5_dummy/config.ru
 - test/rails5_dummy/config/application.rb
 - test/rails5_dummy/config/coverband.rb
@@ -427,6 +445,10 @@ files:
 - test/rails5_dummy/tmp/.keep
 - test/rails6_dummy/Rakefile
 - test/rails6_dummy/app/controllers/dummy_controller.rb
+- test/rails6_dummy/app/controllers/dummy_view_controller.rb
+- test/rails6_dummy/app/views/dummy_view/show.html.erb
+- test/rails6_dummy/app/views/dummy_view/show_haml.html.haml
+- test/rails6_dummy/app/views/dummy_view/show_slim.html.slim
 - test/rails6_dummy/config.ru
 - test/rails6_dummy/config/application.rb
 - test/rails6_dummy/config/boot.rb
@@ -500,10 +522,12 @@ test_files:
 - test/coverband/reporters/html_test.rb
 - test/coverband/reporters/web_test.rb
 - test/coverband/utils/absolute_file_converter_test.rb
+- test/coverband/utils/dead_methods_test.rb
 - test/coverband/utils/file_hasher_test.rb
 - test/coverband/utils/file_list_test.rb
 - test/coverband/utils/html_formatter_test.rb
 - test/coverband/utils/lines_classifier_test.rb
+- test/coverband/utils/method_definition_scanner_test.rb
 - test/coverband/utils/relative_file_converter_test.rb
 - test/coverband/utils/result_test.rb
 - test/coverband/utils/results_test.rb
@@ -514,17 +538,24 @@ test_files:
 - test/fake_app/basic_rack.rb
 - test/fixtures/app/controllers/sample_controller.rb
 - test/fixtures/app/models/user.rb
+- test/fixtures/casting_invitor.rb
 - test/fixtures/never.rb
 - test/fixtures/sample.rb
 - test/fixtures/skipped.rb
 - test/fixtures/skipped_and_executed.rb
 - test/fixtures/utf-8.rb
 - test/forked/rails_full_stack_test.rb
+- test/forked/rails_full_stack_views_test.rb
 - test/forked/rails_rake_full_stack_test.rb
+- test/forked/rails_view_tracker_stack_test.rb
 - test/integration/full_stack_test.rb
 - test/jruby_check.rb
 - test/rails4_dummy/Rakefile
 - test/rails4_dummy/app/controllers/dummy_controller.rb
+- test/rails4_dummy/app/controllers/dummy_view_controller.rb
+- test/rails4_dummy/app/views/dummy_view/show.html.erb
+- test/rails4_dummy/app/views/dummy_view/show_haml.html.haml
+- test/rails4_dummy/app/views/dummy_view/show_slim.html.slim
 - test/rails4_dummy/config.ru
 - test/rails4_dummy/config/application.rb
 - test/rails4_dummy/config/boot.rb
@@ -536,6 +567,10 @@ test_files:
 - test/rails4_dummy/tmp/.keep
 - test/rails5_dummy/Rakefile
 - test/rails5_dummy/app/controllers/dummy_controller.rb
+- test/rails5_dummy/app/controllers/dummy_view_controller.rb
+- test/rails5_dummy/app/views/dummy_view/show.html.erb
+- test/rails5_dummy/app/views/dummy_view/show_haml.html.haml
+- test/rails5_dummy/app/views/dummy_view/show_slim.html.slim
 - test/rails5_dummy/config.ru
 - test/rails5_dummy/config/application.rb
 - test/rails5_dummy/config/coverband.rb
@@ -545,6 +580,10 @@ test_files:
 - test/rails5_dummy/tmp/.keep
 - test/rails6_dummy/Rakefile
 - test/rails6_dummy/app/controllers/dummy_controller.rb
+- test/rails6_dummy/app/controllers/dummy_view_controller.rb
+- test/rails6_dummy/app/views/dummy_view/show.html.erb
+- test/rails6_dummy/app/views/dummy_view/show_haml.html.haml
+- test/rails6_dummy/app/views/dummy_view/show_slim.html.slim
 - test/rails6_dummy/config.ru
 - test/rails6_dummy/config/application.rb
 - test/rails6_dummy/config/boot.rb

data/.travis.yml

@@ -1,48 +0,0 @@
-language: ruby
-rvm:
-  - "2.3"
-  - "2.4"
-  - "2.5"
-  - "2.6.1"
-  - "2.7"
-  - jruby-9.2.6.0
-gemfile:
-  - Gemfile
-  - Gemfile.rails4
-  - Gemfile.rails6
-env:
-  global:
-    # --dev improves JRuby startup time
-    # See https://github.com/jruby/jruby/wiki/Improving-startup-time
-    - JRUBY_OPTS="--dev"
-    - JAVA_OPTS="--add-opens java.base/{java.security.cert=ALL-UNNAMED --add-opens java.base/java.security=ALL-UNNAMED --add-opens java.base/java.util.zip=ALL-UNNAMED"
-
-jobs:
-  exclude:
-    - rvm: "2.3"
-      gemfile: Gemfile.rails6
-    - rvm: "2.4"
-      gemfile: Gemfile.rails6
-    - rvm: "2.7"
-      gemfile: Gemfile.rails4
-    - rvm: jruby-9.2.6.0
-      gemfile: Gemfile.rails4
-
-cache:
-  bundler: true
-  directories:
-    - $HOME/lua51
-services:
-  - redis-server
-script:
-  - sudo ./lua/install.sh
-  - $HOME/lua51/bin/busted lua/test/*
-  - bundle exec standardrb
-  - COVERBAND_HASH_REDIS_STORE=t bundle exec rake
-  - COVERBAND_HASH_REDIS_STORE=t bundle exec rake forked_tests
-  - bundle exec rake
-  - bundle exec rake forked_tests
-  # remove this for now as it is flaky
-  # passes locally on 2.3.5 on travis passes sometimes on 2.4 and always on 2.6.1
-  #- bundle exec rake benchmarks:memory
-  - bundle exec rake benchmarks