coverband 5.0.1.rc.1 → 5.1.0.rcmailer.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3b37c0fc6c990699ceb5af49f39121abb439a125f9740a40ece5b661085c116e
-  data.tar.gz: ac164ef1389b907353155c9beacd67e99a61397105f5c7f91fee8ef988ec6237
+  metadata.gz: 356bd2d155bece44c71e186cc25072ede61e25e3e8236c311cd2c160c93fd6b0
+  data.tar.gz: 609ac60c8757360b59ad63051e14357635bd2395b0ba9ba09add3140505415c7
 SHA512:
-  metadata.gz: 3e27a72cdc036a41f3d8466e8513fa4073a2615f54bb7e414a7690dae80e45cb5b5bf5617d17e55ef6660eaa9a8181962e33f0cdef046832b0cd1d277f93676b
-  data.tar.gz: 7563f4760ed9359746e2d35ddeaa22145a433c33cb5285c33794ecc46ea987e2ccb5e165e60fafb372f9ef3a2d03edd2fa2b2bf916bae198a9579498792c7a9e
+  metadata.gz: 929208aaadba979be02db9eb55153f91515c14bed94c94de7115255ea89413b87547518a6bbf11f250df506f8604dd1f64c9582b6536a4595943fd2692736776
+  data.tar.gz: 37ca9ec442e80223284a4b5e9ec6234d1fbff014270f7b9e905db71a9c7513e700a07417f47a123ecbc4b561b0adc075f2e68dd328763599c0f8b2676c555d08

data/.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,38 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Desktop (please complete the following information):**
+ - OS: [e.g. iOS]
+ - Browser [e.g. chrome, safari]
+ - Version [e.g. 22]
+
+**Smartphone (please complete the following information):**
+ - Device: [e.g. iPhone6]
+ - OS: [e.g. iOS8.1]
+ - Browser [e.g. stock browser, safari]
+ - Version [e.g. 22]
+
+**Additional context**
+Add any other context about the problem here.

data/.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

data/.github/workflows/main.yml

@@ -0,0 +1,30 @@
+name: CI
+# Controls when the action will run.
+on:
+  # Triggers the workflow on push or pull request events but only for the master branch
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+jobs:
+  test:
+    strategy:
+      fail-fast: false
+      matrix:
+        # need to figure out how to use redis on macos github actions
+        # os: [ubuntu, macos]
+        os: [ubuntu]
+        # remove until I sort out CI issues for truffle
+        # truffleruby,
+        # truffleruby-head,
+        ruby: [2.3, 2.4, 2.5, 2.6, 2.7, jruby, jruby-head]
+        redis-version: [5]
+    runs-on: ${{ matrix.os }}-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: supercharge/redis-github-action@1.1.0
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - run: bundle exec rake

data/CONTRIBUTING.md

@@ -0,0 +1 @@
+See our [code of conduct](https://github.com/danmayer/coverband/blob/master/CODE_OF_CONDUCT.md)

data/Gemfile

@@ -15,5 +15,7 @@ else
 end
 
 gem "rails", "~>5"
+gem "haml"
+gem "slim"
 # these gems are used for testing gem tracking
 gem "irb", require: false

data/Gemfile.rails4

@@ -5,3 +5,5 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in coverband.gemspec
 gemspec
 gem 'rails', '~>4'
+gem "haml"
+gem "slim"

data/Gemfile.rails6

@@ -5,3 +5,5 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in coverband.gemspec
 gemspec
 gem 'rails', '~>6'
+gem "haml"
+gem "slim"

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2010-2018 Dan Mayer
+Copyright (c) 2010-2020 Dan Mayer
 
 MIT License
 

data/README.md

@@ -2,7 +2,7 @@
 
 # Coverband
 
-[![Build Status](https://travis-ci.org/danmayer/coverband.svg?branch=master)](https://travis-ci.org/danmayer/coverband)
+[![GithubCI](https://github.com/danmayer/coverband/workflows/CI/badge.svg)](https://github.com/danmayer/coverband/actions)
 [![Coverage Status](https://coveralls.io/repos/github/danmayer/coverband/badge.svg?branch=master)](https://coveralls.io/github/danmayer/coverband?branch=master)
 [![Maintainability](https://api.codeclimate.com/v1/badges/1e6682f9540d75f26da7/maintainability)](https://codeclimate.com/github/danmayer/coverband/maintainability)
 [![Discord Shield](https://img.shields.io/discord/609509533999562753)](https://discord.gg/KAH38EV)
@@ -65,7 +65,7 @@ The Railtie integration means you shouldn't need to do anything else other than
 
 ## Sinatra
 
-For the best coverage you want this loaded as early as possible. We recommend requiring cover band directly in the `config.ru`.  Requiring coverband within an initializer could also work, but you may end up missing some boot up coverage. To start collection require Coverband as early as possible.
+For the best coverage you want this loaded as early as possible. We recommend requiring cover band directly in the `config.ru`. Requiring coverband within an initializer could also work, but you may end up missing some boot up coverage. To start collection require Coverband as early as possible.
 
 ```ruby
 require 'coverband'
@@ -91,7 +91,7 @@ run ActionController::Dispatcher.new
 
   - Clear coverage report
 
-    This will clear the coverage data. This wipes out all collected data. 
+    This will clear the coverage data. This wipes out all collected data.
 
   - Clear individual file coverage
 
@@ -128,10 +128,16 @@ or you can enable basic auth by setting `ENV['COVERBAND_PASSWORD']` or via your
 The coverage server can also be started standalone with a rake task:
 
 ```
- bundle exec rake coverband:coverage_server
+bundle exec rake coverband:coverage_server
 ```
 
-The web UI should then be available here: http://localhost:1022/
+The web UI should then be available here: http://localhost:9022/
+
+If you want to run on an alternative port:
+
+```
+COVERBAND_COVERAGE_PORT=8086 bundle exec rake coverband:coverage_server
+```
 
 This is especially useful for projects that are api only and cannot support the mounted rack app. To get production coverage, point coverband at your production redis server and ensure to checkout the production version of your project code locally.
 
@@ -298,6 +304,8 @@ rake coverband:coverage      # report runtime coverband code coverage
 
 Coverband starts on require of the the library which is usually done within the Gemfile. This can be disabled by setting the `COVERBAND_DISABLE_AUTO_START` environment variable. This environment variable can be useful to toggle coverband on and off in certain environments.
 
+**NOTE:** That any value set for `COVERBAND_DISABLE_AUTO_START` is considered true, it does not match the string content but only checks the presence of the ENV variable.
+
 In order to start coverband manually yourself when this flag is enabled, call `Coverband.configure` followed by `Coverband.start`.
 
 ```ruby
@@ -327,7 +335,7 @@ If you currently have require: false, remove the 'coverband' string from the req
 gem 'coverband', require: ['alternative_coverband_patch']
 ```
 
-This conflict happens when a ruby method is patched twice, once using module prepend, and once using method aliasing. See this ruby issue for details. The fix is to apply all patches the same way. Coverband by default will apply its patch using prepend, but you can change that to  method aliasing by adding require: ['alternative_coverband_patch'] to the gem line as shown above.
+This conflict happens when a ruby method is patched twice, once using module prepend, and once using method aliasing. See this ruby issue for details. The fix is to apply all patches the same way. Coverband by default will apply its patch using prepend, but you can change that to method aliasing by adding require: ['alternative_coverband_patch'] to the gem line as shown above.
 
 # Prerequisites
 
@@ -379,7 +387,9 @@ If you submit a change please make sure the tests and benchmarks are passing.
 - **total fail** on front end code, for line for line coverage, because of the precompiled template step basically coverage doesn't work well for `erb`, `slim`, and the like.
   - related it will try to report something, but the line numbers reported for `ERB` files are often off and aren't considered useful. I recommend filtering out .erb using the `config.ignore` option. The default configuration excludes these files
   - **NOTE:** We now have file level coverage for view files, but don't support line level detail
-  - The view file detection doesn't workf or mailers at the moment only for web related views / JSON templates. This is due to how Rails active mailer notifications work.
+- **Coverage does NOT work when used alongside Scout APM Auto Instrumentation**
+  - In an environment that uses Scout's `AUTO_INSTRUMENT=true` (usually production or staging) it stops reporting any coverage, it will show one or two files that have been loaded at the start but everything else will show up as having 0% coverage
+  - Bug tracked here: https://github.com/scoutapp/scout_apm_ruby/issues/343
 
 ### Debugging Redis Store
 

data/changes.md

@@ -53,12 +53,27 @@ Will be the fully modern release that drops maintenance legacy support in favor
 
 # Alpha / Beta / Release Candidates
 
-### Coverband 5.0.1
+### Coverband 5.0.4
 
 - ?
 
 # Released
 
+### Coverband 5.0.3
+
+- fix for non standard root paths for view_tracker thx @markshawtoronto 
+- support basic auth for Rack prior to 2.0 thx @kadru
+
+### Coverband 5.0.2
+
+- change default port of local server
+- update on readme about issue with scout app, thanks @mrbongiolo 
+- fix on configuration page not loading when redis can't load
+
+### Coverband 5.0.1
+
+- fix for race condition on view tracker redis configuration setting ensuring it is set after it is configured... bug only impacted apps that have multiple redis connections for the same system and have Coverband not on the default REDIS_URL
+
 ### Coverband 5.0.0
 
 - Full JRuby support

data/lib/coverband/adapters/base.rb

@@ -40,7 +40,11 @@ module Coverband
       end
 
       def size_in_mib
-        format("%<size>.2f", size: (size.to_f / 2**20))
+        if size
+          format("%<size>.2f", size: (size.to_f / 2**20))
+        else
+          "N/A"
+        end
       end
 
       def save_report(_report)

data/lib/coverband/adapters/file_store.rb

@@ -20,7 +20,7 @@ module Coverband
     # files matching the path pattern, in this case `log/coverage.log.*`
     #
     # run: `bundle exec rake coverband:coverage_server`
-    # open http://localhost:1022/
+    # open http://localhost:9022/
     #
     # one could also build a report via code, the output is suitable to feed into SimpleCov
     #

data/lib/coverband/adapters/redis_store.rb

@@ -44,7 +44,7 @@ module Coverband
       end
 
       def size
-        @redis.get(base_key).bytesize
+        @redis.get(base_key) ? @redis.get(base_key).bytesize : "N/A"
       end
 
       ###

data/lib/coverband/at_exit.rb

@@ -20,6 +20,9 @@ module Coverband
             # skip reporting
           else
             Coverband.report_coverage
+            # to ensure we track mailer views we now need to report views tracking
+            # at exit as well for rake tasks and background tasks that can trigger email
+            Coverband.configuration.view_tracker&.report_views_tracked
           end
         end
       end

data/lib/coverband/collectors/view_tracker.rb

@@ -10,22 +10,20 @@ module Coverband
     # This is a port of Flatfoot, a project I open sourced years ago,
     # but am now rolling into Coverband
     # https://github.com/livingsocial/flatfoot
-    #
-    # TODO: test and ensure slim, haml, and other support
     ###
     class ViewTracker
-      DEFAULT_TARGET = Dir.glob("app/views/**/*.html.erb").reject { |file| file.match(/(_mailer)/) }
       attr_accessor :target, :logged_views, :views_to_record
       attr_reader :logger, :roots, :store, :ignore_patterns
 
       def initialize(options = {})
         raise NotImplementedError, "View Tracker requires Rails 4 or greater" unless self.class.supported_version?
+        raise "Coverband: view tracker initialized before configuration!" if !Coverband.configured? && ENV["COVERBAND_TEST"] == "test"
 
         @project_directory = File.expand_path(Coverband.configuration.root)
         @ignore_patterns = Coverband.configuration.ignore
         @store = options.fetch(:store) { Coverband.configuration.store }
         @logger = options.fetch(:logger) { Coverband.configuration.logger }
-        @target = options.fetch(:target) { DEFAULT_TARGET }
+        @target = options.fetch(:target) { Dir.glob("#{@project_directory}/app/views/**/*.html.{erb,haml,slim}") }
 
         @roots = options.fetch(:roots) { Coverband.configuration.all_root_patterns }
         @roots = @roots.split(",") if @roots.is_a?(String)
@@ -65,18 +63,29 @@ module Coverband
         normalized_views = {}
         views.each_pair do |view, time|
           roots.each do |root|
-            view = view.gsub(/#{root}/, "")
+            view = view.gsub(root, "")
           end
           normalized_views[view] = time
         end
         normalized_views
       end
 
+      def all_views
+        all_views = []
+        target.each do |view|
+          roots.each do |root|
+            view = view.gsub(root, "")
+          end
+          all_views << view
+        end
+        all_views.uniq
+      end
+
       def unused_views
         recently_used_views = used_views.keys
-        all_views = target.reject { |view| recently_used_views.include?(view) }
+        unused_views = all_views.reject { |view| recently_used_views.include?(view) }
         # since layouts don't include format we count them used if they match with ANY formats
-        all_views.reject { |view| view.match(/\/layouts\//) && recently_used_views.any? { |used_view| view.include?(used_view) } }
+        unused_views.reject { |view| view.match(/\/layouts\//) && recently_used_views.any? { |used_view| view.include?(used_view) } }
       end
 
       def as_json

data/lib/coverband/reporters/web.rb

@@ -23,7 +23,8 @@ module Coverband
       def check_auth
         return true unless Coverband.configuration.password
 
-        auth_header = request.get_header("HTTP_AUTHORIZATION")
+        # support rack 1.6.x and rack 2.0 (get_header)
+        auth_header = request.respond_to?(:get_header) ? request.get_header("HTTP_AUTHORIZATION") : request.env["HTTP_AUTHORIZATION"]
         return unless auth_header
 
         Coverband.configuration.password == Base64.decode64(auth_header.split[1]).split(":")[1]

data/lib/coverband/utils/tasks.rb

@@ -13,7 +13,7 @@ namespace :coverband do
   task :coverage_server do
     Rake.application["environment"].invoke if Rake::Task.task_defined?("environment")
     Coverband.configuration.store.merge_mode = true if Coverband.configuration.store.is_a?(Coverband::Adapters::FileStore)
-    Rack::Server.start app: Coverband::Reporters::Web.new, Port: ENV.fetch("COVERBAND_COVERAGE_PORT", 1022).to_i
+    Rack::Server.start app: Coverband::Reporters::Web.new, Port: ENV.fetch("COVERBAND_COVERAGE_PORT", 9022).to_i
   end
 
   ###

data/lib/coverband/version.rb

@@ -5,5 +5,5 @@
 # use format '4.2.1.rc.1' ~> 4.2.1.rc to prerelease versions like v4.2.1.rc.2 and v4.2.1.rc.3
 ###
 module Coverband
-  VERSION = "5.0.1.rc.1"
+  VERSION = "5.1.0.rcmailer.2"
 end

data/test/coverband/collectors/view_tracker_test.rb

@@ -42,6 +42,16 @@ class ReporterTest < Minitest::Test
     assert_equal [file_path], tracker.used_views.keys
   end
 
+  test "track partials that include the word _mailer in the path" do
+    Coverband::Collectors::ViewTracker.expects(:supported_version?).returns(true)
+    store = fake_store
+    file_path = "#{File.expand_path(Coverband.configuration.root)}/_mailer/file"
+    tracker = Coverband::Collectors::ViewTracker.new(store: store, roots: "dir")
+    tracker.track_views("name", "start", "finish", "id", identifier: file_path)
+    tracker.report_views_tracked
+    assert_equal [file_path], tracker.used_views.keys
+  end
+
   test "ignore partials that include the folder vendor in the path" do
     Coverband::Collectors::ViewTracker.expects(:supported_version?).returns(true)
     store = fake_store

data/test/coverband/reporters/web_test.rb

@@ -43,4 +43,38 @@ if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.2.0")
       end
     end
   end
+
+  module Coverband
+    class AuthWebTest < Minitest::Test
+      include Rack::Test::Methods
+
+      def setup
+        super
+        @store = Coverband.configuration.store
+        Coverband.configure do |config|
+          config.password = "test_pass"
+        end
+      end
+
+      def app
+        Coverband::Reporters::Web.new
+      end
+
+      def teardown
+        super
+      end
+
+      test "renders index with basic auth" do
+        basic_authorize "anything", "test_pass"
+        get "/"
+        assert last_response.ok?
+        assert_match "Coverband Home", last_response.body
+      end
+
+      test "renders 401 auth error when not provided" do
+        get "/"
+        assert_equal 401, last_response.status
+      end
+    end
+  end
 end

data/test/forked/rails_full_stack_test.rb

@@ -35,7 +35,7 @@ class RailsFullStackTest < Minitest::Test
       end
 
       # Test eager load data stored separately
-      dummy_controller = "./test/rails#{Rails::VERSION::MAJOR}_dummy/app/controllers/dummy_controller.rb"
+      dummy_controller = "./app/controllers/dummy_controller.rb"
       store.type = :eager_loading
       eager_expected = [1, 1, 0, nil, nil]
       results = store.coverage[dummy_controller]["data"]

data/test/forked/rails_full_stack_views_test.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+require File.expand_path("../rails_test_helper", File.dirname(__FILE__))
+
+class RailsFullStackTest < Minitest::Test
+  include Capybara::DSL
+  include Capybara::Minitest::Assertions
+
+  def setup
+    super
+    rails_setup
+    Coverband.report_coverage
+  end
+
+  def teardown
+    super
+    Capybara.reset_sessions!
+    Capybara.use_default_driver
+  end
+
+  test "verify erb haml slim support" do
+    visit "/dummy_view/show"
+    assert_content("I am no dummy view tracker text")
+    Coverband.report_coverage
+    Coverband.configuration.view_tracker&.report_views_tracked
+    visit "/coverage/view_tracker"
+    assert_content("Used Views: (1)")
+    assert_content("Unused Views: (2)")
+    assert_selector("li.used-views", text: "dummy_view/show.html.erb")
+    assert_selector("li.unused-views", text: "dummy_view/show_haml.html.haml")
+    assert_selector("li.unused-views", text: "dummy_view/show_slim.html.slim")
+
+    visit "/dummy_view/show_haml"
+    assert_content("I am haml text")
+    Coverband.report_coverage
+    Coverband.configuration.view_tracker&.report_views_tracked
+    visit "/coverage/view_tracker"
+    assert_content("Used Views: (2)")
+    assert_content("Unused Views: (1)")
+    assert_selector("li.used-views", text: "dummy_view/show_haml.html.haml")
+
+    visit "/dummy_view/show_slim"
+    assert_content("I am slim text")
+    Coverband.report_coverage
+    Coverband.configuration.view_tracker&.report_views_tracked
+    visit "/coverage/view_tracker"
+    assert_content("Used Views: (3)")
+    assert_content("Unused Views: (0)")
+    assert_selector("li.used-views", text: "dummy_view/show_slim.html.slim")
+  end
+end

data/test/forked/rails_view_tracker_stack_test.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require File.expand_path("../rails_test_helper", File.dirname(__FILE__))
+
+class RailsWithoutConfigStackTest < Minitest::Test
+  def setup
+    super
+    setup_server
+  end
+
+  def teardown
+    super
+    shutdown_server
+  end
+
+  test "check view tracker" do
+    output = `sleep 7 && curl http://localhost:9999/dummy_view/show`
+    assert output.match(/rendered view/)
+    assert output.match(/I am no dummy view tracker text/)
+    output = `sleep 1 && curl http://localhost:9999/coverage/view_tracker`
+    assert output.match(/Used Views: \(1\)/)
+    assert output.match(/dummy_view\/show/)
+  end
+
+  private
+
+  # NOTE: We aren't leveraging Capybara because it loads all of our other test helpers and such,
+  # which in turn Configures coverband making it impossible to test the configuration error
+  def setup_server
+    ENV["RAILS_ENV"] = "test"
+    require "rails"
+    fork do
+      exec "cd test/rails#{Rails::VERSION::MAJOR}_dummy && COVERBAND_TEST=test bundle exec rackup config.ru -p 9999 --pid /tmp/testrack.pid"
+    end
+  end
+
+  def shutdown_server
+    if File.exist?("/tmp/testrack.pid")
+      pid = `cat /tmp/testrack.pid`&.strip&.to_i
+      Process.kill("HUP", pid)
+      sleep 1
+    end
+  end
+end

data/test/rails4_dummy/app/controllers/dummy_view_controller.rb

@@ -0,0 +1,16 @@
+class DummyViewController < ActionController::Base
+  def show
+    @text = "I am no dummy view tracker text"
+    render layout: false
+  end
+
+  def show_haml
+    @text = "I am haml text"
+    render layout: false
+  end
+
+  def show_slim
+    @text = "I am slim text"
+    render layout: false
+  end
+end

data/test/rails4_dummy/app/views/dummy_view/show.html.erb

@@ -0,0 +1,5 @@
+rendered view
+
+<div>
+  <%= @text %>
+</div>

data/test/rails4_dummy/app/views/dummy_view/show_haml.html.haml

@@ -0,0 +1,4 @@
+rendered haml view
+
+#foo
+  = @text

data/test/rails4_dummy/app/views/dummy_view/show_slim.html.slim

@@ -0,0 +1,4 @@
+rendered slim view
+
+#content
+  = @text

data/test/rails4_dummy/config/application.rb

@@ -10,5 +10,6 @@ Bundler.require(*Rails.groups)
 module Rails4Dummy
   class Application < Rails::Application
     config.eager_load = true
+    config.consider_all_requests_local = true
   end
 end

data/test/rails4_dummy/config/routes.rb

@@ -1,4 +1,7 @@
 Rails.application.routes.draw do
   get "dummy/show"
+  get "dummy_view/show", to: "dummy_view#show"
+  get "dummy_view/show_haml", to: "dummy_view#show_haml"
+  get "dummy_view/show_slim", to: "dummy_view#show_slim"
   mount Coverband::Reporters::Web.new, at: "/coverage"
 end

data/test/rails5_dummy/app/controllers/dummy_view_controller.rb

@@ -0,0 +1,16 @@
+class DummyViewController < ActionController::Base
+  def show
+    @text = "I am no dummy view tracker text"
+    render layout: false
+  end
+
+  def show_haml
+    @text = "I am haml text"
+    render layout: false
+  end
+
+  def show_slim
+    @text = "I am slim text"
+    render layout: false
+  end
+end

data/test/rails5_dummy/app/views/dummy_view/show.html.erb

@@ -0,0 +1,5 @@
+rendered view
+
+<div>
+  <%= @text %>
+</div>

data/test/rails5_dummy/app/views/dummy_view/show_haml.html.haml

@@ -0,0 +1,4 @@
+rendered haml view
+
+#foo
+  = @text

data/test/rails5_dummy/app/views/dummy_view/show_slim.html.slim

@@ -0,0 +1,4 @@
+rendered slim view
+
+#content
+  = @text

data/test/rails5_dummy/config/application.rb

@@ -2,11 +2,13 @@
 
 require "rails"
 require "action_controller/railtie"
+require "action_view/railtie"
 require "coverband"
 Bundler.require(*Rails.groups)
 
 module Rails5Dummy
   class Application < Rails::Application
     config.eager_load = true
+    config.consider_all_requests_local = true
   end
 end

data/test/rails5_dummy/config/coverband.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 
 Coverband.configure do |config|
-  config.root = Dir.pwd
+  # NOTE: we reuse this config in each of the fake rails projects
+  # the below ensures the root is set to the correct fake project
+  config.root = ::File.expand_path("../../../", __FILE__).to_s + "/rails#{Rails::VERSION::MAJOR}_dummy"
   config.store = Coverband::Adapters::RedisStore.new(Redis.new(db: 2, url: ENV["REDIS_URL"]), redis_namespace: "coverband_test") if defined? Redis
   config.ignore = %w[.erb$ .slim$]
   config.root_paths = []

data/test/rails5_dummy/config/routes.rb

@@ -1,4 +1,7 @@
 Rails.application.routes.draw do
   get "dummy/show"
+  get "dummy_view/show", to: "dummy_view#show"
+  get "dummy_view/show_haml", to: "dummy_view#show_haml"
+  get "dummy_view/show_slim", to: "dummy_view#show_slim"
   mount Coverband::Reporters::Web.new, at: "/coverage"
 end

data/test/rails6_dummy/app/controllers/dummy_view_controller.rb

@@ -0,0 +1,16 @@
+class DummyViewController < ActionController::Base
+  def show
+    @text = "I am no dummy view tracker text"
+    render layout: false
+  end
+
+  def show_haml
+    @text = "I am haml text"
+    render layout: false
+  end
+
+  def show_slim
+    @text = "I am slim text"
+    render layout: false
+  end
+end

data/test/rails6_dummy/app/views/dummy_view/show.html.erb

@@ -0,0 +1,5 @@
+rendered view
+
+<div>
+  <%= @text %>
+</div>

data/test/rails6_dummy/app/views/dummy_view/show_haml.html.haml

@@ -0,0 +1,4 @@
+rendered haml view
+
+#foo
+  = @text

data/test/rails6_dummy/app/views/dummy_view/show_slim.html.slim

@@ -0,0 +1,4 @@
+rendered slim view
+
+#content
+  = @text

data/test/rails6_dummy/config/application.rb

@@ -10,5 +10,6 @@ Bundler.require(*Rails.groups)
 module Rails6Dummy
   class Application < Rails::Application
     config.eager_load = true
+    config.consider_all_requests_local = true
   end
 end

data/test/rails6_dummy/config/routes.rb

@@ -1,4 +1,7 @@
 Rails.application.routes.draw do
   get "dummy/show"
+  get "dummy_view/show", to: "dummy_view#show"
+  get "dummy_view/show_haml", to: "dummy_view#show_haml"
+  get "dummy_view/show_slim", to: "dummy_view#show_slim"
   mount Coverband::Reporters::Web.new, at: "/coverage"
 end

data/views/view_tracker.erb

@@ -26,7 +26,7 @@
         <p>These views have not been rendered since recording started at <%= tracker.tracking_since %></p>
         <ul>
         <% tracker.unused_views.each do |view_file| %>
-          <li><%= view_file %></li>
+          <li class="unused-views"><%= view_file %></li>
         <% end %>
         </ul>
 
@@ -34,7 +34,7 @@
         <p>These views have been rendered at least once</p>
         <ul>
         <% tracker.used_views.each_pair do |view_file, time_at| %>
-          <li>
+          <li class="used-views">
             <%= view_file %>
             <span class="last_seen_at">last activity recorded <%= Time.at(time_at.to_i)%></span>
             <% if Coverband.configuration.web_enable_clear %>

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 5.0.1.rc.1
+  version: 5.1.0.rcmailer.2
 platform: ruby
 authors:
 - Dan Mayer
 - Karl Baum
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-07 00:00:00.000000000 Z
+date: 2020-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
@@ -270,11 +270,14 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/ISSUE_TEMPLATE/bug_report.md"
+- ".github/ISSUE_TEMPLATE/feature_request.md"
+- ".github/workflows/main.yml"
 - ".gitignore"
 - ".jrubyrc"
 - ".standard.yml"
-- ".travis.yml"
 - CODE_OF_CONDUCT.md
+- CONTRIBUTING.md
 - Gemfile
 - Gemfile.rails4
 - Gemfile.rails6
@@ -402,11 +405,17 @@ files:
 - test/fixtures/skipped_and_executed.rb
 - test/fixtures/utf-8.rb
 - test/forked/rails_full_stack_test.rb
+- test/forked/rails_full_stack_views_test.rb
 - test/forked/rails_rake_full_stack_test.rb
+- test/forked/rails_view_tracker_stack_test.rb
 - test/integration/full_stack_test.rb
 - test/jruby_check.rb
 - test/rails4_dummy/Rakefile
 - test/rails4_dummy/app/controllers/dummy_controller.rb
+- test/rails4_dummy/app/controllers/dummy_view_controller.rb
+- test/rails4_dummy/app/views/dummy_view/show.html.erb
+- test/rails4_dummy/app/views/dummy_view/show_haml.html.haml
+- test/rails4_dummy/app/views/dummy_view/show_slim.html.slim
 - test/rails4_dummy/config.ru
 - test/rails4_dummy/config/application.rb
 - test/rails4_dummy/config/boot.rb
@@ -418,6 +427,10 @@ files:
 - test/rails4_dummy/tmp/.keep
 - test/rails5_dummy/Rakefile
 - test/rails5_dummy/app/controllers/dummy_controller.rb
+- test/rails5_dummy/app/controllers/dummy_view_controller.rb
+- test/rails5_dummy/app/views/dummy_view/show.html.erb
+- test/rails5_dummy/app/views/dummy_view/show_haml.html.haml
+- test/rails5_dummy/app/views/dummy_view/show_slim.html.slim
 - test/rails5_dummy/config.ru
 - test/rails5_dummy/config/application.rb
 - test/rails5_dummy/config/coverband.rb
@@ -427,6 +440,10 @@ files:
 - test/rails5_dummy/tmp/.keep
 - test/rails6_dummy/Rakefile
 - test/rails6_dummy/app/controllers/dummy_controller.rb
+- test/rails6_dummy/app/controllers/dummy_view_controller.rb
+- test/rails6_dummy/app/views/dummy_view/show.html.erb
+- test/rails6_dummy/app/views/dummy_view/show_haml.html.haml
+- test/rails6_dummy/app/views/dummy_view/show_slim.html.slim
 - test/rails6_dummy/config.ru
 - test/rails6_dummy/config/application.rb
 - test/rails6_dummy/config/boot.rb
@@ -451,7 +468,7 @@ homepage: https://github.com/danmayer/coverband
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -467,7 +484,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubygems_version: 3.0.3
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Rack middleware to measure production code usage (LOC runtime usage)
 test_files:
@@ -520,11 +537,17 @@ test_files:
 - test/fixtures/skipped_and_executed.rb
 - test/fixtures/utf-8.rb
 - test/forked/rails_full_stack_test.rb
+- test/forked/rails_full_stack_views_test.rb
 - test/forked/rails_rake_full_stack_test.rb
+- test/forked/rails_view_tracker_stack_test.rb
 - test/integration/full_stack_test.rb
 - test/jruby_check.rb
 - test/rails4_dummy/Rakefile
 - test/rails4_dummy/app/controllers/dummy_controller.rb
+- test/rails4_dummy/app/controllers/dummy_view_controller.rb
+- test/rails4_dummy/app/views/dummy_view/show.html.erb
+- test/rails4_dummy/app/views/dummy_view/show_haml.html.haml
+- test/rails4_dummy/app/views/dummy_view/show_slim.html.slim
 - test/rails4_dummy/config.ru
 - test/rails4_dummy/config/application.rb
 - test/rails4_dummy/config/boot.rb
@@ -536,6 +559,10 @@ test_files:
 - test/rails4_dummy/tmp/.keep
 - test/rails5_dummy/Rakefile
 - test/rails5_dummy/app/controllers/dummy_controller.rb
+- test/rails5_dummy/app/controllers/dummy_view_controller.rb
+- test/rails5_dummy/app/views/dummy_view/show.html.erb
+- test/rails5_dummy/app/views/dummy_view/show_haml.html.haml
+- test/rails5_dummy/app/views/dummy_view/show_slim.html.slim
 - test/rails5_dummy/config.ru
 - test/rails5_dummy/config/application.rb
 - test/rails5_dummy/config/coverband.rb
@@ -545,6 +572,10 @@ test_files:
 - test/rails5_dummy/tmp/.keep
 - test/rails6_dummy/Rakefile
 - test/rails6_dummy/app/controllers/dummy_controller.rb
+- test/rails6_dummy/app/controllers/dummy_view_controller.rb
+- test/rails6_dummy/app/views/dummy_view/show.html.erb
+- test/rails6_dummy/app/views/dummy_view/show_haml.html.haml
+- test/rails6_dummy/app/views/dummy_view/show_slim.html.slim
 - test/rails6_dummy/config.ru
 - test/rails6_dummy/config/application.rb
 - test/rails6_dummy/config/boot.rb

data/.travis.yml

@@ -1,48 +0,0 @@
-language: ruby
-rvm:
-  - "2.3"
-  - "2.4"
-  - "2.5"
-  - "2.6.1"
-  - "2.7"
-  - jruby-9.2.6.0
-gemfile:
-  - Gemfile
-  - Gemfile.rails4
-  - Gemfile.rails6
-env:
-  global:
-    # --dev improves JRuby startup time
-    # See https://github.com/jruby/jruby/wiki/Improving-startup-time
-    - JRUBY_OPTS="--dev"
-    - JAVA_OPTS="--add-opens java.base/{java.security.cert=ALL-UNNAMED --add-opens java.base/java.security=ALL-UNNAMED --add-opens java.base/java.util.zip=ALL-UNNAMED"
-
-jobs:
-  exclude:
-    - rvm: "2.3"
-      gemfile: Gemfile.rails6
-    - rvm: "2.4"
-      gemfile: Gemfile.rails6
-    - rvm: "2.7"
-      gemfile: Gemfile.rails4
-    - rvm: jruby-9.2.6.0
-      gemfile: Gemfile.rails4
-
-cache:
-  bundler: true
-  directories:
-    - $HOME/lua51
-services:
-  - redis-server
-script:
-  - sudo ./lua/install.sh
-  - $HOME/lua51/bin/busted lua/test/*
-  - bundle exec standardrb
-  - COVERBAND_HASH_REDIS_STORE=t bundle exec rake
-  - COVERBAND_HASH_REDIS_STORE=t bundle exec rake forked_tests
-  - bundle exec rake
-  - bundle exec rake forked_tests
-  # remove this for now as it is flaky
-  # passes locally on 2.3.5 on travis passes sometimes on 2.4 and always on 2.6.1
-  #- bundle exec rake benchmarks:memory
-  - bundle exec rake benchmarks