coverband 4.2.7 → 5.0.0.rc.3

data/test/dog.rb

@@ -2,6 +2,6 @@
 
 class Dog
   def bark
-    'woof'
+    "woof"
   end
 end

data/test/fake_app/basic_rack.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-require 'rack'
+require "rack"
 
 class HelloWorld
   def call(_env)
-    [200, { 'Content-Type' => 'text/html' }, 'Hello Rack!']
+    [200, {"Content-Type" => "text/html"}, "Hello Rack!"]
   end
 end

data/test/fixtures/app/controllers/sample_controller.rb

@@ -1,7 +1,7 @@
 # Foo class
 class Foo
   def initialize
-    @foo = 'baz'
+    @foo = "baz"
   end
 
   def bar

data/test/fixtures/app/models/user.rb

@@ -1,7 +1,7 @@
 # Foo class
 class Foo
   def initialize
-    @foo = 'baz'
+    @foo = "baz"
   end
 
   def bar

data/test/fixtures/sample.rb

@@ -1,7 +1,7 @@
 # Foo class
 class Foo
   def initialize
-    @foo = 'baz'
+    @foo = "baz"
   end
 
   def bar

data/test/fixtures/utf-8.rb

@@ -1,3 +1 @@
-# encoding: utf-8
-
 puts "135°C"

data/test/forked/rails_full_stack_test.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../rails_test_helper', File.dirname(__FILE__))
+require File.expand_path("../rails_test_helper", File.dirname(__FILE__))
 
 class RailsFullStackTest < Minitest::Test
   include Capybara::DSL
@@ -11,8 +11,8 @@ class RailsFullStackTest < Minitest::Test
     rails_setup
     # preload first coverage hit
     Coverband.report_coverage
-    require 'rainbow'
-    Rainbow('this text is red').red
+    require "rainbow"
+    Rainbow("this text is red").red
   end
 
   def teardown
@@ -24,30 +24,27 @@ class RailsFullStackTest < Minitest::Test
   # We have to combine everything in one test
   # because we can only initialize rails once per test
   # run. Possibly fork test runs to avoid this problem in future?
-  unless ENV['COVERBAND_MEMORY_TEST']
-    test 'this is how we do it' do
-      visit '/dummy/show'
+  unless ENV["COVERBAND_MEMORY_TEST"]
+    test "this is how we do it" do
+      visit "/dummy/show"
       Coverband.report_coverage
-      assert_content('I am no dummy')
-      visit '/coverage'
-      within page.find('a', text: /dummy_controller.rb/).find(:xpath, '../..') do
-        assert_selector('td', text: '100.0 %')
+      assert_content("I am no dummy")
+      visit "/coverage"
+      within page.find("a", text: /dummy_controller.rb/).find(:xpath, "../..") do
+        assert_selector("td", text: "100.0 %")
       end
 
-      # Test gems are reporting coverage
-      assert_content('Gems')
-      assert page.html.match('rainbow/wrapper.rb')
-
       # Test eager load data stored separately
       dummy_controller = "./test/rails#{Rails::VERSION::MAJOR}_dummy/app/controllers/dummy_controller.rb"
       store.type = :eager_loading
       eager_expected = [1, 1, 0, nil, nil]
-      results = store.coverage[dummy_controller]['data']
+      results = store.coverage[dummy_controller]["data"]
       assert_equal(eager_expected, results)
 
       store.type = Coverband::RUNTIME_TYPE
       runtime_expected = [0, 0, 1, nil, nil]
-      results = store.coverage[dummy_controller]['data']
+      results = store.coverage[dummy_controller]["data"]
+      assert_equal(runtime_expected, results)
     end
   end
 
@@ -55,20 +52,20 @@ class RailsFullStackTest < Minitest::Test
   # as we run it in single test mode via the benchmarks.
   # Add new tests below this test
   ###
-  if ENV['COVERBAND_MEMORY_TEST']
-    test 'memory usage' do
-      return unless ENV['COVERBAND_MEMORY_TEST']
+  if ENV["COVERBAND_MEMORY_TEST"]
+    test "memory usage" do
+      return unless ENV["COVERBAND_MEMORY_TEST"]
 
       # we don't want this to run during our standard test suite
       # as the below profiler changes the runtime
       # and shold only be included for isolated processes
       begin
-        require 'memory_profiler'
+        require "memory_profiler"
 
         # warmup
         3.times do
-          visit '/dummy/show'
-          assert_content('I am no dummy')
+          visit "/dummy/show"
+          assert_content("I am no dummy")
           Coverband.report_coverage
         end
 
@@ -76,10 +73,10 @@ class RailsFullStackTest < Minitest::Test
         capture = StringIO.new
         $stdout = capture
 
-        MemoryProfiler.report do
+        MemoryProfiler.report {
           15.times do
-            visit '/dummy/show'
-            assert_content('I am no dummy')
+            visit "/dummy/show"
+            assert_content("I am no dummy")
             Coverband.report_coverage
             ###
             # Set to nil not {} as it is easier to verify that no memory is retained when nil gets released
@@ -91,12 +88,12 @@ class RailsFullStackTest < Minitest::Test
             # needed to test older versions to discover when we had the regression
             # Coverband::Collectors::Coverage.instance.send(:add_previous_results, nil)
           end
-        end.pretty_print
+        }.pretty_print
         data = $stdout.string
         $stdout = previous_out
         if data.match(/retained objects by gem(.*)retained objects by file/m)[0]&.match(/coverband/)
           puts data
-          raise 'leaking memory!!!'
+          raise "leaking memory!!!"
         end
       ensure
         $stdout = previous_out

data/test/forked/rails_rake_full_stack_test.rb

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
 
-require File.expand_path('../rails_test_helper', File.dirname(__FILE__))
-require 'rails'
-require 'pundit'
+require File.expand_path("../rails_test_helper", File.dirname(__FILE__))
+require "rails"
 
 class RailsRakeFullStackTest < Minitest::Test
   def setup
@@ -11,31 +10,13 @@ class RailsRakeFullStackTest < Minitest::Test
     Coverband.configure("./test/rails#{Rails::VERSION::MAJOR}_dummy/config/coverband.rb")
   end
 
-  test 'rake tasks shows coverage properly within eager_loading' do
-    store.instance_variable_set(:@redis_namespace, 'coverband_test')
-    store.clear!
-    system("COVERBAND_CONFIG=./test/rails#{Rails::VERSION::MAJOR}_dummy/config/coverband.rb bundle exec rake -f test/rails#{Rails::VERSION::MAJOR}_dummy/Rakefile middleware")
-    store.instance_variable_set(:@redis_namespace, 'coverband_test')
-    store.type = :eager_loading
-    pundit_file = store.coverage.keys.grep(/pundit.rb/).first
-    refute_nil pundit_file
-    pundit_coverage = store.coverage[pundit_file]
-    refute_nil pundit_coverage
-    assert_includes pundit_coverage['data'], 1
-
-    store.type = Coverband::RUNTIME_TYPE
-    if ENV['SIMULATE_ONESHOT']
-      pundit_coverage = store.get_coverage_report[Coverband::RUNTIME_TYPE][pundit_file]
-      assert pundit_coverage['data'].compact.all? { |el| el == 0 }
-    else
-      pundit_coverage = store.coverage[pundit_file]
-      assert_nil pundit_coverage
-    end
-  end
+  # test 'rake tasks shows coverage properly within eager_loading' do
+  # this was testing gem data, which we no logner support and I dont know if this makes sense anymre
+  # end
 
   test "ignored rake tasks don't add coverage" do
     store.clear!
-    store.instance_variable_set(:@redis_namespace, 'coverband_test')
+    store.instance_variable_set(:@redis_namespace, "coverband_test")
     store.send(:save_report, basic_coverage_full_path)
     output = `COVERBAND_CONFIG=./test/rails#{Rails::VERSION::MAJOR}_dummy/config/coverband.rb bundle exec rake -f test/rails#{Rails::VERSION::MAJOR}_dummy/Rakefile coverband:clear`
     assert_nil output.match(/Coverband: Reported coverage via thread/)
@@ -49,7 +30,7 @@ class RailsRakeFullStackTest < Minitest::Test
   test "doesn't exit non-zero with error on missing redis" do
     output = `COVERBAND_CONFIG=./test/rails#{Rails::VERSION::MAJOR}_dummy/config/coverband_missing_redis.rb bundle exec rake -f test/rails#{Rails::VERSION::MAJOR}_dummy/Rakefile -T`
     assert_equal 0, $?.to_i
-    if ENV['COVERBAND_HASH_REDIS_STORE']
+    if ENV["COVERBAND_HASH_REDIS_STORE"]
       assert output.match(/Redis is not available/)
     else
       assert output.match(/coverage failed to store/)

data/test/integration/full_stack_test.rb

@@ -1,57 +1,46 @@
 # frozen_string_literal: true
 
-require File.expand_path('../test_helper', File.dirname(__FILE__))
-require 'rack'
+require File.expand_path("../test_helper", File.dirname(__FILE__))
+require "rack"
 
 class FullStackTest < Minitest::Test
   REDIS_STORAGE_FORMAT_VERSION = Coverband::Adapters::RedisStore::REDIS_STORAGE_FORMAT_VERSION
-  TEST_RACK_APP = '../fake_app/basic_rack.rb'
+  TEST_RACK_APP = "../fake_app/basic_rack.rb"
 
   def setup
     super
     Coverband::Collectors::Coverage.instance.reset_instance
     Coverband.configure do |config|
-      config.s3_bucket = nil
       config.background_reporting_enabled = false
       config.track_gems = true
     end
     Coverband.start
     Coverband::Collectors::Coverage.instance.eager_loading!
-    @rack_file = require_unique_file 'fake_app/basic_rack.rb'
+    @rack_file = require_unique_file "fake_app/basic_rack.rb"
     Coverband.report_coverage
     Coverband::Collectors::Coverage.instance.runtime!
   end
 
-  test 'call app' do
-    request = Rack::MockRequest.env_for('/anything.json')
+  test "call app" do
+    request = Rack::MockRequest.env_for("/anything.json")
     middleware = Coverband::BackgroundMiddleware.new(fake_app_with_lines)
     results = middleware.call(request)
-    assert_equal 'Hello Rack!', results.last
+    assert_equal "Hello Rack!", results.last
     Coverband.report_coverage
     expected = [nil, nil, 0, nil, 0, 0, 1, nil, nil]
-    assert_equal expected, Coverband.configuration.store.coverage[@rack_file]['data']
+    assert_equal expected, Coverband.configuration.store.coverage[@rack_file]["data"]
 
     # additional calls increase count by 1
     middleware.call(request)
     Coverband.report_coverage
     expected = [nil, nil, 0, nil, 0, 0, 2, nil, nil]
-    assert_equal expected, Coverband.configuration.store.coverage[@rack_file]['data']
+    assert_equal expected, Coverband.configuration.store.coverage[@rack_file]["data"]
 
     # class coverage
     Coverband.eager_loading_coverage!
-    Coverband.configuration.store.coverage[@rack_file]['data']
+    Coverband.configuration.store.coverage[@rack_file]["data"]
     expected = [nil, nil, 1, nil, 1, 1, 0, nil, nil]
-  end
-
-  test 'call app with gem tracking' do
-    require 'rainbow'
-    Rainbow('this text is red').red
-    request = Rack::MockRequest.env_for('/anything.json')
-    middleware = Coverband::BackgroundMiddleware.new(fake_app_with_lines)
-    results = middleware.call(request)
-    assert_equal 'Hello Rack!', results.last
-    Coverband.report_coverage
-    assert Coverband.configuration.store.coverage.keys.any? { |key| key.end_with?('rainbow/global.rb') }
+    assert_equal expected, Coverband.configuration.store.coverage[@rack_file]["data"]
   end
 
   private

data/test/jruby_check.rb

@@ -1,8 +1,8 @@
-require 'coverage'
+require "coverage"
 
 Coverage.start
 
-require './test/dog.rb'
+require "./test/dog.rb"
 
 puts Coverage.peek_result
 
@@ -11,4 +11,3 @@ puts Dog.new.bark
 puts Coverage.peek_result
 
 puts "done"
-

data/test/rails4_dummy/Rakefile

@@ -1,6 +1,6 @@
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
-require_relative 'config/application'
+require_relative "config/application"
 
 Rails.application.load_tasks

data/test/rails4_dummy/config.ru

@@ -1,4 +1,4 @@
 # This file is used by Rack-based servers to start the application.
 
-require ::File.expand_path('../config/environment', __FILE__)
+require ::File.expand_path("../config/environment", __FILE__)
 run Rails.application

data/test/rails4_dummy/config/application.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-require File.expand_path('boot', __dir__)
+require File.expand_path("boot", __dir__)
 
-require 'rails'
-require 'action_controller/railtie'
-require 'coverband'
+require "rails"
+require "action_controller/railtie"
+require "coverband"
 Bundler.require(*Rails.groups)
 
 module Rails4Dummy

data/test/rails4_dummy/config/boot.rb

@@ -1,3 +1,3 @@
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", __FILE__)
 
-require 'bundler/setup' # Set up gems listed in the Gemfile.
+require "bundler/setup" # Set up gems listed in the Gemfile.

data/test/rails4_dummy/config/coverband.rb

@@ -1,3 +1,3 @@
 # frozen_string_literal: true
 
-require_relative '../../rails5_dummy/config/coverband'
+require_relative "../../rails5_dummy/config/coverband"

data/test/rails4_dummy/config/coverband_missing_redis.rb

@@ -1,3 +1,3 @@
 # frozen_string_literal: true
 
-require_relative '../../rails5_dummy/config/coverband_missing_redis'
+require_relative "../../rails5_dummy/config/coverband_missing_redis"

data/test/rails4_dummy/config/environment.rb

@@ -1,5 +1,5 @@
 # Load the Rails application.
-require File.expand_path('../application', __FILE__)
+require File.expand_path("../application", __FILE__)
 
 # Initialize the Rails application.
 Rails.application.initialize!

data/test/rails4_dummy/config/routes.rb

@@ -1,4 +1,4 @@
 Rails.application.routes.draw do
-  get 'dummy/show'
-  mount Coverband::Reporters::Web.new, at: '/coverage'
+  get "dummy/show"
+  mount Coverband::Reporters::Web.new, at: "/coverage"
 end

data/test/rails5_dummy/Rakefile

@@ -1,6 +1,6 @@
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
-require_relative 'config/application'
+require_relative "config/application"
 
 Rails.application.load_tasks

data/test/rails5_dummy/config.ru

@@ -1,3 +1,3 @@
-require_relative 'config/environment'
+require_relative "config/environment"
 
 run Rails.application

data/test/rails5_dummy/config/application.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require 'rails'
-require 'action_controller/railtie'
-require 'coverband'
+require "rails"
+require "action_controller/railtie"
+require "coverband"
 Bundler.require(*Rails.groups)
 
 module Rails5Dummy

data/test/rails5_dummy/config/coverband.rb

@@ -1,15 +1,15 @@
 # frozen_string_literal: true
 
 Coverband.configure do |config|
-  config.root              = Dir.pwd
-  config.store             = Coverband::Adapters::RedisStore.new(Redis.new(db: 2, url: ENV['REDIS_URL']), redis_namespace: 'coverband_test') if defined? Redis
-  config.ignore            = %w[.erb$ .slim$]
-  config.root_paths        = []
-  config.logger            = Rails.logger
-  config.verbose           = true
+  config.root = Dir.pwd
+  config.store = Coverband::Adapters::RedisStore.new(Redis.new(db: 2, url: ENV["REDIS_URL"]), redis_namespace: "coverband_test") if defined? Redis
+  config.ignore = %w[.erb$ .slim$]
+  config.root_paths = []
+  config.logger = Rails.logger
+  config.verbose = true
   config.background_reporting_enabled = true
   config.track_gems = true
   config.gem_details = true
-  config.use_oneshot_lines_coverage = true if ENV['ONESHOT']
-  config.simulate_oneshot_lines_coverage = true if ENV['SIMULATE_ONESHOT']
+  config.use_oneshot_lines_coverage = true if ENV["ONESHOT"]
+  config.simulate_oneshot_lines_coverage = true if ENV["SIMULATE_ONESHOT"]
 end

data/test/rails5_dummy/config/coverband_missing_redis.rb

@@ -1,15 +1,15 @@
 # frozen_string_literal: true
 
 Coverband.configure do |config|
-  config.root              = Dir.pwd
-  config.store             = Coverband::Adapters::RedisStore.new(Redis.new(db: 2, url: 'redis://127.0.0.1:123'), redis_namespace: 'coverband_test') if defined? Redis
-  config.ignore            = %w[vendor .erb$ .slim$]
-  config.root_paths        = []
-  config.logger            = Rails.logger
-  config.verbose           = true
+  config.root = Dir.pwd
+  config.store = Coverband::Adapters::RedisStore.new(Redis.new(db: 2, url: "redis://127.0.0.1:123"), redis_namespace: "coverband_test") if defined? Redis
+  config.ignore = %w[vendor .erb$ .slim$]
+  config.root_paths = []
+  config.logger = Rails.logger
+  config.verbose = true
   config.background_reporting_enabled = true
   config.track_gems = true
   config.gem_details = true
-  config.use_oneshot_lines_coverage = true if ENV['ONESHOT']
-  config.simulate_oneshot_lines_coverage = true if ENV['SIMULATE_ONESHOT']
+  config.use_oneshot_lines_coverage = true if ENV["ONESHOT"]
+  config.simulate_oneshot_lines_coverage = true if ENV["SIMULATE_ONESHOT"]
 end