coverband 4.2.3 → 4.2.4

data/test/coverband/reporters/base_test.rb

@@ -3,6 +3,10 @@
 require File.expand_path('../../test_helper', File.dirname(__FILE__))
 
 class ReportsBaseTest < Minitest::Test
+  def setup
+    super
+  end
+
   test '#merge_arrays basic merge preserves order and counts' do
     first = [0, 0, 1, 0, 1]
     second = [nil, 0, 1, 0, 0]
@@ -28,14 +32,9 @@ class ReportsBaseTest < Minitest::Test
   end
 
   test "#get_current_scov_data_imp doesn't ignore folders with default ignore keys" do
-    @redis = Redis.new
-    store = Coverband::Adapters::RedisStore.new(@redis, redis_namespace: 'coverband_test')
-    store.clear!
-
     Coverband.configure do |config|
       config.reporter          = 'std_out'
       config.root              = '/full/remote_app/path'
-      config.store             = store
     end
 
     key = '/a_path/that_has_erb_in/thepath.rb'
@@ -55,6 +54,7 @@ class ReportsBaseTest < Minitest::Test
   # rubocop:disable all
   ###
   test '#get_current_scov_data_imp merges multiples of file data' do
+    skip "@danmayer to take a closer look at this one"
     coverage = {'/base/66/app/controllers/dashboard_controller.rb' =>
        {"first_updated_at"=>1549610119,
         "last_updated_at"=>1549610200,
@@ -88,4 +88,5 @@ class ReportsBaseTest < Minitest::Test
                 "data"=>[38, 38, 38, nil, 38, 38, nil, nil, 38, nil, 38, 80, 80, nil, 80, 80, 80, 80, 80, 80, 80, nil, nil, 38, nil, 38, 80, 55, 0, 0, 0, 0, nil, nil, nil, nil, 0, 0, nil, nil, 38, 80, 80, 80, nil, nil, nil, nil, nil, 38, 80, nil, nil, 38, 80, nil, nil]}
     assert_equal expected, Coverband::Reporters::Base.send(:get_current_scov_data_imp, store, roots)[:merged][key]
   end
+
 end

data/test/coverband/reporters/console_test.rb

@@ -7,15 +7,12 @@ class HTMLReportTest < Minitest::Test
 
   def setup
     super
-    @redis = Redis.new
-    @store = Coverband::Adapters::RedisStore.new(@redis, redis_namespace: 'coverband_test')
-    @store.clear!
+    @store = Coverband.configuration.store
   end
 
   test 'report data' do
     Coverband.configure do |config|
-      config.reporter            = 'std_out'
-      config.store               = @store
+      config.reporter = 'std_out'
     end
     Coverband.configuration.logger.stubs('info')
     mock_file_hash

data/test/coverband/reporters/html_test.rb

@@ -5,9 +5,7 @@ require File.expand_path('../../test_helper', File.dirname(__FILE__))
 class ReportHTMLTest < Minitest::Test
   def setup
     super
-    @redis = Redis.new
-    @store = Coverband::Adapters::RedisStore.new(@redis, redis_namespace: 'coverband_test')
-    @store.clear!
+    @store = Coverband.configuration.store
     Coverband.configure do |config|
       config.store             = @store
       config.root              = fixtures_root

data/test/coverband/utils/html_formatter_test.rb

@@ -5,9 +5,7 @@ require File.expand_path('../../test_helper', File.dirname(__FILE__))
 class HTMLFormatterTest < Minitest::Test
   def setup
     super
-    @redis = Redis.new
-    @store = Coverband::Adapters::RedisStore.new(@redis, redis_namespace: 'coverband_test')
-    @store.clear!
+    @store = Coverband::Adapters::RedisStore.new(Coverband::Test.redis, redis_namespace: 'coverband_test')
   end
 
   test 'generate dynamic content hosted html report' do

data/test/forked/rails_rake_full_stack_test.rb

@@ -45,4 +45,14 @@ class RailsRakeFullStackTest < Minitest::Test
     assert_equal empty_hash, coverage_report[:eager_loading]
     assert_equal empty_hash, coverage_report[:merged]
   end
+
+  test "doesn't exit non-zero with error on missing redis" do
+    output = `COVERBAND_CONFIG=./test/rails#{Rails::VERSION::MAJOR}_dummy/config/coverband_missing_redis.rb bundle exec rake -f test/rails#{Rails::VERSION::MAJOR}_dummy/Rakefile -T`
+    assert_equal 0, $?.to_i
+    if ENV['COVERBAND_HASH_REDIS_STORE']
+      assert output.match(/Redis is not available/)
+    else
+      assert output.match(/coverage failed to store/)
+    end
+  end
 end

data/test/integration/full_stack_test.rb

@@ -11,12 +11,10 @@ class FullStackTest < Minitest::Test
     super
     Coverband::Collectors::Coverage.instance.reset_instance
     Coverband.configure do |config|
-      config.store = Coverband::Adapters::RedisStore.new(Redis.new, redis_namespace: 'coverband_test')
       config.s3_bucket = nil
-      config.background_reporting_enabled = true
+      config.background_reporting_enabled = false
       config.track_gems = true
     end
-    Coverband.configuration.store.clear!
     Coverband.start
     Coverband::Collectors::Coverage.instance.eager_loading!
     @rack_file = require_unique_file 'fake_app/basic_rack.rb'

data/test/rails4_dummy/config/coverband.rb

@@ -1,13 +1,3 @@
-Coverband.configure do |config|
-  config.root              = Dir.pwd
-  config.store             = Coverband::Adapters::RedisStore.new(Redis.new(url: ENV['REDIS_URL']), redis_namespace: 'coverband_test') if defined? Redis
-  config.ignore            = %w[vendor .erb$ .slim$]
-  config.root_paths        = []
-  config.logger            = Rails.logger
-  config.verbose           = true
-  config.background_reporting_enabled = true
-  config.track_gems = true
-  config.gem_details = true
-  config.use_oneshot_lines_coverage = true if ENV['ONESHOT']
-  config.simulate_oneshot_lines_coverage = true if ENV['SIMULATE_ONESHOT']
-end
+# frozen_string_literal: true
+
+require_relative '../../rails5_dummy/config/coverband'

data/test/rails4_dummy/config/coverband_missing_redis.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+require_relative '../../rails5_dummy/config/coverband_missing_redis'

data/test/rails5_dummy/config/coverband.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 Coverband.configure do |config|
   config.root              = Dir.pwd
-  config.store             = Coverband::Adapters::RedisStore.new(Redis.new(url: ENV['REDIS_URL']), redis_namespace: 'coverband_test') if defined? Redis
-  config.ignore            = %w[vendor .erb$ .slim$]
+  config.store             = Coverband::Adapters::RedisStore.new(Redis.new(db: 2, url: ENV['REDIS_URL']), redis_namespace: 'coverband_test') if defined? Redis
+  config.ignore            = %w[.erb$ .slim$]
   config.root_paths        = []
   config.logger            = Rails.logger
   config.verbose           = true

data/test/rails5_dummy/config/coverband_missing_redis.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+Coverband.configure do |config|
+  config.root              = Dir.pwd
+  config.store             = Coverband::Adapters::RedisStore.new(Redis.new(db: 2, url: 'redis://127.0.0.1:123'), redis_namespace: 'coverband_test') if defined? Redis
+  config.ignore            = %w[vendor .erb$ .slim$]
+  config.root_paths        = []
+  config.logger            = Rails.logger
+  config.verbose           = true
+  config.background_reporting_enabled = true
+  config.track_gems = true
+  config.gem_details = true
+  config.use_oneshot_lines_coverage = true if ENV['ONESHOT']
+  config.simulate_oneshot_lines_coverage = true if ENV['SIMULATE_ONESHOT']
+end

data/test/test_helper.rb

@@ -30,20 +30,24 @@ end
 
 module Coverband
   module Test
+    TEST_DB = 2
+
+    def self.redis
+      @redis ||= Redis.new(db: TEST_DB)
+    end
+
     def self.reset
       Coverband.configuration.redis_namespace = 'coverband_test'
       Coverband.configuration.store.instance_variable_set(:@redis_namespace, 'coverband_test')
       Coverband.configuration.store.class.class_variable_set(:@@path_cache, {})
-      %i[eager_loading runtime].each do |type|
-        Coverband.configuration.store.type = type
-        Coverband.configuration.store.clear!
-      end
       Coverband.configuration.reset
       Coverband::Collectors::Coverage.instance.reset_instance
       Coverband::Utils::RelativeFileConverter.reset
       Coverband::Utils::AbsoluteFileConverter.reset
       Coverband.configuration.redis_namespace = 'coverband_test'
       Coverband::Background.stop
+      Coverband.configuration.store.instance_variable_set(:@redis, redis)
+      redis.flushdb
     end
 
     def setup

data/views/data.erb

@@ -0,0 +1 @@
+<%= result.source_files.to_json %>

data/views/nav.erb

@@ -7,6 +7,7 @@
   <% end %>
   <% if Coverband.configuration.web_debug %>
     <a href='<%= base_path %>debug_data'>Debug Data</a> &nbsp;
+    <a href='<%= base_path %>enriched_debug_data'>Coverage Data</a> &nbsp;
   <% end %>
 </div>
 <% if notice.to_s.length > 0 %>

data/views/view_tracker.erb

@@ -14,11 +14,14 @@
       <%= display_nav(show_coverage_link: true) %>
       <div id="content">
         <% tracker = Coverband::Collectors::ViewTracker.new(store: Coverband.configuration.store) %>
-        <h3>
+        <h4>
           <% if Coverband.configuration.web_enable_clear %>
             <%= button("#{base_path}clear_view_tracking", 'reset view tracker', delete: true) %>
           <% end %>
-        </h3>
+          <% if Coverband.configuration.web_debug %>
+            <a href='<%= "#{base_path}view_tracker_data" %>'>view tracker data</a>
+          <% end %>
+        </h4>
         <h2>Unused Views: (<%= tracker.unused_views.length %>)</h2>
         <p>These views have not been rendered since recording started at <%= tracker.tracking_since %></p>
         <ul>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 4.2.3
+  version: 4.2.4
 platform: ruby
 authors:
 - Dan Mayer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-28 00:00:00.000000000 Z
+date: 2019-12-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-s3
@@ -193,6 +193,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -304,6 +318,12 @@ files:
 - lib/coverband/utils/source_file.rb
 - lib/coverband/utils/tasks.rb
 - lib/coverband/version.rb
+- lua/install.sh
+- lua/lib/persist-coverage.lua
+- lua/test/bootstrap.lua
+- lua/test/harness.lua
+- lua/test/redis-call.lua
+- lua/test/test-persist-coverage.lua
 - public/application.css
 - public/application.js
 - public/colorbox/border.png
@@ -388,6 +408,7 @@ files:
 - test/rails4_dummy/config/application.rb
 - test/rails4_dummy/config/boot.rb
 - test/rails4_dummy/config/coverband.rb
+- test/rails4_dummy/config/coverband_missing_redis.rb
 - test/rails4_dummy/config/environment.rb
 - test/rails4_dummy/config/routes.rb
 - test/rails4_dummy/config/secrets.yml
@@ -397,12 +418,14 @@ files:
 - test/rails5_dummy/config.ru
 - test/rails5_dummy/config/application.rb
 - test/rails5_dummy/config/coverband.rb
+- test/rails5_dummy/config/coverband_missing_redis.rb
 - test/rails5_dummy/config/environment.rb
 - test/rails5_dummy/config/routes.rb
 - test/rails5_dummy/tmp/.keep
 - test/rails_test_helper.rb
 - test/test_helper.rb
 - test/unique_files.rb
+- views/data.erb
 - views/file_list.erb
 - views/gem_list.erb
 - views/layout.erb
@@ -493,6 +516,7 @@ test_files:
 - test/rails4_dummy/config/application.rb
 - test/rails4_dummy/config/boot.rb
 - test/rails4_dummy/config/coverband.rb
+- test/rails4_dummy/config/coverband_missing_redis.rb
 - test/rails4_dummy/config/environment.rb
 - test/rails4_dummy/config/routes.rb
 - test/rails4_dummy/config/secrets.yml
@@ -502,6 +526,7 @@ test_files:
 - test/rails5_dummy/config.ru
 - test/rails5_dummy/config/application.rb
 - test/rails5_dummy/config/coverband.rb
+- test/rails5_dummy/config/coverband_missing_redis.rb
 - test/rails5_dummy/config/environment.rb
 - test/rails5_dummy/config/routes.rb
 - test/rails5_dummy/tmp/.keep