coverband 4.2.1 → 4.2.2

data/test/coverband/reporters/html_test.rb

@@ -52,9 +52,9 @@ class ReportHTMLTest < Minitest::Test
     filename = basic_coverage_file_full_path
     base_path = '/coverage'
     html = Coverband::Reporters::HTMLReport.new(Coverband.configuration.store,
-      filename: filename,
-      base_path: base_path,
-      open_report: false).file_details
+                                                filename: filename,
+                                                base_path: base_path,
+                                                open_report: false).file_details
     assert_match 'Coverage first seen', html
   end
 
@@ -64,9 +64,9 @@ class ReportHTMLTest < Minitest::Test
     filename = 'missing_path'
     base_path = '/coverage'
     html = Coverband::Reporters::HTMLReport.new(Coverband.configuration.store,
-      filename: filename,
-      base_path: base_path,
-      open_report: false).file_details
+                                                filename: filename,
+                                                base_path: base_path,
+                                                open_report: false).file_details
     assert_match 'File No Longer Available', html
   end
 
@@ -76,9 +76,9 @@ class ReportHTMLTest < Minitest::Test
     filename = "#{test_root}/test_helper.rb"
     base_path = '/coverage'
     html = Coverband::Reporters::HTMLReport.new(Coverband.configuration.store,
-      filename: filename,
-      base_path: base_path,
-      open_report: false).file_details
+                                                filename: filename,
+                                                base_path: base_path,
+                                                open_report: false).file_details
     assert_match 'File No Longer Available', html
   end
 end

data/test/coverband/utils/absolute_file_converter_test.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../test_helper', File.dirname(__FILE__))
+
+module Coverband
+  module Utils
+    class AbsoluteFileConverterTest < ::Minitest::Test
+      def test_convert
+        converter = AbsoluteFileConverter.new([FileUtils.pwd])
+        assert_equal("#{FileUtils.pwd}/lib/coverband.rb", converter.convert('./lib/coverband.rb'))
+      end
+
+      def test_convert_multiple_roots
+        converter = AbsoluteFileConverter.new(['/foo/bar', FileUtils.pwd])
+        assert_equal("#{FileUtils.pwd}/Rakefile", converter.convert('./Rakefile'))
+      end
+
+      test 'relative_path_to_full leave filename from a key with a local path' do
+        converter = AbsoluteFileConverter.new(['/app/', '/full/remote_app/path/'])
+        assert_equal '/full/remote_app/path/is/a/path.rb', converter.convert('/full/remote_app/path/is/a/path.rb')
+      end
+
+      test 'relative_path_to_full fix filename from a key with a swappable path' do
+        key = '/app/is/a/path.rb'
+        converter = AbsoluteFileConverter.new(['/app/', '/full/remote_app/path/'])
+        expected_path = '/full/remote_app/path/is/a/path.rb'
+        File.expects(:exist?).with(key).returns(false)
+        File.expects(:exist?).with(expected_path).returns(true)
+        assert_equal expected_path, converter.convert(key)
+      end
+
+      test 'relative_path_to_full fix filename a changing deploy path with quotes' do
+        converter = AbsoluteFileConverter.new(['/box/apps/app_name/releases/\\d+/', '/full/remote_app/path/'])
+        expected_path = '/full/remote_app/path/app/models/user.rb'
+        key = '/box/apps/app_name/releases/20140725203539/app/models/user.rb'
+        File.expects(:exist?).with('/box/apps/app_name/releases/\\d+/app/models/user.rb').returns(false)
+        File.expects(:exist?).with(expected_path).returns(true)
+        assert_equal expected_path, converter.convert(key)
+        assert_equal expected_path, converter.convert(key)
+      end
+
+      test 'relative_path_to_full fix filename a changing deploy path real world examples' do
+        current_app_root = '/var/local/company/company.d/79'
+        converter = AbsoluteFileConverter.new(['/var/local/company/company.d/[0-9]*/', "#{current_app_root}/"])
+
+        expected_path = '/var/local/company/company.d/79/app/controllers/dashboard_controller.rb'
+        key = '/var/local/company/company.d/78/app/controllers/dashboard_controller.rb'
+        File.expects(:exist?).with('/var/local/company/company.d/[0-9]*/app/controllers/dashboard_controller.rb').returns(false)
+        File.expects(:exist?).with(expected_path).returns(true)
+        roots = ['/var/local/company/company.d/[0-9]*/', "#{current_app_root}/"]
+        assert_equal expected_path, converter.convert(key)
+        assert_equal expected_path, converter.convert(key)
+      end
+    end
+  end
+end

data/test/coverband/utils/file_hasher_test.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../test_helper', File.dirname(__FILE__))
+
+module Coverband
+  module Utils
+    class FileHasherTest < Minitest::Test
+      def test_hash_same_file
+        refute_nil FileHasher.hash('./test/dog.rb')
+        assert_equal(FileHasher.hash('./test/dog.rb'), FileHasher.hash('./test/dog.rb'))
+        assert_equal(FileHasher.hash(File.expand_path('./test/dog.rb')), FileHasher.hash('./test/dog.rb'))
+      end
+
+      def test_hash_different_files
+        refute_equal(FileHasher.hash('./test/dog.rb'), FileHasher.hash('./lib/coverband.rb'))
+      end
+
+      def test_hash_file_not_exists
+        assert_nil(FileHasher.hash('./made_up_file.py'))
+      end
+
+      def test_hash_gem_file
+        spec = Gem::Specification.find_by_name('rainbow')
+        assert FileHasher.hash("./gems/rainbow-#{spec.version}/lib/rainbow.rb",
+                               path_converter: AbsoluteFileConverter.new(Coverband.configuration.gem_paths))
+      end
+    end
+  end
+end

data/test/coverband/utils/relative_file_converter_test.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../test_helper', File.dirname(__FILE__))
+
+module Coverband
+  module Utils
+    class RelativeFileConverterTest < ::Minitest::Test
+      def test_convert
+        converter = RelativeFileConverter.new(['/bar/tmp/'])
+        assert_equal('./gracie.rb', converter.convert('/bar/tmp/gracie.rb'))
+      end
+
+      def test_convert_without_leading_forward_slash
+        converter = RelativeFileConverter.new(['/foo/bar'])
+        assert_equal('./file.rb', converter.convert('/foo/bar/file.rb'))
+      end
+
+      def test_multiple_roots
+        converter = RelativeFileConverter.new(['/bar/tmp/', '/foo/bar/'])
+        assert_equal('./josie.rb', converter.convert('/foo/bar/josie.rb'))
+      end
+
+      def test_no_match
+        converter = RelativeFileConverter.new(['/bar/tmp/', '/foo/bar/'])
+        assert_equal('/foo/josie.rb', converter.convert('/foo/josie.rb'))
+      end
+
+      def test_middle_path_match
+        converter = RelativeFileConverter.new(['/bar/tmp/', '/foo/bar/'])
+        assert_equal('/tmp/foo/bar/josie.rb', converter.convert('/tmp/foo/bar/josie.rb'))
+      end
+
+      def test_already_relative_file
+        converter = RelativeFileConverter.new(['/bar/tmp/', '/foo/bar/'])
+        assert_equal('./foo/bar/josie.rb', converter.convert('./foo/bar/josie.rb'))
+      end
+    end
+  end
+end

data/test/forked/rails_rake_full_stack_test.rb

@@ -1,7 +1,15 @@
+# frozen_string_literal: true
+
 require File.expand_path('../rails_test_helper', File.dirname(__FILE__))
 require 'rails'
+require 'pundit'
 
 class RailsRakeFullStackTest < Minitest::Test
+  def setup
+    super
+    Coverband.configuration.reset
+    Coverband.configure("./test/rails#{Rails::VERSION::MAJOR}_dummy/config/coverband.rb")
+  end
 
   test 'rake tasks shows coverage properly within eager_loading' do
     store.instance_variable_set(:@redis_namespace, 'coverband_test')
@@ -18,7 +26,7 @@ class RailsRakeFullStackTest < Minitest::Test
     store.type = Coverband::RUNTIME_TYPE
     if ENV['SIMULATE_ONESHOT']
       pundit_coverage = store.get_coverage_report[Coverband::RUNTIME_TYPE][pundit_file]
-      assert pundit_coverage['data'].compact.all? { |el| el == 0}
+      assert pundit_coverage['data'].compact.all? { |el| el == 0 }
     else
       pundit_coverage = store.coverage[pundit_file]
       assert_nil pundit_coverage

data/test/integration/full_stack_test.rb

@@ -11,10 +11,9 @@ class FullStackTest < Minitest::Test
     super
     Coverband::Collectors::Coverage.instance.reset_instance
     Coverband.configure do |config|
-      config.store = Coverband::Adapters::RedisStore.new(Redis.new(), redis_namespace: 'coverband_test')
+      config.store = Coverband::Adapters::RedisStore.new(Redis.new, redis_namespace: 'coverband_test')
       config.s3_bucket = nil
       config.background_reporting_enabled = true
-      config.root_paths = ["#{File.expand_path('../', File.dirname(__FILE__))}/"]
       config.track_gems = true
     end
     Coverband.configuration.store.clear!

data/test/test_helper.rb

@@ -28,19 +28,20 @@ unless ENV['ONESHOT'] || ENV['SIMULATE_ONESHOT']
   Coveralls.wear!
 end
 
-
 module Coverband
   module Test
     def self.reset
       Coverband.configuration.redis_namespace = 'coverband_test'
       Coverband.configuration.store.instance_variable_set(:@redis_namespace, 'coverband_test')
       Coverband.configuration.store.class.class_variable_set(:@@path_cache, {})
-      [:eager_loading, :runtime].each do |type|
+      %i[eager_loading runtime].each do |type|
         Coverband.configuration.store.type = type
         Coverband.configuration.store.clear!
       end
       Coverband.configuration.reset
       Coverband::Collectors::Coverage.instance.reset_instance
+      Coverband::Utils::RelativeFileConverter.reset
+      Coverband::Utils::AbsoluteFileConverter.reset
       Coverband.configuration.redis_namespace = 'coverband_test'
       Coverband::Background.stop
     end
@@ -82,10 +83,8 @@ def test(name, &block)
   end
 end
 
-def mock_file_hash
-  mock_file = mock('mock_file')
-  mock_file.expects(:hexdigest).at_least_once.returns('abcd')
-  Digest::MD5.expects(:file).at_least_once.returns(mock_file)
+def mock_file_hash(hash: 'abcd')
+  Coverband::Utils::FileHasher.expects(:hash).at_least_once.returns(hash)
 end
 
 def example_line
@@ -124,7 +123,7 @@ end
 # This handles an issue where the store is setup in tests prior to being able to set the namespace
 ###
 def store
-  if Coverband.configuration.store.redis_namespace=='coverband_test'
+  if Coverband.configuration.store.redis_namespace == 'coverband_test'
     Coverband.configuration.store
   else
     Coverband.configuration.redis_namespace = 'coverband_test'

data/test/unique_files.rb

@@ -17,7 +17,7 @@ def require_unique_file(file = 'dog.rb', variables = {})
   file_contents = ERB.new(file_contents).result(OpenStruct.new(variables).instance_eval { binding }) if variables.any?
   File.open(temp_file, 'w') { |w| w.write(file_contents) }
   require temp_file
-  Coverband::Utils::FilePathHelper.full_path_to_relative(File.expand_path(temp_file))
+  Coverband::Utils::RelativeFileConverter.convert(File.expand_path(temp_file))
 end
 
 def remove_unique_files

data/views/layout.erb

@@ -15,26 +15,7 @@
       <img src="<%= assets_path('loading.gif') %>" alt="loading"/>
     </div>
     <div id="wrapper" style="display:none;">
-      <div id="header">
-        <a href='<%= base_path %>'>Coverband Admin</a> &nbsp;
-        <a href='<%= base_path %>settings'>Info</a> &nbsp;
-        <% if Coverband.configuration.web_enable_clear %>
-          <%= button("#{base_path}clear", 'clear coverage report', delete: true) %>
-        <% end %>
-        <% if Coverband.configuration.web_debug %>
-          <a href='<%= base_path %>debug_data'>Debug Data</a> &nbsp;
-        <% end %>
-      </div>
-      <% if notice.to_s.length > 0 %>
-      <div class="notice"><%= notice %></div>
-      <% end %>
-      <div class="timestamp">Generated <%= timeago(Time.now) %></div>
-      <br/>
-      <div class="timestamp">
-        Coverage Recording Started: <%= timeago(result.source_files.first_seen_at) %>
-      </div>
-
-      <ul class="group_tabs"></ul>
+      <%= display_nav %>
 
       <div id="content">
         <%= formatted_file_list("All Files", result, result.source_files) unless view_gems? %>

data/views/nav.erb

@@ -0,0 +1,35 @@
+
+<div id="header">
+  <a href='<%= base_path %>'>Coverband Admin</a> &nbsp;
+  <a href='<%= base_path %>settings'>Info</a> &nbsp;
+  <% if Coverband.configuration.web_enable_clear %>
+    <%= button("#{base_path}clear", 'clear coverage report', delete: true) %>
+  <% end %>
+  <% if Coverband.configuration.web_debug %>
+    <a href='<%= base_path %>debug_data'>Debug Data</a> &nbsp;
+  <% end %>
+</div>
+<% if notice.to_s.length > 0 %>
+<div class="notice"><%= notice %></div>
+<% end %>
+<div class="timestamp">Generated <%= timeago(Time.now) %></div>
+<br/>
+<% if defined?(result) %>
+  <div class="timestamp">
+    Coverage Recording Started: <%= timeago(result.source_files.first_seen_at) %>
+  </div>
+<% end %>
+
+<ul class="group_tabs">
+</ul>
+
+<ul class="extra_tabs">
+  <% if nav_options[:show_coverage_link] %>
+    <li><a href='<%= base_path %>'>Coverage</a></li>
+  <% end %>
+  <% if Coverband.configuration.track_views %>
+    <li class='<%= nav_options[:show_coverage_link] ? 'active' : '' %>'>
+      <a href='<%= base_path %>view_tracker'>Views Tracker</a>
+    </li>
+  <% end %>
+</ul>

data/views/view_tracker.erb

@@ -0,0 +1,37 @@
+<!DOCTYPE html>
+<html xmlns='http://www.w3.org/1999/xhtml'>
+  <head>
+    <title>Coverband Info: <%= Coverband::VERSION %></title>
+    <meta http-equiv="content-type" content="text/html; charset=utf-8" />
+    <script src='<%= assets_path('application.js') %>' type='text/javascript'></script>
+    <link href='<%= assets_path('application.css') %>' media='screen, projection, print' rel='stylesheet' type='text/css'>
+    <link rel="icon" type="image/png" href="<%= assets_path('favicon.png') %>" />
+  </head>
+
+  <body>
+    <div id="wrapper" style="">
+      <%= display_nav(show_coverage_link: true) %>
+      <div id="content">
+        <% tracker = Coverband::Collectors::ViewTracker.new(store: Coverband.configuration.store) %>
+        <h2>Unused Views: (<%= tracker.unused_views.length %>)</h2>
+        <p>These views have never been rendered</p>
+        <ul>
+        <% tracker.unused_views.each do |view_file| %>
+          <li><%= view_file %></li>
+        <% end %>
+        </ul>
+
+        <h2>Used Views: (<%= tracker.used_views.length %>)</h2>
+        <p>These views have been rendered at least once</p>
+        <ul>
+        <% tracker.used_views.each do |view_file| %>
+          <li><%= view_file %></li>
+        <% end %>
+        </ul>
+      </div>
+      <div id="footer">
+        Generated by <a href="http://github.com/danmayer/coverband">Coverband</a> v<%= Coverband::VERSION %>
+      </div>
+    </div>
+  </body>
+</html>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 4.2.1
+  version: 4.2.2
 platform: ruby
 authors:
 - Dan Mayer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-28 00:00:00.000000000 Z
+date: 2019-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-s3
@@ -193,34 +193,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: minitest-reporters
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: classifier-reborn
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -287,6 +259,7 @@ files:
 - ".gitignore"
 - ".rubocop.yml"
 - ".travis.yml"
+- CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.rails4
 - LICENSE
@@ -299,10 +272,12 @@ files:
 - lib/coverband.rb
 - lib/coverband/adapters/base.rb
 - lib/coverband/adapters/file_store.rb
+- lib/coverband/adapters/hash_redis_store.rb
 - lib/coverband/adapters/redis_store.rb
 - lib/coverband/at_exit.rb
 - lib/coverband/collectors/coverage.rb
 - lib/coverband/collectors/delta.rb
+- lib/coverband/collectors/view_tracker.rb
 - lib/coverband/configuration.rb
 - lib/coverband/integrations/background.rb
 - lib/coverband/integrations/background_middleware.rb
@@ -314,13 +289,15 @@ files:
 - lib/coverband/reporters/console_report.rb
 - lib/coverband/reporters/html_report.rb
 - lib/coverband/reporters/web.rb
+- lib/coverband/utils/absolute_file_converter.rb
 - lib/coverband/utils/file_groups.rb
+- lib/coverband/utils/file_hasher.rb
 - lib/coverband/utils/file_list.rb
-- lib/coverband/utils/file_path_helper.rb
 - lib/coverband/utils/gem_list.rb
 - lib/coverband/utils/html_formatter.rb
 - lib/coverband/utils/lines_classifier.rb
 - lib/coverband/utils/railtie.rb
+- lib/coverband/utils/relative_file_converter.rb
 - lib/coverband/utils/result.rb
 - lib/coverband/utils/results.rb
 - lib/coverband/utils/s3_report.rb
@@ -358,12 +335,15 @@ files:
 - test/benchmarks/coverage_fork.sh
 - test/benchmarks/dog.rb
 - test/benchmarks/graph_bench.sh
+- test/benchmarks/init_rails.rake
 - test/coverband/adapters/base_test.rb
 - test/coverband/adapters/file_store_test.rb
+- test/coverband/adapters/hash_redis_store_test.rb
 - test/coverband/adapters/redis_store_test.rb
 - test/coverband/at_exit_test.rb
 - test/coverband/collectors/coverage_test.rb
 - test/coverband/collectors/delta_test.rb
+- test/coverband/collectors/view_tracker_test.rb
 - test/coverband/configuration_test.rb
 - test/coverband/coverband_test.rb
 - test/coverband/integrations/background_middleware_test.rb
@@ -376,11 +356,14 @@ files:
 - test/coverband/reporters/console_test.rb
 - test/coverband/reporters/html_test.rb
 - test/coverband/reporters/web_test.rb
+- test/coverband/utils/absolute_file_converter_test.rb
 - test/coverband/utils/file_groups_test.rb
+- test/coverband/utils/file_hasher_test.rb
 - test/coverband/utils/file_list_test.rb
 - test/coverband/utils/gem_list_test.rb
 - test/coverband/utils/html_formatter_test.rb
 - test/coverband/utils/lines_classifier_test.rb
+- test/coverband/utils/relative_file_converter_test.rb
 - test/coverband/utils/result_test.rb
 - test/coverband/utils/results_test.rb
 - test/coverband/utils/s3_report_test.rb
@@ -423,9 +406,11 @@ files:
 - views/file_list.erb
 - views/gem_list.erb
 - views/layout.erb
+- views/nav.erb
 - views/settings.erb
 - views/source_file.erb
 - views/source_file_loader.erb
+- views/view_tracker.erb
 homepage: https://github.com/danmayer/coverband
 licenses:
 - MIT
@@ -455,12 +440,15 @@ test_files:
 - test/benchmarks/coverage_fork.sh
 - test/benchmarks/dog.rb
 - test/benchmarks/graph_bench.sh
+- test/benchmarks/init_rails.rake
 - test/coverband/adapters/base_test.rb
 - test/coverband/adapters/file_store_test.rb
+- test/coverband/adapters/hash_redis_store_test.rb
 - test/coverband/adapters/redis_store_test.rb
 - test/coverband/at_exit_test.rb
 - test/coverband/collectors/coverage_test.rb
 - test/coverband/collectors/delta_test.rb
+- test/coverband/collectors/view_tracker_test.rb
 - test/coverband/configuration_test.rb
 - test/coverband/coverband_test.rb
 - test/coverband/integrations/background_middleware_test.rb
@@ -473,11 +461,14 @@ test_files:
 - test/coverband/reporters/console_test.rb
 - test/coverband/reporters/html_test.rb
 - test/coverband/reporters/web_test.rb
+- test/coverband/utils/absolute_file_converter_test.rb
 - test/coverband/utils/file_groups_test.rb
+- test/coverband/utils/file_hasher_test.rb
 - test/coverband/utils/file_list_test.rb
 - test/coverband/utils/gem_list_test.rb
 - test/coverband/utils/html_formatter_test.rb
 - test/coverband/utils/lines_classifier_test.rb
+- test/coverband/utils/relative_file_converter_test.rb
 - test/coverband/utils/result_test.rb
 - test/coverband/utils/results_test.rb
 - test/coverband/utils/s3_report_test.rb

data/lib/coverband/utils/file_path_helper.rb

@@ -1,68 +0,0 @@
-# frozen_string_literal: true
-
-####
-# Helper functions for shared logic related to file path manipulation
-####
-module Coverband
-  module Utils
-    module FilePathHelper
-      module_function
-
-      @@path_cache = {}
-
-      ###
-      # Takes a full path and converts to a relative path
-      ###
-      def full_path_to_relative(full_path)
-        return @@path_cache[full_path] if @@path_cache.key?(full_path)
-
-        relative_filename = full_path
-        Coverband.configuration.all_root_patterns.each do |root|
-          relative_filename = relative_filename.sub(root, './')
-          # once we have a relative path break out of the loop
-          break if relative_filename.start_with? './'
-        end
-
-        @@path_cache[full_path] = relative_filename
-
-        relative_filename
-      end
-
-      ###
-      # relative_path_to_full code takes:
-      # relative_path: which is a full path the same as reported by Coverage
-      # roots: if a collection of all possible full app paths
-      #    EX: [Coverband.configuration.root_paths, "#{current_root}/"]
-      # The LAST item should be the current file system root
-      # it expands that expands and adds a '/' as that isn't there from Dir.pwd
-      #
-      # NOTEs on configuration.root_paths usage
-      # strings: matching is pretty simple for full string paths
-      # regex: to get regex to work for changing deploy directories
-      #        the regex must be double escaped in double quotes
-      #          (if using \d for example)
-      #        or use single qoutes
-      #        example: '/box/apps/app_name/releases/\d+/'
-      #        example: '/var/local/company/company.d/[0-9]*/'
-      ###
-      def relative_path_to_full(relative_path, roots)
-        relative_filename = relative_path
-        local_filename = relative_filename
-        roots.each do |root|
-          relative_filename = relative_filename.sub(/^#{root}/, './')
-          # once we have a relative path break out of the loop
-          break if relative_filename.start_with? './'
-        end
-        # the filename for our reports is expected to be a full path.
-        # roots.last should be roots << current_root}/
-        # a fully expanded path of config.root
-        # filename = filename.gsub('./', roots.last)
-        # above only works for app files
-        # we need to rethink some of this logic
-        # gems aren't at project root and can have multiple locations
-        local_root = roots.find { |root| File.exist?(relative_filename.gsub('./', root)) }
-        local_root ? relative_filename.gsub('./', local_root) : local_filename
-      end
-    end
-  end
-end