coverband 4.2.1.rc2 → 4.2.1.rc3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b36c74e7000d8cd20c424fff66e2de35be821c440fbaf54be18b81e2e8de48d1
-  data.tar.gz: b459fd5abde8bdb4cb5283e9512ccc8a25e61d98fd6bb678d16854273f8df1a0
+  metadata.gz: 5cb0c3fd4256ad4d254c22cd98528bc34528e968ca65cfebc3a4720844e2a07d
+  data.tar.gz: 83cb0d9d97861c92e688274dc6885025ff2282d6a2625e473b148a3f68be0c05
 SHA512:
-  metadata.gz: 0e906b9c7e280e18b10e5c852199fb379600642c50bb566d678ea17ca2633ced35fc5d184ac93665c5c7eecc80ca0ee49cac161ff0dda06f66cc81b626031722
-  data.tar.gz: f59cb2a359a719837577ba143c60f6ad1e16fe12272c34843d8a0b9c030ab4030afc32343e3d3bbad6804f1f326e47f81cddc7c84e913a14f173c2bb9652c507
+  metadata.gz: 2d1206b71ffe2fddb8145a5f168a317a5e54373dd2b8b708ae6c86da800d015215c7d60b9906c791b725c8127add8bfb59343cad812f4f70ddc69b00d7a179a3
+  data.tar.gz: d2c1e07f8df62c8b4c4be64f009e2206b103b1685e2064664b1042d6ae25c9196247832007e707b6b3a7e1aa67aed454857bc64f13d44d594d86878f903d1a02

data/.travis.yml

@@ -13,8 +13,6 @@ script:
   - bundle exec rake rubocop
   - bundle exec rake
   - bundle exec rake forked_tests
-addons:
-  chrome: stable
 before_install:
   - echo 'this is a hack to clear default bundler and force bundler 1.17.3'
   - ls /home/travis/.rvm/gems/
@@ -24,4 +22,3 @@ before_install:
   - gem uninstall bundler || true
   - gem install bundler -v '1.17.3'
   - bundler --version
-  - google-chrome-stable --headless --disable-gpu --remote-debugging-port=9222 http://localhost &

data/README.md

@@ -254,6 +254,8 @@ By adding any files above you will get reporting on those files as part of your
 
 ### Collecting Gem / Library Usage
 
+__NOTE:__ Gem Tracking is still in testing stagings we have some performance issues on the reporting side and have heard reports of increased memory usage. We recommend deploying WITHOUT `track_gems` first and only enabling it after confirming that Coverband is working and performing well.
+
 Gem usage can be tracked by enabling the `track_gems` config.
 
 ```

data/changes.md

@@ -49,6 +49,7 @@ Will be the fully modern release that drops maintenance legacy support in favor
 - move all code to work with relative paths leaving only stdlib Coverage working on full paths
 - add gem_safe_lists to track only some gems
 - add gem_details_safe list to report on details on some gems
+- - display gems that are in loaded with 0 coverage, thanks @kbaum 
 
 ### Coverband_jam_session
 
@@ -91,7 +92,7 @@ Feature Ideas:
 - improved runtime / eager loading tracking
 - updated runtime relavent lines and runtime percentages
 - fix on gem runtime code coverage support, thanks @kbaum
-- display gems that are in loaded with 0 coverage, thanks @kbaum  
+
 
 # Released
 

data/coverband.gemspec

@@ -35,8 +35,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'resque'
   spec.add_development_dependency 'rubocop'
-  spec.add_development_dependency 'selenium-webdriver'
-  spec.add_development_dependency 'webdrivers', '~> 3.0'
   # temporarily needed to run tests for classifier-reborn as part of benchmarks
   spec.add_development_dependency 'minitest-reporters'
 

data/lib/coverband/reporters/base.rb

@@ -27,16 +27,12 @@ module Coverband
         ###
         def fix_reports(reports)
           # list all files, even if not tracked by Coverband (0% coverage)
-          file_patterns = ["#{Coverband.configuration.current_root}/{app,lib,config}/**/*.{rb}"]
-          if Coverband.configuration.track_gems
-            file_patterns.concat(Bundler.definition.specs.reject { |spec| spec.name == 'coverband' }.map(&:full_require_paths)
-              .flatten.map { |path| "#{path}/**/*.{rb}" })
-          end
+          tracked_glob = "#{Coverband.configuration.current_root}/{app,lib,config}/**/*.{rb}"
           filtered_report_files = {}
 
           reports.each_pair do |report_name, report_data|
             filtered_report_files[report_name] = {}
-            report_files = Coverband::Utils::Result.add_not_loaded_files(report_data, file_patterns)
+            report_files = Coverband::Utils::Result.add_not_loaded_files(report_data, tracked_glob)
 
             # apply coverband filters
             report_files.each_pair do |file, data|

data/lib/coverband/utils/result.rb

@@ -53,14 +53,17 @@ module Coverband
 
       # Finds files that were to be tracked but were not loaded and initializes
       # the line-by-line coverage to zero (if relevant) or nil (comments / whitespace etc).
-      def self.add_not_loaded_files(result, file_patterns)
-        file_patterns.each_with_object(result.dup) do |file_pattern, results_dup|
-          Dir[file_pattern].each do |file|
+      def self.add_not_loaded_files(result, tracked_files)
+        if tracked_files
+          result = result.dup
+          Dir[tracked_files].each do |file|
             absolute = File.expand_path(file)
 
-            results_dup[absolute] ||= Coverband::Utils::LinesClassifier.new.classify(File.foreach(absolute))
+            result[absolute] ||= Coverband::Utils::LinesClassifier.new.classify(File.foreach(absolute))
           end
         end
+
+        result
       end
     end
   end

data/lib/coverband/utils/source_file.rb

@@ -253,7 +253,7 @@ module Coverband
       end
 
       def gem_name
-        gem? ? short_name.split('/').first.gsub(/^\./, '') : nil
+        gem? ? short_name.split('/').first.gsub(%r{^\.}, '') : nil
       end
 
       private

data/lib/coverband/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Coverband
-  VERSION = '4.2.1.rc2'
+  VERSION = '4.2.1.rc3'
 end

data/test/benchmarks/benchmark.rake

@@ -32,7 +32,10 @@ namespace :benchmarks do
   end
 
   def clone_classifier
-    system "git clone https://github.com/jekyll/classifier-reborn.git #{classifier_dir}" unless Dir.exist? classifier_dir
+    unless Dir.exist? classifier_dir
+      system "git clone https://github.com/jekyll/classifier-reborn.git #{classifier_dir}"
+    end
+    # rubocop:enable Style/IfUnlessModifier
   end
 
   # desc 'setup standard benchmark'

data/test/coverband/reporters/html_test.rb

@@ -11,7 +11,7 @@ class ReportHTMLTest < Minitest::Test
     Coverband.configure do |config|
       config.store             = @store
       config.root              = fixtures_root
-      config.ignore            = ['notsomething.rb']
+      config.ignore            = ['notsomething.rb', 'lib/*']
     end
     mock_file_hash
   end
@@ -36,30 +36,6 @@ class ReportHTMLTest < Minitest::Test
     assert_match 'app/models/user.rb', html
   end
 
-  test 'Gem files with no coverage are shown in report' do
-    Coverband.configure do |config|
-      config.track_gems = true
-    end
-    @store.send(:save_report, basic_source_fixture_coverage)
-
-    html = Coverband::Reporters::HTMLReport.new(@store,
-                                                static: false,
-                                                open_report: false).report
-    assert_match 'rainbow', html
-  end
-
-  test 'Gem files are not shown in report when not configured' do
-    Coverband.configure do |config|
-      config.track_gems = false
-    end
-    @store.send(:save_report, basic_source_fixture_coverage)
-
-    html = Coverband::Reporters::HTMLReport.new(@store,
-                                                static: false,
-                                                open_report: false).report
-    refute_match 'rainbow', html
-  end
-
   test 'generate static HTML report file' do
     @store.send(:save_report, basic_coverage)
 
@@ -76,9 +52,9 @@ class ReportHTMLTest < Minitest::Test
     filename = basic_coverage_file_full_path
     base_path = '/coverage'
     html = Coverband::Reporters::HTMLReport.new(Coverband.configuration.store,
-                                                filename: filename,
-                                                base_path: base_path,
-                                                open_report: false).file_details
+      filename: filename,
+      base_path: base_path,
+      open_report: false).file_details
     assert_match 'Coverage first seen', html
   end
 
@@ -88,9 +64,9 @@ class ReportHTMLTest < Minitest::Test
     filename = 'missing_path'
     base_path = '/coverage'
     html = Coverband::Reporters::HTMLReport.new(Coverband.configuration.store,
-                                                filename: filename,
-                                                base_path: base_path,
-                                                open_report: false).file_details
+      filename: filename,
+      base_path: base_path,
+      open_report: false).file_details
     assert_match 'File No Longer Available', html
   end
 
@@ -100,9 +76,9 @@ class ReportHTMLTest < Minitest::Test
     filename = "#{test_root}/test_helper.rb"
     base_path = '/coverage'
     html = Coverband::Reporters::HTMLReport.new(Coverband.configuration.store,
-                                                filename: filename,
-                                                base_path: base_path,
-                                                open_report: false).file_details
+      filename: filename,
+      base_path: base_path,
+      open_report: false).file_details
     assert_match 'File No Longer Available', html
   end
 end

data/test/coverband/utils/result_test.rb

@@ -16,27 +16,6 @@ describe 'result' do
       }
     end
 
-    describe '#add_not_loaded_files' do
-      it 'Adds files not yet tracked' do
-        results = Coverband::Utils::Result.add_not_loaded_files({}, ['./test/dog.*'])
-        dog_file = results.keys.grep(/dog.rb/).first
-        assert dog_file
-      end
-
-      it 'Does not overrwrite existing coverage' do
-        dog_file = File.expand_path('./test/dog.rb')
-        results = Coverband::Utils::Result.add_not_loaded_files({ dog_file => [0, 1] }, ['./test/dog.*'])
-        assert_equal({ dog_file => [0, 1] }, results)
-      end
-
-      it 'Adds files not yet tracked from multiple file globs' do
-        dog_file = File.expand_path('./test/dog.rb')
-        test_helper_file = File.expand_path('./test/test_helper.rb')
-        results = Coverband::Utils::Result.add_not_loaded_files({}, ['./test/dog.*', './test/test_helper.rb'])
-        assert_equal [dog_file, test_helper_file].to_set, results.keys.to_set
-      end
-    end
-
     describe 'a simple cov result initialized from that' do
       subject { Coverband::Utils::Result.new(original_result) }
 

data/test/forked/rails_full_stack_test.rb

@@ -11,6 +11,8 @@ class RailsFullStackTest < Minitest::Test
     rails_setup
     # preload first coverage hit
     Coverband.report_coverage
+    require 'rainbow'
+    Rainbow('this text is red').red
   end
 
   def teardown
@@ -19,17 +21,10 @@ class RailsFullStackTest < Minitest::Test
     Capybara.use_default_driver
   end
 
-  test 'list all gems even if no coverage' do
-    Capybara.current_driver = :selenium_chrome_headless
-    visit '/coverage'
-    find('a.Gems').click
-    assert_selector('a.gem-link', text: /pundit/)
-    assert_selector('a.gem-link', text: /rainbow/)
-  end
-
+  # We have to combine everything in one test
+  # because we can only initialize rails once per test
+  # run. Possibly fork test runs to avoid this problem in future?
   test 'this is how we do it' do
-    require 'rainbow'
-    Rainbow('this text is red').red
     visit '/dummy/show'
     Coverband.report_coverage
     assert_content('I am no dummy')

data/test/rails_test_helper.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'selenium-webdriver'
-require 'webdrivers'
 require 'minitest'
 require 'minitest/fork_executor'
 
@@ -31,5 +29,4 @@ def rails_setup
   # Our coverage report is wrapped in display:none as of now
   Capybara.ignore_hidden_elements = false
   require 'mocha/minitest'
-  Capybara.server = :webrick
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 4.2.1.rc2
+  version: 4.2.1.rc3
 platform: ruby
 authors:
 - Dan Mayer
@@ -193,34 +193,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: selenium-webdriver
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: webdrivers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: minitest-reporters
   requirement: !ruby/object:Gem::Requirement