coverband 4.2.0 → 4.2.2

data/test/coverband/configuration_test.rb

@@ -5,31 +5,53 @@ require File.expand_path('../test_helper', File.dirname(__FILE__))
 class BaseTest < Minitest::Test
   def setup
     super
+    Coverband.configuration.reset
     Coverband.configure do |config|
       config.root                = Dir.pwd
       config.s3_bucket           = nil
       config.root_paths          = ['/app_path/']
-      config.ignore              = ['vendor']
-      config.reporting_frequency = 100.0
+      config.ignore              = ['config/envionments']
       config.reporter            = 'std_out'
-      config.store               = Coverband::Adapters::RedisStore.new(Redis.new)
+      config.store               = Coverband::Adapters::RedisStore.new(Redis.new, redis_namespace: 'coverband_test')
     end
   end
 
-  test 'defaults' do
+  test 'ignore works with equal' do
     coverband = Coverband::Collectors::Coverage.instance.reset_instance
-    assert_equal ['vendor', 'internal:prelude', 'schema.rb'], coverband.instance_variable_get('@ignore_patterns')
+    expected = ["vendor", ".erb$", ".slim$", "/tmp", "internal:prelude", "schema.rb", "config/envionments"]
+    assert_equal expected, Coverband.configuration.ignore
+  end
+
+  test 'ignore works with plus equal' do
+    Coverband.configure do |config|
+      config.ignore += ['config/initializers']
+    end
+    coverband = Coverband::Collectors::Coverage.instance.reset_instance
+    expected = ["vendor",
+      ".erb$",
+      ".slim$",
+      "/tmp",
+      "internal:prelude",
+      "schema.rb",
+      "config/envionments",
+      "config/initializers"]
+    assert_equal expected, Coverband.configuration.ignore
+  end
+
+  test 'ignore' do
+    Coverband::Collectors::Coverage.instance.reset_instance
+    assert !Coverband.configuration.gem_paths.first.nil?
   end
 
   test 'gem_paths' do
     Coverband::Collectors::Coverage.instance.reset_instance
-    assert Coverband.configuration.gem_paths.first != nil
+    assert !Coverband.configuration.gem_paths.first.nil?
   end
 
   test 'groups' do
     Coverband::Collectors::Coverage.instance.reset_instance
     Coverband.configuration.track_gems = true
-    assert_equal %w(App Gems), Coverband.configuration.groups.keys
+    assert_equal %w[App Gems], Coverband.configuration.groups.keys
   end
 
   test 'all_root_paths' do
@@ -64,4 +86,22 @@ class BaseTest < Minitest::Test
       end
     end
   end
+
+  test 'use_oneshot_lines_coverage' do
+    refute Coverband.configuration.use_oneshot_lines_coverage
+
+    Coverband.configuration.stubs(:one_shot_coverage_implemented_in_ruby_version?).returns(true)
+    Coverband.configuration.use_oneshot_lines_coverage = true
+    assert Coverband.configuration.use_oneshot_lines_coverage
+
+    Coverband.configuration.use_oneshot_lines_coverage = false
+    refute Coverband.configuration.use_oneshot_lines_coverage
+
+    Coverband.configuration.stubs(:one_shot_coverage_implemented_in_ruby_version?).returns(false)
+    exception = assert_raises Exception do
+      Coverband.configuration.use_oneshot_lines_coverage = true
+    end
+    assert_equal 'One shot line coverage is only available in ruby >= 2.6', exception.message
+    refute Coverband.configuration.use_oneshot_lines_coverage
+  end
 end

data/test/coverband/coverband_test.rb

@@ -3,7 +3,6 @@
 require File.expand_path('../test_helper', File.dirname(__FILE__))
 
 class CoverbandTest < Minitest::Test
-
   test 'Coverband#start kicks off background reporting if enabled and not in rack server' do
     Coverband.configuration.stubs(:background_reporting_enabled).returns(:true)
     Coverband::RackServerCheck.expects(:running?).returns(false)
@@ -24,10 +23,23 @@ class CoverbandTest < Minitest::Test
     ::Coverband.start
   end
 
+  test 'Coverband#configured? works' do
+    Coverband.configure
+    assert Coverband.configured?
+  end
+
+  test 'Eager load coverage block' do
+    Coverband.eager_loading_coverage {
+      #some code
+      1 + 1
+    }
+    assert_equal :runtime, Coverband.configuration.store.type
+  end
+
   test 'Eager load coverage' do
     Coverband.eager_loading_coverage!
     assert_equal :eager_loading, Coverband.configuration.store.type
     Coverband.runtime_coverage!
-    assert_nil Coverband.configuration.store.type
+    assert_equal :runtime, Coverband.configuration.store.type
   end
 end

data/test/coverband/integrations/background_middleware_test.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require 'rack'
+
+class BackgroundMiddlewareTest < Minitest::Test
+  def setup
+    super
+    Coverband.configure do |config|
+      config.background_reporting_enabled = false
+    end
+  end
+
+  test 'call app' do
+    request = Rack::MockRequest.env_for('/anything.json')
+    Coverband::Collectors::Coverage.instance.reset_instance
+    middleware = Coverband::BackgroundMiddleware.new(fake_app)
+    results = middleware.call(request)
+    assert_equal '/anything.json', results.last
+  end
+
+  test 'pass all rack lint checks' do
+    Coverband::Collectors::Coverage.instance.reset_instance
+    app = Rack::Lint.new(Coverband::BackgroundMiddleware.new(fake_app))
+    env = Rack::MockRequest.env_for('/hello')
+    app.call(env)
+  end
+
+  test 'starts background reporter when configured' do
+    request = Rack::MockRequest.env_for('/anything.json')
+    Coverband.configuration.stubs(:background_reporting_enabled).returns(true)
+    Coverband::Background.expects(:start)
+    middleware = Coverband::BackgroundMiddleware.new(fake_app)
+    middleware.call(request)
+  end
+
+  private
+
+  def fake_app
+    @fake_app ||= lambda do |env|
+      [200, { 'Content-Type' => 'text/plain' }, env['PATH_INFO']]
+    end
+  end
+end

data/test/coverband/integrations/background_test.rb

@@ -4,8 +4,7 @@ require File.expand_path('../../test_helper', File.dirname(__FILE__))
 
 class BackgroundTest < Minitest::Test
   class ThreadDouble < Struct.new(:alive)
-    def exit
-    end
+    def exit; end
 
     def alive?
       alive
@@ -27,5 +26,4 @@ class BackgroundTest < Minitest::Test
     Coverband::Collectors::Coverage.instance.expects(:report_coverage).twice
     2.times { Coverband::Background.start }
   end
-
 end

data/test/coverband/integrations/report_middleware_test.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require 'coverband/integrations/report_middleware'
+
+class ReportMiddlewareTest < Minitest::Test
+  def setup
+    super
+    Coverband.configure do |config|
+      config.background_reporting_enabled = false
+    end
+  end
+
+  test 'reports coverage' do
+    request = Rack::MockRequest.env_for('/anything.json')
+    Coverband::Collectors::Coverage.instance.expects(:report_coverage)
+    middleware = Coverband::ReportMiddleware.new(fake_app)
+    middleware.call(request)
+  end
+
+  test 'reports coverage when an error is raised' do
+    request = Rack::MockRequest.env_for('/anything.json')
+    Coverband::Collectors::Coverage.instance.reset_instance
+    Coverband::Collectors::Coverage.instance.expects(:report_coverage).once
+    middleware = Coverband::ReportMiddleware.new(fake_app_raise_error)
+    begin
+      middleware.call(request)
+    rescue StandardError
+      nil
+    end
+  end
+
+  private
+
+  def fake_app
+    @fake_app ||= lambda do |env|
+      [200, { 'Content-Type' => 'text/plain' }, env['PATH_INFO']]
+    end
+  end
+
+  def fake_app_raise_error
+    @fake_app_raise_error ||= -> { raise 'hell' }
+  end
+end

data/test/coverband/integrations/resque_worker_test.rb

@@ -5,7 +5,7 @@ require File.expand_path('../../test_helper', File.dirname(__FILE__))
 class ResqueWorkerTest < Minitest::Test
   def enqueue_and_run_job
     Resque.enqueue(TestResqueJob)
-    queue = ENV['QUEUE'] ='resque_coverband'
+    queue = ENV['QUEUE'] = 'resque_coverband'
     worker = Resque::Worker.new
     worker.startup
     worker.work_one_job
@@ -15,15 +15,15 @@ class ResqueWorkerTest < Minitest::Test
     super
     Coverband.configure do |config|
       config.background_reporting_enabled = false
-      config.root_paths = ["#{File.expand_path('../', File.dirname(__FILE__))}/"]
     end
+    Coverband.configuration.store.instance_variable_set(:@redis_namespace, 'coverband_test')
     Coverband.start
-    redis = Coverband.configuration.store.send(:redis)
+    redis = Coverband.configuration.store.instance_eval { @redis }
     Resque.redis = redis
   end
 
   test 'resque job coverage' do
-    relative_job_file = './integrations/test_resque_job.rb'
+    relative_job_file = './test/coverband/integrations/test_resque_job.rb'
     resque_job_file = File.expand_path('./test_resque_job.rb', File.dirname(__FILE__))
     require resque_job_file
 
@@ -36,7 +36,7 @@ class ResqueWorkerTest < Minitest::Test
     Coverband.runtime_coverage!
     report = Coverband.configuration.store.get_coverage_report
 
-    assert_equal 0, report[Coverband::EAGER_TYPE][relative_job_file]['data'][4]
-    assert_equal 1, report[Coverband::RUNTIME_TYPE][relative_job_file]['data'][4]
+    assert_equal 0, report[Coverband::EAGER_TYPE][relative_job_file]['data'][6]
+    assert_equal 1, report[Coverband::RUNTIME_TYPE][relative_job_file]['data'][6]
   end
 end

data/test/coverband/integrations/test_resque_job.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 class TestResqueJob
   @queue = :resque_coverband
 
   def self.perform
-    "resque job perform"
+    'resque job perform'
   end
 end

data/test/coverband/reporters/base_test.rb

@@ -3,74 +3,6 @@
 require File.expand_path('../../test_helper', File.dirname(__FILE__))
 
 class ReportsBaseTest < Minitest::Test
-  test 'relative_path_to_full fix filename from a key with a swappable path' do
-    Coverband.configure do |config|
-      config.reporter          = 'std_out'
-      config.root              = '/full/remote_app/path'
-    end
-
-    key = '/app/is/a/path.rb'
-    # the code takes config.root expands and adds a '/' for the final path in roots
-    roots = ['/app/', '/full/remote_app/path/']
-
-    expected_path = '/full/remote_app/path/is/a/path.rb'
-    File.expects(:exist?).with(key).returns(false)
-    File.expects(:exist?).with(expected_path).returns(true)
-    assert_equal expected_path, Coverband::Reporters::Base.send(:relative_path_to_full, key, roots)
-  end
-
-  test 'relative_path_to_full fix filename a changing deploy path with quotes' do
-    Coverband.configure do |config|
-      config.reporter          = 'std_out'
-      config.root              = '/full/remote_app/path'
-    end
-
-    expected_path = '/full/remote_app/path/app/models/user.rb'
-    key = '/box/apps/app_name/releases/20140725203539/app/models/user.rb'
-    roots = ["/box/apps/app_name/releases/\\d+/", '/full/remote_app/path/']
-    File.expects(:exist?).with('/box/apps/app_name/releases/\\d+/app/models/user.rb').returns(false)
-    File.expects(:exist?).with(expected_path).returns(true)
-    assert_equal expected_path, Coverband::Reporters::Base.send(:relative_path_to_full, key, roots)
-    File.expects(:exist?).with('/box/apps/app_name/releases/\\d+/app/models/user.rb').returns(false)
-    File.expects(:exist?).with(expected_path).returns(true)
-    roots = ['/box/apps/app_name/releases/\d+/', '/full/remote_app/path/']
-    assert_equal expected_path, Coverband::Reporters::Base.send(:relative_path_to_full, key, roots)
-  end
-
-  test 'relative_path_to_full fix filename a changing deploy path real world examples' do
-    current_app_root = '/var/local/company/company.d/79'
-    Coverband.configure do |config|
-      config.reporter          = 'std_out'
-      config.root              = current_app_root
-    end
-
-    expected_path = '/var/local/company/company.d/79/app/controllers/dashboard_controller.rb'
-    key = '/var/local/company/company.d/78/app/controllers/dashboard_controller.rb'
-
-    File.expects(:exist?).with('/var/local/company/company.d/[0-9]*/app/controllers/dashboard_controller.rb').returns(false)
-    File.expects(:exist?).with(expected_path).returns(true)
-    roots = ['/var/local/company/company.d/[0-9]*/', "#{current_app_root}/"]
-    assert_equal expected_path, Coverband::Reporters::Base.send(:relative_path_to_full, key, roots)
-    File.expects(:exist?).with('/var/local/company/company.d/[0-9]*/app/controllers/dashboard_controller.rb').returns(false)
-    File.expects(:exist?).with(expected_path).returns(true)
-    roots = ["/var/local/company/company.d/[0-9]*/", "#{current_app_root}/"]
-    assert_equal expected_path, Coverband::Reporters::Base.send(:relative_path_to_full, key, roots)
-  end
-
-  test 'relative_path_to_full leave filename from a key with a local path' do
-    Coverband.configure do |config|
-      config.reporter          = 'std_out'
-      config.root              = '/full/remote_app/path'
-    end
-
-    key = '/full/remote_app/path/is/a/path.rb'
-    # the code takes config.root expands and adds a '/' for the final path in roots
-    roots = ['/app/', '/full/remote_app/path/']
-
-    expected_path = '/full/remote_app/path/is/a/path.rb'
-    assert_equal expected_path, Coverband::Reporters::Base.send(:relative_path_to_full, key, roots)
-  end
-
   test '#merge_arrays basic merge preserves order and counts' do
     first = [0, 0, 1, 0, 1]
     second = [nil, 0, 1, 0, 0]
@@ -97,7 +29,7 @@ class ReportsBaseTest < Minitest::Test
 
   test "#get_current_scov_data_imp doesn't ignore folders with default ignore keys" do
     @redis = Redis.new
-    store = Coverband::Adapters::RedisStore.new(@redis)
+    store = Coverband::Adapters::RedisStore.new(@redis, redis_namespace: 'coverband_test')
     store.clear!
 
     Coverband.configure do |config|
@@ -139,19 +71,10 @@ class ReportsBaseTest < Minitest::Test
         "file_hash"=>"14dc84e940e26cbfb9ac79b43862e762",
         "data"=>[16, 16, 16, nil, 16, 16, nil, nil, 16, nil, 16, 32, 32, nil, 32, 32, 32, 32, 32, 32, 32, nil, nil, 16, nil, 16, 32, 23, 0, 0, 0, 0, nil, nil, nil, nil, 0, 0, nil, nil, 16, 32, 32, 32, nil, nil, nil, nil, nil, 16, 32, nil, nil, 16, 32, nil, nil]}
       }
-    @redis = Redis.new
-    store = Coverband::Adapters::RedisStore.new(@redis)
-    store.clear!
-
-    Coverband.configure do |config|
-      config.reporter          = 'std_out'
-      config.root              = '/base/78/app/'
-      config.store             = store
-    end
-
     key = '/base/78/app/app/controllers/dashboard_controller.rb'
     roots = ['/base/[0-9]*/', '/base/78/app/']
 
+    Coverband.configuration.stubs(:all_root_paths).returns(roots)
     lines_hit = [1, 3, 6]
     store.stubs(:merged_coverage).returns(coverage)
     File.expects(:exist?).at_least_once

data/test/coverband/reporters/console_test.rb

@@ -8,7 +8,7 @@ class HTMLReportTest < Minitest::Test
   def setup
     super
     @redis = Redis.new
-    @store = Coverband::Adapters::RedisStore.new(@redis)
+    @store = Coverband::Adapters::RedisStore.new(@redis, redis_namespace: 'coverband_test')
     @store.clear!
   end
 
@@ -16,14 +16,10 @@ class HTMLReportTest < Minitest::Test
     Coverband.configure do |config|
       config.reporter            = 'std_out'
       config.store               = @store
-      config.reporting_frequency = 100.0
     end
     Coverband.configuration.logger.stubs('info')
     mock_file_hash
-    Coverband.configuration
-             .expects(:current_root)
-             .at_least_once
-             .returns('app_path')
+    Coverband::Utils::RelativeFileConverter.expects(:convert).with('app_path/dog.rb').returns('./dog.rb')
     @store.send(:save_report, basic_coverage)
 
     report = Coverband::Reporters::ConsoleReport.report(@store)[:merged]

data/test/coverband/reporters/html_test.rb

@@ -6,40 +6,79 @@ class ReportHTMLTest < Minitest::Test
   def setup
     super
     @redis = Redis.new
-    @store = Coverband::Adapters::RedisStore.new(@redis)
+    @store = Coverband::Adapters::RedisStore.new(@redis, redis_namespace: 'coverband_test')
     @store.clear!
-  end
-
-  test 'generate scov html report' do
     Coverband.configure do |config|
-      config.reporter          = 'scov'
       config.store             = @store
-      config.s3_bucket         = nil
-      config.ignore            = ['notsomething.rb']
+      config.root              = fixtures_root
+      config.ignore            = ['notsomething.rb', 'lib/*']
     end
     mock_file_hash
+  end
+
+  test 'generate dynamic content hosted html report' do
     @store.send(:save_report, basic_coverage)
 
     html = Coverband::Reporters::HTMLReport.new(@store,
-                                                   html: true,
-                                                   open_report: false).report
+                                                static: false,
+                                                open_report: false).report
     assert_match 'Generated by', html
   end
 
-  test 'generate scov report file' do
-    Coverband.configure do |config|
-      config.reporter          = 'scov'
-      config.store             = @store
-      config.s3_bucket         = nil
-      config.ignore            = ['notsomething.rb']
-    end
-    mock_file_hash
+  test 'files with no Coverage but in project are shown in reports' do
+    @store.send(:save_report, basic_source_fixture_coverage)
+
+    html = Coverband::Reporters::HTMLReport.new(@store,
+                                                static: false,
+                                                open_report: false).report
+    assert_match 'sample.rb', html
+    # in project, but not in coverage data
+    assert_match 'app/models/user.rb', html
+  end
+
+  test 'generate static HTML report file' do
     @store.send(:save_report, basic_coverage)
 
     reporter = Coverband::Reporters::HTMLReport.new(@store,
-                                                    html: false,
+                                                    static: true,
                                                     open_report: false)
-    Coverband::Utils::HTMLFormatter.any_instance.expects(:format!).once
+    Coverband::Utils::HTMLFormatter.any_instance.expects(:format_static_html!).once
     reporter.report
   end
+
+  test 'generate dynamic content detailed file report' do
+    @store.send(:save_report, basic_coverage_full_path)
+
+    filename = basic_coverage_file_full_path
+    base_path = '/coverage'
+    html = Coverband::Reporters::HTMLReport.new(Coverband.configuration.store,
+                                                filename: filename,
+                                                base_path: base_path,
+                                                open_report: false).file_details
+    assert_match 'Coverage first seen', html
+  end
+
+  test 'generate dynamic content detailed file report handles missing file' do
+    @store.send(:save_report, basic_coverage_full_path)
+
+    filename = 'missing_path'
+    base_path = '/coverage'
+    html = Coverband::Reporters::HTMLReport.new(Coverband.configuration.store,
+                                                filename: filename,
+                                                base_path: base_path,
+                                                open_report: false).file_details
+    assert_match 'File No Longer Available', html
+  end
+
+  test 'generate dynamic content detailed file report does not allow loading real non project files' do
+    @store.send(:save_report, basic_coverage_full_path)
+
+    filename = "#{test_root}/test_helper.rb"
+    base_path = '/coverage'
+    html = Coverband::Reporters::HTMLReport.new(Coverband.configuration.store,
+                                                filename: filename,
+                                                base_path: base_path,
+                                                open_report: false).file_details
+    assert_match 'File No Longer Available', html
+  end
 end

data/test/coverband/reporters/web_test.rb

@@ -37,16 +37,6 @@ if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.2.0')
         post '/clear'
         assert_equal 301, last_response.status
       end
-
-      test 'collect_coverage' do
-        post '/collect_coverage'
-        assert_equal 301, last_response.status
-      end
-
-      test 'reload_files' do
-        post '/reload_files'
-        assert_equal 301, last_response.status
-      end
     end
   end
 end

data/test/coverband/utils/absolute_file_converter_test.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../test_helper', File.dirname(__FILE__))
+
+module Coverband
+  module Utils
+    class AbsoluteFileConverterTest < ::Minitest::Test
+      def test_convert
+        converter = AbsoluteFileConverter.new([FileUtils.pwd])
+        assert_equal("#{FileUtils.pwd}/lib/coverband.rb", converter.convert('./lib/coverband.rb'))
+      end
+
+      def test_convert_multiple_roots
+        converter = AbsoluteFileConverter.new(['/foo/bar', FileUtils.pwd])
+        assert_equal("#{FileUtils.pwd}/Rakefile", converter.convert('./Rakefile'))
+      end
+
+      test 'relative_path_to_full leave filename from a key with a local path' do
+        converter = AbsoluteFileConverter.new(['/app/', '/full/remote_app/path/'])
+        assert_equal '/full/remote_app/path/is/a/path.rb', converter.convert('/full/remote_app/path/is/a/path.rb')
+      end
+
+      test 'relative_path_to_full fix filename from a key with a swappable path' do
+        key = '/app/is/a/path.rb'
+        converter = AbsoluteFileConverter.new(['/app/', '/full/remote_app/path/'])
+        expected_path = '/full/remote_app/path/is/a/path.rb'
+        File.expects(:exist?).with(key).returns(false)
+        File.expects(:exist?).with(expected_path).returns(true)
+        assert_equal expected_path, converter.convert(key)
+      end
+
+      test 'relative_path_to_full fix filename a changing deploy path with quotes' do
+        converter = AbsoluteFileConverter.new(['/box/apps/app_name/releases/\\d+/', '/full/remote_app/path/'])
+        expected_path = '/full/remote_app/path/app/models/user.rb'
+        key = '/box/apps/app_name/releases/20140725203539/app/models/user.rb'
+        File.expects(:exist?).with('/box/apps/app_name/releases/\\d+/app/models/user.rb').returns(false)
+        File.expects(:exist?).with(expected_path).returns(true)
+        assert_equal expected_path, converter.convert(key)
+        assert_equal expected_path, converter.convert(key)
+      end
+
+      test 'relative_path_to_full fix filename a changing deploy path real world examples' do
+        current_app_root = '/var/local/company/company.d/79'
+        converter = AbsoluteFileConverter.new(['/var/local/company/company.d/[0-9]*/', "#{current_app_root}/"])
+
+        expected_path = '/var/local/company/company.d/79/app/controllers/dashboard_controller.rb'
+        key = '/var/local/company/company.d/78/app/controllers/dashboard_controller.rb'
+        File.expects(:exist?).with('/var/local/company/company.d/[0-9]*/app/controllers/dashboard_controller.rb').returns(false)
+        File.expects(:exist?).with(expected_path).returns(true)
+        roots = ['/var/local/company/company.d/[0-9]*/', "#{current_app_root}/"]
+        assert_equal expected_path, converter.convert(key)
+        assert_equal expected_path, converter.convert(key)
+      end
+    end
+  end
+end

data/test/coverband/utils/file_groups_test.rb

@@ -3,16 +3,18 @@
 require File.expand_path('../../test_helper', File.dirname(__FILE__))
 
 describe Coverband::Utils::FileGroups do
-  FAKE_GEM_PATH = 'fake/gem/path'
+  FAKE_GEM_PATH = '/Users/danmayer/.rvm/gems/ruby-2.6.2/gems'
+  SECONDAY_GEM_PATH = '/Users/danmayer/.rvm/rubies/ruby-2.6.2/lib/ruby/gems/2.6.0/gems'
   subject do
     controller_lines = [nil, 2, 2, 0, nil, nil, 0, nil, nil, nil]
     files = [
       Coverband::Utils::SourceFile.new(source_fixture('sample.rb'), [nil, 1, 1, 1, nil, nil, 1, 1, nil, nil]),
       Coverband::Utils::SourceFile.new(source_fixture('app/models/user.rb'), [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil]),
       Coverband::Utils::SourceFile.new(source_fixture('app/controllers/sample_controller.rb'), controller_lines),
-      Coverband::Utils::SourceFile.new("#{FAKE_GEM_PATH}/gem_name.rb", controller_lines)
+      Coverband::Utils::SourceFile.new("#{FAKE_GEM_PATH}/gem_name-1.0.0/gem_name.rb", controller_lines),
+      Coverband::Utils::SourceFile.new("#{SECONDAY_GEM_PATH}/gem_two_name-1.1.1/gem_two.rb", controller_lines)
     ]
-    Coverband.configuration.expects(:gem_paths).at_least_once.returns([FAKE_GEM_PATH])
+    Coverband.configuration.expects(:gem_paths).at_least_once.returns([FAKE_GEM_PATH, SECONDAY_GEM_PATH])
     Coverband.configuration.track_gems = true
     Coverband::Utils::FileGroups.new(files)
   end
@@ -22,7 +24,11 @@ describe Coverband::Utils::FileGroups do
   end
 
   it 'has gem files' do
-    assert_equal "#{FAKE_GEM_PATH}/gem_name.rb", subject.grouped_results['Gems'].first.first.short_name
+    assert_equal "gem_name-1.0.0", subject.grouped_results['Gems'].first.first.gem_name
+  end
+
+  it 'has gem files from secondary gem paths' do
+    assert_equal "gem_two_name-1.1.1", subject.grouped_results['Gems'][1].first.gem_name
   end
 end
 
@@ -50,6 +56,6 @@ describe Coverband::Utils::FileGroups, :vendored_gems do
   end
 
   it 'does has gem files' do
-    assert_equal 'gem_name.rb', subject.grouped_results['Gems'].first.first.short_name
+    assert_equal '.gem_name.rb', subject.grouped_results['Gems'].first.first.short_name
   end
 end

data/test/coverband/utils/file_hasher_test.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../test_helper', File.dirname(__FILE__))
+
+module Coverband
+  module Utils
+    class FileHasherTest < Minitest::Test
+      def test_hash_same_file
+        refute_nil FileHasher.hash('./test/dog.rb')
+        assert_equal(FileHasher.hash('./test/dog.rb'), FileHasher.hash('./test/dog.rb'))
+        assert_equal(FileHasher.hash(File.expand_path('./test/dog.rb')), FileHasher.hash('./test/dog.rb'))
+      end
+
+      def test_hash_different_files
+        refute_equal(FileHasher.hash('./test/dog.rb'), FileHasher.hash('./lib/coverband.rb'))
+      end
+
+      def test_hash_file_not_exists
+        assert_nil(FileHasher.hash('./made_up_file.py'))
+      end
+
+      def test_hash_gem_file
+        spec = Gem::Specification.find_by_name('rainbow')
+        assert FileHasher.hash("./gems/rainbow-#{spec.version}/lib/rainbow.rb",
+                               path_converter: AbsoluteFileConverter.new(Coverband.configuration.gem_paths))
+      end
+    end
+  end
+end