coverband 4.2.0.rc1 → 4.2.0.rc2

data/lib/coverband/adapters/redis_store.rb

@@ -22,7 +22,17 @@ module Coverband
       end
 
       def clear!
-        @redis.del(base_key)
+        Coverband::TYPES.each do |type|
+          @redis.del(type_base_key(type))
+        end
+      end
+
+      def clear_file!(filename)
+        Coverband::TYPES.each do |type|
+          data = get_report(type)
+          data.delete(filename)
+          save_coverage(data, type)
+        end
       end
 
       def size
@@ -51,6 +61,11 @@ module Coverband
         save_coverage(merge_reports(get_report, relative_path_report, skip_expansion: true))
       end
 
+      def type=(type)
+        super
+        reset_base_key
+      end
+
       private
 
       attr_reader :redis
@@ -60,16 +75,22 @@ module Coverband
       end
 
       def base_key
-        @base_key ||= [@format_version, @redis_namespace].compact.join('.')
+        @base_key ||= [@format_version, @redis_namespace, type].compact.join('.')
+      end
+
+      def type_base_key(local_type)
+        [@format_version, @redis_namespace, local_type].compact.join('.')
       end
 
-      def save_coverage(data)
-        redis.set base_key, data.to_json
-        redis.expire(base_key, @ttl) if @ttl
+      def save_coverage(data, local_type = nil)
+        local_type ||= type
+        redis.set type_base_key(local_type), data.to_json
+        redis.expire(type_base_key(local_type), @ttl) if @ttl
       end
 
-      def get_report
-        data = redis.get base_key
+      def get_report(local_type = nil)
+        local_type ||= type
+        data = redis.get type_base_key(local_type)
         data ? JSON.parse(data) : {}
       end
     end

data/lib/coverband/at_exit.rb

@@ -4,15 +4,32 @@ module Coverband
   class AtExit
     @semaphore = Mutex.new
 
+    @at_exit_registered = nil
     def self.register
+      return if ENV['COVERBAND_DISABLE_AT_EXIT']
       return if @at_exit_registered
+
       @semaphore.synchronize do
         return if @at_exit_registered
+
         @at_exit_registered = true
         at_exit do
           ::Coverband::Background.stop
-          Coverband.report_coverage(true)
-          Coverband.configuration.logger&.debug('Coverband: Reported coverage before exit')
+
+          #####
+          # TODO: This is is brittle and not a great solution to avoid deploy time
+          # actions polluting the 'runtime' metrics
+          #
+          # * should we skip /bin/rails webpacker:compile ?
+          # * Perhaps detect heroku deployment ENV var opposed to tasks?
+          #####
+          default_heroku_tasks = ['assets:clean', 'assets:precompile']
+          if defined?(Rake) && Rake.respond_to?(:application) && (Rake&.application&.top_level_tasks || []).any? { |task| default_heroku_tasks.include?(task) }
+            # skip reporting
+          else
+            Coverband.report_coverage(true)
+            #Coverband.configuration.logger&.debug('Coverband: Reported coverage before exit')
+          end
         end
       end
     end

data/lib/coverband/collectors/coverage.rb

@@ -1,48 +1,62 @@
 # frozen_string_literal: true
+require 'singleton'
+require_relative 'delta'
 
 module Coverband
   module Collectors
     ###
     # TODO: look at alternatives to semaphore
-    # StandardError seems line be better option
+    # StandardError seems like be better option
     # coverband previously had RuntimeError here
     # but runtime error can let a large number of error crash this method
     # and this method is currently in a ensure block in middleware and threads
     ###
     class Coverage
-      def self.instance
-        Thread.current[:coverband_instance] ||= Coverband::Collectors::Coverage.new
-      end
+      include Singleton
+      extend Forwardable
 
       def reset_instance
         @project_directory = File.expand_path(Coverband.configuration.root)
-        @file_line_usage = {}
         @ignore_patterns = Coverband.configuration.ignore + ['internal:prelude', 'schema.rb']
         @reporting_frequency = Coverband.configuration.reporting_frequency
         @store = Coverband.configuration.store
         @verbose  = Coverband.configuration.verbose
         @logger   = Coverband.configuration.logger
-        @current_thread = Thread.current
         @test_env = Coverband.configuration.test_env
         @track_gems = Coverband.configuration.track_gems
-        @@previous_results = nil
-        Thread.current[:coverband_instance] = nil
+        Delta.reset
         self
       end
 
+      def runtime!
+        @store.type = nil
+      end
+
+      def eager_loading!
+        @store.type = Coverband::EAGER_TYPE
+      end
+
       def report_coverage(force_report = false)
         return if !ready_to_report? && !force_report
         raise 'no Coverband store set' unless @store
 
-        new_results = get_new_coverage_results
-        add_filtered_files(new_results)
-        @store.save_report(files_with_line_usage)
-        @file_line_usage.clear
+        original_previous_set = Delta.previous_results
+        files_with_line_usage = filtered_files(Delta.results)
+
+        ###
+        # Hack to prevent processes and threads from reporting first Coverage hit
+        # when we are in runtime collection mode, which do not have a cache of previous
+        # coverage to remove the initial stdlib Coverage loading data
+        ###
+        if ((original_previous_set.nil? && @store.type == Coverband::EAGER_TYPE) ||
+           (original_previous_set && @store.type != Coverband::EAGER_TYPE))
+          @store.save_report(files_with_line_usage)
+        end
       rescue StandardError => err
         if @verbose
-          @logger.error 'coverage failed to store'
-          @logger.error "error: #{err.inspect} #{err.message}"
-          @logger.error err.backtrace
+          @logger&.error 'coverage failed to store'
+          @logger&.error "error: #{err.inspect} #{err.message}"
+          @logger&.error err.backtrace
         end
         raise err if @test_env
       end
@@ -59,85 +73,27 @@ module Coverband
         @ignore_patterns.none? do |pattern|
           file.include?(pattern)
         end && (file.start_with?(@project_directory) ||
-         (@track_gems &&
-          Coverband.configuration.gem_paths.any? { |path| file.start_with?(path) }))
+                (@track_gems &&
+                 Coverband.configuration.gem_paths.any? { |path| file.start_with?(path) }))
       end
 
       private
 
-      def add_filtered_files(new_results)
-        new_results.each_pair do |file, line_counts|
-          next unless track_file?(file)
-          add_file(file, line_counts)
-        end
+      def filtered_files(new_results)
+        new_results.each_with_object({}) do |(file, line_counts), file_line_usage|
+          file_line_usage[file] = line_counts if track_file?(file)
+        end.select { |_file_name, coverage| coverage.any? { |value| value&.nonzero? } }
       end
 
       def ready_to_report?
         (rand * 100.0) >= (100.0 - @reporting_frequency)
       end
 
-      def get_new_coverage_results
-        @semaphore.synchronize { new_coverage(::Coverage.peek_result.dup) }
-      end
-
-      def files_with_line_usage
-        @file_line_usage.select do |_file_name, coverage|
-          coverage.any? { |value| value&.nonzero? }
-        end
-      end
-
-      def array_diff(latest, original)
-        latest.map.with_index do |v, i|
-           if (v && original[i])
-              if v >= original[i]
-                v - original[i]
-              else
-                0
-              end
-           else
-            nil
-           end
-         end
-      end
-
-      def previous_results
-        @@previous_results
-      end
-
-      def add_previous_results(val)
-        @@previous_results = val
-      end
-
-      def new_coverage(current_coverage)
-        if previous_results
-          new_results = {}
-          current_coverage.each_pair do |file, line_counts|
-            if previous_results[file]
-              new_results[file] = array_diff(line_counts, previous_results[file])
-            else
-              new_results[file] = line_counts
-            end
-          end
-        else
-          new_results = current_coverage
-        end
-
-        add_previous_results(current_coverage)
-        new_results.dup
-      end
-
-      def add_file(file, line_counts)
-        @file_line_usage[file] = line_counts
-      end
-
       def initialize
         if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.3.0')
           raise NotImplementedError, 'not supported until Ruby 2.3.0 and later'
         end
-        unless defined?(::Coverage)
-          # puts 'loading coverage'
-          require 'coverage'
-        end
+        require 'coverage'
         if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.5.0')
           ::Coverage.start unless ::Coverage.running?
         else
@@ -148,8 +104,6 @@ module Coverband
             load safe_file
           end
         end
-        @semaphore = Mutex.new
-        @@previous_results = nil
         reset_instance
       end
     end

data/lib/coverband/collectors/delta.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+module Coverband
+  module Collectors
+    class Delta
+      @semaphore = Mutex.new
+      @@previous_coverage = nil
+      attr_reader :current_coverage
+
+      def initialize(current_coverage)
+        @current_coverage = current_coverage
+      end
+
+      class RubyCoverage
+        def self.results
+          ::Coverage.peek_result.dup
+        end
+      end
+
+      def self.results(process_coverage = RubyCoverage)
+        @semaphore.synchronize do
+          @@previous_coverage ||= {}
+          new(process_coverage.results).results
+        end
+      end
+
+      def self.previous_results
+        @@previous_coverage
+      end
+
+      def results
+        new_results = generate
+        @@previous_coverage = current_coverage
+        new_results
+      end
+
+      def self.reset
+        @@previous_coverage = nil
+      end
+
+      private
+
+      def generate
+        current_coverage.each_with_object({}) do |(file, line_counts), new_results|
+          if @@previous_coverage[file]
+            new_results[file] = array_diff(line_counts, @@previous_coverage[file])
+          else
+            new_results[file] = line_counts
+          end
+        end
+      end
+
+      def array_diff(latest, original)
+        latest.map.with_index do |v, i|
+          if (v && original[i])
+            [0, v - original[i]].max
+          else
+            nil
+          end
+        end
+      end
+    end
+  end
+end

data/lib/coverband/integrations/background.rb

@@ -3,6 +3,7 @@
 module Coverband
   class Background
     @semaphore = Mutex.new
+    @thread = nil
 
     def self.stop
       return unless @thread
@@ -15,15 +16,15 @@ module Coverband
     end
 
     def self.running?
-      !!@thread
+      @thread && @thread.alive?
     end
 
     def self.start
-      return if @thread
+      return if running?
 
       logger = Coverband.configuration.logger
       @semaphore.synchronize do
-        return if @thread
+        return if running?
         logger&.debug('Coverband: Starting background reporting')
         sleep_seconds = Coverband.configuration.background_reporting_sleep_seconds
         @thread = Thread.new do

data/lib/coverband/integrations/rack_server_check.rb

@@ -20,7 +20,10 @@ module Coverband
 
     def rails_server?
       @stack.any? do |location|
-        location.path.include?('rails/commands/commands_tasks.rb') && location.label == 'server'
+        (
+          location.path.include?('rails/commands/commands_tasks.rb') && location.label == 'server' ||
+          location.path.include?('rails/commands/server/server_command.rb') && location.label == 'perform'
+        )
       end
     end
   end

data/lib/coverband/reporters/base.rb

@@ -15,7 +15,7 @@ module Coverband
 
           if Coverband.configuration.verbose
             msg = "report:\n #{scov_style_report.inspect}"
-            Coverband.configuration.logger.debug msg
+            # Coverband.configuration.logger.debug msg
           end
           scov_style_report
         end
@@ -28,15 +28,18 @@ module Coverband
           end
 
           # normalize names across servers
-          report_hash.each_with_object({}) do |(key, vals), fixed_report|
-            filename = relative_path_to_full(key, roots)
-            fixed_report[filename] = if fixed_report.key?(filename) && fixed_report[filename]['data'] && vals['data']
-                                       merged_data = merge_arrays(fixed_report[filename]['data'], vals['data'])
-                                       vals['data'] = merged_data
-                                       vals
-                                     else
-                                       vals
-                                     end
+          report_hash.each_with_object({}) do |(name, report), fixed_report|
+            fixed_report[name] = {}
+            report.each_pair do |key, vals|
+              filename = relative_path_to_full(key, roots)
+              fixed_report[name][filename] = if fixed_report[name].key?(filename) && fixed_report[name][filename]['data'] && vals['data']
+                                         merged_data = merge_arrays(fixed_report[name][filename]['data'], vals['data'])
+                                         vals['data'] = merged_data
+                                         vals
+                                       else
+                                         vals
+                                       end
+            end
           end
         end
 
@@ -64,10 +67,14 @@ module Coverband
         ###
         def get_current_scov_data_imp(store, roots)
           scov_style_report = {}
-          store.coverage.each_pair do |key, line_data|
-            next if Coverband.configuration.ignore.any? { |i| key.match(i) }
-            next unless line_data
-            scov_style_report[key] = line_data
+          store.get_coverage_report.each_pair do |name, data|
+            data.each_pair do |key, line_data|
+              next if Coverband.configuration.ignore.any? { |i| key.match(i) }
+              next unless line_data
+
+              scov_style_report[name] = {} unless scov_style_report.key?(name)
+              scov_style_report[name][key] = line_data
+            end
           end
 
           scov_style_report = fix_file_names(scov_style_report, roots)

data/lib/coverband/reporters/html_report.rb

@@ -3,23 +3,28 @@
 module Coverband
   module Reporters
     class HTMLReport < Base
-      def self.report(store, options = {})
-        scov_style_report = super(store, options)
-        open_report = options.fetch(:open_report) { true }
-        html = options.fetch(:html) { false }
-        notice = options.fetch(:notice) { nil }
-        base_path = options.fetch(:base_path) { nil }
+      attr_accessor :filtered_report_files, :open_report, :html, :notice,
+                    :base_path, :filename
 
-        # list all files, even if not tracked by Coverband (0% coverage)
-        tracked_glob = "#{Coverband.configuration.current_root}/{app,lib,config}/**/*.{rb}"
-        report_files = Coverband::Utils::Result.add_not_loaded_files(scov_style_report, tracked_glob)
-        # apply coverband filters
-        filtered_report_files = {}
-        report_files.each_pair do |file, data|
-          next if Coverband.configuration.ignore.any? { |i| file.match(i) }
-          filtered_report_files[file] = data
-        end
+      def initialize(store, options = {})
+        coverband_reports = Coverband::Reporters::Base.report(store, options)
+        self.open_report = options.fetch(:open_report) { true }
+        self.html = options.fetch(:html) { false }
+        # TODO: refactor notice out to top level of web only
+        self.notice = options.fetch(:notice) { nil }
+        self.base_path = options.fetch(:base_path) { nil }
+        self.filename = options.fetch(:filename) { nil }
+
+        self.filtered_report_files = self.class.fix_reports(coverband_reports)
+      end
+
+      def file_details
+        Coverband::Utils::HTMLFormatter.new(filtered_report_files,
+                                            base_path: base_path,
+                                            notice: notice).format_source_file!(filename)
+      end
 
+      def report
         if html
           Coverband::Utils::HTMLFormatter.new(filtered_report_files,
                                               base_path: base_path,
@@ -35,6 +40,26 @@ module Coverband
           Coverband::Utils::S3Report.instance.persist! if Coverband.configuration.s3_bucket
         end
       end
+
+      private
+
+      def self.fix_reports(reports)
+        # list all files, even if not tracked by Coverband (0% coverage)
+        tracked_glob = "#{Coverband.configuration.current_root}/{app,lib,config}/**/*.{rb}"
+        filtered_report_files = {}
+
+        reports.each_pair do |report_name, report_data|
+          filtered_report_files[report_name] = {}
+          report_files = Coverband::Utils::Result.add_not_loaded_files(report_data, tracked_glob)
+
+          # apply coverband filters
+          report_files.each_pair do |file, data|
+            next if Coverband.configuration.ignore.any? { |i| file.match(i) }
+
+            filtered_report_files[report_name][file] = data
+          end
+        end
+      end
     end
   end
 end